From andrew at openjdk.org Sat Nov 1 20:14:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 1 Nov 2025 20:14:18 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Merge `jdk8u472-ga` ------------- Commit messages: - Merge tag 'jdk8u472-ga' into cpu-2025-10 - 8360937: Enhance certificate handling - 8356294: Enhance Path Factories - 8352637: Enhance bytecode verification - 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI - 8368308: ISO 4217 Amendment 180 Update - 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/710/files Stats: 872 lines in 22 files changed: 714 ins; 91 del; 67 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/710.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/710/head:pull/710 PR: https://git.openjdk.org/jdk8u-dev/pull/710 From andrew at openjdk.org Sun Nov 2 14:02:02 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 2 Nov 2025 14:02:02 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge `jdk8u472-ga` Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision: - Merge tag 'jdk8u472-ga' into cpu-2025-10 Added tag jdk8u472-ga for changeset d5ac2ad89a3 - 8367257: [8u] Problem list CAInterop.java#entrustrootcag4 test Reviewed-by: andrew - 8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer Reviewed-by: phh, stuefe - 8219006: AArch64: Register corruption in slow subtype check Reviewed-by: phh, shade Backport-of: 4ac927853957fe691692137a6cabbd1b141b95d4 - 8297088: Update LCMS to 2.14 Reviewed-by: abakhtin, andrew Backport-of: 01b213899cb8124860441fa26c9652b4a4bff896 - 8367115: [8u] Problem list CAInterop.java#actalisauthenticationrootca test Reviewed-by: andrew - 8364597: Replace THL A29 Limited with Tencent Reviewed-by: andrew Backport-of: 4c9eaddaef83c6ba30e27ae3e0d16caeeec206cb - 8345358: Some DLL Files are missing Windows Properties Reviewed-by: andrew, serb - 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. 8182577: Exception when Tab key moves focus to a JCheckbox with a custom ButtonModel Reviewed-by: phh, andrew Backport-of: 8d81ec63b2bafc431cbb8572a3e45e76580ab46f - 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash Reviewed-by: phh, shade Backport-of: 64ec8b3e5c8a8d44c92591710d73b833f13c1500 - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/879855dd...4cbb2c5a ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/710/files - new: https://git.openjdk.org/jdk8u-dev/pull/710/files/4cbb2c5a..4cbb2c5a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=710&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=710&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/710.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/710/head:pull/710 PR: https://git.openjdk.org/jdk8u-dev/pull/710 From andrew at openjdk.org Sun Nov 2 14:02:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 2 Nov 2025 14:02:03 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 1 Nov 2025 20:07:54 GMT, Andrew John Hughes wrote: > Merge `jdk8u472-ga` This pull request has now been integrated. Changeset: 18438d23 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/18438d23e100a0ebf159838e2d3e5e2df405c5a8 Stats: 872 lines in 22 files changed: 714 ins; 91 del; 67 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/710 From zzambers at openjdk.org Mon Nov 3 10:35:46 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 3 Nov 2025 10:35:46 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: On Fri, 31 Oct 2025 07:16:03 GMT, Ji?? Van?k wrote: > ``` > :38:43.3378937Z FAILED: gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java > 2025-10-28T14:38:43.3379819Z FAILED: gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java > ``` > > Are the failing jtregs. Do not seem to be related though > > Am also digging in 32windows time-outs, and can not see culprit. @zzambers any ideas? There are some unstable tests on x86 (32-bit) and probably unrelated to your PR. Segfault in `SystemGCOnForegroundCollector.java` seems like [JDK-8361833](https://bugs.openjdk.org/browse/JDK-8361833?focusedId=14826833&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14826833) - known issue. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3479860377 From andrew at openjdk.org Mon Nov 3 19:33:35 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 3 Nov 2025 19:33:35 GMT Subject: [jdk8u-dev] RFR: 8354941: Build failure with glibc 2.42 due to uabs() name collision Message-ID: This backport replaces the local definition of `uabs` with `g_uabs` to avoid a conflict with the `uabs` declared in versions of glibc 2.42 and later. The patch is mostly clean, with the exception of two conflicts: 1. In `assembler_aarch64.cpp`, the type of `uimm` is `unsigned long` in 8u, rather than `uint64_t`. 8u is missing a sequence of changes, which begins with [JDK-8248414](https://bugs.openjdk.org/browse/JDK-8248414), "AArch64: Remove uses of long and unsigned long ints" and [JDK-8251930](https://bugs.openjdk.org/browse/JDK-8251930), "AArch64: Native types mismatch in hotspot", but these in turn require adaptation to work around other missing changes like [JDK-8222412](https://bugs.openjdk.org/browse/JDK-8222412) "AARCH64: multiple instructions encoding issues" and [JDK-8139043](https://bugs.openjdk.org/browse/JDK-8139043), "aarch64: add support for adler32 intrinsic". Backporting 8248414 & 8251930 may be worthwhile, especially if Windows & Mac AArch64 ports are ever considered for 8u, but really needs to be done by someone with access to AArch64 hardware to verify the changes. I don't think it's necessary just for a simple name substitution. 2. In `stubGenerator_aarch64.cpp`, I corrected the type of `granularity` in `copy_memory(bool, Register, Register, Register, Register, int)` from `int` to `unsigned int`, which matches the signature of `g_uabs`. This same correction was made in later JDKs as part of an enhancement, [JDK-8257436](https://bugs.openjdk.org/browse/JDK-8257436) "Regressions in ArrayCopyUnalignedDst.testByte/testChar for 65-78 bytes when UseSIMDForMemoryOps is on". Again, the rest may be worth backporting if the same performance improvement is visible on 8u AArch64, but the risk isn't appropriate for this change. The change was verified by ensuring that `uabs` no longer exists in the source code after this patch. ~~~ $ grep -r 'uabs' hotspot/ hotspot/src/cpu/aarch64/vm/assembler_aarch64.hpp: return g_uabs(target - branch) < branch_range; hotspot/src/cpu/aarch64/vm/macroAssembler_aarch64.cpp: if (g_uabs(imm) < (1 << 24)) { hotspot/src/cpu/aarch64/vm/stubGenerator_aarch64.cpp: size_t granularity = g_uabs(step); hotspot/src/cpu/aarch64/vm/stubGenerator_aarch64.cpp: unsigned int granularity = g_uabs(step); hotspot/src/cpu/aarch64/vm/assembler_aarch64.cpp: unsigned long uimm = g_uabs(imm); hotspot/src/share/vm/opto/mulnode.cpp: unsigned int abs_con = g_uabs(con); hotspot/src/share/vm/opto/mulnode.cpp: julong abs_con = g_uabs(con); hotspot/src/share/vm/utilities/globalDefinitions.hpp:static inline unsigned int g_uabs(unsigned int n) { hotspot/src/share/vm/utilities/globalDefinitions.hpp:static inline julong g_uabs(julong n) { hotspot/src/share/vm/utilities/globalDefinitions.hpp:static inline julong g_uabs(jlong n) { return g_uabs((julong)n); } hotspot/src/share/vm/utilities/globalDefinitions.hpp:static inline unsigned int g_uabs(int n) { return g_uabs((unsigned int)n); } $ grep -r 'uabs' hotspot/|grep -v g_uabs ~~~ ------------- Commit messages: - Backport 26a8acad1f45bec90ad6c4ff5cd41f4e7450a962 Changes: https://git.openjdk.org/jdk8u-dev/pull/711/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=711&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8354941 Stats: 11 lines in 6 files changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/711.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/711/head:pull/711 PR: https://git.openjdk.org/jdk8u-dev/pull/711 From duke at openjdk.org Tue Nov 4 16:59:45 2025 From: duke at openjdk.org (duke) Date: Tue, 4 Nov 2025 16:59:45 GMT Subject: [jdk8u-dev] Withdrawn: 8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles In-Reply-To: References: Message-ID: On Sat, 6 Sep 2025 20:38:02 GMT, Jan Kratochvil wrote: > Built-in singleton ICC_Profiles could be modified using setData(). Throw an exception for such an attempt. > A testcase is included. > It is not a clean backport - it has to change return switch expressions to their old format and there are also other 2 minor conflicts. > This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. > It requires https://github.com/openjdk/jdk8u-dev/pull/692 as a prerequisite. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/693 From duke at openjdk.org Tue Nov 4 17:02:09 2025 From: duke at openjdk.org (duke) Date: Tue, 4 Nov 2025 17:02:09 GMT Subject: [jdk8u-dev] Withdrawn: 6986863: ProfileDeferralMgr throwing ConcurrentModificationException In-Reply-To: References: Message-ID: <--B5XZzacLCU0nR5KgbGL7MdOd6UeisyQ78UgUBSaps=.1e33d491-a934-4e1c-a2f8-687269923738@github.com> On Sat, 6 Sep 2025 20:24:12 GMT, Jan Kratochvil wrote: > It is needed in jdk8 as a prerequisite for JDK-8347377. > A testcase is included. > It is not a clean backport - source files are moved, copyright years update, original patch uses extra function getStandardProfileInputStream(), Anton Voznia hasn't implemented it by himself, he borrowed it from another patch https://bugs.openjdk.org/browse/JDK-8039271 and changed it a bit according to the requirements. He didn't include entire fix because it's redundant. > This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. > It requires https://github.com/openjdk/jdk8u-dev/pull/690 as a prerequisite. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/691 From duke at openjdk.org Tue Nov 4 17:00:50 2025 From: duke at openjdk.org (duke) Date: Tue, 4 Nov 2025 17:00:50 GMT Subject: [jdk8u-dev] Withdrawn: 8347377: Add validation checks for ICC_Profile header fields In-Reply-To: References: Message-ID: On Sat, 6 Sep 2025 20:32:28 GMT, Jan Kratochvil wrote: > ICC_Profile header is validated too late leading later to unexpected exceptions. > A testcase is included. > It is not a clean backport - it has to change return switch expressions to their old format, also source files are moved, copyright years updated. > This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. > It requires https://github.com/openjdk/jdk8u-dev/pull/691 as a prerequisite. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/692 From zzambers at openjdk.org Wed Nov 5 12:13:59 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 12:13:59 GMT Subject: [jdk8u-dev] RFR: 8371334: [8u] GHA: installation of VS2010 hangs Message-ID: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> Installation of VS2010 hangs. As result Windows x86 (32-bit) jobs in GitHub CI timeout and get cancelled. After some debugging, it turns out, that issue is caused by missing PowerShell 2, required by VS2010 installer. See screenshot: screen-10 PowerShell 2.0 was deprecated and recently stopped being shipped by on windows. Microsoft says following on it's [page](https://support.microsoft.com/en-us/topic/powershell-2-0-removal-from-windows-fe6d1edc-2ed2-4c33-b297-afe82a64200a): > PowerShell 2.0 will be removed in a later release starting in August 2025 for Windows 11, version 24H2 and a September 2025 release for Windows Server 2025. All later releases for Windows 11 and Windows Server 2025 will not include PowerShell 2.0. Fortunately they still provide archive to install it manually. This PR does that. ------------- Commit messages: - install PowerShell 2 required by vs2010 installer Changes: https://git.openjdk.org/jdk8u-dev/pull/712/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=712&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8371334 Stats: 29 lines in 2 files changed: 29 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/712.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/712/head:pull/712 PR: https://git.openjdk.org/jdk8u-dev/pull/712 From zzambers at openjdk.org Wed Nov 5 12:34:25 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 12:34:25 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: On Tue, 28 Oct 2025 13:31:44 GMT, Ji?? Van?k wrote: > Hi! > > I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: > > java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer > at java.lang.ClassLoader$NativeLibrary.load(Native Method) > at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) > at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) > at java.lang.Runtime.loadLibrary0(Runtime.java:843) > at java.lang.System.loadLibrary(System.java:1136) > at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) > at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) > at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) > at java.security.AccessController.doPrivileged(Native Method) > at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) > > > As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` > > This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? > > pandoc --version > pandoc 3.1.11.1 > Features: +server +lua > Scripting engine: Lua 5.4 > > > I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). > > For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 btw. there is also issue with Windows x86 build jobs, where VS2010 installation hangs and jobs get cancelled. I have created [PR](https://github.com/openjdk/jdk8u-dev/pull/712) for that. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3490966772 From fferrari at openjdk.org Wed Nov 5 13:53:34 2025 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Wed, 5 Nov 2025 13:53:34 GMT Subject: [jdk8u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v2] In-Reply-To: References: Message-ID: On Fri, 19 Sep 2025 18:51:57 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this is a backport of openjdk/jdk11u-dev#3098. The backport isn't clean, because of the following: >> >> * File paths that require adjustment for 8u >> * In `Main.java`, trivial context differences and code that needs adjustment from 11u to 8u: >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `InputStream::transferTo(OutputStream.nullOutputStream())` ? [original code before a review suggestion](https://github.com/openjdk/jdk/pull/23532/commits/ef546f4b778e8a1f43dbedc56a79bb53d169a1e7#diff-7083af3b8473a092987afa0bbb4d1694664649534bac716f6b9cd3c3b9833219L1185-L1186) >> * In the test (`VerifyJarEntryName.java`), code that needs adjustment from 11u to 8u: >> * `@library /test/lib` ? `@library /lib/testlibrary` >> * JUnit 5 ? JUnit 4 >> * `org.junit.jupiter.api.BeforeAll` ? `org.junit.BeforeClass` >> * `org.junit.jupiter.api.BeforeEach` ? `org.junit.Before` >> * `org.junit.jupiter.api.Test` ? `org.junit.Test` >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `@BeforeClass`, `@Before` and `@Test` methods must be public >> * Can't use `var` >> * `Arrays.equals(a, start, end, b, 0, b.length)` ? `Arrays.equals(Arrays.copyOfRange(a, start, end), b)` (`Arrays::equals` with offsets not present in 8u) >> * ~~NOTE: for the Japanese manpages translation approach, please refer to openjdk/jdk11u-dev#3098~~ >> * ~~I updated `jdk/src/linux/doc/man/ja/jarsigner.1` and `jdk/src/solaris/doc/sun/man/man1/ja/jarsigner.1` (identical), and left `dk/src/bsd/doc/man/ja/jarsigner.1` untouched (doesn't have any content besides the headers)~~ >> * $\mbox{\color{red}UPDATE}$ (28348b29f892b685d9098c4560128a8bfb206afd): all the internationalized messages have been removed, as they aren't typically included in backports (thanks @jerboaa for letting me know). >> >> #### Related issues ("relates to" Jira issue links) >> >> [JDK-8353299](https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails") (openjdk/jdk at acd4da49a01760599ec4c325ff6c56f53ba5cc9c) and [JDK-8367782](https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName") (openjdk/jdk at 1b9a11682d5f73885213822423bfce8dfc17febd) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of `VerifyJarEntryName.java`. >> >> Since `test/hotspot/jtreg/runtime/appcds/SignedJar.java` is ... > > Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: > > Remove internationalized messages @gnu-andrew, @jerboaa: please consider these issues for `jdk8u482`. Also, I will need an additional look from a Reviewer in 8u updates. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/699#issuecomment-3491332574 From zzambers at openjdk.org Wed Nov 5 15:42:00 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 15:42:00 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c Message-ID: JDK 8 code fails to build using VS2010 with errors: ... check_code.c d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier **Testing:** - GHA: OK - security infra problems are unrelated ------------- Commit messages: - Fix compilation errors on VS2010 - install PowerShell 2 required by vs2010 installer Changes: https://git.openjdk.org/jdk8u-dev/pull/713/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=713&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8371352 Stats: 40 lines in 3 files changed: 33 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/713.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/713/head:pull/713 PR: https://git.openjdk.org/jdk8u-dev/pull/713 From zzambers at openjdk.org Wed Nov 5 15:55:07 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 15:55:07 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: Message-ID: > JDK 8 code fails to build using VS2010 with errors: > > ... > check_code.c > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier > > > **Testing:** > - GHA: OK > - security infra problems are unrelated Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/713/files - new: https://git.openjdk.org/jdk8u-dev/pull/713/files/e2b07451..e2b07451 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=713&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=713&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/713.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/713/head:pull/713 PR: https://git.openjdk.org/jdk8u-dev/pull/713 From zzambers at openjdk.org Wed Nov 5 16:04:55 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 16:04:55 GMT Subject: [jdk8u-dev] RFR: 8371334: [8u] GHA: installation of VS2010 hangs In-Reply-To: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> References: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> Message-ID: On Wed, 5 Nov 2025 12:08:09 GMT, Zdenek Zambersky wrote: > Installation of VS2010 hangs. As result Windows x86 (32-bit) jobs in GitHub CI timeout and get cancelled. > > After some debugging, it turns out, that issue is caused by missing PowerShell 2, required by VS2010 installer. See screenshot: > screen-10 > > PowerShell 2.0 was deprecated and recently stopped being shipped by on windows. Microsoft says following on it's [page](https://support.microsoft.com/en-us/topic/powershell-2-0-removal-from-windows-fe6d1edc-2ed2-4c33-b297-afe82a64200a): > > >> PowerShell 2.0 will be removed in a later release starting in August 2025 for Windows 11, version 24H2 and a September 2025 release for Windows Server 2025. All later releases for Windows 11 and Windows Server 2025 will not include PowerShell 2.0. > > > Fortunately they still provide archive to install it manually. This PR does that. > > **Testing:** > - build still fails on windows x86 due to recent changes to jdk 8 code. It can be fixed in followup PR. > - MacOS build job got canceled because [MacOS 13 is deprecated in GHA](https://github.com/actions/runner-images/issues/13046) (this is separate issue not related to this) > - security infra failures are unrelated Follow-up PR with fixes of build errors on VS2010: https://github.com/openjdk/jdk8u-dev/pull/713 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/712#issuecomment-3492055076 From serb at openjdk.org Wed Nov 5 17:57:28 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 5 Nov 2025 17:57:28 GMT Subject: [jdk8u-dev] RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v4] In-Reply-To: References: Message-ID: <-q6gK_N7JjdlD5lgyUG0ejBbd1AdWZCOsVGGMoqYhnI=.37f4dd8d-3b4e-4bb5-be64-9f5fa8280f65@github.com> > Hi all, > > This pull request contains a backport of commit [2fcb8168](https://github.com/openjdk/jdk/commit/2fcb816858406f33cefef3164b2c85f9f996c7da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 9 Apr 2024 and was reviewed by Phil Race and Sergey Bylokhov. > > The patch is mostly clean, I had to delete `@modules` and `--add-opens` in the test see https://github.com/openjdk/jdk8u-dev/pull/522/commits/2dcba6b8048de90e29c5cd8eaca3be407db2c24e > > The fix verified by the test, no new issues were found by the `:jdk_desktop` tests > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Delete @modules - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Backport 2fcb816858406f33cefef3164b2c85f9f996c7da ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/522/files - new: https://git.openjdk.org/jdk8u-dev/pull/522/files/0decb232..74ef0daa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=522&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=522&range=02-03 Stats: 879 lines in 24 files changed: 719 ins; 91 del; 69 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/522.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/522/head:pull/522 PR: https://git.openjdk.org/jdk8u-dev/pull/522 From ktakakuri at openjdk.org Thu Nov 6 07:12:45 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 6 Nov 2025 07:12:45 GMT Subject: [jdk8u-dev] RFR: 8371387: [8u] hotspot needs to recognise latest VS2022 Message-ID: This fix updates the hotspot build script to recognize the latest version of VS2022. The fix is similar to: #412. I confirmed that the build succeeds using Visual Studio 2022 17.14 with this fix. ------------- Commit messages: - 8371387: [8u] hotspot needs to recognise latest VS2022 Changes: https://git.openjdk.org/jdk8u-dev/pull/714/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=714&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8371387 Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/714.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/714/head:pull/714 PR: https://git.openjdk.org/jdk8u-dev/pull/714 From phh at openjdk.org Thu Nov 6 15:54:21 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 6 Nov 2025 15:54:21 GMT Subject: [jdk8u-dev] RFR: 8371387: [8u] hotspot needs to recognise latest VS2022 In-Reply-To: References: Message-ID: On Thu, 6 Nov 2025 07:07:18 GMT, Kazuhisa Takakuri wrote: > This fix updates the hotspot build script to recognize the latest version of VS2022. The fix is similar to: #412. > I confirmed that the build succeeds using Visual Studio 2022 17.14 with this fix. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/714#pullrequestreview-3428985385 From phh at openjdk.org Thu Nov 6 16:08:36 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 6 Nov 2025 16:08:36 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: Message-ID: <-0_6l3BvSNynMT1SkzPSJ_RaDJCAizIKKi0lQR2cpEY=.3125d974-043d-4cac-a788-1979f26b7ae3@github.com> On Wed, 5 Nov 2025 15:55:07 GMT, Zdenek Zambersky wrote: >> JDK 8 code fails to build using VS2010 with errors: >> >> ... >> check_code.c >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> >> >> Issue is JDK 8 only, because newer JDKs require higher version of visual studio. >> >> **Testing:** >> - GHA: OK >> - security infra problems are unrelated > > Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/713#pullrequestreview-3429076368