From andrew at openjdk.org Sat Nov 1 20:14:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 1 Nov 2025 20:14:18 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Merge `jdk8u472-ga` ------------- Commit messages: - Merge tag 'jdk8u472-ga' into cpu-2025-10 - 8360937: Enhance certificate handling - 8356294: Enhance Path Factories - 8352637: Enhance bytecode verification - 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI - 8368308: ISO 4217 Amendment 180 Update - 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/710/files Stats: 872 lines in 22 files changed: 714 ins; 91 del; 67 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/710.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/710/head:pull/710 PR: https://git.openjdk.org/jdk8u-dev/pull/710 From andrew at openjdk.org Sun Nov 2 14:02:02 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 2 Nov 2025 14:02:02 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge `jdk8u472-ga` Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision: - Merge tag 'jdk8u472-ga' into cpu-2025-10 Added tag jdk8u472-ga for changeset d5ac2ad89a3 - 8367257: [8u] Problem list CAInterop.java#entrustrootcag4 test Reviewed-by: andrew - 8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer Reviewed-by: phh, stuefe - 8219006: AArch64: Register corruption in slow subtype check Reviewed-by: phh, shade Backport-of: 4ac927853957fe691692137a6cabbd1b141b95d4 - 8297088: Update LCMS to 2.14 Reviewed-by: abakhtin, andrew Backport-of: 01b213899cb8124860441fa26c9652b4a4bff896 - 8367115: [8u] Problem list CAInterop.java#actalisauthenticationrootca test Reviewed-by: andrew - 8364597: Replace THL A29 Limited with Tencent Reviewed-by: andrew Backport-of: 4c9eaddaef83c6ba30e27ae3e0d16caeeec206cb - 8345358: Some DLL Files are missing Windows Properties Reviewed-by: andrew, serb - 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. 8182577: Exception when Tab key moves focus to a JCheckbox with a custom ButtonModel Reviewed-by: phh, andrew Backport-of: 8d81ec63b2bafc431cbb8572a3e45e76580ab46f - 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash Reviewed-by: phh, shade Backport-of: 64ec8b3e5c8a8d44c92591710d73b833f13c1500 - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/879855dd...4cbb2c5a ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/710/files - new: https://git.openjdk.org/jdk8u-dev/pull/710/files/4cbb2c5a..4cbb2c5a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=710&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=710&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/710.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/710/head:pull/710 PR: https://git.openjdk.org/jdk8u-dev/pull/710 From andrew at openjdk.org Sun Nov 2 14:02:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 2 Nov 2025 14:02:03 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: On Sat, 1 Nov 2025 20:07:54 GMT, Andrew John Hughes wrote: > Merge `jdk8u472-ga` This pull request has now been integrated. Changeset: 18438d23 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/18438d23e100a0ebf159838e2d3e5e2df405c5a8 Stats: 872 lines in 22 files changed: 714 ins; 91 del; 67 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/710 From zzambers at openjdk.org Mon Nov 3 10:35:46 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 3 Nov 2025 10:35:46 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: On Fri, 31 Oct 2025 07:16:03 GMT, Ji?? Van?k wrote: > ``` > :38:43.3378937Z FAILED: gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java > 2025-10-28T14:38:43.3379819Z FAILED: gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java > ``` > > Are the failing jtregs. Do not seem to be related though > > Am also digging in 32windows time-outs, and can not see culprit. @zzambers any ideas? There are some unstable tests on x86 (32-bit) and probably unrelated to your PR. Segfault in `SystemGCOnForegroundCollector.java` seems like [JDK-8361833](https://bugs.openjdk.org/browse/JDK-8361833?focusedId=14826833&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14826833) - known issue. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3479860377 From andrew at openjdk.org Mon Nov 3 19:33:35 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 3 Nov 2025 19:33:35 GMT Subject: [jdk8u-dev] RFR: 8354941: Build failure with glibc 2.42 due to uabs() name collision Message-ID: This backport replaces the local definition of `uabs` with `g_uabs` to avoid a conflict with the `uabs` declared in versions of glibc 2.42 and later. The patch is mostly clean, with the exception of two conflicts: 1. In `assembler_aarch64.cpp`, the type of `uimm` is `unsigned long` in 8u, rather than `uint64_t`. 8u is missing a sequence of changes, which begins with [JDK-8248414](https://bugs.openjdk.org/browse/JDK-8248414), "AArch64: Remove uses of long and unsigned long ints" and [JDK-8251930](https://bugs.openjdk.org/browse/JDK-8251930), "AArch64: Native types mismatch in hotspot", but these in turn require adaptation to work around other missing changes like [JDK-8222412](https://bugs.openjdk.org/browse/JDK-8222412) "AARCH64: multiple instructions encoding issues" and [JDK-8139043](https://bugs.openjdk.org/browse/JDK-8139043), "aarch64: add support for adler32 intrinsic". Backporting 8248414 & 8251930 may be worthwhile, especially if Windows & Mac AArch64 ports are ever considered for 8u, but really needs to be done by someone with access to AArch64 hardware to verify the changes. I don't think it's necessary just for a simple name substitution. 2. In `stubGenerator_aarch64.cpp`, I corrected the type of `granularity` in `copy_memory(bool, Register, Register, Register, Register, int)` from `int` to `unsigned int`, which matches the signature of `g_uabs`. This same correction was made in later JDKs as part of an enhancement, [JDK-8257436](https://bugs.openjdk.org/browse/JDK-8257436) "Regressions in ArrayCopyUnalignedDst.testByte/testChar for 65-78 bytes when UseSIMDForMemoryOps is on". Again, the rest may be worth backporting if the same performance improvement is visible on 8u AArch64, but the risk isn't appropriate for this change. The change was verified by ensuring that `uabs` no longer exists in the source code after this patch. ~~~ $ grep -r 'uabs' hotspot/ hotspot/src/cpu/aarch64/vm/assembler_aarch64.hpp: return g_uabs(target - branch) < branch_range; hotspot/src/cpu/aarch64/vm/macroAssembler_aarch64.cpp: if (g_uabs(imm) < (1 << 24)) { hotspot/src/cpu/aarch64/vm/stubGenerator_aarch64.cpp: size_t granularity = g_uabs(step); hotspot/src/cpu/aarch64/vm/stubGenerator_aarch64.cpp: unsigned int granularity = g_uabs(step); hotspot/src/cpu/aarch64/vm/assembler_aarch64.cpp: unsigned long uimm = g_uabs(imm); hotspot/src/share/vm/opto/mulnode.cpp: unsigned int abs_con = g_uabs(con); hotspot/src/share/vm/opto/mulnode.cpp: julong abs_con = g_uabs(con); hotspot/src/share/vm/utilities/globalDefinitions.hpp:static inline unsigned int g_uabs(unsigned int n) { hotspot/src/share/vm/utilities/globalDefinitions.hpp:static inline julong g_uabs(julong n) { hotspot/src/share/vm/utilities/globalDefinitions.hpp:static inline julong g_uabs(jlong n) { return g_uabs((julong)n); } hotspot/src/share/vm/utilities/globalDefinitions.hpp:static inline unsigned int g_uabs(int n) { return g_uabs((unsigned int)n); } $ grep -r 'uabs' hotspot/|grep -v g_uabs ~~~ ------------- Commit messages: - Backport 26a8acad1f45bec90ad6c4ff5cd41f4e7450a962 Changes: https://git.openjdk.org/jdk8u-dev/pull/711/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=711&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8354941 Stats: 11 lines in 6 files changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/711.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/711/head:pull/711 PR: https://git.openjdk.org/jdk8u-dev/pull/711 From duke at openjdk.org Tue Nov 4 16:59:45 2025 From: duke at openjdk.org (duke) Date: Tue, 4 Nov 2025 16:59:45 GMT Subject: [jdk8u-dev] Withdrawn: 8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles In-Reply-To: References: Message-ID: On Sat, 6 Sep 2025 20:38:02 GMT, Jan Kratochvil wrote: > Built-in singleton ICC_Profiles could be modified using setData(). Throw an exception for such an attempt. > A testcase is included. > It is not a clean backport - it has to change return switch expressions to their old format and there are also other 2 minor conflicts. > This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. > It requires https://github.com/openjdk/jdk8u-dev/pull/692 as a prerequisite. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/693 From duke at openjdk.org Tue Nov 4 17:02:09 2025 From: duke at openjdk.org (duke) Date: Tue, 4 Nov 2025 17:02:09 GMT Subject: [jdk8u-dev] Withdrawn: 6986863: ProfileDeferralMgr throwing ConcurrentModificationException In-Reply-To: References: Message-ID: <--B5XZzacLCU0nR5KgbGL7MdOd6UeisyQ78UgUBSaps=.1e33d491-a934-4e1c-a2f8-687269923738@github.com> On Sat, 6 Sep 2025 20:24:12 GMT, Jan Kratochvil wrote: > It is needed in jdk8 as a prerequisite for JDK-8347377. > A testcase is included. > It is not a clean backport - source files are moved, copyright years update, original patch uses extra function getStandardProfileInputStream(), Anton Voznia hasn't implemented it by himself, he borrowed it from another patch https://bugs.openjdk.org/browse/JDK-8039271 and changed it a bit according to the requirements. He didn't include entire fix because it's redundant. > This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. > It requires https://github.com/openjdk/jdk8u-dev/pull/690 as a prerequisite. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/691 From duke at openjdk.org Tue Nov 4 17:00:50 2025 From: duke at openjdk.org (duke) Date: Tue, 4 Nov 2025 17:00:50 GMT Subject: [jdk8u-dev] Withdrawn: 8347377: Add validation checks for ICC_Profile header fields In-Reply-To: References: Message-ID: On Sat, 6 Sep 2025 20:32:28 GMT, Jan Kratochvil wrote: > ICC_Profile header is validated too late leading later to unexpected exceptions. > A testcase is included. > It is not a clean backport - it has to change return switch expressions to their old format, also source files are moved, copyright years updated. > This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. > It requires https://github.com/openjdk/jdk8u-dev/pull/691 as a prerequisite. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/692 From zzambers at openjdk.org Wed Nov 5 12:13:59 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 12:13:59 GMT Subject: [jdk8u-dev] RFR: 8371334: [8u] GHA: installation of VS2010 hangs Message-ID: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> Installation of VS2010 hangs. As result Windows x86 (32-bit) jobs in GitHub CI timeout and get cancelled. After some debugging, it turns out, that issue is caused by missing PowerShell 2, required by VS2010 installer. See screenshot: screen-10 PowerShell 2.0 was deprecated and recently stopped being shipped by on windows. Microsoft says following on it's [page](https://support.microsoft.com/en-us/topic/powershell-2-0-removal-from-windows-fe6d1edc-2ed2-4c33-b297-afe82a64200a): > PowerShell 2.0 will be removed in a later release starting in August 2025 for Windows 11, version 24H2 and a September 2025 release for Windows Server 2025. All later releases for Windows 11 and Windows Server 2025 will not include PowerShell 2.0. Fortunately they still provide archive to install it manually. This PR does that. ------------- Commit messages: - install PowerShell 2 required by vs2010 installer Changes: https://git.openjdk.org/jdk8u-dev/pull/712/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=712&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8371334 Stats: 29 lines in 2 files changed: 29 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/712.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/712/head:pull/712 PR: https://git.openjdk.org/jdk8u-dev/pull/712 From zzambers at openjdk.org Wed Nov 5 12:34:25 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 12:34:25 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: On Tue, 28 Oct 2025 13:31:44 GMT, Ji?? Van?k wrote: > Hi! > > I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: > > java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer > at java.lang.ClassLoader$NativeLibrary.load(Native Method) > at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) > at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) > at java.lang.Runtime.loadLibrary0(Runtime.java:843) > at java.lang.System.loadLibrary(System.java:1136) > at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) > at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) > at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) > at java.security.AccessController.doPrivileged(Native Method) > at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) > > > As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` > > This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? > > pandoc --version > pandoc 3.1.11.1 > Features: +server +lua > Scripting engine: Lua 5.4 > > > I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). > > For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 btw. there is also issue with Windows x86 build jobs, where VS2010 installation hangs and jobs get cancelled. I have created [PR](https://github.com/openjdk/jdk8u-dev/pull/712) for that. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3490966772 From fferrari at openjdk.org Wed Nov 5 13:53:34 2025 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Wed, 5 Nov 2025 13:53:34 GMT Subject: [jdk8u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v2] In-Reply-To: References: Message-ID: On Fri, 19 Sep 2025 18:51:57 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this is a backport of openjdk/jdk11u-dev#3098. The backport isn't clean, because of the following: >> >> * File paths that require adjustment for 8u >> * In `Main.java`, trivial context differences and code that needs adjustment from 11u to 8u: >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `InputStream::transferTo(OutputStream.nullOutputStream())` ? [original code before a review suggestion](https://github.com/openjdk/jdk/pull/23532/commits/ef546f4b778e8a1f43dbedc56a79bb53d169a1e7#diff-7083af3b8473a092987afa0bbb4d1694664649534bac716f6b9cd3c3b9833219L1185-L1186) >> * In the test (`VerifyJarEntryName.java`), code that needs adjustment from 11u to 8u: >> * `@library /test/lib` ? `@library /lib/testlibrary` >> * JUnit 5 ? JUnit 4 >> * `org.junit.jupiter.api.BeforeAll` ? `org.junit.BeforeClass` >> * `org.junit.jupiter.api.BeforeEach` ? `org.junit.Before` >> * `org.junit.jupiter.api.Test` ? `org.junit.Test` >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `@BeforeClass`, `@Before` and `@Test` methods must be public >> * Can't use `var` >> * `Arrays.equals(a, start, end, b, 0, b.length)` ? `Arrays.equals(Arrays.copyOfRange(a, start, end), b)` (`Arrays::equals` with offsets not present in 8u) >> * ~~NOTE: for the Japanese manpages translation approach, please refer to openjdk/jdk11u-dev#3098~~ >> * ~~I updated `jdk/src/linux/doc/man/ja/jarsigner.1` and `jdk/src/solaris/doc/sun/man/man1/ja/jarsigner.1` (identical), and left `dk/src/bsd/doc/man/ja/jarsigner.1` untouched (doesn't have any content besides the headers)~~ >> * $\mbox{\color{red}UPDATE}$ (28348b29f892b685d9098c4560128a8bfb206afd): all the internationalized messages have been removed, as they aren't typically included in backports (thanks @jerboaa for letting me know). >> >> #### Related issues ("relates to" Jira issue links) >> >> [JDK-8353299](https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails") (openjdk/jdk at acd4da49a01760599ec4c325ff6c56f53ba5cc9c) and [JDK-8367782](https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName") (openjdk/jdk at 1b9a11682d5f73885213822423bfce8dfc17febd) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of `VerifyJarEntryName.java`. >> >> Since `test/hotspot/jtreg/runtime/appcds/SignedJar.java` is ... > > Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: > > Remove internationalized messages @gnu-andrew, @jerboaa: please consider these issues for `jdk8u482`. Also, I will need an additional look from a Reviewer in 8u updates. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/699#issuecomment-3491332574 From zzambers at openjdk.org Wed Nov 5 15:42:00 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 15:42:00 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c Message-ID: JDK 8 code fails to build using VS2010 with errors: ... check_code.c d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier **Testing:** - GHA: OK - security infra problems are unrelated ------------- Commit messages: - Fix compilation errors on VS2010 - install PowerShell 2 required by vs2010 installer Changes: https://git.openjdk.org/jdk8u-dev/pull/713/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=713&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8371352 Stats: 40 lines in 3 files changed: 33 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/713.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/713/head:pull/713 PR: https://git.openjdk.org/jdk8u-dev/pull/713 From zzambers at openjdk.org Wed Nov 5 15:55:07 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 15:55:07 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: Message-ID: > JDK 8 code fails to build using VS2010 with errors: > > ... > check_code.c > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier > > > **Testing:** > - GHA: OK > - security infra problems are unrelated Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/713/files - new: https://git.openjdk.org/jdk8u-dev/pull/713/files/e2b07451..e2b07451 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=713&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=713&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/713.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/713/head:pull/713 PR: https://git.openjdk.org/jdk8u-dev/pull/713 From zzambers at openjdk.org Wed Nov 5 16:04:55 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 5 Nov 2025 16:04:55 GMT Subject: [jdk8u-dev] RFR: 8371334: [8u] GHA: installation of VS2010 hangs In-Reply-To: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> References: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> Message-ID: On Wed, 5 Nov 2025 12:08:09 GMT, Zdenek Zambersky wrote: > Installation of VS2010 hangs. As result Windows x86 (32-bit) jobs in GitHub CI timeout and get cancelled. > > After some debugging, it turns out, that issue is caused by missing PowerShell 2, required by VS2010 installer. See screenshot: > screen-10 > > PowerShell 2.0 was deprecated and recently stopped being shipped by on windows. Microsoft says following on it's [page](https://support.microsoft.com/en-us/topic/powershell-2-0-removal-from-windows-fe6d1edc-2ed2-4c33-b297-afe82a64200a): > > >> PowerShell 2.0 will be removed in a later release starting in August 2025 for Windows 11, version 24H2 and a September 2025 release for Windows Server 2025. All later releases for Windows 11 and Windows Server 2025 will not include PowerShell 2.0. > > > Fortunately they still provide archive to install it manually. This PR does that. > > **Testing:** > - build still fails on windows x86 due to recent changes to jdk 8 code. It can be fixed in followup PR. > - MacOS build job got canceled because [MacOS 13 is deprecated in GHA](https://github.com/actions/runner-images/issues/13046) (this is separate issue not related to this) > - security infra failures are unrelated Follow-up PR with fixes of build errors on VS2010: https://github.com/openjdk/jdk8u-dev/pull/713 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/712#issuecomment-3492055076 From serb at openjdk.org Wed Nov 5 17:57:28 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 5 Nov 2025 17:57:28 GMT Subject: [jdk8u-dev] RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v4] In-Reply-To: References: Message-ID: <-q6gK_N7JjdlD5lgyUG0ejBbd1AdWZCOsVGGMoqYhnI=.37f4dd8d-3b4e-4bb5-be64-9f5fa8280f65@github.com> > Hi all, > > This pull request contains a backport of commit [2fcb8168](https://github.com/openjdk/jdk/commit/2fcb816858406f33cefef3164b2c85f9f996c7da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 9 Apr 2024 and was reviewed by Phil Race and Sergey Bylokhov. > > The patch is mostly clean, I had to delete `@modules` and `--add-opens` in the test see https://github.com/openjdk/jdk8u-dev/pull/522/commits/2dcba6b8048de90e29c5cd8eaca3be407db2c24e > > The fix verified by the test, no new issues were found by the `:jdk_desktop` tests > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Delete @modules - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Backport 2fcb816858406f33cefef3164b2c85f9f996c7da ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/522/files - new: https://git.openjdk.org/jdk8u-dev/pull/522/files/0decb232..74ef0daa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=522&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=522&range=02-03 Stats: 879 lines in 24 files changed: 719 ins; 91 del; 69 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/522.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/522/head:pull/522 PR: https://git.openjdk.org/jdk8u-dev/pull/522 From ktakakuri at openjdk.org Thu Nov 6 07:12:45 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 6 Nov 2025 07:12:45 GMT Subject: [jdk8u-dev] RFR: 8371387: [8u] hotspot needs to recognise latest VS2022 Message-ID: This fix updates the hotspot build script to recognize the latest version of VS2022. The fix is similar to: #412. I confirmed that the build succeeds using Visual Studio 2022 17.14 with this fix. ------------- Commit messages: - 8371387: [8u] hotspot needs to recognise latest VS2022 Changes: https://git.openjdk.org/jdk8u-dev/pull/714/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=714&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8371387 Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/714.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/714/head:pull/714 PR: https://git.openjdk.org/jdk8u-dev/pull/714 From phh at openjdk.org Thu Nov 6 15:54:21 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 6 Nov 2025 15:54:21 GMT Subject: [jdk8u-dev] RFR: 8371387: [8u] hotspot needs to recognise latest VS2022 In-Reply-To: References: Message-ID: On Thu, 6 Nov 2025 07:07:18 GMT, Kazuhisa Takakuri wrote: > This fix updates the hotspot build script to recognize the latest version of VS2022. The fix is similar to: #412. > I confirmed that the build succeeds using Visual Studio 2022 17.14 with this fix. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/714#pullrequestreview-3428985385 From phh at openjdk.org Thu Nov 6 16:08:36 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 6 Nov 2025 16:08:36 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: Message-ID: <-0_6l3BvSNynMT1SkzPSJ_RaDJCAizIKKi0lQR2cpEY=.3125d974-043d-4cac-a788-1979f26b7ae3@github.com> On Wed, 5 Nov 2025 15:55:07 GMT, Zdenek Zambersky wrote: >> JDK 8 code fails to build using VS2010 with errors: >> >> ... >> check_code.c >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> >> >> Issue is JDK 8 only, because newer JDKs require higher version of visual studio. >> >> **Testing:** >> - GHA: OK >> - security infra problems are unrelated > > Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/713#pullrequestreview-3429076368 From tkiriyama at openjdk.org Mon Nov 10 02:33:47 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Mon, 10 Nov 2025 02:33:47 GMT Subject: [jdk8u-dev] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 Message-ID: Hi all, I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean. This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together. https://github.com/openjdk/jdk8u-dev/pull/706 I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016. I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass. Thank you. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/706 Commit messages: - 8258805: Japanese characters not entered by mouse click on Windows 10 Changes: https://git.openjdk.org/jdk8u-dev/pull/716/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=716&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8258805 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/716.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/716/head:pull/716 PR: https://git.openjdk.org/jdk8u-dev/pull/716 From andrew at openjdk.org Mon Nov 10 20:28:40 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 10 Nov 2025 20:28:40 GMT Subject: [jdk8u-dev] RFR: 8371334: [8u] GHA: installation of VS2010 hangs In-Reply-To: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> References: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> Message-ID: On Wed, 5 Nov 2025 12:08:09 GMT, Zdenek Zambersky wrote: > Installation of VS2010 hangs. As result Windows x86 (32-bit) jobs in GitHub CI timeout and get cancelled. > > After some debugging, it turns out, that issue is caused by missing PowerShell 2, required by VS2010 installer. See screenshot: > screen-10 > > PowerShell 2.0 was deprecated and recently stopped being shipped by on windows. Microsoft says following on their [page](https://support.microsoft.com/en-us/topic/powershell-2-0-removal-from-windows-fe6d1edc-2ed2-4c33-b297-afe82a64200a): > > >> PowerShell 2.0 will be removed in a later release starting in August 2025 for Windows 11, version 24H2 and a September 2025 release for Windows Server 2025. All later releases for Windows 11 and Windows Server 2025 will not include PowerShell 2.0. > > > Fortunately they still provide archive to install it manually. This PR does that. > > **Testing:** > - build still fails on windows x86 due to recent changes to jdk 8 code. It can be fixed in followup PR. > - MacOS build job got canceled because [MacOS 13 is deprecated in GHA](https://github.com/actions/runner-images/issues/13046) (this is separate issue not related to this) > - security infra failures are unrelated This looks good to me. Thanks for fixing this. I had seen the failures on recent PRs, but just thought it was a temporary outage. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/712#pullrequestreview-3445016670 From andrew at openjdk.org Mon Nov 10 20:44:22 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 10 Nov 2025 20:44:22 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: Message-ID: <7lWHHUDplfw3jU0HzEdSvFXzYIiOmseLmGcuIKWD6-Y=.08e023c0-926b-4f42-857b-a0403241e1ef@github.com> On Wed, 5 Nov 2025 15:55:07 GMT, Zdenek Zambersky wrote: >> JDK 8 code fails to build using VS2010 with errors: >> >> ... >> check_code.c >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> >> >> Issue is JDK 8 only, because newer JDKs require higher version of visual studio. >> >> **Testing:** >> - GHA: OK >> - security infra problems are unrelated > > Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Looks fine to me. Broken by JDK-8352637: "Enhance bytecode verification", one of the 2025-10 security update changes. I seem to recall that I tested a patch a while back that checked for this with `gcc`. I should try and dig that out so we can catch these issues on GNU/Linux before they make it in. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/713#pullrequestreview-3445075371 From andrew at openjdk.org Mon Nov 10 22:21:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 10 Nov 2025 22:21:18 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: On Tue, 28 Oct 2025 13:31:44 GMT, Ji?? Van?k wrote: > Hi! > > I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: > > java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer > at java.lang.ClassLoader$NativeLibrary.load(Native Method) > at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) > at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) > at java.lang.Runtime.loadLibrary0(Runtime.java:843) > at java.lang.System.loadLibrary(System.java:1136) > at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) > at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) > at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) > at java.security.AccessController.doPrivileged(Native Method) > at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) > > > As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` > > This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? > > pandoc --version > pandoc 3.1.11.1 > Features: +server +lua > Scripting engine: Lua 5.4 > > > I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). > > For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 Thanks for taking this over. In like manner, I have leveraged my previous review and just compared the diff for your PR with the one for #318. I see `building.html` is now updated. I also think your choice of keeping the example and removing the freetype part is a better idea than removing the entire thing, even if it deviates from the backported change. I do think we should test this on Windows & VS2010 before merging, so I will approve this once #712 & #713 are merged and this PR is updated with those changes. In the meantime, please use the [contributor command](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/contributor) to credit @gdams for his work here. ------------- Changes requested by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/709#pullrequestreview-3445399584 From andrew at openjdk.org Mon Nov 10 22:24:24 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 10 Nov 2025 22:24:24 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: <12B4A3Vb4WKE-9bUMExdF1NEmrikH-ijtnu5YEwcvFg=.6695f985-fb78-44aa-9acf-f8fccc765e44@github.com> On Wed, 5 Nov 2025 12:32:06 GMT, Zdenek Zambersky wrote: > btw. there is also issue with Windows x86 build jobs, where VS2010 installation hangs and jobs get cancelled. I have created [PR](https://github.com/openjdk/jdk8u-dev/pull/712) for that. Thanks for analysiing the test results and debugging this stalling build job. I observed it when merging the security update in, but had no idea what was causing it. I've reviewed #712 & #713 so we should be able to get them in shortly and then Jiri can merge them into his branch. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3514133484 From syan at openjdk.org Tue Nov 11 03:14:31 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Nov 2025 03:14:31 GMT Subject: [jdk8u-dev] RFR: 8313770: jdk/internal/platform/docker/TestSystemMetrics.java fails on Ubuntu Message-ID: <49SJ2vedvFNoqlWGOL4Sry6F9DE0NtcDeEG8E3DlR_o=.4ae68b83-9c16-45a1-b910-29f26e537c12@github.com> Hi all, This pull request contains a backport of commit [aec13888](https://github.com/openjdk/jdk/commit/aec138886ec2dff765ed810059a1c7b9905c43ca) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Casper Norrbin on 23 Oct 2025 and was reviewed by Severin Gehwolf, Matthias Baesken and SendaoYan. Thanks! ------------- Commit messages: - Backport aec138886ec2dff765ed810059a1c7b9905c43ca Changes: https://git.openjdk.org/jdk8u-dev/pull/717/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=717&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313770 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/717.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/717/head:pull/717 PR: https://git.openjdk.org/jdk8u-dev/pull/717 From syan at openjdk.org Tue Nov 11 03:17:20 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Nov 2025 03:17:20 GMT Subject: [jdk8u-dev] RFR: 8313770: jdk/internal/platform/docker/TestSystemMetrics.java fails on Ubuntu In-Reply-To: <49SJ2vedvFNoqlWGOL4Sry6F9DE0NtcDeEG8E3DlR_o=.4ae68b83-9c16-45a1-b910-29f26e537c12@github.com> References: <49SJ2vedvFNoqlWGOL4Sry6F9DE0NtcDeEG8E3DlR_o=.4ae68b83-9c16-45a1-b910-29f26e537c12@github.com> Message-ID: On Tue, 11 Nov 2025 03:08:49 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [aec13888](https://github.com/openjdk/jdk/commit/aec138886ec2dff765ed810059a1c7b9905c43ca) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Casper Norrbin on 23 Oct 2025 and was reviewed by Severin Gehwolf, Matthias Baesken and SendaoYan. > > Thanks! Change has been verified locally on linux-64. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/717#issuecomment-3514823440 From syan at openjdk.org Tue Nov 11 03:53:13 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 11 Nov 2025 03:53:13 GMT Subject: [jdk8u-dev] RFR: 8132786: java/security/cert/CertPathValidator/OCSP/AIACheck.java fails intermittently In-Reply-To: References: Message-ID: On Mon, 13 Oct 2025 09:10:48 GMT, SendaoYan wrote: > Hi all, > > This is clean backport to fix the test bug which will cause test intermittently fails. Change has been verified locally on linux-x64, test-fix only, no risk. GHA report test runtime/CompressedOops/CompressedClassPointers.java fails, this fails seems similar to https://bugs.openjdk.org/browse/JDK-8318485. I think this test fails is unrelated to this backport PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/704#issuecomment-3514881177 From ktakakuri at openjdk.org Tue Nov 11 05:27:04 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 11 Nov 2025 05:27:04 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. [v7] In-Reply-To: References: Message-ID: > This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful. > > This patch has already been applied to OracleJDK8. > As noted in the Bug Issue comments, some tests do not exist in 8u. Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge branch 'openjdk:master' into 8160974 - Merge branch 'master' into 8160974 - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 - Merge branch 'master' into 8160974 - Merge branch 'master' into 8160974 - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/383/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=383&range=06 Stats: 1049 lines in 533 files changed: 633 ins; 1 del; 415 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/383.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/383/head:pull/383 PR: https://git.openjdk.org/jdk8u-dev/pull/383 From jvanek at openjdk.org Tue Nov 11 08:04:17 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 11 Nov 2025 08:04:17 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: <0-Ru1mfjRWuRJC76InezkA_Xx2XMzCysyHzF8OL7e0U=.e00119bc-e37c-45eb-84ae-23597db94355@github.com> On Mon, 10 Nov 2025 22:18:32 GMT, Andrew John Hughes wrote: > Thanks for taking this over. In like manner, I have leveraged my previous review and just compared the diff for your PR with the one for #318. I see `building.html` is now updated. I also think your choice of keeping the example and removing the freetype part is a better idea than removing the entire thing, even if it deviates from the backported change. > > I do think we should test this on Windows & VS2010 before merging, so I will approve this once #712 & #713 are I had been testing it on windows, but sure, no objection to wait. Thank you! > merged and this PR is updated with those changes. In the meantime, please use the [contributor command](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/contributor) to credit @gdams for his work here. done! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3515432295 From sgehwolf at openjdk.org Tue Nov 11 09:34:16 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 11 Nov 2025 09:34:16 GMT Subject: [jdk8u-dev] RFR: 8371334: [8u] GHA: installation of VS2010 hangs In-Reply-To: References: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> Message-ID: On Wed, 5 Nov 2025 16:02:40 GMT, Zdenek Zambersky wrote: >> Installation of VS2010 hangs. As result Windows x86 (32-bit) jobs in GitHub CI timeout and get cancelled. >> >> After some debugging, it turns out, that issue is caused by missing PowerShell 2, required by VS2010 installer. See screenshot: >> screen-10 >> >> PowerShell 2.0 was deprecated and recently stopped being shipped by on windows. Microsoft says following on their [page](https://support.microsoft.com/en-us/topic/powershell-2-0-removal-from-windows-fe6d1edc-2ed2-4c33-b297-afe82a64200a): >> >> >>> PowerShell 2.0 will be removed in a later release starting in August 2025 for Windows 11, version 24H2 and a September 2025 release for Windows Server 2025. All later releases for Windows 11 and Windows Server 2025 will not include PowerShell 2.0. >> >> >> Fortunately they still provide archive to install it manually. This PR does that. >> >> **Testing:** >> - build still fails on windows x86 due to recent changes to jdk 8 code. It can be fixed in followup PR. >> - MacOS build job got canceled because [MacOS 13 is deprecated in GHA](https://github.com/actions/runner-images/issues/13046) (this is separate issue not related to this) >> - security infra failures are unrelated > > Follow-up PR with fixes of build errors on VS2010: https://github.com/openjdk/jdk8u-dev/pull/713 @zzambers Please apply for approval to make progress on the GHA issues. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/712#issuecomment-3515848879 From zzambers at openjdk.org Tue Nov 11 11:27:28 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 11 Nov 2025 11:27:28 GMT Subject: [jdk8u-dev] Integrated: 8371334: [8u] GHA: installation of VS2010 hangs In-Reply-To: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> References: <7ts8vEFmKBXDYNPMdvQqpuOM2GKygMVV3EN_w_PmMlY=.ff32da2f-64df-4425-898c-6c42bb49ac8f@github.com> Message-ID: On Wed, 5 Nov 2025 12:08:09 GMT, Zdenek Zambersky wrote: > Installation of VS2010 hangs. As result Windows x86 (32-bit) jobs in GitHub CI timeout and get cancelled. > > After some debugging, it turns out, that issue is caused by missing PowerShell 2, required by VS2010 installer. See screenshot: > screen-10 > > PowerShell 2.0 was deprecated and recently stopped being shipped by on windows. Microsoft says following on their [page](https://support.microsoft.com/en-us/topic/powershell-2-0-removal-from-windows-fe6d1edc-2ed2-4c33-b297-afe82a64200a): > > >> PowerShell 2.0 will be removed in a later release starting in August 2025 for Windows 11, version 24H2 and a September 2025 release for Windows Server 2025. All later releases for Windows 11 and Windows Server 2025 will not include PowerShell 2.0. > > > Fortunately they still provide archive to install it manually. This PR does that. > > **Testing:** > - build still fails on windows x86 due to recent changes to jdk 8 code. It can be fixed in followup PR. > - MacOS build job got canceled because [MacOS 13 is deprecated in GHA](https://github.com/actions/runner-images/issues/13046) (this is separate issue not related to this) > - security infra failures are unrelated This pull request has now been integrated. Changeset: a8cf6db4 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/a8cf6db481b7dd9f55694a8210a7654ff70ec078 Stats: 29 lines in 2 files changed: 29 ins; 0 del; 0 mod 8371334: [8u] GHA: installation of VS2010 hangs Reviewed-by: andrew ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/712 From sgehwolf at openjdk.org Tue Nov 11 11:32:22 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 11 Nov 2025 11:32:22 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: Message-ID: On Wed, 5 Nov 2025 15:55:07 GMT, Zdenek Zambersky wrote: >> JDK 8 code fails to build using VS2010 with errors: >> >> ... >> check_code.c >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> >> >> Issue is JDK 8 only, because newer JDKs require higher version of visual studio. >> >> **Testing:** >> - GHA: OK >> - security infra problems are unrelated > > Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. @zzambers Please merge master branch. Then this change should transition to ready. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/713#issuecomment-3516423518 From sgehwolf at openjdk.org Tue Nov 11 11:38:33 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 11 Nov 2025 11:38:33 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: Message-ID: <3QUZ3Ri4LXpJrJVMNkC87C_IbJ236EkCxnZUd_pey-Y=.0a33fc3b-e7b2-4684-9440-cdad46e03a67@github.com> On Wed, 5 Nov 2025 15:55:07 GMT, Zdenek Zambersky wrote: >> JDK 8 code fails to build using VS2010 with errors: >> >> ... >> check_code.c >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier >> >> >> Issue is JDK 8 only, because newer JDKs require higher version of visual studio. >> >> **Testing:** >> - GHA: OK >> - security infra problems are unrelated > > Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. @zzambers Please merge master first! Not sure if the bot will do the right thing now. It includes changes from #712 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/713#issuecomment-3516452854 From zzambers at openjdk.org Tue Nov 11 11:38:35 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 11 Nov 2025 11:38:35 GMT Subject: [jdk8u-dev] Integrated: 8371352: [8u] Fix VS2010 build issue in check_code.c In-Reply-To: References: Message-ID: On Wed, 5 Nov 2025 15:36:18 GMT, Zdenek Zambersky wrote: > JDK 8 code fails to build using VS2010 with errors: > > ... > check_code.c > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type' > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier > d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier > > > Issue is JDK 8 only, because newer JDKs require higher version of visual studio. > > **Testing:** > - GHA: OK > - security infra problems are unrelated This pull request has now been integrated. Changeset: 6526a275 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/6526a275b8f2c870b65b3de76c997a89c6244c1a Stats: 11 lines in 1 file changed: 4 ins; 0 del; 7 mod 8371352: [8u] Fix VS2010 build issue in check_code.c Reviewed-by: phh, andrew ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/713 From zzambers at openjdk.org Tue Nov 11 11:43:23 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 11 Nov 2025 11:43:23 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: <3QUZ3Ri4LXpJrJVMNkC87C_IbJ236EkCxnZUd_pey-Y=.0a33fc3b-e7b2-4684-9440-cdad46e03a67@github.com> References: <3QUZ3Ri4LXpJrJVMNkC87C_IbJ236EkCxnZUd_pey-Y=.0a33fc3b-e7b2-4684-9440-cdad46e03a67@github.com> Message-ID: On Tue, 11 Nov 2025 11:35:47 GMT, Severin Gehwolf wrote: > @zzambers Please merge master first! Not sure if the bot will do the right thing now. It includes changes from #712 Oh, sorry, I saw that bot eventually changed state to ready, so I went forward with integration. (and it only says to merge not to confuse reviewers with additional commits). Anyway PR got integrated and it seems bot did the right thing. :) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/713#issuecomment-3516474943 From sgehwolf at openjdk.org Tue Nov 11 11:58:27 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 11 Nov 2025 11:58:27 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: <3QUZ3Ri4LXpJrJVMNkC87C_IbJ236EkCxnZUd_pey-Y=.0a33fc3b-e7b2-4684-9440-cdad46e03a67@github.com> Message-ID: On Tue, 11 Nov 2025 11:40:49 GMT, Zdenek Zambersky wrote: > Anyway PR got integrated and it seems bot did the right thing. :) Right, fortunately. Still worth doing the merge next time for dependent PRs. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/713#issuecomment-3516523170 From andrew at openjdk.org Tue Nov 11 13:41:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Nov 2025 13:41:19 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: <3QUZ3Ri4LXpJrJVMNkC87C_IbJ236EkCxnZUd_pey-Y=.0a33fc3b-e7b2-4684-9440-cdad46e03a67@github.com> Message-ID: <2wTwpGfqYhNYqr0MVH9X9Wizbl1RJv2VDUkvkSa8u7M=.13bd3064-e4a4-4933-97af-fbdbab1f4f7f@github.com> On Tue, 11 Nov 2025 11:55:24 GMT, Severin Gehwolf wrote: > > Anyway PR got integrated and it seems bot did the right thing. :) > > Right, fortunately. Still worth doing the merge next time for dependent PRs. No real reason for these to be dependent in the first place, as they touch completely different files. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/713#issuecomment-3516977085 From andrew at openjdk.org Tue Nov 11 13:42:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Nov 2025 13:42:19 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: <0-Ru1mfjRWuRJC76InezkA_Xx2XMzCysyHzF8OL7e0U=.e00119bc-e37c-45eb-84ae-23597db94355@github.com> References: <0-Ru1mfjRWuRJC76InezkA_Xx2XMzCysyHzF8OL7e0U=.e00119bc-e37c-45eb-84ae-23597db94355@github.com> Message-ID: On Tue, 11 Nov 2025 08:01:12 GMT, Ji?? Van?k wrote: > > Thanks for taking this over. In like manner, I have leveraged my previous review and just compared the diff for your PR with the one for #318. I see `building.html` is now updated. I also think your choice of keeping the example and removing the freetype part is a better idea than removing the entire thing, even if it deviates from the backported change. > > I do think we should test this on Windows & VS2010 before merging, so I will approve this once #712 & #713 are > > I had been testing it on windows, but sure, no objection to wait. Thank you! On VS2010? Patches are now merged so just merge into your tree and push, please. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3516981885 From zzambers at openjdk.org Tue Nov 11 13:54:31 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 11 Nov 2025 13:54:31 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: <2wTwpGfqYhNYqr0MVH9X9Wizbl1RJv2VDUkvkSa8u7M=.13bd3064-e4a4-4933-97af-fbdbab1f4f7f@github.com> References: <3QUZ3Ri4LXpJrJVMNkC87C_IbJ236EkCxnZUd_pey-Y=.0a33fc3b-e7b2-4684-9440-cdad46e03a67@github.com> <2wTwpGfqYhNYqr0MVH9X9Wizbl1RJv2VDUkvkSa8u7M=.13bd3064-e4a4-4933-97af-fbdbab1f4f7f@github.com> Message-ID: On Tue, 11 Nov 2025 13:38:33 GMT, Andrew John Hughes wrote: > > > Anyway PR got integrated and it seems bot did the right thing. :) > > > > > > Right, fortunately. Still worth doing the merge next time for dependent PRs. > > No real reason for these to be dependent in the first place, as they touch completely different files. Yes, changes are independent. However I wanted to have it tested on Windows x86 in GHA, so I made this fix on top of the other PR. (And made it dependent to avoid changes from the other PR being considered part of this PR.) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/713#issuecomment-3517031724 From jvanek at openjdk.org Tue Nov 11 14:09:23 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 11 Nov 2025 14:09:23 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: On Tue, 28 Oct 2025 13:31:44 GMT, Ji?? Van?k wrote: > Hi! > > I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: > > java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer > at java.lang.ClassLoader$NativeLibrary.load(Native Method) > at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) > at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) > at java.lang.Runtime.loadLibrary0(Runtime.java:843) > at java.lang.System.loadLibrary(System.java:1136) > at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) > at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) > at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) > at java.security.AccessController.doPrivileged(Native Method) > at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) > > > As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` > > This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? > > pandoc --version > pandoc 3.1.11.1 > Features: +server +lua > Scripting engine: Lua 5.4 > > > I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). > > For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 nope configure: Rewriting VS_ENV_CMD to "/cygdrive/c/progra~1/micros~1/2022/commun~1/vc/auxili~1/build/vcvars~2.bat" configure: Trying to extract Visual Studio environment variables ********************************************************************** ** Visual Studio 2022 Developer Command Prompt v17.7.6 ** Copyright (c) 2022 Microsoft Corporation ********************************************************************** [vcvarsall.bat] Environment initialized for: 'x86_x64' Sorry. Mergin in progress ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3517054942 From jvanek at openjdk.org Tue Nov 11 14:09:21 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 11 Nov 2025 14:09:21 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: References: Message-ID: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> > Hi! > > I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: > > java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer > at java.lang.ClassLoader$NativeLibrary.load(Native Method) > at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) > at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) > at java.lang.Runtime.loadLibrary0(Runtime.java:843) > at java.lang.System.loadLibrary(System.java:1136) > at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) > at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) > at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) > at java.security.AccessController.doPrivileged(Native Method) > at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) > > > As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` > > This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? > > pandoc --version > pandoc 3.1.11.1 > Features: +server +lua > Scripting engine: Lua 5.4 > > > I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). > > For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 58ff4ee8c4ec399528338b59eadea996110366a0 Co-authored-by: George Adams ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/709/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=709&range=01 Stats: 168637 lines in 324 files changed: 162607 ins; 5654 del; 376 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/709.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/709/head:pull/709 PR: https://git.openjdk.org/jdk8u-dev/pull/709 From jvanek at openjdk.org Tue Nov 11 14:09:38 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 11 Nov 2025 14:09:38 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: On Tue, 28 Oct 2025 13:31:44 GMT, Ji?? Van?k wrote: > Hi! > > I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: > > java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer > at java.lang.ClassLoader$NativeLibrary.load(Native Method) > at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) > at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) > at java.lang.Runtime.loadLibrary0(Runtime.java:843) > at java.lang.System.loadLibrary(System.java:1136) > at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) > at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) > at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) > at java.security.AccessController.doPrivileged(Native Method) > at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) > > > As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` > > This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? > > pandoc --version > pandoc 3.1.11.1 > Features: +server +lua > Scripting engine: Lua 5.4 > > > I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). > > For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 x86 windows still do not look healthy ERROR: C:\Users\runneradmin\vs-2010-express-1\VS2010Express1.iso Cannot open the file as archive 7-Zip 25.01 (x64) : Copyright (c) 1999-2025 Igor Pavlov : 2025-08-03 Scanning the drive for archives: 1 file, 170 bytes (1 KiB) Extracting archive: C:\Users\runneradmin\vs-2010-express-1\VS2010Express1.iso Can't open as archive: 1 Files: 0 Size: 0 Compressed: 0 Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3517091036 From zzambers at openjdk.org Tue Nov 11 14:14:27 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 11 Nov 2025 14:14:27 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> References: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> Message-ID: On Tue, 11 Nov 2025 14:09:21 GMT, Ji?? Van?k wrote: >> Hi! >> >> I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: >> >> java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer >> at java.lang.ClassLoader$NativeLibrary.load(Native Method) >> at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) >> at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) >> at java.lang.Runtime.loadLibrary0(Runtime.java:843) >> at java.lang.System.loadLibrary(System.java:1136) >> at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) >> at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) >> at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) >> >> >> As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` >> >> This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? >> >> pandoc --version >> pandoc 3.1.11.1 >> Features: +server +lua >> Scripting engine: Lua 5.4 >> >> >> I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). >> >> For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 58ff4ee8c4ec399528338b59eadea996110366a0 > > Co-authored-by: George Adams Hmm, now I see download of VS2010 iso failed in GHA. Windows x86 stubbornly refuses to work. (Download worked few days ago when doing my PRs. Maybe temporary issue?) :( ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3517111319 From andrew at openjdk.org Tue Nov 11 14:34:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Nov 2025 14:34:45 GMT Subject: [jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2] In-Reply-To: References: <3QUZ3Ri4LXpJrJVMNkC87C_IbJ236EkCxnZUd_pey-Y=.0a33fc3b-e7b2-4684-9440-cdad46e03a67@github.com> <2wTwpGfqYhNYqr0MVH9X9Wizbl1RJv2VDUkvkSa8u7M=.13bd3064-e4a4-4933-97af-fbdbab1f4f7f@github.com> Message-ID: On Tue, 11 Nov 2025 13:51:54 GMT, Zdenek Zambersky wrote: > > > > Anyway PR got integrated and it seems bot did the right thing. :) > > > > > > > > > Right, fortunately. Still worth doing the merge next time for dependent PRs. > > > > > > No real reason for these to be dependent in the first place, as they touch completely different files. > > Yes, changes are independent. However I wanted to have it tested on Windows x86 in GHA, so I made this fix on top of the other PR. (And made it dependent to avoid changes from the other PR being considered part of this PR.) Ah yes, true to actually test it of course. But there should be no chance of a merge conflict :) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/713#issuecomment-3517193300 From andrew at openjdk.org Tue Nov 11 14:43:24 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Nov 2025 14:43:24 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: References: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> Message-ID: On Tue, 11 Nov 2025 14:11:49 GMT, Zdenek Zambersky wrote: > Hmm, now I see download of VS2010 iso failed in GHA. Windows x86 stubbornly refuses to work. (Download worked few days ago when doing my PRs. Maybe temporary issue?) :( Maybe. It was just working for @zzambers Checking other archive.org links right now ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3517232777 From zzambers at openjdk.org Tue Nov 11 14:51:22 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 11 Nov 2025 14:51:22 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> References: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> Message-ID: On Tue, 11 Nov 2025 14:09:21 GMT, Ji?? Van?k wrote: >> Hi! >> >> I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: >> >> java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer >> at java.lang.ClassLoader$NativeLibrary.load(Native Method) >> at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) >> at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) >> at java.lang.Runtime.loadLibrary0(Runtime.java:843) >> at java.lang.System.loadLibrary(System.java:1136) >> at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) >> at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) >> at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) >> >> >> As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` >> >> This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? >> >> pandoc --version >> pandoc 3.1.11.1 >> Features: +server +lua >> Scripting engine: Lua 5.4 >> >> >> I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). >> >> For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 58ff4ee8c4ec399528338b59eadea996110366a0 > > Co-authored-by: George Adams Seems like some parts archive.org now giving: 500 Internal Server Error. I was able to download VS2010 using aria2c locally (using torrent), but did not work in GHA in my fork (seems like it depends on mirror chosen for downloading torrent file or something). Regular (fallback used by curl) link giving me "500 Internal Server Error" also locally. Hopefully this will be temporary issue. I don't think we can do anything from our side... (Apart from waiting and trying to reschedule later...) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3517275960 From andrew at openjdk.org Tue Nov 11 15:04:50 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Nov 2025 15:04:50 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: References: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> Message-ID: On Tue, 11 Nov 2025 14:48:54 GMT, Zdenek Zambersky wrote: > Seems like some parts archive.org now giving: 500 Internal Server Error. > > I was able to download VS2010 using aria2c locally (using torrent), but did not work in GHA in my fork (seems like it depends on mirror chosen for downloading torrent file or something). Regular (fallback used by curl) link giving me "500 Internal Server Error" also locally. > > Hopefully this will be temporary issue. I don't think we can do anything from our side... (Apart from waiting and trying to reschedule later...) I concur. All files in that directory seem to be giving this 500 error at the moment. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3517327701 From andrew at openjdk.org Tue Nov 11 15:15:41 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Nov 2025 15:15:41 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> References: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> Message-ID: <8RaWFwmyMeilFX_HoMqXowDphPG81i58knPCf_fydhk=.d67a6719-cc67-4b5b-ae84-52ae46c099a3@github.com> On Tue, 11 Nov 2025 14:09:21 GMT, Ji?? Van?k wrote: >> Hi! >> >> I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: >> >> java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer >> at java.lang.ClassLoader$NativeLibrary.load(Native Method) >> at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) >> at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) >> at java.lang.Runtime.loadLibrary0(Runtime.java:843) >> at java.lang.System.loadLibrary(System.java:1136) >> at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) >> at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) >> at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) >> >> >> As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` >> >> This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? >> >> pandoc --version >> pandoc 3.1.11.1 >> Features: +server +lua >> Scripting engine: Lua 5.4 >> >> >> I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). >> >> For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 58ff4ee8c4ec399528338b59eadea996110366a0 > > Co-authored-by: George Adams Possible alternatives if it doesn't come back: * https://web.archive.org/web/20130811055544/http://download.microsoft.com/download/1/E/5/1E5F1C0A-0D5B-426A-A603-1798B951DDAE/VS2010Express1.iso * https://archive.org/details/en_visual_studio_2010_express_x86_dvd_510419_202310 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3517375516 From duke at openjdk.org Tue Nov 11 22:27:25 2025 From: duke at openjdk.org (Elif Aslan) Date: Tue, 11 Nov 2025 22:27:25 GMT Subject: [jdk8u-dev] RFR: 8257709: C1: Double assignment in InstructionPrinter::print_stack Message-ID: Clean backport.Resolves al2023 fastdebug build failure. This double assignment causes undefined behavior. ------------- Commit messages: - Backport 563b268c8f23a1f9f5e70065419d4e8661d1d0b4 Changes: https://git.openjdk.org/jdk8u-dev/pull/718/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=718&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8257709 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/718.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/718/head:pull/718 PR: https://git.openjdk.org/jdk8u-dev/pull/718 From andrew at openjdk.org Tue Nov 11 22:47:42 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Nov 2025 22:47:42 GMT Subject: [jdk8u-dev] RFR: 8269668: [aarch64] java.library.path not including /usr/lib64 Message-ID: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> The AArch64 `DEFAULT_LIBPATH` on OpenJDK 11 & 17 was adjusted back in July 2021 to include `/usr/lib64` and `/lib64`, as it is a 64-bit architecture where these library directories may be used. 8u was not included in this backporting at the time, leading to inconsistent library loading between AArch64 on OpenJDK 8 and later JDK versions. I don't see any strong reason to retain this inconsistency. Using the conservative version backported to 11u, libraries in `/lib` and `/usr/lib`will still take priority, so the only effect of this change is in allowing the JDK to find libraries on AArch64 systems where libraries are installed in `/lib64` and `/usr/lib64`, where this would currently fail. The content of the change itself applies as is to 8u. The patch did not apply due to differing context and I took this opportunity to also fix the indentation in that section (done as part of the more comprehensive change [JDK-8057109](https://bugs.openjdk.org/browse/JDK-8057109) in OpenJDK 9 and later) rather than breaking the indentation for the new lines. ------------- Commit messages: - Backport 05c76978a6954897500c3dc8ac6aeca0f23e57cd Changes: https://git.openjdk.org/jdk8u-dev/pull/719/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=719&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269668 Stats: 15 lines in 1 file changed: 7 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/719.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/719/head:pull/719 PR: https://git.openjdk.org/jdk8u-dev/pull/719 From serb at openjdk.org Tue Nov 11 22:53:17 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 11 Nov 2025 22:53:17 GMT Subject: [jdk8u-dev] RFR: 8257709: C1: Double assignment in InstructionPrinter::print_stack In-Reply-To: References: Message-ID: On Tue, 11 Nov 2025 22:22:34 GMT, Elif Aslan wrote: > Clean backport.Resolves al2023 fastdebug build failure. This double assignment causes undefined behavior. Looks fine and clean. ------------- Marked as reviewed by serb (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/718#pullrequestreview-3450459486 From andrew at openjdk.org Tue Nov 11 22:57:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Nov 2025 22:57:18 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> References: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> Message-ID: <1ryPLWmyCpFDQ5wXTepUaojGOlRZ5KqI0OuFqecMKjM=.a1bac5e4-c624-4aae-b7de-6abce6793465@github.com> On Tue, 11 Nov 2025 14:09:21 GMT, Ji?? Van?k wrote: >> Hi! >> >> I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: >> >> java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer >> at java.lang.ClassLoader$NativeLibrary.load(Native Method) >> at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) >> at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) >> at java.lang.Runtime.loadLibrary0(Runtime.java:843) >> at java.lang.System.loadLibrary(System.java:1136) >> at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) >> at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) >> at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) >> >> >> As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` >> >> This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? >> >> pandoc --version >> pandoc 3.1.11.1 >> Features: +server +lua >> Scripting engine: Lua 5.4 >> >> >> I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). >> >> For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 58ff4ee8c4ec399528338b59eadea996110366a0 > > Co-authored-by: George Adams It seems to have resolved itself now and is working on my PR, #719 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3519038216 From andrew at openjdk.org Tue Nov 11 23:39:11 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 11 Nov 2025 23:39:11 GMT Subject: [jdk8u-dev] RFR: 8269668: [aarch64] java.library.path not including /usr/lib64 In-Reply-To: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> References: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> Message-ID: <8U2I_uuMkvrl0SG9_PSpAk-dB0OjJOlwanYg43lSrh8=.14f41bfc-98dd-4ef1-ae56-d8d008950622@github.com> On Tue, 11 Nov 2025 22:40:57 GMT, Andrew John Hughes wrote: > The AArch64 `DEFAULT_LIBPATH` on OpenJDK 11 & 17 was adjusted back in July 2021 to include `/usr/lib64` and `/lib64`, as it is a 64-bit architecture where these library directories may be used. 8u was not included in this backporting at the time, leading to inconsistent library loading between AArch64 on OpenJDK 8 and later JDK versions. > > I don't see any strong reason to retain this inconsistency. Using the conservative version backported to 11u, libraries in `/lib` and `/usr/lib`will still take priority, so the only effect of this change is in allowing the JDK to find libraries on AArch64 systems where libraries are installed in `/lib64` and `/usr/lib64`, where this would currently fail. > > The content of the change itself applies as is to 8u. The patch did not apply due to differing context and I took this opportunity to also fix the indentation in that section (done as part of the more comprehensive change [JDK-8057109](https://bugs.openjdk.org/browse/JDK-8057109) in OpenJDK 9 and later) rather than breaking the indentation for the new lines. I don't see how this would break `gc/logging/TestGCId.java` on x86. Existing sporadic failure? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/719#issuecomment-3519176409 From serb at openjdk.org Wed Nov 12 07:12:25 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 12 Nov 2025 07:12:25 GMT Subject: [jdk8u-dev] Integrated: 8305072: Win32ShellFolder2.compareTo is inconsistent In-Reply-To: References: Message-ID: On Tue, 18 Jun 2024 17:03:12 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [2fcb8168](https://github.com/openjdk/jdk/commit/2fcb816858406f33cefef3164b2c85f9f996c7da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 9 Apr 2024 and was reviewed by Phil Race and Sergey Bylokhov. > > The patch is mostly clean, I had to delete `@modules` and `--add-opens` in the test see https://github.com/openjdk/jdk8u-dev/pull/522/commits/2dcba6b8048de90e29c5cd8eaca3be407db2c24e > > The fix verified by the test, no new issues were found by the `:jdk_desktop` tests > > Thanks! This pull request has now been integrated. Changeset: fad33c7d Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/fad33c7dbae384de71f6ac1c110c14bea427f2ba Stats: 159 lines in 2 files changed: 157 ins; 0 del; 2 mod 8305072: Win32ShellFolder2.compareTo is inconsistent Reviewed-by: phh Backport-of: 2fcb816858406f33cefef3164b2c85f9f996c7da ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/522 From jvanek at openjdk.org Wed Nov 12 08:41:14 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 12 Nov 2025 08:41:14 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v3] In-Reply-To: References: Message-ID: > Hi! > > I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: > > java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer > at java.lang.ClassLoader$NativeLibrary.load(Native Method) > at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) > at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) > at java.lang.Runtime.loadLibrary0(Runtime.java:843) > at java.lang.System.loadLibrary(System.java:1136) > at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) > at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) > at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) > at java.security.AccessController.doPrivileged(Native Method) > at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) > > > As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` > > This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? > > pandoc --version > pandoc 3.1.11.1 > Features: +server +lua > Scripting engine: Lua 5.4 > > > I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). > > For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 58ff4ee8c4ec399528338b59eadea996110366a0 Co-authored-by: George Adams ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/709/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=709&range=02 Stats: 168637 lines in 324 files changed: 162607 ins; 5654 del; 376 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/709.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/709/head:pull/709 PR: https://git.openjdk.org/jdk8u-dev/pull/709 From jvanek at openjdk.org Wed Nov 12 08:41:16 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 12 Nov 2025 08:41:16 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> References: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> Message-ID: On Tue, 11 Nov 2025 14:09:21 GMT, Ji?? Van?k wrote: >> Hi! >> >> I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: >> >> java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer >> at java.lang.ClassLoader$NativeLibrary.load(Native Method) >> at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) >> at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) >> at java.lang.Runtime.loadLibrary0(Runtime.java:843) >> at java.lang.System.loadLibrary(System.java:1136) >> at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) >> at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) >> at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) >> >> >> As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` >> >> This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? >> >> pandoc --version >> pandoc 3.1.11.1 >> Features: +server +lua >> Scripting engine: Lua 5.4 >> >> >> I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). >> >> For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. thanx! Rerunning. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3520646750 From sgehwolf at openjdk.org Wed Nov 12 09:09:38 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 12 Nov 2025 09:09:38 GMT Subject: [jdk8u-dev] RFR: 8269668: [aarch64] java.library.path not including /usr/lib64 In-Reply-To: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> References: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> Message-ID: On Tue, 11 Nov 2025 22:40:57 GMT, Andrew John Hughes wrote: > The AArch64 `DEFAULT_LIBPATH` on OpenJDK 11 & 17 was adjusted back in July 2021 to include `/usr/lib64` and `/lib64`, as it is a 64-bit architecture where these library directories may be used. 8u was not included in this backporting at the time, leading to inconsistent library loading between AArch64 on OpenJDK 8 and later JDK versions. > > I don't see any strong reason to retain this inconsistency. Using the conservative version backported to 11u, libraries in `/lib` and `/usr/lib`will still take priority, so the only effect of this change is in allowing the JDK to find libraries on AArch64 systems where libraries are installed in `/lib64` and `/usr/lib64`, where this would currently fail. > > The content of the change itself applies as is to 8u. The patch did not apply due to differing context and I took this opportunity to also fix the indentation in that section (done as part of the more comprehensive change [JDK-8057109](https://bugs.openjdk.org/browse/JDK-8057109) in OpenJDK 9 and later) rather than breaking the indentation for the new lines. OK. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/719#pullrequestreview-3452356658 From jvanek at openjdk.org Wed Nov 12 09:38:40 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 12 Nov 2025 09:38:40 GMT Subject: [jdk8u-dev] RFR: 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on [v6] In-Reply-To: References: Message-ID: > We are seeing rare crashes in jcstress with jdk8 on aarch64 with jfron. Those crashes are real, however we were not able to reproduce with builds on gcc 5 and up. The real culprint was not found. but gcc version on aarch64 should be checked. Ideal version seems 7, but I'm not that bold. > > I think this change must be accompanied by regenerating `generated-configure` but am not sure with process on it. Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - regenerated generated-configure by self built autoconf 2.69 Skipping about 50 hunks like: @@ -50158,7 +50167,7 @@ ac_compiler_gnu=$ac_cv_cxx_compiler_gnu /* end confdefs.h. */ int -main (void) +main () { return 0; ; - Improved error message - Moved compiler version result to earlier stage - 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/697/files - new: https://git.openjdk.org/jdk8u-dev/pull/697/files/78ee959b..99ce7cdf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=697&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=697&range=04-05 Stats: 3338 lines in 69 files changed: 2562 ins; 235 del; 541 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/697.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/697/head:pull/697 PR: https://git.openjdk.org/jdk8u-dev/pull/697 From jvanek at openjdk.org Wed Nov 12 09:38:41 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 12 Nov 2025 09:38:41 GMT Subject: [jdk8u-dev] RFR: 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on [v5] In-Reply-To: <196Y7TKF9GNgwVRcKposFa5qZ_kfOvdgDAEgckqyRPg=.dba882cd-f17d-44e1-9db0-fd2c8cbfb5a4@github.com> References: <196Y7TKF9GNgwVRcKposFa5qZ_kfOvdgDAEgckqyRPg=.dba882cd-f17d-44e1-9db0-fd2c8cbfb5a4@github.com> Message-ID: On Thu, 18 Sep 2025 08:00:59 GMT, Ji?? Van?k wrote: >> We are seeing rare crashes in jcstress with jdk8 on aarch64 with jfron. Those crashes are real, however we were not able to reproduce with builds on gcc 5 and up. The real culprint was not found. but gcc version on aarch64 should be checked. Ideal version seems 7, but I'm not that bold. >> >> I think this change must be accompanied by regenerating `generated-configure` but am not sure with process on it. > > Ji?? Van?k has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > regenerated generated-configure by self built autoconf 2.69 > > Skipping about 50 hunks like: > @@ -50158,7 +50167,7 @@ ac_compiler_gnu=$ac_cv_cxx_compiler_gnu > /* end confdefs.h. */ > > int > -main (void) > +main () > { > return 0; > ; Rebased to tip and reruning checks ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/697#issuecomment-3520985833 From jvanek at openjdk.org Wed Nov 12 10:07:36 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 12 Nov 2025 10:07:36 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: <1ryPLWmyCpFDQ5wXTepUaojGOlRZ5KqI0OuFqecMKjM=.a1bac5e4-c624-4aae-b7de-6abce6793465@github.com> References: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> <1ryPLWmyCpFDQ5wXTepUaojGOlRZ5KqI0OuFqecMKjM=.a1bac5e4-c624-4aae-b7de-6abce6793465@github.com> Message-ID: On Tue, 11 Nov 2025 22:54:57 GMT, Andrew John Hughes wrote: >> Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> Backport 58ff4ee8c4ec399528338b59eadea996110366a0 >> >> Co-authored-by: George Adams > > It seems to have resolved itself now and is working on my PR, #719 @gnu-andrew it is green!-) @zzambers ty! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3521105880 From zzambers at openjdk.org Wed Nov 12 10:27:23 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 12 Nov 2025 10:27:23 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v2] In-Reply-To: References: <3zkh_z_KANZyufuLz6TWCCJZwiKlFvqpVTmse8b9MvU=.47d75af2-d1b0-4311-b089-f7ae60ce7c1f@github.com> <1ryPLWmyCpFDQ5wXTepUaojGOlRZ5KqI0OuFqecMKjM=.a1bac5e4-c624-4aae-b7de-6abce6793465@github.com> Message-ID: <0s9upMecTsklOehVvf9uqdQpa59x7IrN1L2DkZtBL0Q=.e3aeb9ed-2363-4864-995f-87d615388f96@github.com> On Wed, 12 Nov 2025 10:04:29 GMT, Ji?? Van?k wrote: >> It seems to have resolved itself now and is working on my PR, #719 > > @gnu-andrew it is green!-) @zzambers ty! @judovana Wow, completely green, even security infra stuff and all 32-bit tests. Have not seen such for a long time here. Lucky run :) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3521192705 From jvanek at openjdk.org Wed Nov 12 10:47:27 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 12 Nov 2025 10:47:27 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v3] In-Reply-To: References: Message-ID: On Wed, 12 Nov 2025 08:41:14 GMT, Ji?? Van?k wrote: >> Hi! >> >> I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: >> >> java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer >> at java.lang.ClassLoader$NativeLibrary.load(Native Method) >> at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) >> at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) >> at java.lang.Runtime.loadLibrary0(Runtime.java:843) >> at java.lang.System.loadLibrary(System.java:1136) >> at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) >> at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) >> at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) >> >> >> As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` >> >> This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? >> >> pandoc --version >> pandoc 3.1.11.1 >> Features: +server +lua >> Scripting engine: Lua 5.4 >> >> >> I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). >> >> For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 58ff4ee8c4ec399528338b59eadea996110366a0 > > Co-authored-by: George Adams You know.. great PR :). But I think luck had nothing to do with it. Thank you for fixing them. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3521280833 From jvanek at openjdk.org Wed Nov 12 10:49:22 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 12 Nov 2025 10:49:22 GMT Subject: [jdk8u-dev] RFR: 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on [v6] In-Reply-To: References: Message-ID: On Wed, 12 Nov 2025 09:38:40 GMT, Ji?? Van?k wrote: >> We are seeing rare crashes in jcstress with jdk8 on aarch64 with jfron. Those crashes are real, however we were not able to reproduce with builds on gcc 5 and up. The real culprint was not found. but gcc version on aarch64 should be checked. Ideal version seems 7, but I'm not that bold. >> >> I think this change must be accompanied by regenerating `generated-configure` but am not sure with process on it. > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - regenerated generated-configure by self built autoconf 2.69 > > Skipping about 50 hunks like: > @@ -50158,7 +50167,7 @@ ac_compiler_gnu=$ac_cv_cxx_compiler_gnu > /* end confdefs.h. */ > > int > -main (void) > +main () > { > return 0; > ; > - Improved error message > - Moved compiler version result to earlier stage > - 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on `gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java` on linux and `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6` on Mac do not seem related. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/697#issuecomment-3521288528 From sgehwolf at openjdk.org Wed Nov 12 12:46:46 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 12 Nov 2025 12:46:46 GMT Subject: [jdk8u-dev] RFR: 8354941: Build failure with glibc 2.42 due to uabs() name collision In-Reply-To: References: Message-ID: On Mon, 3 Nov 2025 19:28:14 GMT, Andrew John Hughes wrote: > This backport replaces the local definition of `uabs` with `g_uabs` to avoid a conflict with the `uabs` declared in versions of glibc 2.42 and later. > > The patch is mostly clean, with the exception of two conflicts: > > 1. In `assembler_aarch64.cpp`, the type of `uimm` is `unsigned long` in 8u, rather than `uint64_t`. 8u is missing a sequence of changes, which begins with [JDK-8248414](https://bugs.openjdk.org/browse/JDK-8248414), "AArch64: Remove uses of long and unsigned long ints" and [JDK-8251930](https://bugs.openjdk.org/browse/JDK-8251930), "AArch64: Native types mismatch in hotspot", but these in turn require adaptation to work around other missing changes like [JDK-8222412](https://bugs.openjdk.org/browse/JDK-8222412) "AARCH64: multiple instructions encoding issues" and [JDK-8139043](https://bugs.openjdk.org/browse/JDK-8139043), "aarch64: add support for adler32 intrinsic". Backporting 8248414 & 8251930 may be worthwhile, especially if Windows & Mac AArch64 ports are ever considered for 8u, but really needs to be done by someone with access to AArch64 hardware to verify the changes. I don't think it's necessary just for a simple name substitution. > 2. In `stubGenerator_aarch64.cpp`, I corrected the type of `granularity` in `copy_memory(bool, Register, Register, Register, Register, int)` from `int` to `unsigned int`, which matches the signature of `g_uabs`. This same correction was made in later JDKs as part of an enhancement, [JDK-8257436](https://bugs.openjdk.org/browse/JDK-8257436) "Regressions in ArrayCopyUnalignedDst.testByte/testChar for 65-78 bytes when UseSIMDForMemoryOps is on". Again, the rest may be worth backporting if the same performance improvement is visible on 8u AArch64, but the risk isn't appropriate for this change. > > The change was verified by ensuring that `uabs` no longer exists in the source code after this patch. > ~~~ > $ grep -r 'uabs' hotspot/ > hotspot/src/cpu/aarch64/vm/assembler_aarch64.hpp: return g_uabs(target - branch) < branch_range; > hotspot/src/cpu/aarch64/vm/macroAssembler_aarch64.cpp: if (g_uabs(imm) < (1 << 24)) { > hotspot/src/cpu/aarch64/vm/stubGenerator_aarch64.cpp: size_t granularity = g_uabs(step); > hotspot/src/cpu/aarch64/vm/stubGenerator_aarch64.cpp: unsigned int granularity = g_uabs(step); > hotspot/src/cpu/aarch64/vm/assembler_aarch64.cpp: unsigned long uimm = g_uabs(imm); > hotspot/src/share/vm/opto/mulnode.cpp: unsigned int abs_con = g_uabs(con); > hotspot/src/share/vm/opto/mulnode.cpp: julong abs_con = g_... This seems OK. It would be good to merge latest master to get cleaner GHA runs. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/711#pullrequestreview-3453251365 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/711#issuecomment-3521751573 From sgehwolf at openjdk.org Wed Nov 12 13:36:37 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 12 Nov 2025 13:36:37 GMT Subject: [jdk8u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v2] In-Reply-To: References: Message-ID: On Fri, 19 Sep 2025 18:51:57 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this is a backport of openjdk/jdk11u-dev#3098. The backport isn't clean, because of the following: >> >> * File paths that require adjustment for 8u >> * In `Main.java`, trivial context differences and code that needs adjustment from 11u to 8u: >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `InputStream::transferTo(OutputStream.nullOutputStream())` ? [original code before a review suggestion](https://github.com/openjdk/jdk/pull/23532/commits/ef546f4b778e8a1f43dbedc56a79bb53d169a1e7#diff-7083af3b8473a092987afa0bbb4d1694664649534bac716f6b9cd3c3b9833219L1185-L1186) >> * In the test (`VerifyJarEntryName.java`), code that needs adjustment from 11u to 8u: >> * `@library /test/lib` ? `@library /lib/testlibrary` >> * JUnit 5 ? JUnit 4 >> * `org.junit.jupiter.api.BeforeAll` ? `org.junit.BeforeClass` >> * `org.junit.jupiter.api.BeforeEach` ? `org.junit.Before` >> * `org.junit.jupiter.api.Test` ? `org.junit.Test` >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `@BeforeClass`, `@Before` and `@Test` methods must be public >> * Can't use `var` >> * `Arrays.equals(a, start, end, b, 0, b.length)` ? `Arrays.equals(Arrays.copyOfRange(a, start, end), b)` (`Arrays::equals` with offsets not present in 8u) >> * ~~NOTE: for the Japanese manpages translation approach, please refer to openjdk/jdk11u-dev#3098~~ >> * ~~I updated `jdk/src/linux/doc/man/ja/jarsigner.1` and `jdk/src/solaris/doc/sun/man/man1/ja/jarsigner.1` (identical), and left `dk/src/bsd/doc/man/ja/jarsigner.1` untouched (doesn't have any content besides the headers)~~ >> * $\mbox{\color{red}UPDATE}$ (28348b29f892b685d9098c4560128a8bfb206afd): all the internationalized messages have been removed, as they aren't typically included in backports (thanks @jerboaa for letting me know). >> >> #### Related issues ("relates to" Jira issue links) >> >> [JDK-8353299](https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails") (openjdk/jdk at acd4da49a01760599ec4c325ff6c56f53ba5cc9c) and [JDK-8367782](https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName") (openjdk/jdk at 1b9a11682d5f73885213822423bfce8dfc17febd) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of `VerifyJarEntryName.java`. >> >> Since `test/hotspot/jtreg/runtime/appcds/SignedJar.java` is ... > > Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: > > Remove internationalized messages This looks OK to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/699#pullrequestreview-3453487264 From andrew at openjdk.org Wed Nov 12 14:13:48 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 12 Nov 2025 14:13:48 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v3] In-Reply-To: References: Message-ID: On Wed, 12 Nov 2025 08:41:14 GMT, Ji?? Van?k wrote: >> Hi! >> >> I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: >> >> java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer >> at java.lang.ClassLoader$NativeLibrary.load(Native Method) >> at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) >> at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) >> at java.lang.Runtime.loadLibrary0(Runtime.java:843) >> at java.lang.System.loadLibrary(System.java:1136) >> at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) >> at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) >> at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) >> >> >> As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` >> >> This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? >> >> pandoc --version >> pandoc 3.1.11.1 >> Features: +server +lua >> Scripting engine: Lua 5.4 >> >> >> I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). >> >> For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 58ff4ee8c4ec399528338b59eadea996110366a0 > > Co-authored-by: George Adams Testing looks good. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/709#pullrequestreview-3453651360 From andrew at openjdk.org Wed Nov 12 14:13:48 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 12 Nov 2025 14:13:48 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v3] In-Reply-To: References: Message-ID: On Wed, 12 Nov 2025 10:44:56 GMT, Ji?? Van?k wrote: >> Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: >> >> Backport 58ff4ee8c4ec399528338b59eadea996110366a0 >> >> Co-authored-by: George Adams > > You know.. great PR :). But I think luck had nothing to do with it. Thank you for fixing them. > @judovana Wow, completely green, even security infra stuff and all 32-bit tests. Have not seen such for a long time here. Lucky run :) Clearly GHA is eager for FreeType support too ;) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3522142833 From aph at openjdk.org Wed Nov 12 14:23:50 2025 From: aph at openjdk.org (Andrew Haley) Date: Wed, 12 Nov 2025 14:23:50 GMT Subject: [jdk8u-dev] RFR: 8269668: [aarch64] java.library.path not including /usr/lib64 In-Reply-To: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> References: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> Message-ID: On Tue, 11 Nov 2025 22:40:57 GMT, Andrew John Hughes wrote: > The AArch64 `DEFAULT_LIBPATH` on OpenJDK 11 & 17 was adjusted back in July 2021 to include `/usr/lib64` and `/lib64`, as it is a 64-bit architecture where these library directories may be used. 8u was not included in this backporting at the time, leading to inconsistent library loading between AArch64 on OpenJDK 8 and later JDK versions. > > I don't see any strong reason to retain this inconsistency. Using the conservative version backported to 11u, libraries in `/lib` and `/usr/lib`will still take priority, so the only effect of this change is in allowing the JDK to find libraries on AArch64 systems where libraries are installed in `/lib64` and `/usr/lib64`, where this would currently fail. > > The content of the change itself applies as is to 8u. The patch did not apply due to differing context and I took this opportunity to also fix the indentation in that section (done as part of the more comprehensive change [JDK-8057109](https://bugs.openjdk.org/browse/JDK-8057109) in OpenJDK 9 and later) rather than breaking the indentation for the new lines. Marked as reviewed by aph (Lead). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/719#pullrequestreview-3453699655 From jvanek at openjdk.org Wed Nov 12 14:47:19 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 12 Nov 2025 14:47:19 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v3] In-Reply-To: References: Message-ID: <6H1G9bH8xtpw9aAx2fCh30FGw4gzkld0J_8ZrhiSYn4=.51808668-6e59-4244-ad1d-3f77de610654@github.com> On Wed, 12 Nov 2025 08:41:14 GMT, Ji?? Van?k wrote: >> Hi! >> >> I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: >> >> java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer >> at java.lang.ClassLoader$NativeLibrary.load(Native Method) >> at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) >> at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) >> at java.lang.Runtime.loadLibrary0(Runtime.java:843) >> at java.lang.System.loadLibrary(System.java:1136) >> at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) >> at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) >> at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) >> at java.security.AccessController.doPrivileged(Native Method) >> at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) >> >> >> As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` >> >> This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? >> >> pandoc --version >> pandoc 3.1.11.1 >> Features: +server +lua >> Scripting engine: Lua 5.4 >> >> >> I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). >> >> For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 58ff4ee8c4ec399528338b59eadea996110366a0 > > Co-authored-by: George Adams Note that I'm not commiter, so would be nice somebody sponsors this. ty! Looking forward to see this in! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3522307974 From jvanek at openjdk.org Wed Nov 12 14:49:32 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 12 Nov 2025 14:49:32 GMT Subject: [jdk8u-dev] Integrated: 8193017: Import freetype sources into OpenJDK source tree In-Reply-To: References: Message-ID: On Tue, 28 Oct 2025 13:31:44 GMT, Ji?? Van?k wrote: > Hi! > > I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar: > > java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-1.8.0-openjdk-jdk8u462.b05-0.ojdk8~u~upstream.hotspot.release.sdk.el7.x86_64.tarxz/jre/lib/amd64/libfontmanager.so: /lib64/libharfbuzz.so.0: undefined symbol: FT_Get_Color_Glyph_Layer > at java.lang.ClassLoader$NativeLibrary.load(Native Method) > at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) > at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) > at java.lang.Runtime.loadLibrary0(Runtime.java:843) > at java.lang.System.loadLibrary(System.java:1136) > at sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32) > at sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:85) > at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:137) > at java.security.AccessController.doPrivileged(Native Method) > at sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:74) > > > As per investigations the issue is in duality of freetype, and is solved by `8193017: Import freetype sources into OpenJDK source tree` > > This is fully based on unfinished https://github.com/openjdk/jdk8u-dev/pull/318 , with smal lexception of rebase, and docs adaptation. The change in `doc/building.html ` is unluckily done manually, as `make update-build-docs` is regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use? > > pandoc --version > pandoc 3.1.11.1 > Features: +server +lua > Scripting engine: Lua 5.4 > > > I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running). > > For record, I built by temurin build wrapper, which needed an change to adapt to this: https://github.com/adoptium/temurin-build/pull/4287 This pull request has now been integrated. Changeset: 335fce59 Author: Ji?? Van?k Committer: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/335fce5950cdb8f5e2227019ad3a908432654211 Stats: 168637 lines in 324 files changed: 162607 ins; 5654 del; 376 mod 8193017: Import freetype sources into OpenJDK source tree Co-authored-by: George Adams Reviewed-by: andrew Backport-of: 58ff4ee8c4ec399528338b59eadea996110366a0 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/709 From ktakakuri at openjdk.org Thu Nov 13 11:24:22 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 13 Nov 2025 11:24:22 GMT Subject: [jdk8u-dev] RFR: 8371387: [8u] hotspot needs to recognise latest VS2022 In-Reply-To: References: Message-ID: On Thu, 6 Nov 2025 07:07:18 GMT, Kazuhisa Takakuri wrote: > This fix updates the hotspot build script to recognize the latest version of VS2022. The fix is similar to: #412. > I confirmed that the build succeeds using Visual Studio 2022 17.14 with this fix. @gnu-andrew I apologize for bothering you during your busy schedule, but could you please review the Fix Request? I would like to include this fix in the January release. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/714#issuecomment-3527343467 From serb at openjdk.org Thu Nov 13 18:00:47 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 13 Nov 2025 18:00:47 GMT Subject: [jdk8u-dev] RFR: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above [v2] In-Reply-To: <5u5R1gq0ZcLvJ8y7wI6ci9Q_i9sqFQu-AY2Pn3OLAM4=.f69fe961-48ab-4869-9567-0231e9b524a5@github.com> References: <5u5R1gq0ZcLvJ8y7wI6ci9Q_i9sqFQu-AY2Pn3OLAM4=.f69fe961-48ab-4869-9567-0231e9b524a5@github.com> Message-ID: > Hi all, > > This pull request contains a backport of commit [37123ee7](https://github.com/openjdk/jdk11u-dev/commit/37123ee7a5058ec81f2ef85a68fe9ae43b0ba216) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Sergey Bylokhov on 27 Aug 2025 and had no reviewers. > > The patch is clean(need to fix copyright and path to the test) and has been verified by the new test. No new issues were found by the jdk_desktop tests. The patch fixes the fullscreen windows, which are currently non-functional. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-37123ee7-master - Backport 37123ee7a5058ec81f2ef85a68fe9ae43b0ba216 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/694/files - new: https://git.openjdk.org/jdk8u-dev/pull/694/files/93f10cf1..e588f1d9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=694&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=694&range=00-01 Stats: 172279 lines in 396 files changed: 165439 ins; 5904 del; 936 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/694.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/694/head:pull/694 PR: https://git.openjdk.org/jdk8u-dev/pull/694 From serb at openjdk.org Thu Nov 13 18:28:19 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 13 Nov 2025 18:28:19 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v3] In-Reply-To: <6H1G9bH8xtpw9aAx2fCh30FGw4gzkld0J_8ZrhiSYn4=.51808668-6e59-4244-ad1d-3f77de610654@github.com> References: <6H1G9bH8xtpw9aAx2fCh30FGw4gzkld0J_8ZrhiSYn4=.51808668-6e59-4244-ad1d-3f77de610654@github.com> Message-ID: On Wed, 12 Nov 2025 14:44:48 GMT, Ji?? Van?k wrote: >> Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> Backport 58ff4ee8c4ec399528338b59eadea996110366a0 >> >> Co-authored-by: George Adams > > Note that I'm not commiter, so would be nice somebody sponsors this. ty! Looking forward to see this in! @judovana, are you planning to work on the followup issues to bump the freetype version to match the one used in jdk11+? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3529129860 From duke at openjdk.org Thu Nov 13 23:17:36 2025 From: duke at openjdk.org (duke) Date: Thu, 13 Nov 2025 23:17:36 GMT Subject: [jdk8u-dev] Withdrawn: 8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file In-Reply-To: References: Message-ID: <-9nbzIq8UC21XVQQ-G8PxnYS7bmL3_wR06qwwQ-k25U=.76a488c3-5a47-4a73-b2a4-90a3ba4a4636@github.com> On Thu, 18 Sep 2025 07:07:08 GMT, John Jiang wrote: > `java/util/zip/DeflateIn_InflateOut.java` failed with a system zlib. > The backport is clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/698 From duke at openjdk.org Thu Nov 13 23:30:41 2025 From: duke at openjdk.org (duke) Date: Thu, 13 Nov 2025 23:30:41 GMT Subject: [jdk8u-dev] Withdrawn: 8303482: Update LCMS to 2.15 In-Reply-To: References: Message-ID: On Thu, 21 Aug 2025 23:04:18 GMT, Ekaterina Vergizova wrote: > I'd like to backport it for parity with Oracle 8u. > 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. > > GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/678 From evergizova at openjdk.org Thu Nov 13 23:38:41 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Thu, 13 Nov 2025 23:38:41 GMT Subject: [jdk8u-dev] Withdrawn: 8321489: Update LCMS to 2.16 In-Reply-To: References: Message-ID: On Fri, 22 Aug 2025 16:49:35 GMT, Ekaterina Vergizova wrote: > I'd like to backport it for parity with Oracle 8u. > 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. > > GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/679 From evergizova at openjdk.org Thu Nov 13 23:39:18 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Thu, 13 Nov 2025 23:39:18 GMT Subject: [jdk8u-dev] Withdrawn: 8348110: Update LCMS to 2.17 In-Reply-To: References: Message-ID: On Fri, 22 Aug 2025 18:47:47 GMT, Ekaterina Vergizova wrote: > I'd like to backport it for parity with Oracle 8u. > 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. > > GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/680 From jvanek at openjdk.org Fri Nov 14 08:57:22 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 14 Nov 2025 08:57:22 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v3] In-Reply-To: References: <6H1G9bH8xtpw9aAx2fCh30FGw4gzkld0J_8ZrhiSYn4=.51808668-6e59-4244-ad1d-3f77de610654@github.com> Message-ID: <36U3nG6uRJhSu5J-GObRmJwb15fblf9E1yq4wNflZAM=.5d853915-d793-43cb-966a-bcfe41c7a3db@github.com> On Thu, 13 Nov 2025 18:25:34 GMT, Sergey Bylokhov wrote: >> Note that I'm not commiter, so would be nice somebody sponsors this. ty! Looking forward to see this in! > > @judovana, are you planning to work on the followup issues to bump the freetype version to match the one used in jdk11+? @mrserb hi! I have no objections to do so, and test that. if it is wanted, which I guess it is. That would be directly to https://bugs.openjdk.org/browse/JDK-8351538 ? Or one by one? Generally any gudidance to save both mine and reviewers cycles Welcomed. Thanx for pointing it out. I wanted to do it as part of the rebase, but Andrew advised against, and that was good intermediate step. Is it supposed to target before January CPU,or rather later? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3531660303 From jvanek at openjdk.org Fri Nov 14 10:10:02 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 14 Nov 2025 10:10:02 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v3] In-Reply-To: References: <6H1G9bH8xtpw9aAx2fCh30FGw4gzkld0J_8ZrhiSYn4=.51808668-6e59-4244-ad1d-3f77de610654@github.com> Message-ID: On Thu, 13 Nov 2025 18:25:34 GMT, Sergey Bylokhov wrote: >> Note that I'm not commiter, so would be nice somebody sponsors this. ty! Looking forward to see this in! > > @judovana, are you planning to work on the followup issues to bump the freetype version to match the one used in jdk11+? @mrserb Unless you advice differently, I will be backporting one by one, not necessasrily doing PR with each minor, but will be testing build-ability on old systems. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3531959598 From jvanek at openjdk.org Fri Nov 14 10:52:42 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 14 Nov 2025 10:52:42 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v3] In-Reply-To: References: <6H1G9bH8xtpw9aAx2fCh30FGw4gzkld0J_8ZrhiSYn4=.51808668-6e59-4244-ad1d-3f77de610654@github.com> Message-ID: <5BAnxmfgnEtJEOSp6sqMVBVnvxNHQyj7erngl6ysreA=.7d5772d0-ce96-4b81-ac49-a11665a2139a@github.com> On Thu, 13 Nov 2025 18:25:34 GMT, Sergey Bylokhov wrote: >> Note that I'm not commiter, so would be nice somebody sponsors this. ty! Looking forward to see this in! > > @judovana, are you planning to work on the followup issues to bump the freetype version to match the one used in jdk11+? @mrserb Despite from build system, only " --- jdk/make/lib/Awt2dLibraries.gmk +++ jdk/make/lib/Awt2dLibraries.gmk @@ -541,6 +541,7 @@ else E_STATEMENT_NOT_REACHED \ E_END_OF_LOOP_CODE_NOT_REACHED, \ DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ LDFLAGS := $(LDFLAGS_JDKLIB) \ $(call SET_SHARED_LIBRARY_ORIGIN), \ )) is present in 2.9.1, it requires https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 thoughts? I guess I will bring it on jdk8u mailing liat... ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/709#issuecomment-3532154010 From andrew at openjdk.org Mon Nov 17 22:29:36 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 17 Nov 2025 22:29:36 GMT Subject: [jdk8u-dev] Integrated: 8269668: [aarch64] java.library.path not including /usr/lib64 In-Reply-To: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> References: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> Message-ID: On Tue, 11 Nov 2025 22:40:57 GMT, Andrew John Hughes wrote: > The AArch64 `DEFAULT_LIBPATH` on OpenJDK 11 & 17 was adjusted back in July 2021 to include `/usr/lib64` and `/lib64`, as it is a 64-bit architecture where these library directories may be used. 8u was not included in this backporting at the time, leading to inconsistent library loading between AArch64 on OpenJDK 8 and later JDK versions. > > I don't see any strong reason to retain this inconsistency. Using the conservative version backported to 11u, libraries in `/lib` and `/usr/lib`will still take priority, so the only effect of this change is in allowing the JDK to find libraries on AArch64 systems where libraries are installed in `/lib64` and `/usr/lib64`, where this would currently fail. > > The content of the change itself applies as is to 8u. The patch did not apply due to differing context and I took this opportunity to also fix the indentation in that section (done as part of the more comprehensive change [JDK-8057109](https://bugs.openjdk.org/browse/JDK-8057109) in OpenJDK 9 and later) rather than breaking the indentation for the new lines. This pull request has now been integrated. Changeset: a87381a6 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/a87381a6e8c008ada0152128aa581319e2ef99b3 Stats: 15 lines in 1 file changed: 7 ins; 0 del; 8 mod 8269668: [aarch64] java.library.path not including /usr/lib64 Reviewed-by: sgehwolf, aph Backport-of: 05c76978a6954897500c3dc8ac6aeca0f23e57cd ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/719 From andrew at openjdk.org Mon Nov 17 22:29:35 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 17 Nov 2025 22:29:35 GMT Subject: [jdk8u-dev] RFR: 8269668: [aarch64] java.library.path not including /usr/lib64 In-Reply-To: References: <-aLKggt8pyLCSMV-tycizzhBh9BeXEaY5245Sn9YRLE=.267d7967-824a-4ff7-90f7-b230eb971a5a@github.com> Message-ID: <1Rp6OPcopwIKuSIZdpilUp7lVTI5JwXJGSpVTDKQHTc=.5ce137d6-8ef3-48af-a1d7-b4129eb61df5@github.com> On Wed, 12 Nov 2025 09:07:00 GMT, Severin Gehwolf wrote: >> The AArch64 `DEFAULT_LIBPATH` on OpenJDK 11 & 17 was adjusted back in July 2021 to include `/usr/lib64` and `/lib64`, as it is a 64-bit architecture where these library directories may be used. 8u was not included in this backporting at the time, leading to inconsistent library loading between AArch64 on OpenJDK 8 and later JDK versions. >> >> I don't see any strong reason to retain this inconsistency. Using the conservative version backported to 11u, libraries in `/lib` and `/usr/lib`will still take priority, so the only effect of this change is in allowing the JDK to find libraries on AArch64 systems where libraries are installed in `/lib64` and `/usr/lib64`, where this would currently fail. >> >> The content of the change itself applies as is to 8u. The patch did not apply due to differing context and I took this opportunity to also fix the indentation in that section (done as part of the more comprehensive change [JDK-8057109](https://bugs.openjdk.org/browse/JDK-8057109) in OpenJDK 9 and later) rather than breaking the indentation for the new lines. > > OK. Thanks @jerboaa & @theRealAph ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/719#issuecomment-3544110178 From ktakakuri at openjdk.org Tue Nov 18 00:45:32 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 18 Nov 2025 00:45:32 GMT Subject: [jdk8u-dev] RFR: 8371387: [8u] hotspot needs to recognise latest VS2022 In-Reply-To: References: Message-ID: On Thu, 6 Nov 2025 07:07:18 GMT, Kazuhisa Takakuri wrote: > This fix updates the hotspot build script to recognize the latest version of VS2022. The fix is similar to: #412. > I confirmed that the build succeeds using Visual Studio 2022 17.14 with this fix. Thank you for your assistance. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/714#issuecomment-3544542528 From ktakakuri at openjdk.org Tue Nov 18 00:45:33 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 18 Nov 2025 00:45:33 GMT Subject: [jdk8u-dev] Integrated: 8371387: [8u] hotspot needs to recognise latest VS2022 In-Reply-To: References: Message-ID: On Thu, 6 Nov 2025 07:07:18 GMT, Kazuhisa Takakuri wrote: > This fix updates the hotspot build script to recognize the latest version of VS2022. The fix is similar to: #412. > I confirmed that the build succeeds using Visual Studio 2022 17.14 with this fix. This pull request has now been integrated. Changeset: fcd1361e Author: Kazuhisa Takakuri URL: https://git.openjdk.org/jdk8u-dev/commit/fcd1361e9e661620dfa6e8b0b35f994c4f9a23f1 Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod 8371387: [8u] hotspot needs to recognise latest VS2022 Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/714 From syan at openjdk.org Tue Nov 18 03:20:23 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 18 Nov 2025 03:20:23 GMT Subject: [jdk8u-dev] RFR: 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points [v3] In-Reply-To: References: Message-ID: <-N88WzzLdOmxPEVcIav_feEzramSoW_-0V-V3r8KWZ8=.4491a261-8825-4797-86a4-13d0ebfc2b73@github.com> > Hi all, > > This pull request contains a backport of commit [b6876649](https://github.com/openjdk/jdk/commit/b6876649a82bed508d817ccbde1600d00937e4b2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This backport PR try to fix the test bug, test will skip the '/run/user' directory when it throw FileSystemException. This PR add `import jdk.test.lib.Platform;` and `@library /test/lib` make this backport uncleanly, other parts are backport cleanly. > > Change has been verified locally, test-fix only, no risk. > > Thanks! SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into jbs8277159 - Add "@libiray /test/lib" and "import jdk.test.lib.Platform;" - Backport b6876649a82bed508d817ccbde1600d00937e4b2 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/705/files - new: https://git.openjdk.org/jdk8u-dev/pull/705/files/2f4d2fa0..c9cc3c0b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=705&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=705&range=01-02 Stats: 169722 lines in 352 files changed: 163519 ins; 5744 del; 459 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/705.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/705/head:pull/705 PR: https://git.openjdk.org/jdk8u-dev/pull/705 From jvanek at openjdk.org Wed Nov 19 11:21:25 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 19 Nov 2025 11:21:25 GMT Subject: [jdk8u-dev] RFR: 8222362: Upgrade to Freetype 2.10.0 Message-ID: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Without index 00d35a69844..3464eb15e88 100644 --- a/jdk/make/lib/Awt2dLibraries.gmk +++ b/jdk/make/lib/Awt2dLibraries.gmk @@ -541,6 +541,7 @@ else E_STATEMENT_NOT_REACHED \ E_END_OF_LOOP_CODE_NOT_REACHED, \ DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ LDFLAGS := $(LDFLAGS_JDKLIB) \ $(call SET_SHARED_LIBRARY_ORIGIN), \ )) which needs https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk ------------- Commit messages: - 8222362: Upgrade to Freetype 2.10.0 - 8203367: Upgrade to freetype 2.9.1 Changes: https://git.openjdk.org/jdk8u-dev/pull/720/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=720&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8222362 Stats: 36875 lines in 315 files changed: 5646 ins; 5323 del; 25906 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/720.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/720/head:pull/720 PR: https://git.openjdk.org/jdk8u-dev/pull/720 From jvanek at openjdk.org Wed Nov 19 11:21:26 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 19 Nov 2025 11:21:26 GMT Subject: [jdk8u-dev] RFR: 8222362: Upgrade to Freetype 2.10.0 In-Reply-To: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: On Fri, 14 Nov 2025 10:53:19 GMT, Ji?? Van?k wrote: > Without > > index 00d35a69844..3464eb15e88 100644 > --- a/jdk/make/lib/Awt2dLibraries.gmk > +++ b/jdk/make/lib/Awt2dLibraries.gmk > @@ -541,6 +541,7 @@ else > E_STATEMENT_NOT_REACHED \ > E_END_OF_LOOP_CODE_NOT_REACHED, \ > DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ > + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ > LDFLAGS := $(LDFLAGS_JDKLIB) \ > $(call SET_SHARED_LIBRARY_ORIGIN), \ > )) > > which needs > https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: > https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk runtime/containers/docker/TestCPUAwareness.java from linux x64 nor gc/6581734/Test6581734.java gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java on linux i686 does not looks related. Am running it locally, and wills tart full multi paltform/multi OS QA in Monday. Any inputs welcomed, especially about the `8199639: Introduce SetupJdkLibrary and SetupJdkExecutable`. In future updates, following changes to build happens: * 8222362: Upgrade to Freetype 2.10.0 index bad68c7d3e2..9c7c251779f 100644 --- a/make/lib/Awt2dLibraries.gmk +++ b/make/lib/Awt2dLibraries.gmk @@ -503,6 +503,8 @@ else LIBFREETYPE_CFLAGS := -I$(BUILD_LIBFREETYPE_HEADER_DIRS) ifeq ($(OPENJDK_TARGET_OS), windows) LIBFREETYPE_LIBS := $(SUPPORT_OUTPUTDIR)/native/$(MODULE)/libfreetype/freetype.lib + # freetype now requires you to manually define this (see ftconfig.h) + BUILD_LIBFREETYPE_CFLAGS += -DDLL_EXPORT else LIBFREETYPE_LIBS := -lfreetype endif @@ -516,8 +518,8 @@ else DISABLED_WARNINGS_solstudio := \ E_STATEMENT_NOT_REACHED \ E_END_OF_LOOP_CODE_NOT_REACHED, \ - DISABLED_WARNINGS_microsoft := 4267 4244 4312 4819, \ - DISABLED_WARNINGS_gcc := implicit-fallthrough, \ + DISABLED_WARNINGS_microsoft := 4018 4267 4244 4312 4819, \ + DISABLED_WARNINGS_gcc := implicit-fallthrough cast-function-type bad-function-cast, \ LDFLAGS := $(LDFLAGS_JDKLIB) \ $(call SET_SHARED_LIBRARY_ORIGIN), \ )) * 8306881: Update FreeType to 2.13.0 index 19ef7ba0410..fecbb248a7c 100644 --- a/make/lib/Awt2dLibraries.gmk +++ b/make/lib/Awt2dLibraries.gmk @@ -527,6 +527,7 @@ else E_END_OF_LOOP_CODE_NOT_REACHED, \ DISABLED_WARNINGS_microsoft := 4018 4267 4244 4312 4819, \ DISABLED_WARNINGS_gcc := implicit-fallthrough cast-function-type bad-function-cast, \ + DISABLED_WARNINGS_clang := missing-declarations, \ LDFLAGS := $(LDFLAGS_JDKLIB) \ $(call SET_SHARED_LIBRARY_ORIGIN), \ )) and side one: * 8324347: Enable "maybe-uninitialized" warning for FreeType index 73bb9325194..37f35dd3214 100644 --- a/make/lib/Awt2dLibraries.gmk +++ b/make/lib/Awt2dLibraries.gmk @@ -516,7 +516,6 @@ else LIBFREETYPE_LIBS := -lfreetype endif - # gcc_ftobjs.c := maybe-uninitialized required for GCC 7 builds. $(eval $(call SetupJdkLibrary, BUILD_LIBFREETYPE, \ NAME := freetype, \ OPTIMIZATION := HIGHEST, \ @@ -529,7 +528,6 @@ else DISABLED_WARNINGS_microsoft := 4018 4267 4244 4312 4819, \ DISABLED_WARNINGS_gcc := implicit-fallthrough cast-function-type bad-function-cast, \ DISABLED_WARNINGS_clang := missing-declarations, \ - DISABLED_WARNINGS_gcc_ftobjs.c := maybe-uninitialized, \ LDFLAGS := $(LDFLAGS_JDKLIB) \ $(call SET_SHARED_LIBRARY_ORIGIN), \ )) Ok, now updated to 2.10. As noted before, umiteed hunks were: --- jdk/make/lib/Awt2dLibraries.gmk +++ jdk/make/lib/Awt2dLibraries.gmk @@ -503,6 +503,8 @@ else LIBFREETYPE_CFLAGS := -I$(BUILD_LIBFREETYPE_HEADER_DIRS) ifeq ($(OPENJDK_TARGET_OS), windows) LIBFREETYPE_LIBS := $(SUPPORT_OUTPUTDIR)/native/$(MODULE)/libfreetype/freetype.lib + # freetype now requires you to manually define this (see ftconfig.h) + BUILD_LIBFREETYPE_CFLAGS += -DDLL_EXPORT else LIBFREETYPE_LIBS := -lfreetype endif @@ -516,8 +518,8 @@ else DISABLED_WARNINGS_solstudio := \ E_STATEMENT_NOT_REACHED \ E_END_OF_LOOP_CODE_NOT_REACHED, \ - DISABLED_WARNINGS_microsoft := 4267 4244 4312 4819, \ - DISABLED_WARNINGS_gcc := implicit-fallthrough, \ + DISABLED_WARNINGS_microsoft := 4018 4267 4244 4312 4819, \ + DISABLED_WARNINGS_gcc := implicit-fallthrough cast-function-type bad-function-cast, \ LDFLAGS := $(LDFLAGS_JDKLIB) \ $(call SET_SHARED_LIBRARY_ORIGIN), \ )) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3532335612 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3532629877 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3552139727 From jvanek at openjdk.org Wed Nov 19 11:21:27 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 19 Nov 2025 11:21:27 GMT Subject: [jdk8u-dev] RFR: 8222362: Upgrade to Freetype 2.10.0 In-Reply-To: <-ZdyVDkIahSPcrGQyPHzBgW4hFzJgjYh5hbD0HUBpLQ=.c0783cea-76f1-4953-87c4-4870acb7d509@github.com> References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> <-ZdyVDkIahSPcrGQyPHzBgW4hFzJgjYh5hbD0HUBpLQ=.c0783cea-76f1-4953-87c4-4870acb7d509@github.com> Message-ID: On Wed, 19 Nov 2025 00:24:56 GMT, Andrew John Hughes wrote: >> Without >> >> index 00d35a69844..3464eb15e88 100644 >> --- a/jdk/make/lib/Awt2dLibraries.gmk >> +++ b/jdk/make/lib/Awt2dLibraries.gmk >> @@ -541,6 +541,7 @@ else >> E_STATEMENT_NOT_REACHED \ >> E_END_OF_LOOP_CODE_NOT_REACHED, \ >> DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ >> + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ >> LDFLAGS := $(LDFLAGS_JDKLIB) \ >> $(call SET_SHARED_LIBRARY_ORIGIN), \ >> )) >> >> which needs >> https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: >> https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk > > I think we may need to merge this with at least [8222362](https://bugs.openjdk.org/browse/JDK-8222362): "Upgrade to Freetype 2.10.0" as the 2.9.1 is not public and so Skara can't pick it up as a backport. As long as both bugs are credited and in separate commits I'm fine with this. > > As to the warning flags, we should just add them as `CFLAGS`. The `-DDLL_EXPORT` is actually already there. It should be easy enough to just add things like `BUILD_LIBFREETYPE_CFLAGS += -Wno-implicit-fallthrough` when on Linux. However, I'm not sure we even need them on 8u - at least not immediately - as I don't think it builds with warnings as errors for the JDK code as it stands. Hi @gnu-andrew ! Sure thing, I tried all the backports up to 13, and they apply moreover cleanly. So its ok for me to add individual commits, each with one freetype bump here, up to 2.10 as you suggests. Thanx a lot for guidance on flags, Thats exactly what I htough, an holed you guys will vote for. I will apply the 2.10 now, and ignore the makefiles changes. If my QA will fail, will elaborate on them one by one as you suggested. ok? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3551384840 From andrew at openjdk.org Wed Nov 19 11:21:26 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 19 Nov 2025 11:21:26 GMT Subject: [jdk8u-dev] RFR: 8222362: Upgrade to Freetype 2.10.0 In-Reply-To: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: <-ZdyVDkIahSPcrGQyPHzBgW4hFzJgjYh5hbD0HUBpLQ=.c0783cea-76f1-4953-87c4-4870acb7d509@github.com> On Fri, 14 Nov 2025 10:53:19 GMT, Ji?? Van?k wrote: > Without > > index 00d35a69844..3464eb15e88 100644 > --- a/jdk/make/lib/Awt2dLibraries.gmk > +++ b/jdk/make/lib/Awt2dLibraries.gmk > @@ -541,6 +541,7 @@ else > E_STATEMENT_NOT_REACHED \ > E_END_OF_LOOP_CODE_NOT_REACHED, \ > DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ > + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ > LDFLAGS := $(LDFLAGS_JDKLIB) \ > $(call SET_SHARED_LIBRARY_ORIGIN), \ > )) > > which needs > https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: > https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk I think we may need to merge this with at least [8222362](https://bugs.openjdk.org/browse/JDK-8222362): "Upgrade to Freetype 2.10.0" as the 2.9.1 is not public and so Skara can't pick it up as a backport. As long as both bugs are credited and in separate commits I'm fine with this. As to the warning flags, we should just add them as `CFLAGS`. The `-DDLL_EXPORT` is actually already there. It should be easy enough to just add things like `BUILD_LIBFREETYPE_CFLAGS += -Wno-implicit-fallthrough` when on Linux. However, I'm not sure we even need them on 8u - at least not immediately - as I don't think it builds with warnings as errors for the JDK code as it stands. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3550017945 From duke at openjdk.org Wed Nov 19 13:27:14 2025 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 19 Nov 2025 13:27:14 GMT Subject: [jdk8u-dev] RFR: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server" Message-ID: Backport of https://github.com/openjdk/jdk11u-dev/pull/1377 Eclipse Temurin has seen this failure on some systems and this backport resolves them. Sample failure when trying 100 iterations: https://ci.adoptium.net/job/Grinder/15544/testReport/ (82/100 failed) Sample pass with this branch: https://ci.adoptium.net/job/Grinder/15551/testReport (zero failures) Ref: https://bugs.openjdk.org/browse/JDK-8285836 Testing tier 1: - [Linux/x64](https://ci.adoptium.net/job/Grinder/15559/testReport) - [Linux/aarch64](https://ci.adoptium.net/job/Grinder/15558/testReport) - [Windows/x64](https://ci.adoptium.net/job/Grinder/15563/testReport) - [Mac/x64](https://ci.adoptium.net/job/Grinder/15565/testReport) - [AIX](https://ci.adoptium.net/job/Grinder/15564/testReport) ------------- Commit messages: - Backport af529be069b651808310c3c37e2167d216979f69 Changes: https://git.openjdk.org/jdk8u-dev/pull/721/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=721&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285836 Stats: 3 lines in 1 file changed: 2 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/721.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/721/head:pull/721 PR: https://git.openjdk.org/jdk8u-dev/pull/721 From jvanek at openjdk.org Wed Nov 19 13:32:47 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Wed, 19 Nov 2025 13:32:47 GMT Subject: [jdk8u-dev] RFR: 8222362: Upgrade to Freetype 2.10.0 In-Reply-To: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: On Fri, 14 Nov 2025 10:53:19 GMT, Ji?? Van?k wrote: > Without > > index 00d35a69844..3464eb15e88 100644 > --- a/jdk/make/lib/Awt2dLibraries.gmk > +++ b/jdk/make/lib/Awt2dLibraries.gmk > @@ -541,6 +541,7 @@ else > E_STATEMENT_NOT_REACHED \ > E_END_OF_LOOP_CODE_NOT_REACHED, \ > DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ > + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ > LDFLAGS := $(LDFLAGS_JDKLIB) \ > $(call SET_SHARED_LIBRARY_ORIGIN), \ > )) > > which needs > https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: > https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk So far the testinmg is gooing good. As for GHA: Linux 86 and x64 runtime/containers/docker/TestCPUAwareness.java macos x64: many com/sun/jdi/ ... does not seem to be realted. Will be back in Monday after I run our local QA. If all is good, will add another layer(s) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3552730072 From duke at openjdk.org Wed Nov 19 13:44:11 2025 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 19 Nov 2025 13:44:11 GMT Subject: [jdk8u-dev] RFR: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server" In-Reply-To: References: Message-ID: On Wed, 19 Nov 2025 13:20:16 GMT, Stewart X Addison wrote: > Backport of https://github.com/openjdk/jdk11u-dev/pull/1377 > Eclipse Temurin has seen this failure on some systems and this backport resolves them. > > Sample failure when trying 100 iterations: https://ci.adoptium.net/job/Grinder/15544/testReport/ (82/100 failed) > Sample pass with this branch: https://ci.adoptium.net/job/Grinder/15551/testReport (zero failures) > > Ref: https://bugs.openjdk.org/browse/JDK-8285836 > > Testing tier 1: > - [Linux/x64](https://ci.adoptium.net/job/Grinder/15559/testReport) ? > - [Linux/aarch64](https://ci.adoptium.net/job/Grinder/15558/testReport) ? > - [Windows/x64](https://ci.adoptium.net/job/Grinder/15563/testReport) > - [Mac/x64](https://ci.adoptium.net/job/Grinder/15565/testReport) ? > - [AIX](https://ci.adoptium.net/job/Grinder/15564/testReport) `runtime/containers/docker/TestCPUAwareness.java` failure in the [Pre-submit tests - Linux x64 - Test (tier1)](https://github.com/openjdk/jdk8u-dev/pull/721/checks?check_run_id=55821626443) (and the 32-bit version) in GHA are failing on other PRs so is not related to this change and can therefore be ignored. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/721#issuecomment-3552766076 From jdowland at openjdk.org Wed Nov 19 14:57:04 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Wed, 19 Nov 2025 14:57:04 GMT Subject: [jdk8u-dev] RFR: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server" In-Reply-To: References: Message-ID: On Wed, 19 Nov 2025 13:20:16 GMT, Stewart X Addison wrote: > Backport of https://github.com/openjdk/jdk11u-dev/pull/1377 > Eclipse Temurin has seen this failure on some systems and this backport resolves them. > > Sample failure when trying 100 iterations: https://ci.adoptium.net/job/Grinder/15544/testReport/ (82/100 failed) > Sample pass with this branch: https://ci.adoptium.net/job/Grinder/15551/testReport (zero failures) > > Ref: https://bugs.openjdk.org/browse/JDK-8285836 > > Testing tier 1: > - [Linux/x64](https://ci.adoptium.net/job/Grinder/15559/testReport) ? > - [Linux/aarch64](https://ci.adoptium.net/job/Grinder/15558/testReport) ? > - [Windows/x64](https://ci.adoptium.net/job/Grinder/15563/testReport) > - [Mac/x64](https://ci.adoptium.net/job/Grinder/15565/testReport) ? > - [AIX](https://ci.adoptium.net/job/Grinder/15564/testReport) I am not a Reviewer in jdk8u but to gain experience of doing so I've reviewed this change. The PR is not labelled "clean" but I'm not sure why, the patch is identical to that in 11u and applies with no fuzz. As @sxa notes the pre-submit failure is an issue in the main 8u tree at the moment and is not specific to this change. Test-only change. I've run it and it passes for me after this patch, although I haven't done a battery of runs to aggregate the results, like the backporter has. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/721#issuecomment-3553145632 From sgehwolf at openjdk.org Wed Nov 19 15:37:31 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 19 Nov 2025 15:37:31 GMT Subject: [jdk8u-dev] RFR: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server" In-Reply-To: References: Message-ID: On Wed, 19 Nov 2025 13:39:06 GMT, Stewart X Addison wrote: > `runtime/containers/docker/TestCPUAwareness.java` failure That is https://bugs.openjdk.org/browse/JDK-8370492 and a combination that `--cpu-shares=1023` back-mapping to the default `100` with the new mapping function. So a value of `--cpu-shares=1000` (mapping to `99`) should be chosen for the test. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/721#issuecomment-3553372378 From sgehwolf at openjdk.org Wed Nov 19 15:42:12 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 19 Nov 2025 15:42:12 GMT Subject: [jdk8u-dev] RFR: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server" In-Reply-To: References: Message-ID: On Wed, 19 Nov 2025 14:52:52 GMT, Jonathan Dowland wrote: > The PR is not labelled "clean" but I'm not sure why, the patch is identical to that in 11u and applies with no fuzz. Path in JDK 11 is `test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java`. JDK 8 path is `jdk/test/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java`. I.e. `test/jdk` vs. `jdk/test`. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/721#issuecomment-3553391650 From jdowland at openjdk.org Wed Nov 19 16:38:04 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Wed, 19 Nov 2025 16:38:04 GMT Subject: [jdk8u-dev] RFR: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server" In-Reply-To: References: Message-ID: On Wed, 19 Nov 2025 15:39:37 GMT, Severin Gehwolf wrote: > Path in JDK 11 is test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java. JDK 8 path is jdk/test/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java. I.e. test/jdk vs. jdk/test. Thanks... I had to read your comment _twice_ to see the difference! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/721#issuecomment-3553655850 From duke at openjdk.org Wed Nov 19 16:54:12 2025 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 19 Nov 2025 16:54:12 GMT Subject: [jdk8u-dev] RFR: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server" In-Reply-To: References: Message-ID: <0zojRCyAfZ2bX0ketjXHQ5SMweCtJXeOBPcfEEq-tKo=.6b13a607-0191-488b-bce5-c7919653da22@github.com> On Wed, 19 Nov 2025 13:20:16 GMT, Stewart X Addison wrote: > Backport of https://github.com/openjdk/jdk11u-dev/pull/1377 > Eclipse Temurin has seen this failure on some systems and this backport resolves them. > > Sample failure when trying 100 iterations: https://ci.adoptium.net/job/Grinder/15544/testReport/ (82/100 failed) > Sample pass with this branch: https://ci.adoptium.net/job/Grinder/15551/testReport (zero failures) > > Ref: https://bugs.openjdk.org/browse/JDK-8285836 > > Testing tier 1: > - [Linux/x64](https://ci.adoptium.net/job/Grinder/15559/testReport) ? > - [Linux/aarch64](https://ci.adoptium.net/job/Grinder/15558/testReport) ? > - [Windows/x64](https://ci.adoptium.net/job/Grinder/15563/testReport) > - [Mac/x64](https://ci.adoptium.net/job/Grinder/15565/testReport) ? > - [AIX](https://ci.adoptium.net/job/Grinder/15564/testReport) Is there anything else I need to do because it's not considered clean, or is that up to the reviewers? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/721#issuecomment-3553728688 From sgehwolf at openjdk.org Wed Nov 19 18:03:46 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 19 Nov 2025 18:03:46 GMT Subject: [jdk8u-dev] RFR: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server" In-Reply-To: References: Message-ID: <1_lhQ-inqMu8u7anAEnl1-NR47CdhB4naTpTu0jx328=.fb87f875-0486-4092-ba6b-81190effaeac@github.com> On Wed, 19 Nov 2025 13:20:16 GMT, Stewart X Addison wrote: > Backport of https://github.com/openjdk/jdk11u-dev/pull/1377 > Eclipse Temurin has seen this failure on some systems and this backport resolves them. > > Sample failure when trying 100 iterations: https://ci.adoptium.net/job/Grinder/15544/testReport/ (82/100 failed) > Sample pass with this branch: https://ci.adoptium.net/job/Grinder/15551/testReport (zero failures) > > Ref: https://bugs.openjdk.org/browse/JDK-8285836 > > Testing tier 1: > - [Linux/x64](https://ci.adoptium.net/job/Grinder/15559/testReport) ? > - [Linux/aarch64](https://ci.adoptium.net/job/Grinder/15558/testReport) ? > - [Windows/x64](https://ci.adoptium.net/job/Grinder/15563/testReport) > - [Mac/x64](https://ci.adoptium.net/job/Grinder/15565/testReport) ? > - [AIX](https://ci.adoptium.net/job/Grinder/15564/testReport) Looks good. Clean after path unshuffeling. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/721#pullrequestreview-3483961862 From zzambers at openjdk.org Wed Nov 19 18:23:14 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 19 Nov 2025 18:23:14 GMT Subject: [jdk8u-dev] RFR: 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value Message-ID: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> Backport fixes left shift on negative value which is undefined behavior. This is required to build on newer clang (macos). See also [backport of JDK-8157758](https://github.com/openjdk/jdk8u-dev/pull/682). File has different path on JDK 8, but changes applied cleanly. ------------- Commit messages: - Backport 44f94ee8bc6c934be1f4435227a81e6072361110 Changes: https://git.openjdk.org/jdk8u-dev/pull/722/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=722&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8211804 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/722.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/722/head:pull/722 PR: https://git.openjdk.org/jdk8u-dev/pull/722 From phh at openjdk.org Wed Nov 19 21:24:50 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 19 Nov 2025 21:24:50 GMT Subject: [jdk8u-dev] RFR: 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value In-Reply-To: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> References: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> Message-ID: On Wed, 19 Nov 2025 17:47:43 GMT, Zdenek Zambersky wrote: > Backport fixes left shift on negative value which is undefined behavior. This is required to build on newer clang (macos). See also [backport of JDK-8157758](https://github.com/openjdk/jdk8u-dev/pull/682). > > File has different path on JDK 8, but changes applied cleanly. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/722#pullrequestreview-3484792856 From sgehwolf at openjdk.org Thu Nov 20 10:00:20 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 20 Nov 2025 10:00:20 GMT Subject: [jdk8u-dev] RFR: 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value In-Reply-To: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> References: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> Message-ID: On Wed, 19 Nov 2025 17:47:43 GMT, Zdenek Zambersky wrote: > Backport fixes left shift on negative value which is undefined behavior. This is required to build on newer clang (macos). See also [backport of JDK-8157758](https://github.com/openjdk/jdk8u-dev/pull/682). > > File has different path on JDK 8, but changes applied cleanly. LGTM ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/722#pullrequestreview-3486764465 From jvanek at openjdk.org Thu Nov 20 11:09:47 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 20 Nov 2025 11:09:47 GMT Subject: [jdk8u-dev] RFR: 8222362: Upgrade to Freetype 2.10.0 [v2] In-Reply-To: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: > Without > > index 00d35a69844..3464eb15e88 100644 > --- a/jdk/make/lib/Awt2dLibraries.gmk > +++ b/jdk/make/lib/Awt2dLibraries.gmk > @@ -541,6 +541,7 @@ else > E_STATEMENT_NOT_REACHED \ > E_END_OF_LOOP_CODE_NOT_REACHED, \ > DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ > + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ > LDFLAGS := $(LDFLAGS_JDKLIB) \ > $(call SET_SHARED_LIBRARY_ORIGIN), \ > )) > > which needs > https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: > https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: 8227324: Upgrade to freetype 2.10.1 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/720/files - new: https://git.openjdk.org/jdk8u-dev/pull/720/files/e818636c..7874f255 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=720&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=720&range=00-01 Stats: 2395 lines in 61 files changed: 1234 ins; 623 del; 538 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/720.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/720/head:pull/720 PR: https://git.openjdk.org/jdk8u-dev/pull/720 From jdowland at openjdk.org Thu Nov 20 11:10:02 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 20 Nov 2025 11:10:02 GMT Subject: [jdk8u-dev] RFR: 8220658: Improve the readability of container information in the error log Message-ID: This ([8220658]) is a low-risk change which improves the readability of some debug values reported to humans. I wish to backport this to 8u partly for Oracle parity, and partly because I intend to backport [8284758], which refactors and moves most of the code introduced here to another routine. Doing 8220658 first will ease 8284758 (reduced merge conflicts). Not doing 8220658 (and later backporting 8284758) will result in some of this code making it into 8u (the refactored bits) but not all (the improved cpu quota etc reporting) Patch is not clean due to path differences but otherwise applied without conflicts or fuzz. Builds and smoke tests fine. I've had some trouble running tier1 locally (OOMed my workstation) so I'm going to watch for the GitHub bot results whilst I retry. [8220658]: https://bugs.openjdk.org/browse/JDK-8220658 [8284758]: https://bugs.openjdk.org/browse/JDK-8284758 ------------- Commit messages: - 8220658: Improve the readability of container information in the error log Changes: https://git.openjdk.org/jdk8u-dev/pull/723/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=723&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8220658 Stats: 54 lines in 1 file changed: 41 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/723.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/723/head:pull/723 PR: https://git.openjdk.org/jdk8u-dev/pull/723 From sgehwolf at openjdk.org Thu Nov 20 11:34:26 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 20 Nov 2025 11:34:26 GMT Subject: [jdk8u-dev] RFR: 8220658: Improve the readability of container information in the error log In-Reply-To: References: Message-ID: On Thu, 20 Nov 2025 10:58:09 GMT, Jonathan Dowland wrote: > This ([8220658]) is a low-risk change which improves the readability of some debug values reported to humans. I wish to backport this to 8u partly for Oracle parity, and partly because I intend to backport [8284758], which refactors and moves most of the code introduced here to another routine. > > Doing 8220658 first will ease 8284758 (reduced merge conflicts). Not doing 8220658 (and later backporting 8284758) will result in some of this code making it into 8u (the refactored bits) but not all (the improved cpu quota etc reporting) > > Patch is not clean due to path differences but otherwise applied without conflicts or fuzz. Builds and smoke tests fine. I've had some trouble running tier1 locally (OOMed my workstation) so I'm going to watch for the GitHub bot results whilst I retry. > > [8220658]: https://bugs.openjdk.org/browse/JDK-8220658 > [8284758]: https://bugs.openjdk.org/browse/JDK-8284758 OK ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/723#pullrequestreview-3487317550 From jvanek at openjdk.org Thu Nov 20 11:52:25 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 20 Nov 2025 11:52:25 GMT Subject: [jdk8u-dev] RFR: 8247867: Upgrade to freetype 2.10.2 [v3] In-Reply-To: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: > Without > > index 00d35a69844..3464eb15e88 100644 > --- a/jdk/make/lib/Awt2dLibraries.gmk > +++ b/jdk/make/lib/Awt2dLibraries.gmk > @@ -541,6 +541,7 @@ else > E_STATEMENT_NOT_REACHED \ > E_END_OF_LOOP_CODE_NOT_REACHED, \ > DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ > + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ > LDFLAGS := $(LDFLAGS_JDKLIB) \ > $(call SET_SHARED_LIBRARY_ORIGIN), \ > )) > > which needs > https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: > https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: 8247867: Upgrade to freetype 2.10.2 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/720/files - new: https://git.openjdk.org/jdk8u-dev/pull/720/files/7874f255..125b3501 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=720&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=720&range=01-02 Stats: 3716 lines in 274 files changed: 3090 ins; 76 del; 550 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/720.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/720/head:pull/720 PR: https://git.openjdk.org/jdk8u-dev/pull/720 From jdowland at openjdk.org Thu Nov 20 11:53:30 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 20 Nov 2025 11:53:30 GMT Subject: [jdk8u-dev] RFR: 8220658: Improve the readability of container information in the error log In-Reply-To: References: Message-ID: <88rC0Vdkab0lPUNCTDPUgYzTO9P6xt7JU7TAOJszckM=.b7745dda-86bc-4b0c-b614-e8c0816977d2@github.com> On Thu, 20 Nov 2025 10:58:09 GMT, Jonathan Dowland wrote: > This ([8220658]) is a low-risk change which improves the readability of some debug values reported to humans. I wish to backport this to 8u partly for Oracle parity, and partly because I intend to backport [8284758], which refactors and moves most of the code introduced here to another routine. > > Doing 8220658 first will ease 8284758 (reduced merge conflicts). Not doing 8220658 (and later backporting 8284758) will result in some of this code making it into 8u (the refactored bits) but not all (the improved cpu quota etc reporting) > > Patch is not clean due to path differences but otherwise applied without conflicts or fuzz. Builds and smoke tests fine. I've had some trouble running tier1 locally (OOMed my workstation) so I'm going to watch for the GitHub bot results whilst I retry. > > [8220658]: https://bugs.openjdk.org/browse/JDK-8220658 > [8284758]: https://bugs.openjdk.org/browse/JDK-8284758 Test failures seem unrelated (I'm going to look at those separately soon) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/723#issuecomment-3557593295 From jvanek at openjdk.org Thu Nov 20 11:58:56 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 20 Nov 2025 11:58:56 GMT Subject: [jdk8u-dev] RFR: 8247867: Upgrade to freetype 2.10.2 [v4] In-Reply-To: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: > Without > > index 00d35a69844..3464eb15e88 100644 > --- a/jdk/make/lib/Awt2dLibraries.gmk > +++ b/jdk/make/lib/Awt2dLibraries.gmk > @@ -541,6 +541,7 @@ else > E_STATEMENT_NOT_REACHED \ > E_END_OF_LOOP_CODE_NOT_REACHED, \ > DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ > + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ > LDFLAGS := $(LDFLAGS_JDKLIB) \ > $(call SET_SHARED_LIBRARY_ORIGIN), \ > )) > > which needs > https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: > https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: 8261170: Upgrade to freetype 2.10.4 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/720/files - new: https://git.openjdk.org/jdk8u-dev/pull/720/files/125b3501..1fddebc7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=720&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=720&range=02-03 Stats: 4253 lines in 265 files changed: 1642 ins; 1368 del; 1243 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/720.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/720/head:pull/720 PR: https://git.openjdk.org/jdk8u-dev/pull/720 From jvanek at openjdk.org Thu Nov 20 12:07:37 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 20 Nov 2025 12:07:37 GMT Subject: [jdk8u-dev] RFR: 8261170: Upgrade to FreeType 2.10.4 [v4] In-Reply-To: References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: On Thu, 20 Nov 2025 11:58:56 GMT, Ji?? Van?k wrote: >> Without >> >> index 00d35a69844..3464eb15e88 100644 >> --- a/jdk/make/lib/Awt2dLibraries.gmk >> +++ b/jdk/make/lib/Awt2dLibraries.gmk >> @@ -541,6 +541,7 @@ else >> E_STATEMENT_NOT_REACHED \ >> E_END_OF_LOOP_CODE_NOT_REACHED, \ >> DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ >> + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ >> LDFLAGS := $(LDFLAGS_JDKLIB) \ >> $(call SET_SHARED_LIBRARY_ORIGIN), \ >> )) >> >> which needs >> https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: >> https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > 8261170: Upgrade to freetype 2.10.4 Hello! On 8203367: Upgrade to freetype 2.9.1 - I run buildability and full jtregs on on x64 linux (passed except few known trouble making tests) 8222362: Upgrade to Freetype 2.10.0 - - I run buildability on x64 win+linux, aarrch64 + ppc64 linux and quite a lot of tests we usually run in IBM (again on x64 win+linux, aarrch64 + ppc64 linux); passed buildability, tests still run 8227324: Upgrade to freetype 2.10.1 - I run buildability and jtregs tier1 on x64 linux ; passed 8247867: Upgrade to freetype 2.10.2 - I run buildability and jtregs tier1 on x64 linux ; keep ruinning, looks good 8261170: Upgrade to freetype 2.10.4 - *will* run buildability and jtregs tier1 on x64 linux ; once 2.10.2 finsihes. Will run "full qa" as for 2.10.0 , once it is finished. Done and out for now. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3557657922 From jvanek at openjdk.org Thu Nov 20 13:19:06 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 20 Nov 2025 13:19:06 GMT Subject: [jdk8u-dev] RFR: 8261170: Upgrade to FreeType 2.10.4 [v4] In-Reply-To: References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: On Thu, 20 Nov 2025 11:58:56 GMT, Ji?? Van?k wrote: >> Without >> >> index 00d35a69844..3464eb15e88 100644 >> --- a/jdk/make/lib/Awt2dLibraries.gmk >> +++ b/jdk/make/lib/Awt2dLibraries.gmk >> @@ -541,6 +541,7 @@ else >> E_STATEMENT_NOT_REACHED \ >> E_END_OF_LOOP_CODE_NOT_REACHED, \ >> DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ >> + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ >> LDFLAGS := $(LDFLAGS_JDKLIB) \ >> $(call SET_SHARED_LIBRARY_ORIGIN), \ >> )) >> >> which needs >> https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: >> https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > 8261170: Upgrade to freetype 2.10.4 The sec_infra are failing with security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3 security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca3g3 Several jrtreg failures with `runtime/containers/docker/TestCPUAwareness.java ` Otherwise GHas are good. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3558002225 From jdowland at openjdk.org Thu Nov 20 13:35:29 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 20 Nov 2025 13:35:29 GMT Subject: [jdk8u-dev] RFR: 8284758: [linux] improve print_container_info Message-ID: <7KHPPrp_04m38_FLqfv2s2IgVr_DN4DvUxFUonkNXGU=.0e22ac8c-4d3c-4f93-a227-5c2eff93c077@github.com> Low-risk, for Oracle parity. Mostly a clean-up. This will ease the future backporting of [JDK-8287011]. Doesn't apply clean: needs adjusting for paths and also context, to reflect 8u's lack of the pid controller ([JDK-8266490]). [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8287011 (forthcoming) [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8266490 (not considered) ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/723 Commit messages: - 8284758: [linux] improve print_container_info Changes: https://git.openjdk.org/jdk8u-dev/pull/724/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=724&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284758 Stats: 52 lines in 1 file changed: 13 ins; 34 del; 5 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/724.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/724/head:pull/724 PR: https://git.openjdk.org/jdk8u-dev/pull/724 From tkiriyama at openjdk.org Thu Nov 20 13:39:58 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Thu, 20 Nov 2025 13:39:58 GMT Subject: [jdk8u-dev] RFR: 8212678: Windows IME related patch In-Reply-To: References: Message-ID: On Tue, 21 Oct 2025 09:15:32 GMT, Takuya Kiriyama wrote: > Hi All, > > I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer. > > The following fixes are resolved. > > **Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component** > It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it. > > **Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries** > It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it. > > **Issue C: Check pre-edit string availability for Windows Chinese IME** > It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix. > > JTREG tests were executed using the `-a` option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found. > > The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated. > I plan to create a separate pull request. > > Thank you. Would anyone be willing to review this? This fix is pretty much clean. The GHA failure is not due to this fix. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/706#issuecomment-3558106526 From sgehwolf at openjdk.org Thu Nov 20 16:18:09 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 20 Nov 2025 16:18:09 GMT Subject: [jdk8u-dev] RFR: 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value In-Reply-To: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> References: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> Message-ID: On Wed, 19 Nov 2025 17:47:43 GMT, Zdenek Zambersky wrote: > Backport fixes left shift on negative value which is undefined behavior. This is required to build on newer clang (macos). See also [backport of JDK-8157758](https://github.com/openjdk/jdk8u-dev/pull/682). > > File has different path on JDK 8, but changes applied cleanly. > @zzambers 8211804: Can not be found in the JDK project. @kevinrushforth Any ideas what's going on? --^ ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/722#issuecomment-3558897059 From kcr at openjdk.org Thu Nov 20 16:27:38 2025 From: kcr at openjdk.org (Kevin Rushforth) Date: Thu, 20 Nov 2025 16:27:38 GMT Subject: [jdk8u-dev] RFR: 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value In-Reply-To: References: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> Message-ID: On Thu, 20 Nov 2025 16:14:27 GMT, Severin Gehwolf wrote: > > @zzambers 8211804: Can not be found in the JDK project. > > @kevinrushforth Any ideas what's going on? --^ It seems to be some intermittent issue with JBS. Retry it and see if that helps. @erikj79 Should Skara retry automatically? It doesn't seem like it is in either this case or similar cases. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/722#issuecomment-3558946265 From sgehwolf at openjdk.org Thu Nov 20 17:02:00 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 20 Nov 2025 17:02:00 GMT Subject: [jdk8u-dev] RFR: 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value In-Reply-To: References: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> Message-ID: <-erp8kfVeJNGwnFxsM6lcTo2t0-wgu-N2IbInLP-HyA=.e8ffd979-9c42-40a2-8cc9-8c4bd61fcd08@github.com> On Thu, 20 Nov 2025 16:24:37 GMT, Kevin Rushforth wrote: > > > @zzambers 8211804: Can not be found in the JDK project. > > > > > > @kevinrushforth Any ideas what's going on? --^ > > It seems to be some intermittent issue with JBS. Retry it and see if that helps. It seems to be happening a lot today. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/722#issuecomment-3559099852 From jdowland at openjdk.org Fri Nov 21 12:06:03 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 21 Nov 2025 12:06:03 GMT Subject: [jdk8u-dev] RFR: 8287011: Improve container information Message-ID: Low-risk backport for Oracle parity. Improves diagnostic output for humans. Not quite clean: path shuffling; comment copyright line adjustments; context issues as jdk8u lacks the pid controller (JDK-8266490) ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/724 Commit messages: - 8287011: Improve container information Changes: https://git.openjdk.org/jdk8u-dev/pull/725/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=725&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287011 Stats: 127 lines in 9 files changed: 106 ins; 13 del; 8 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/725.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/725/head:pull/725 PR: https://git.openjdk.org/jdk8u-dev/pull/725 From fthevenet at openjdk.org Mon Nov 24 08:19:43 2025 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Mon, 24 Nov 2025 08:19:43 GMT Subject: [jdk8u-dev] RFR: 8212678: Windows IME related patch In-Reply-To: References: Message-ID: On Tue, 21 Oct 2025 09:15:32 GMT, Takuya Kiriyama wrote: > Hi All, > > I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer. > > The following fixes are resolved. > > **Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component** > It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it. > > **Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries** > It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it. > > **Issue C: Check pre-edit string availability for Windows Chinese IME** > It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix. > > JTREG tests were executed using the `-a` option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found. > > The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated. > I plan to create a separate pull request. > > Thank you. [Disclaimer: I'm not a formal reviewer for the JDK Updates project] I had a look this PRs which, as stated above is indeed a clean backport (aside from copyright year) and according to its JBS issue, it was in fact back-ported to Oracle's 8u291 release back in 2021. Furthermore, I have checked that the entirety of the original content this in patch is still present "as is" in the current JDK, which presumes it's not been found to cause issues since it was introduced back in JDK 13. I therefore feel it is safe to integrate. Regards, Frederic ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/706#issuecomment-3569442990 From fthevenet at openjdk.org Mon Nov 24 08:19:46 2025 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Mon, 24 Nov 2025 08:19:46 GMT Subject: [jdk8u-dev] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 In-Reply-To: References: Message-ID: On Fri, 7 Nov 2025 05:46:36 GMT, Takuya Kiriyama wrote: > Hi all, > I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean. > This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together. > https://github.com/openjdk/jdk8u-dev/pull/706 > > I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016. > I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass. > > Thank you. [Disclaimer: I'm not a formal reviewer for the JDK Updates project] I had a look this PRs which, as stated above is indeed a clean backport (aside from copyright year) and according to its JBS issue, it was in fact back-ported to Oracle's 8u291 release back in 2021. Furthermore, I have checked that the entirety of the original content for this in patch is still present "as is" in the current JDK, which presumes it's not been found to cause issues since it was introduced back in JDK 13. I therefore feel it is safe to integrate. Regards, Frederic ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/716#issuecomment-3569449575 From jvanek at openjdk.org Mon Nov 24 13:07:02 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 24 Nov 2025 13:07:02 GMT Subject: [jdk8u-dev] RFR: 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on [v6] In-Reply-To: References: Message-ID: On Wed, 12 Nov 2025 09:38:40 GMT, Ji?? Van?k wrote: >> We are seeing rare crashes in jcstress with jdk8 on aarch64 with jfron. Those crashes are real, however we were not able to reproduce with builds on gcc 5 and up. The real culprint was not found. but gcc version on aarch64 should be checked. Ideal version seems 7, but I'm not that bold. >> >> I think this change must be accompanied by regenerating `generated-configure` but am not sure with process on it. > > Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - regenerated generated-configure by self built autoconf 2.69 > > Skipping about 50 hunks like: > @@ -50158,7 +50167,7 @@ ac_compiler_gnu=$ac_cv_cxx_compiler_gnu > /* end confdefs.h. */ > > int > -main (void) > +main () > { > return 0; > ; > - Improved error message > - Moved compiler version result to earlier stage > - 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on @aph / @gnu-andrew ping? This seems to have all steps to get merged/closed finished, right? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/697#issuecomment-3570699362 From zzambers at openjdk.org Mon Nov 24 15:26:01 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 24 Nov 2025 15:26:01 GMT Subject: [jdk8u-dev] RFR: 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value In-Reply-To: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> References: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> Message-ID: On Wed, 19 Nov 2025 17:47:43 GMT, Zdenek Zambersky wrote: > Backport fixes left shift on negative value which is undefined behavior. This is required to build on newer clang (macos). See also [backport of JDK-8157758](https://github.com/openjdk/jdk8u-dev/pull/682). > > File has different path on JDK 8, but changes applied cleanly. > > Testing: > GHA: OK (failures seem unrelated) weird, It says it cannot find 8211804, but PR seems to be paired with jira I have created fix request manually ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/722#issuecomment-3571321661 From sgehwolf at openjdk.org Mon Nov 24 16:18:34 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 24 Nov 2025 16:18:34 GMT Subject: [jdk8u-dev] RFR: 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value In-Reply-To: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> References: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> Message-ID: On Wed, 19 Nov 2025 17:47:43 GMT, Zdenek Zambersky wrote: > Backport fixes left shift on negative value which is undefined behavior. This is required to build on newer clang (macos). See also [backport of JDK-8157758](https://github.com/openjdk/jdk8u-dev/pull/682). > > File has different path on JDK 8, but changes applied cleanly. > > Testing: > GHA: OK (failures seem unrelated) (also checking if the JBS issues remain) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/722#issuecomment-3571598513 From zzambers at openjdk.org Mon Nov 24 16:47:09 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 24 Nov 2025 16:47:09 GMT Subject: [jdk8u-dev] Integrated: 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value In-Reply-To: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> References: <0tIBI5TeOfT92kL6dYShvO5ASZPcRnIXW6OBH7QWsFY=.683b1bbd-0e87-4bb9-9bdb-f75e480d8047@github.com> Message-ID: On Wed, 19 Nov 2025 17:47:43 GMT, Zdenek Zambersky wrote: > Backport fixes left shift on negative value which is undefined behavior. This is required to build on newer clang (macos). See also [backport of JDK-8157758](https://github.com/openjdk/jdk8u-dev/pull/682). > > File has different path on JDK 8, but changes applied cleanly. > > Testing: > GHA: OK (failures seem unrelated) This pull request has now been integrated. Changeset: f67be21a Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/f67be21a7ff6de67f415ed652cccbfcc59d2ae75 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value Use unsigned shift. Reviewed-by: phh, sgehwolf Backport-of: 44f94ee8bc6c934be1f4435227a81e6072361110 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/722 From andrew at openjdk.org Tue Nov 25 02:16:43 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 25 Nov 2025 02:16:43 GMT Subject: [jdk8u-dev] RFR: 8261170: Upgrade to FreeType 2.10.4 [v4] In-Reply-To: References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: <4tD9KKhdTVpFZnYGAAmJ40pQtZm6TZRjjWD_JprwRUw=.99ddf74b-6e79-4c66-bb3e-89c8ee1d1055@github.com> On Thu, 20 Nov 2025 11:58:56 GMT, Ji?? Van?k wrote: >> Without >> >> index 00d35a69844..3464eb15e88 100644 >> --- a/jdk/make/lib/Awt2dLibraries.gmk >> +++ b/jdk/make/lib/Awt2dLibraries.gmk >> @@ -541,6 +541,7 @@ else >> E_STATEMENT_NOT_REACHED \ >> E_END_OF_LOOP_CODE_NOT_REACHED, \ >> DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ >> + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ >> LDFLAGS := $(LDFLAGS_JDKLIB) \ >> $(call SET_SHARED_LIBRARY_ORIGIN), \ >> )) >> >> which needs >> https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: >> https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > 8261170: Upgrade to freetype 2.10.4 You can add the other bugs using the [`issue` command](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/issue). You can also use the [`approval` command](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval) to request approval across all bugs once they are added. I'll review the commits tomorrow, but don't foresee there being any problems if it is building fine. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3573509533 From andrew at openjdk.org Tue Nov 25 02:34:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 25 Nov 2025 02:34:18 GMT Subject: [jdk8u-dev] RFR: 8212678: Windows IME related patch In-Reply-To: References: Message-ID: <1VRJZQVNeHQlxj0SfX75R54pdwgwkab0x4uNzibvZ8k=.8ddc878d-327b-46d4-9d25-4447060c7fd0@github.com> On Tue, 21 Oct 2025 09:15:32 GMT, Takuya Kiriyama wrote: > Hi All, > > I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer. > > The following fixes are resolved. > > **Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component** > It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it. > > **Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries** > It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it. > > **Issue C: Check pre-edit string availability for Windows Chinese IME** > It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix. > > JTREG tests were executed using the `-a` option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found. > > The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated. > I plan to create a separate pull request. > > Thank you. I'm happy to back @fthevenet's review. I can confirm the patch is clean bar the missing copyright headers, as `awt_Component.cpp` and `awt_InputMethod.cpp` have been updated to later years already by other changes. The most recent was [JDK-8232114](https://bugs.openjdk.org/browse/JDK-8232114) for `awt_InputMethod.cpp` and [JDK-8346887](https://bugs.openjdk.org/browse/JDK-8346887) for `awt_Component.cpp`. Adding this additional internationalisation support for 8u seems appropriate. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/706#pullrequestreview-3503036676 From andrew at openjdk.org Tue Nov 25 02:38:20 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 25 Nov 2025 02:38:20 GMT Subject: [jdk8u-dev] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 In-Reply-To: References: Message-ID: On Fri, 7 Nov 2025 05:46:36 GMT, Takuya Kiriyama wrote: > Hi all, > I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean. > This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together. > https://github.com/openjdk/jdk8u-dev/pull/706 > > I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016. > I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass. > > Thank you. I can confirm this patch is identical to the one in 11u. I'll wait for the other patch to go in and this one to be rebased against master before concluding the review. ------------- Changes requested by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/716#pullrequestreview-3503041969 From jvanek at openjdk.org Tue Nov 25 11:01:45 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Tue, 25 Nov 2025 11:01:45 GMT Subject: [jdk8u-dev] RFR: 8261170: Upgrade to FreeType 2.10.4 [v4] In-Reply-To: References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: <8YCbx-oB-4V0IVR5iNlteMC_EJ7B6kxOpCiKRIsNDhE=.5205cf99-6138-4281-a5e8-43c39b3c5057@github.com> On Thu, 20 Nov 2025 12:03:39 GMT, Ji?? Van?k wrote: > Hello! On 8203367: Upgrade to freetype 2.9.1 - I run buildability and full jtregs on on x64 linux (passed except few known trouble making tests) 8222362: Upgrade to Freetype 2.10.0 - - I run buildability on x64 win+linux, aarrch64 + ppc64 linux and quite a lot of tests we usually run in IBM (again on x64 win+linux, aarrch64 + ppc64 linux); passed buildability, tests still run 8227324: Upgrade to freetype 2.10.1 - I run buildability and jtregs tier1 on x64 linux ; passed 8247867: Upgrade to freetype 2.10.2 - I run buildability and jtregs tier1 on x64 linux ; passed 8261170: Upgrade to freetype 2.10.4 - I run buildability and jtregs tier1 on x64 linux ; passed . Will run "full qa" as for 2.10.0 , once it is finished. > > Done and out for now. Unluckily only intel finished over weekend, Aarch and ppc are still in queue. Intel looks good. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3575044150 From tkiriyama at openjdk.org Tue Nov 25 11:29:51 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Tue, 25 Nov 2025 11:29:51 GMT Subject: [jdk8u-dev] RFR: 8212678: Windows IME related patch In-Reply-To: References: Message-ID: <5m6tTKTeeyVlMECjJ5tEpqG7gZqRLle4HLYeCJ2Qd9I=.7b30a638-9325-4b96-835f-bf24c8e87f1c@github.com> On Mon, 24 Nov 2025 08:13:49 GMT, Frederic Thevenet wrote: >> Hi All, >> >> I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer. >> >> The following fixes are resolved. >> >> **Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component** >> It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it. >> >> **Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries** >> It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it. >> >> **Issue C: Check pre-edit string availability for Windows Chinese IME** >> It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix. >> >> JTREG tests were executed using the `-a` option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found. >> >> The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated. >> I plan to create a separate pull request. >> >> Thank you. > > [Disclaimer: I'm not a formal reviewer for the JDK Updates project] > > I had a look this PRs which, as stated above is indeed a clean backport (aside from copyright year) and according to its JBS issue, it was in fact back-ported to Oracle's 8u291 release back in 2021. > Furthermore, I have checked that the entirety of the original content this in patch is still present "as is" in the current JDK, which presumes it's not been found to cause issues since it was introduced back in JDK 13. > I therefore feel it is safe to integrate. > > Regards, > Frederic Hi, @fthevenet , @gnu-andrew. Thank you for your review! I create approval request. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/706#issuecomment-3575184345 From andrew at openjdk.org Tue Nov 25 13:55:39 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 25 Nov 2025 13:55:39 GMT Subject: [jdk8u-dev] RFR: 8212678: Windows IME related patch In-Reply-To: References: Message-ID: On Tue, 21 Oct 2025 09:15:32 GMT, Takuya Kiriyama wrote: > Hi All, > > I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer. > > The following fixes are resolved. > > **Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component** > It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it. > > **Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries** > It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it. > > **Issue C: Check pre-edit string availability for Windows Chinese IME** > It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix. > > JTREG tests were executed using the `-a` option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found. > > The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated. > I plan to create a separate pull request. > > Thank you. I see there isn't a x86_32 Windows build on this PR. It would be best to merge latest 8u-dev and make sure that builds before pushing, but we can also check it on the follow-up PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/706#issuecomment-3575769057 From jdowland at openjdk.org Tue Nov 25 17:38:21 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 25 Nov 2025 17:38:21 GMT Subject: [jdk8u-dev] RFR: 8313083: Print 'rss' and 'cache' as part of the container information In-Reply-To: References: Message-ID: On Fri, 21 Nov 2025 15:13:20 GMT, Jonathan Dowland wrote: > Low risk, Oracle parity. Improves diagnostic output. Includes test modifications to cover the new diagnostics. > > Included test `hotspot/test/runtime/containers/docker/TestMisc.java` passes for me. `hotspot/test/runtime/containers/docker/TestMisc.java` failing for me at the moment. Investigating... (edit: resolved) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/726#issuecomment-3566385732 From jdowland at openjdk.org Tue Nov 25 17:38:20 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 25 Nov 2025 17:38:20 GMT Subject: [jdk8u-dev] RFR: 8313083: Print 'rss' and 'cache' as part of the container information Message-ID: Low risk, Oracle parity. Improves diagnostic output. Includes test modifications to cover the new diagnostics. Included test `hotspot/test/runtime/containers/docker/TestMisc.java` passes for me. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/725 Commit messages: - remove reporting on tasks - 8313083: Print 'rss' and 'cache' as part of the container information Changes: https://git.openjdk.org/jdk8u-dev/pull/726/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=726&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313083 Stats: 46 lines in 9 files changed: 45 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/726.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/726/head:pull/726 PR: https://git.openjdk.org/jdk8u-dev/pull/726 From andrew at openjdk.org Wed Nov 26 01:25:03 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 26 Nov 2025 01:25:03 GMT Subject: [jdk8u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v2] In-Reply-To: References: Message-ID: <6XniWL_is5o02v-gYX2Sev6sHV3_V3Bwr2JDtaf_OG8=.270b6d17-7de4-4cd9-80b8-4cfc91852de0@github.com> On Fri, 19 Sep 2025 18:51:57 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this is a backport of openjdk/jdk11u-dev#3098. The backport isn't clean, because of the following: >> >> * File paths that require adjustment for 8u >> * In `Main.java`, trivial context differences and code that needs adjustment from 11u to 8u: >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `InputStream::transferTo(OutputStream.nullOutputStream())` ? [original code before a review suggestion](https://github.com/openjdk/jdk/pull/23532/commits/ef546f4b778e8a1f43dbedc56a79bb53d169a1e7#diff-7083af3b8473a092987afa0bbb4d1694664649534bac716f6b9cd3c3b9833219L1185-L1186) >> * In the test (`VerifyJarEntryName.java`), code that needs adjustment from 11u to 8u: >> * `@library /test/lib` ? `@library /lib/testlibrary` >> * JUnit 5 ? JUnit 4 >> * `org.junit.jupiter.api.BeforeAll` ? `org.junit.BeforeClass` >> * `org.junit.jupiter.api.BeforeEach` ? `org.junit.Before` >> * `org.junit.jupiter.api.Test` ? `org.junit.Test` >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `@BeforeClass`, `@Before` and `@Test` methods must be public >> * Can't use `var` >> * `Arrays.equals(a, start, end, b, 0, b.length)` ? `Arrays.equals(Arrays.copyOfRange(a, start, end), b)` (`Arrays::equals` with offsets not present in 8u) >> * ~~NOTE: for the Japanese manpages translation approach, please refer to openjdk/jdk11u-dev#3098~~ >> * ~~I updated `jdk/src/linux/doc/man/ja/jarsigner.1` and `jdk/src/solaris/doc/sun/man/man1/ja/jarsigner.1` (identical), and left `dk/src/bsd/doc/man/ja/jarsigner.1` untouched (doesn't have any content besides the headers)~~ >> * $\mbox{\color{red}UPDATE}$ (28348b29f892b685d9098c4560128a8bfb206afd): all the internationalized messages have been removed, as they aren't typically included in backports (thanks @jerboaa for letting me know). >> >> #### Related issues ("relates to" Jira issue links) >> >> [JDK-8353299](https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails") (openjdk/jdk at acd4da49a01760599ec4c325ff6c56f53ba5cc9c) and [JDK-8367782](https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName") (openjdk/jdk at 1b9a11682d5f73885213822423bfce8dfc17febd) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of `VerifyJarEntryName.java`. >> >> Since `test/hotspot/jtreg/runtime/appcds/SignedJar.java` is ... > > Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: > > Remove internationalized messages I've compared this against the 11u patch and the changes for 8u (`Paths.of` -> `Paths.get`, `Arrays.equals` alteration, `readEntry` change reversion, test refactoring) seem fine. I'm confused by some of the comments in the PR. I don't see any `var` usage in the 11u patch, which I presume would have to be taken out already for that backport, and it also has the additional bug IDs. I also don't see any discussion about translations and I'm not aware of this policy of not including these changes. What is the reason for this? ------------- Changes requested by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/699#pullrequestreview-3507789082 From tkiriyama at openjdk.org Wed Nov 26 02:30:02 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Wed, 26 Nov 2025 02:30:02 GMT Subject: [jdk8u-dev] RFR: 8212678: Windows IME related patch In-Reply-To: References: Message-ID: <8RamgiEKib5fuCYUIvtlcyyEuGqoGhJ_NOR2eWkB8zM=.153624e1-2afa-4ab2-b70e-2e9af9ef0592@github.com> On Tue, 25 Nov 2025 13:53:26 GMT, Andrew John Hughes wrote: >> Hi All, >> >> I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer. >> >> The following fixes are resolved. >> >> **Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component** >> It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it. >> >> **Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries** >> It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it. >> >> **Issue C: Check pre-edit string availability for Windows Chinese IME** >> It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix. >> >> JTREG tests were executed using the `-a` option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found. >> >> The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated. >> I plan to create a separate pull request. >> >> Thank you. > > I see there isn't a x86_32 Windows build on this PR. It would be best to merge latest 8u-dev and make sure that builds before pushing, but we can also check it on the follow-up PR. @gnu-andrew Thank you. Since the review has already progressed to the approval stage, I plan to integrate this PR. I'll check it in the next [PR](https://github.com/openjdk/jdk8u-dev/pull/716). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/706#issuecomment-3578604049 From duke at openjdk.org Wed Nov 26 02:34:05 2025 From: duke at openjdk.org (duke) Date: Wed, 26 Nov 2025 02:34:05 GMT Subject: [jdk8u-dev] RFR: 8212678: Windows IME related patch In-Reply-To: References: Message-ID: On Tue, 21 Oct 2025 09:15:32 GMT, Takuya Kiriyama wrote: > Hi All, > > I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer. > > The following fixes are resolved. > > **Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component** > It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it. > > **Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries** > It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it. > > **Issue C: Check pre-edit string availability for Windows Chinese IME** > It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix. > > JTREG tests were executed using the `-a` option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found. > > The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated. > I plan to create a separate pull request. > > Thank you. @tkiriyama Your change (at version ccb20c8f04dc24924a18ac63b64afa69a988d4b3) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/706#issuecomment-3578618241 From tkiriyama at openjdk.org Wed Nov 26 09:53:20 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Wed, 26 Nov 2025 09:53:20 GMT Subject: [jdk8u-dev] Integrated: 8212678: Windows IME related patch In-Reply-To: References: Message-ID: On Tue, 21 Oct 2025 09:15:32 GMT, Takuya Kiriyama wrote: > Hi All, > > I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer. > > The following fixes are resolved. > > **Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component** > It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it. > > **Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries** > It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it. > > **Issue C: Check pre-edit string availability for Windows Chinese IME** > It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix. > > JTREG tests were executed using the `-a` option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found. > > The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated. > I plan to create a separate pull request. > > Thank you. This pull request has now been integrated. Changeset: 8304a760 Author: Takuya Kiriyama Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/8304a7607b394f54ba97fb857d721fd16c9a026b Stats: 40 lines in 3 files changed: 38 ins; 0 del; 2 mod 8212678: Windows IME related patch Reviewed-by: andrew Backport-of: 60613c5fbc2554cbbf09d79804de276b9c2d786c ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/706 From fferrari at openjdk.org Wed Nov 26 10:03:28 2025 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Wed, 26 Nov 2025 10:03:28 GMT Subject: [jdk8u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v2] In-Reply-To: <6XniWL_is5o02v-gYX2Sev6sHV3_V3Bwr2JDtaf_OG8=.270b6d17-7de4-4cd9-80b8-4cfc91852de0@github.com> References: <6XniWL_is5o02v-gYX2Sev6sHV3_V3Bwr2JDtaf_OG8=.270b6d17-7de4-4cd9-80b8-4cfc91852de0@github.com> Message-ID: On Wed, 26 Nov 2025 01:22:14 GMT, Andrew John Hughes wrote: > I'm confused by some of the comments in the PR. I don't see any `var` usage in the 11u patch, which I presume would have to be taken out already for that backport, and it also has the additional bug IDs. Hi @gnu-andrew, I'm realizing the comment is very confusing, sorry for that. It was meant to describe the [JDK-8339280] backport only, as the other two issues were mentioned in the _**Related issues ("relates to" Jira issue links)**_ section. It should be clearer with the order of events: * [JDK-8339280] is the main change, it included a test case that was later failing (the test had 2 `var` usages) * [JDK-8353299] is the original fix to the test case, I found it didn't address the root cause of the test failure * [JDK-8367782] is a new fix I proposed in mainline before starting the backports (the `var` usages were removed there) > I also don't see any discussion about translations and I'm not aware of this policy of not including these changes. What is the reason for this? In https://github.com/openjdk/jdk21u-dev/pull/2235#pullrequestreview-3245163053, Severin explained to me that we don't include internationalization changes in backports, when those changes come from bulk updates. In this case, I was taking the translations from [JDK-8359761: JDK 25 RDP1 L10n resource files update](https://bugs.openjdk.org/browse/JDK-8359761) (openjdk/jdk at da7080fffb2389465dc9afca6d02e9085fe15302). [JDK-8339280]: https://bugs.openjdk.org/browse/JDK-8339280 "jarsigner -verify performs cross-checking between CEN and LOC" [JDK-8353299]: https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails" [JDK-8367782]: https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName" ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/699#issuecomment-3580539652 From tkiriyama at openjdk.org Wed Nov 26 10:02:19 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Wed, 26 Nov 2025 10:02:19 GMT Subject: [jdk8u-dev] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2] In-Reply-To: References: Message-ID: > Hi all, > I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean. > This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together. > https://github.com/openjdk/jdk8u-dev/pull/706 > > I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016. > I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass. > > Thank you. Takuya Kiriyama has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/716/files - new: https://git.openjdk.org/jdk8u-dev/pull/716/files/762a0876..762a0876 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=716&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=716&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/716.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/716/head:pull/716 PR: https://git.openjdk.org/jdk8u-dev/pull/716 From tkiriyama at openjdk.org Wed Nov 26 12:10:50 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Wed, 26 Nov 2025 12:10:50 GMT Subject: [jdk8u-dev] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v3] In-Reply-To: References: Message-ID: > Hi all, > I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean. > This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together. > https://github.com/openjdk/jdk8u-dev/pull/706 > > I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016. > I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass. > > Thank you. Takuya Kiriyama has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge master - 8258805: Japanese characters not entered by mouse click on Windows 10 - 8212678: Windows IME related patch ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/716/files - new: https://git.openjdk.org/jdk8u-dev/pull/716/files/762a0876..fdcb1515 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=716&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=716&range=01-02 Stats: 169723 lines in 353 files changed: 163519 ins; 5744 del; 460 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/716.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/716/head:pull/716 PR: https://git.openjdk.org/jdk8u-dev/pull/716 From andrew at openjdk.org Wed Nov 26 17:37:26 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 26 Nov 2025 17:37:26 GMT Subject: [jdk8u-dev] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v3] In-Reply-To: References: Message-ID: On Wed, 26 Nov 2025 12:10:50 GMT, Takuya Kiriyama wrote: >> Hi all, >> I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean. >> This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together. >> https://github.com/openjdk/jdk8u-dev/pull/706 >> >> I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016. >> I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass. >> >> Thank you. > > Takuya Kiriyama has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - 8258805: Japanese characters not entered by mouse click on Windows 10 > - 8212678: Windows IME related patch Test results look good, so happy to raise this to an approved review. Thanks for merging. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/716#pullrequestreview-3512070684 From andrew at openjdk.org Thu Nov 27 01:49:00 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 27 Nov 2025 01:49:00 GMT Subject: [jdk8u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v2] In-Reply-To: References: Message-ID: On Fri, 19 Sep 2025 18:51:57 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this is a backport of openjdk/jdk11u-dev#3098. The backport isn't clean, because of the following: >> >> * File paths that require adjustment for 8u >> * In `Main.java`, trivial context differences and code that needs adjustment from 11u to 8u: >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `InputStream::transferTo(OutputStream.nullOutputStream())` ? [original code before a review suggestion](https://github.com/openjdk/jdk/pull/23532/commits/ef546f4b778e8a1f43dbedc56a79bb53d169a1e7#diff-7083af3b8473a092987afa0bbb4d1694664649534bac716f6b9cd3c3b9833219L1185-L1186) >> * In the test (`VerifyJarEntryName.java`), code that needs adjustment from 11u to 8u: >> * `@library /test/lib` ? `@library /lib/testlibrary` >> * JUnit 5 ? JUnit 4 >> * `org.junit.jupiter.api.BeforeAll` ? `org.junit.BeforeClass` >> * `org.junit.jupiter.api.BeforeEach` ? `org.junit.Before` >> * `org.junit.jupiter.api.Test` ? `org.junit.Test` >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `@BeforeClass`, `@Before` and `@Test` methods must be public >> * Can't use `var` >> * `Arrays.equals(a, start, end, b, 0, b.length)` ? `Arrays.equals(Arrays.copyOfRange(a, start, end), b)` (`Arrays::equals` with offsets not present in 8u) >> * ~~NOTE: for the Japanese manpages translation approach, please refer to openjdk/jdk11u-dev#3098~~ >> * ~~I updated `jdk/src/linux/doc/man/ja/jarsigner.1` and `jdk/src/solaris/doc/sun/man/man1/ja/jarsigner.1` (identical), and left `dk/src/bsd/doc/man/ja/jarsigner.1` untouched (doesn't have any content besides the headers)~~ >> * $\mbox{\color{red}UPDATE}$ (28348b29f892b685d9098c4560128a8bfb206afd): all the internationalized messages have been removed, as they aren't typically included in backports (thanks @jerboaa for letting me know). >> >> #### Related issues ("relates to" Jira issue links) >> >> [JDK-8353299](https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails") (openjdk/jdk at acd4da49a01760599ec4c325ff6c56f53ba5cc9c) and [JDK-8367782](https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName") (openjdk/jdk at 1b9a11682d5f73885213822423bfce8dfc17febd) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of `VerifyJarEntryName.java`. >> >> Since `test/hotspot/jtreg/runtime/appcds/SignedJar.java` is ... > > Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: > > Remove internationalized messages Patch looks good. Thanks for the extra information. I thought you were saying the translations shouldn't be updated at all, but it seems it was more that they shouldn't be mixed into a backport of another change they weren't part of. I do question that they will ever get updated in bulk though, so that is something we should probably look into under another PR. This one should be good to go though. Thanks for clarifying. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/699#pullrequestreview-3513286049 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/699#issuecomment-3583898505 From tkiriyama at openjdk.org Thu Nov 27 01:49:04 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Thu, 27 Nov 2025 01:49:04 GMT Subject: [jdk8u-dev] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 In-Reply-To: References: Message-ID: <_jVaxxs-WO1ejUlwGZySZ12RwrLQuUnc59CvECAQ2F0=.e082e698-35de-4d1d-af86-65dcd37c0ee1@github.com> On Mon, 24 Nov 2025 08:15:13 GMT, Frederic Thevenet wrote: >> Hi all, >> I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean. >> This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together. >> https://github.com/openjdk/jdk8u-dev/pull/706 >> >> I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016. >> I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass. >> >> Thank you. > > [Disclaimer: I'm not a formal reviewer for the JDK Updates project] > > I had a look this PRs which, as stated above is indeed a clean backport (aside from copyright year) and according to its JBS issue, it was in fact back-ported to Oracle's 8u291 release back in 2021. > Furthermore, I have checked that the entirety of the original content for this in patch is still present "as is" in the current JDK, which presumes it's not been found to cause issues since it was introduced back in JDK 13. > I therefore feel it is safe to integrate. > > Regards, > Frederic Hi, @fthevenet , @gnu-andrew. Thank you for your review! I create approval request. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/716#issuecomment-3583900179 From jdowland at openjdk.org Thu Nov 27 10:18:33 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 27 Nov 2025 10:18:33 GMT Subject: [jdk8u-dev] RFR: 8372660: [8u] ProblemList TestCPUAwareness until 8370492 is addressed Message-ID: This test failure is polluting GHA logs for unrelated changes (e.g. https://github.com/openjdk/jdk8u-dev/pull/721#issuecomment-35533723) ------------- Commit messages: - 8372660: [8u] ProblemList TestCPUAwareness until 8370492 is addressed Changes: https://git.openjdk.org/jdk8u-dev/pull/727/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=727&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8372660 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/727.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/727/head:pull/727 PR: https://git.openjdk.org/jdk8u-dev/pull/727 From duke at openjdk.org Thu Nov 27 10:39:05 2025 From: duke at openjdk.org (duke) Date: Thu, 27 Nov 2025 10:39:05 GMT Subject: [jdk8u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v2] In-Reply-To: References: Message-ID: <0QV6kRJGGdDXh2aBzDIqkgeSEpmSLBT9SKMr96IY11s=.390ee83e-5d0f-46e0-9d35-f011db99dd5d@github.com> On Fri, 19 Sep 2025 18:51:57 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this is a backport of openjdk/jdk11u-dev#3098. The backport isn't clean, because of the following: >> >> * File paths that require adjustment for 8u >> * In `Main.java`, trivial context differences and code that needs adjustment from 11u to 8u: >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `InputStream::transferTo(OutputStream.nullOutputStream())` ? [original code before a review suggestion](https://github.com/openjdk/jdk/pull/23532/commits/ef546f4b778e8a1f43dbedc56a79bb53d169a1e7#diff-7083af3b8473a092987afa0bbb4d1694664649534bac716f6b9cd3c3b9833219L1185-L1186) >> * In the test (`VerifyJarEntryName.java`), code that needs adjustment from 11u to 8u: >> * `@library /test/lib` ? `@library /lib/testlibrary` >> * JUnit 5 ? JUnit 4 >> * `org.junit.jupiter.api.BeforeAll` ? `org.junit.BeforeClass` >> * `org.junit.jupiter.api.BeforeEach` ? `org.junit.Before` >> * `org.junit.jupiter.api.Test` ? `org.junit.Test` >> * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` >> * `@BeforeClass`, `@Before` and `@Test` methods must be public >> * Can't use `var` >> * `Arrays.equals(a, start, end, b, 0, b.length)` ? `Arrays.equals(Arrays.copyOfRange(a, start, end), b)` (`Arrays::equals` with offsets not present in 8u) >> * ~~NOTE: for the Japanese manpages translation approach, please refer to openjdk/jdk11u-dev#3098~~ >> * ~~I updated `jdk/src/linux/doc/man/ja/jarsigner.1` and `jdk/src/solaris/doc/sun/man/man1/ja/jarsigner.1` (identical), and left `dk/src/bsd/doc/man/ja/jarsigner.1` untouched (doesn't have any content besides the headers)~~ >> * $\mbox{\color{red}UPDATE}$ (28348b29f892b685d9098c4560128a8bfb206afd): all the internationalized messages have been removed, as they aren't typically included in backports (thanks @jerboaa for letting me know). >> >> #### Related issues ("relates to" Jira issue links) >> >> [JDK-8353299](https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails") (openjdk/jdk at acd4da49a01760599ec4c325ff6c56f53ba5cc9c) and [JDK-8367782](https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName") (openjdk/jdk at 1b9a11682d5f73885213822423bfce8dfc17febd) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of `VerifyJarEntryName.java`. >> >> Since `test/hotspot/jtreg/runtime/appcds/SignedJar.java` is ... > > Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: > > Remove internationalized messages @franferrax Your change (at version 28348b29f892b685d9098c4560128a8bfb206afd) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/699#issuecomment-3585166449 From fferrari at openjdk.org Thu Nov 27 11:08:08 2025 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Thu, 27 Nov 2025 11:08:08 GMT Subject: [jdk8u-dev] Integrated: 8339280: jarsigner -verify performs cross-checking between CEN and LOC In-Reply-To: References: Message-ID: On Fri, 19 Sep 2025 10:20:46 GMT, Francisco Ferrari Bihurriet wrote: > Hi, this is a backport of openjdk/jdk11u-dev#3098. The backport isn't clean, because of the following: > > * File paths that require adjustment for 8u > * In `Main.java`, trivial context differences and code that needs adjustment from 11u to 8u: > * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` > * `InputStream::transferTo(OutputStream.nullOutputStream())` ? [original code before a review suggestion](https://github.com/openjdk/jdk/pull/23532/commits/ef546f4b778e8a1f43dbedc56a79bb53d169a1e7#diff-7083af3b8473a092987afa0bbb4d1694664649534bac716f6b9cd3c3b9833219L1185-L1186) > * In the test (`VerifyJarEntryName.java`), code that needs adjustment from 11u to 8u: > * `@library /test/lib` ? `@library /lib/testlibrary` > * JUnit 5 ? JUnit 4 > * `org.junit.jupiter.api.BeforeAll` ? `org.junit.BeforeClass` > * `org.junit.jupiter.api.BeforeEach` ? `org.junit.Before` > * `org.junit.jupiter.api.Test` ? `org.junit.Test` > * `java.nio.file.Path.of()` ? `java.nio.file.Paths.get()` > * `@BeforeClass`, `@Before` and `@Test` methods must be public > * Can't use `var` > * `Arrays.equals(a, start, end, b, 0, b.length)` ? `Arrays.equals(Arrays.copyOfRange(a, start, end), b)` (`Arrays::equals` with offsets not present in 8u) > * ~~NOTE: for the Japanese manpages translation approach, please refer to openjdk/jdk11u-dev#3098~~ > * ~~I updated `jdk/src/linux/doc/man/ja/jarsigner.1` and `jdk/src/solaris/doc/sun/man/man1/ja/jarsigner.1` (identical), and left `dk/src/bsd/doc/man/ja/jarsigner.1` untouched (doesn't have any content besides the headers)~~ > * $\mbox{\color{red}UPDATE}$ (28348b29f892b685d9098c4560128a8bfb206afd): all the internationalized messages have been removed, as they aren't typically included in backports (thanks @jerboaa for letting me know). > > #### Related issues ("relates to" Jira issue links) > > [JDK-8353299](https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails") (openjdk/jdk at acd4da49a01760599ec4c325ff6c56f53ba5cc9c) and [JDK-8367782](https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName") (openjdk/jdk at 1b9a11682d5f73885213822423bfce8dfc17febd) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of `VerifyJarEntryName.java`. > > Since `test/hotspot/jtreg/runtime/appcds/SignedJar.java` is not present in 8u, [JDK-8353330](https://bugs.open... This pull request has now been integrated. Changeset: 5452da9a Author: Francisco Ferrari Bihurriet Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/5452da9aa2428b6fa143ea3af9cc7d261abf99b3 Stats: 335 lines in 6 files changed: 335 ins; 0 del; 0 mod 8339280: jarsigner -verify performs cross-checking between CEN and LOC 8353299: VerifyJarEntryName.java test fails 8367782: VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName Reviewed-by: abakhtin, sgehwolf, andrew Backport-of: bbd5b174c50346152a624317b6bd76ec48f7e551 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/699 From andrew at openjdk.org Thu Nov 27 11:57:12 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 27 Nov 2025 11:57:12 GMT Subject: [jdk8u-dev] RFR: 8261170: Upgrade to FreeType 2.10.4 [v4] In-Reply-To: References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: On Thu, 20 Nov 2025 11:58:56 GMT, Ji?? Van?k wrote: >> Without >> >> index 00d35a69844..3464eb15e88 100644 >> --- a/jdk/make/lib/Awt2dLibraries.gmk >> +++ b/jdk/make/lib/Awt2dLibraries.gmk >> @@ -541,6 +541,7 @@ else >> E_STATEMENT_NOT_REACHED \ >> E_END_OF_LOOP_CODE_NOT_REACHED, \ >> DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ >> + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ >> LDFLAGS := $(LDFLAGS_JDKLIB) \ >> $(call SET_SHARED_LIBRARY_ORIGIN), \ >> )) >> >> which needs >> https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: >> https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > 8261170: Upgrade to freetype 2.10.4 I reviewed all five commits against their 11u versions. 8227324, 8247867 & 8261170 were all clean with the expected move of the `freetype.md` change to `THIRD_PARTY_README`. Warning flag additions were not ported for 8203367 & 8222362, but I'm ok with this as the JDK (`jdk/src`) native code already does not build with `-Werror` (not added by default, would fail if done) and we don't really gain anything from turning them off in the FreeType code. I may look into this under a separate PR. Let's get this batch of updates in so they can be in the promotion at the end of this week. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/720#pullrequestreview-3514874886 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3585461427 From jvanek at openjdk.org Thu Nov 27 12:00:04 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 27 Nov 2025 12:00:04 GMT Subject: [jdk8u-dev] RFR: 8261170: Upgrade to FreeType 2.10.4 [v4] In-Reply-To: References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: <8E284VIaimcqEkctZAxiu0n_U7UBuQwnzQ4a4JgrYM4=.33ce858e-7648-4b11-a283-a364a57ae871@github.com> On Thu, 20 Nov 2025 11:58:56 GMT, Ji?? Van?k wrote: >> Without >> >> index 00d35a69844..3464eb15e88 100644 >> --- a/jdk/make/lib/Awt2dLibraries.gmk >> +++ b/jdk/make/lib/Awt2dLibraries.gmk >> @@ -541,6 +541,7 @@ else >> E_STATEMENT_NOT_REACHED \ >> E_END_OF_LOOP_CODE_NOT_REACHED, \ >> DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ >> + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ >> LDFLAGS := $(LDFLAGS_JDKLIB) \ >> $(call SET_SHARED_LIBRARY_ORIGIN), \ >> )) >> >> which needs >> https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: >> https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > 8261170: Upgrade to freetype 2.10.4 Thanx! Will do another PR with bump to 2.12.0+2.12.1 maybe up to 2.13.3. Definitely with QA on each major bump (and that is lengthy) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3585476315 From duke at openjdk.org Thu Nov 27 12:34:20 2025 From: duke at openjdk.org (duke) Date: Thu, 27 Nov 2025 12:34:20 GMT Subject: [jdk8u-dev] RFR: 8261170: Upgrade to FreeType 2.10.4 [v4] In-Reply-To: References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: On Thu, 20 Nov 2025 11:58:56 GMT, Ji?? Van?k wrote: >> Without >> >> index 00d35a69844..3464eb15e88 100644 >> --- a/jdk/make/lib/Awt2dLibraries.gmk >> +++ b/jdk/make/lib/Awt2dLibraries.gmk >> @@ -541,6 +541,7 @@ else >> E_STATEMENT_NOT_REACHED \ >> E_END_OF_LOOP_CODE_NOT_REACHED, \ >> DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ >> + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ >> LDFLAGS := $(LDFLAGS_JDKLIB) \ >> $(call SET_SHARED_LIBRARY_ORIGIN), \ >> )) >> >> which needs >> https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: >> https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > 8261170: Upgrade to freetype 2.10.4 @judovana Your change (at version 1fddebc71d0896f697b109e665afb5ceb56961ec) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3585620017 From andrew at openjdk.org Thu Nov 27 13:29:53 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 27 Nov 2025 13:29:53 GMT Subject: [jdk8u-dev] RFR: 8261170: Upgrade to FreeType 2.10.4 [v4] In-Reply-To: <8E284VIaimcqEkctZAxiu0n_U7UBuQwnzQ4a4JgrYM4=.33ce858e-7648-4b11-a283-a364a57ae871@github.com> References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> <8E284VIaimcqEkctZAxiu0n_U7UBuQwnzQ4a4JgrYM4=.33ce858e-7648-4b11-a283-a364a57ae871@github.com> Message-ID: On Thu, 27 Nov 2025 11:57:33 GMT, Ji?? Van?k wrote: > Thanx! Will do another PR with bump to 2.12.0+2.12.1 maybe up to 2.13.3 (because of 8298974) . Definitely with QA on each major bump (and that is lengthy) Let's get them in over the next week. QA can run during rampdown and we can still apply critical fixes then if there are regressions, but we don't want to be doing big library updates in rampdown. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3585865487 From jvanek at openjdk.org Thu Nov 27 13:29:55 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Thu, 27 Nov 2025 13:29:55 GMT Subject: [jdk8u-dev] Integrated: 8261170: Upgrade to FreeType 2.10.4 In-Reply-To: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> References: <58l4r2fkGpYmpry8pTU7Kn25aXA-VWyf6zev98KUHFk=.d00a2da0-cc6b-44aa-8adb-0b4bee7b7d4c@github.com> Message-ID: On Fri, 14 Nov 2025 10:53:19 GMT, Ji?? Van?k wrote: > Without > > index 00d35a69844..3464eb15e88 100644 > --- a/jdk/make/lib/Awt2dLibraries.gmk > +++ b/jdk/make/lib/Awt2dLibraries.gmk > @@ -541,6 +541,7 @@ else > E_STATEMENT_NOT_REACHED \ > E_END_OF_LOOP_CODE_NOT_REACHED, \ > DISABLED_WARNINGS_microsoft := 4267 4244 4312, \ > + DISABLED_WARNINGS_gcc := implicit-fallthrough, \ > LDFLAGS := $(LDFLAGS_JDKLIB) \ > $(call SET_SHARED_LIBRARY_ORIGIN), \ > )) > > which needs > https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others: > https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk This pull request has now been integrated. Changeset: 7cca6260 Author: Ji?? Van?k Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/7cca6260375beac8f4294684438ba9b9d3a26602 Stats: 45919 lines in 326 files changed: 11326 ins; 7104 del; 27489 mod 8261170: Upgrade to FreeType 2.10.4 8222362: Upgrade to Freetype 2.10.0 8227324: Upgrade to freetype 2.10.1 8247867: Upgrade to freetype 2.10.2 Reviewed-by: andrew Backport-of: 33a580c2832bf06dc14972a847c56b87efe9b013 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/720 From duke at openjdk.org Fri Nov 28 00:02:01 2025 From: duke at openjdk.org (duke) Date: Fri, 28 Nov 2025 00:02:01 GMT Subject: [jdk8u-dev] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v3] In-Reply-To: References: Message-ID: On Wed, 26 Nov 2025 12:10:50 GMT, Takuya Kiriyama wrote: >> Hi all, >> I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean. >> This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together. >> https://github.com/openjdk/jdk8u-dev/pull/706 >> >> I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016. >> I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass. >> >> Thank you. > > Takuya Kiriyama has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - 8258805: Japanese characters not entered by mouse click on Windows 10 > - 8212678: Windows IME related patch @tkiriyama Your change (at version fdcb15154dc9064ca95632b38fc9556477afcd88) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/716#issuecomment-3587532010 From tkiriyama at openjdk.org Fri Nov 28 01:20:04 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Fri, 28 Nov 2025 01:20:04 GMT Subject: [jdk8u-dev] Integrated: 8258805: Japanese characters not entered by mouse click on Windows 10 In-Reply-To: References: Message-ID: On Fri, 7 Nov 2025 05:46:36 GMT, Takuya Kiriyama wrote: > Hi all, > I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean. > This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together. > https://github.com/openjdk/jdk8u-dev/pull/706 > > I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016. > I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass. > > Thank you. This pull request has now been integrated. Changeset: 6a3f7bb9 Author: Takuya Kiriyama Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/6a3f7bb9a01114a01628e49792caf1a6c3f071e4 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8258805: Japanese characters not entered by mouse click on Windows 10 Reviewed-by: andrew Backport-of: 53fecba709ed3e748d36e150d950bfae79ab48b1 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/716 From jvanek at openjdk.org Fri Nov 28 09:02:32 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 28 Nov 2025 09:02:32 GMT Subject: [jdk8u-dev] RFR: 8285686: Update FreeType to 2.12.0 Message-ID: This should be last PR on toppic of free type backport. At the end it should contain: * 8285686: Update FreeType to 2.12.0 * 8290334: Update FreeType to 2.12.1 * 8298974: Add ftcolor.c to imported freetype sources * 8306881: Update FreeType to 2.13.0 * 8316028: Update FreeType to 2.13.2 * 8348596: Update FreeType to 2.13.3 I will run full qa on 2.12.0 and 2.13.0 Buildability and tier1 tests on others. The 2.13.3. will get full qa during rampdown I guess... ------------- Commit messages: - 8285686: Update FreeType to 2.12.0 Changes: https://git.openjdk.org/jdk8u-dev/pull/728/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=728&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285686 Stats: 10933 lines in 293 files changed: 6807 ins; 2146 del; 1980 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/728.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/728/head:pull/728 PR: https://git.openjdk.org/jdk8u-dev/pull/728 From jvanek at openjdk.org Fri Nov 28 09:32:42 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 28 Nov 2025 09:32:42 GMT Subject: [jdk8u-dev] RFR: 8290334: Update FreeType to 2.12.1 [v2] In-Reply-To: References: Message-ID: > This should be last PR on toppic of free type backport. At the end it should contain: > * 8285686: Update FreeType to 2.12.0 > * 8290334: Update FreeType to 2.12.1 > * 8298974: Add ftcolor.c to imported freetype sources > * 8306881: Update FreeType to 2.13.0 > * 8316028: Update FreeType to 2.13.2 > * 8348596: Update FreeType to 2.13.3 > > I will run full qa on 2.12.0 and 2.13.0 Buildability and tier1 tests on others. > The 2.13.3. will get full qa during rampdown I guess... Ji?? Van?k has updated the pull request incrementally with two additional commits since the last revision: - 8298974: Add ftcolor.c to imported freetype sources - Update FreeType to 2.12.1 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/728/files - new: https://git.openjdk.org/jdk8u-dev/pull/728/files/18180a46..91b99191 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=728&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=728&range=00-01 Stats: 223 lines in 20 files changed: 166 ins; 8 del; 49 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/728.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/728/head:pull/728 PR: https://git.openjdk.org/jdk8u-dev/pull/728 From jvanek at openjdk.org Fri Nov 28 12:05:16 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 28 Nov 2025 12:05:16 GMT Subject: [jdk8u-dev] RFR: 8306881: Update FreeType to 2.13.0 [v3] In-Reply-To: References: Message-ID: > This should be last PR on toppic of free type backport. At the end it should contain: > * 8285686: Update FreeType to 2.12.0 (pushed, testing in progress) > * 8290334: Update FreeType to 2.12.1 (pushed, smoketests done) > * 8298974: Add ftcolor.c to imported freetype sources (pushed, smoketests done) > * 8293672: Update freetype md file (not clean) > * 8306881: Update FreeType to 2.13.0 (pushed, testing scheduled) > * 8316028: Update FreeType to 2.13.2 > * 8348596: Update FreeType to 2.13.3 > > I will run full qa on 2.12.0 and 2.13.0 Buildability and tier1 tests on others. > The 2.13.3. will get full qa during rampdown I guess... Ji?? Van?k has updated the pull request incrementally with two additional commits since the last revision: - 8306881: Update FreeType to 2.13.0 without: --- jdk/make/lib/Awt2dLibraries.gmk +++ jdk/make/lib/Awt2dLibraries.gmk @@ -527,6 +527,7 @@ else E_END_OF_LOOP_CODE_NOT_REACHED, \ DISABLED_WARNINGS_microsoft := 4018 4267 4244 4312 4819, \ DISABLED_WARNINGS_gcc := implicit-fallthrough cast-function-type bad-function-cast, \ + DISABLED_WARNINGS_clang := missing-declarations, \ LDFLAGS := $(LDFLAGS_JDKLIB) \ $(call SET_SHARED_LIBRARY_ORIGIN), \ )) - 8293672: Update freetype md file ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/728/files - new: https://git.openjdk.org/jdk8u-dev/pull/728/files/91b99191..57ced473 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=728&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=728&range=01-02 Stats: 3692 lines in 283 files changed: 1650 ins; 719 del; 1323 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/728.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/728/head:pull/728 PR: https://git.openjdk.org/jdk8u-dev/pull/728 From jvanek at openjdk.org Fri Nov 28 13:28:47 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 28 Nov 2025 13:28:47 GMT Subject: [jdk8u-dev] RFR: 8316028: Update FreeType to 2.13.2 [v4] In-Reply-To: References: Message-ID: > This should be last PR on toppic of free type backport. At the end it should contain: > * 8285686: Update FreeType to 2.12.0 (pushed, testing in progress) > * 8290334: Update FreeType to 2.12.1 (pushed, smoketests done) > * 8298974: Add ftcolor.c to imported freetype sources (pushed, smoketests done) > * 8293672: Update freetype md file (not clean) > * 8306881: Update FreeType to 2.13.0 (pushed, testing scheduled) > * 8316028: Update FreeType to 2.13.2 (pushed, smoletests running) > * 8348596: Update FreeType to 2.13.3 > > I will run full qa on 2.12.0 and 2.13.0 Buildability and tier1 tests on others. > The 2.13.3. will get full qa during rampdown I guess... Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: 8316028: Update FreeType to 2.13.2 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/728/files - new: https://git.openjdk.org/jdk8u-dev/pull/728/files/57ced473..a188a7d5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=728&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=728&range=02-03 Stats: 5484 lines in 100 files changed: 1565 ins; 2060 del; 1859 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/728.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/728/head:pull/728 PR: https://git.openjdk.org/jdk8u-dev/pull/728 From jvanek at openjdk.org Fri Nov 28 13:50:52 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 28 Nov 2025 13:50:52 GMT Subject: [jdk8u-dev] RFR: 8348596: Update FreeType to 2.13.3 [v5] In-Reply-To: References: Message-ID: > This should be last PR on toppic of free type backport. At the end it should contain: > * 8285686: Update FreeType to 2.12.0 (pushed, testing in progress) > * 8290334: Update FreeType to 2.12.1 (pushed, smoketests done) > * 8298974: Add ftcolor.c to imported freetype sources (pushed, smoketests done) > * 8293672: Update freetype md file (not clean) > * 8306881: Update FreeType to 2.13.0 (pushed, testing scheduled) > * 8316028: Update FreeType to 2.13.2 (pushed, smoletests done) > * 8348596: Update FreeType to 2.13.3 (pushed, smoletests running) > > I will run full qa on 2.12.0 and 2.13.0 Buildability and tier1 tests on others. > The 2.13.3. will get full qa during rampdown I guess... Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: 8348596: Update FreeType to 2.13.3 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/728/files - new: https://git.openjdk.org/jdk8u-dev/pull/728/files/a188a7d5..653357e9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=728&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=728&range=03-04 Stats: 3796 lines in 280 files changed: 996 ins; 1647 del; 1153 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/728.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/728/head:pull/728 PR: https://git.openjdk.org/jdk8u-dev/pull/728 From jvanek at openjdk.org Fri Nov 28 15:28:05 2025 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Fri, 28 Nov 2025 15:28:05 GMT Subject: [jdk8u-dev] RFR: 8348596: Update FreeType to 2.13.3 [v5] In-Reply-To: References: Message-ID: On Fri, 28 Nov 2025 13:50:52 GMT, Ji?? Van?k wrote: >> This should be last PR on toppic of free type backport. At the end it should contain: >> * 8285686: Update FreeType to 2.12.0 (pushed, testing in progress) >> * 8290334: Update FreeType to 2.12.1 (pushed, smoketests done) >> * 8298974: Add ftcolor.c to imported freetype sources (pushed, smoketests done) >> * 8293672: Update freetype md file (not clean) >> * 8306881: Update FreeType to 2.13.0 (pushed, testing scheduled) >> * 8316028: Update FreeType to 2.13.2 (pushed, smoketests done) >> * 8348596: Update FreeType to 2.13.3 (pushed, smoketests done) >> >> I will run full qa on 2.12.0 and 2.13.0 Buildability and tier1 tests on others. >> The 2.13.3. will get full qa during rampdown I guess... > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > 8348596: Update FreeType to 2.13.3 Only `runtime/containers/docker/TestCPUAwareness.java ` in the GHas ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/728#issuecomment-3589707953 From duke at openjdk.org Sat Nov 29 02:25:07 2025 From: duke at openjdk.org (duke) Date: Sat, 29 Nov 2025 02:25:07 GMT Subject: [jdk8u-dev] Withdrawn: 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag In-Reply-To: <9OU59-FHZ2M70rEbLCoTEySTkJO7Js9yIF8f_UuGNlo=.344b0a1f-836b-433b-9d4e-b56bad4b5f23@github.com> References: <9OU59-FHZ2M70rEbLCoTEySTkJO7Js9yIF8f_UuGNlo=.344b0a1f-836b-433b-9d4e-b56bad4b5f23@github.com> Message-ID: On Sat, 6 Sep 2025 20:08:47 GMT, Jan Kratochvil wrote: > It is needed in jdk8 as a prerequisite for JDK-6986863. > A testcase is included. > It is not a clean backport - source files are moved, include files angle vs. quote change, copyright years update. > This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/690