[jdk8u-dev] RFR: 8371352: [8u] Fix VS2010 build issue in check_code.c [v2]

[Andrew John Hughes]

On Wed, 5 Nov 2025 15:55:07 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> JDK 8 code fails to build using VS2010 with errors:
>> 
>> ...
>> check_code.c
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1167) : error C2143: syntax error : missing ';' before 'type'
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1168) : error C2065: 'target' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1183) : error C2143: syntax error : missing ';' before 'type'
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1184) : error C2065: 'target' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1222) : error C2143: syntax error : missing ';' before 'type'
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1223) : error C2065: 'jump' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1225) : error C2143: syntax error : missing ';' before 'type'
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1226) : error C2065: 'target' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1228) : error C2065: 'jump' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1229) : error C2065: 'jump' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'target' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1231) : error C2065: 'jump' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1232) : error C2065: 'target' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1769) : error C2143: syntax error : missing ';' before 'type'
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier
>> d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/common/check_code.c(1770) : error C2065: 'target' : undeclared identifier 
>> 
>> 
>> Issue is JDK 8 only, because newer JDKs require higher version of visual studio. 
>> 
>> **Testing:**
>> - GHA: OK
>> - security infra problems are unrelated
>
> Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Looks fine to me. Broken by JDK-8352637: "Enhance bytecode verification", one of the 2025-10 security update changes.

I seem to recall that I tested a patch a while back that checked for this with `gcc`. I should try and dig that out so we can catch these issues on GNU/Linux before they make it in.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/713#pullrequestreview-3445075371