[jdk8u-dev] RFR: 8222362: Upgrade to Freetype 2.10.0
Andrew John Hughes
andrew at openjdk.org
Wed Nov 19 11:21:26 UTC 2025
On Fri, 14 Nov 2025 10:53:19 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
> Without
>
> index 00d35a69844..3464eb15e88 100644
> --- a/jdk/make/lib/Awt2dLibraries.gmk
> +++ b/jdk/make/lib/Awt2dLibraries.gmk
> @@ -541,6 +541,7 @@ else
> E_STATEMENT_NOT_REACHED \
> E_END_OF_LOOP_CODE_NOT_REACHED, \
> DISABLED_WARNINGS_microsoft := 4267 4244 4312, \
> + DISABLED_WARNINGS_gcc := implicit-fallthrough, \
> LDFLAGS := $(LDFLAGS_JDKLIB) \
> $(call SET_SHARED_LIBRARY_ORIGIN), \
> ))
>
> which needs
> https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others:
> https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk
I think we may need to merge this with at least [8222362](https://bugs.openjdk.org/browse/JDK-8222362): "Upgrade to Freetype 2.10.0" as the 2.9.1 is not public and so Skara can't pick it up as a backport. As long as both bugs are credited and in separate commits I'm fine with this.
As to the warning flags, we should just add them as `CFLAGS`. The `-DDLL_EXPORT` is actually already there. It should be easy enough to just add things like `BUILD_LIBFREETYPE_CFLAGS += -Wno-implicit-fallthrough` when on Linux. However, I'm not sure we even need them on 8u - at least not immediately - as I don't think it builds with warnings as errors for the JDK code as it stands.
-------------
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3550017945
More information about the jdk8u-dev
mailing list