[jdk8u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v2]

Wed Nov 26 10:03:28 UTC 2025

On Wed, 26 Nov 2025 01:22:14 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> I'm confused by some of the comments in the PR. I don't see any `var` usage in the 11u patch, which I presume would have to be taken out already for that backport, and it also has the additional bug IDs.

Hi @gnu-andrew, I'm realizing the comment is very confusing, sorry for that. It was meant to describe the [JDK-8339280] backport only, as the other two issues were mentioned in the _**Related issues ("relates to" Jira issue links)**_ section. It should be clearer with the order of events:
* [JDK-8339280] is the main change, it included a test case that was later failing (the test had 2 `var` usages)
* [JDK-8353299] is the original fix to the test case, I found it didn't address the root cause of the test failure
* [JDK-8367782] is a new fix I proposed in mainline before starting the backports (the `var` usages were removed there)

> I also don't see any discussion about translations and I'm not aware of this policy of not including these changes. What is the reason for this?

In https://github.com/openjdk/jdk21u-dev/pull/2235#pullrequestreview-3245163053, Severin explained to me that we don't include internationalization changes in backports, when those changes come from bulk updates. In this case, I was taking the translations from [JDK-8359761: JDK 25 RDP1 L10n resource files update](https://bugs.openjdk.org/browse/JDK-8359761) (openjdk/jdk at da7080fffb2389465dc9afca6d02e9085fe15302).

[JDK-8339280]: https://bugs.openjdk.org/browse/JDK-8339280 "jarsigner -verify performs cross-checking between CEN and LOC"
[JDK-8353299]: https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails"
[JDK-8367782]: https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName"

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/699#issuecomment-3580539652