[jdk8u-dev] RFR: 8261170: Upgrade to FreeType 2.10.4 [v4]
Andrew John Hughes
andrew at openjdk.org
Thu Nov 27 11:57:12 UTC 2025
On Thu, 20 Nov 2025 11:58:56 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
>> Without
>>
>> index 00d35a69844..3464eb15e88 100644
>> --- a/jdk/make/lib/Awt2dLibraries.gmk
>> +++ b/jdk/make/lib/Awt2dLibraries.gmk
>> @@ -541,6 +541,7 @@ else
>> E_STATEMENT_NOT_REACHED \
>> E_END_OF_LOOP_CODE_NOT_REACHED, \
>> DISABLED_WARNINGS_microsoft := 4267 4244 4312, \
>> + DISABLED_WARNINGS_gcc := implicit-fallthrough, \
>> LDFLAGS := $(LDFLAGS_JDKLIB) \
>> $(call SET_SHARED_LIBRARY_ORIGIN), \
>> ))
>>
>> which needs
>> https://github.com/openjdk/jdk11u/commit/f74d0aef61caa48a248c6661fa8e3871885b0ec8#diff-a634b106e57d9efbd1270664b8b79b2048b035a109b6f5220c4d39a4293d4458 and few others:
>> https://github.com/openjdk/jdk11u/blame/518c6c5dd04dda28d9468e89cc9e322b72fcbcd3/make/lib/Awt2dLibraries.gmk
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
>
> 8261170: Upgrade to freetype 2.10.4
I reviewed all five commits against their 11u versions. 8227324, 8247867 & 8261170 were all clean with the expected move of the `freetype.md` change to `THIRD_PARTY_README`. Warning flag additions were not ported for 8203367 & 8222362, but I'm ok with this as the JDK (`jdk/src`) native code already does not build with `-Werror` (not added by default, would fail if done) and we don't really gain anything from turning them off in the FreeType code. I may look into this under a separate PR.
Let's get this batch of updates in so they can be in the promotion at the end of this week.
-------------
Marked as reviewed by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk8u-dev/pull/720#pullrequestreview-3514874886
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/720#issuecomment-3585461427
More information about the jdk8u-dev
mailing list