From tpushkin at openjdk.org Mon Sep 1 07:42:11 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Mon, 1 Sep 2025 07:42:11 GMT Subject: [jdk8u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources Message-ID: Backport of [JDK-8274893](https://bugs.openjdk.org/browse/JDK-8274893) for parity with Oracle's JDK 8u461. The first commit is a cherry-pick of the backport to JDK 11 with conflicts unresolved, the second resolves the conflicts, the rest resolve issues uncaught by git. Resolved: - `jdk/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java` - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant - Missing JDK-8041679: `StringBuffer` is used instead of `StringBuilder` - `jdk/src/share/classes/javax/swing/text/html/HTMLEditorKit.java` - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant - `jdk/src/share/classes/com/sun/media/sound/StandardMidiFileWriter.java` - Missing JDK-8143909: no `Objects.requireNonNull(...)` in this version - `jdk/src/solaris/classes/sun/awt/motif/MFontConfiguration.java` - Missing JDK-8054834: imports from `sun.font` package are still needed in this file - `jdk/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java` - Missing JDK-8080835: use `IOUtils.readAllBytes(InputStream is)` instead of the missing `InputStream.readAllBytes()` - Missing JDK-7196163: try-with-resources cannot be used with pre-existing variables ? fell back to try-finally in such cases Testing: GitHub CI, `jdk_imageio` test group locally (headless linux/arm64) ------------- Commit messages: - Use IOUtils.readAllBytes(...) - Fall back to try-finally where pre-existing variables are used - Bring back required imports - Resolve conflicts - 8274893: Update java.desktop classes to use try-with-resources Changes: https://git.openjdk.org/jdk8u-dev/pull/686/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=686&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274893 Stats: 205 lines in 23 files changed: 32 ins; 79 del; 94 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/686.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/686/head:pull/686 PR: https://git.openjdk.org/jdk8u-dev/pull/686 From tpushkin at openjdk.org Mon Sep 1 07:50:10 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Mon, 1 Sep 2025 07:50:10 GMT Subject: [jdk8u-dev] RFR: 8347911: Limit the length of inflated text chunks Message-ID: <-2zwBZ1FTUa13C6m980zm5KlZvlGKXsXv03jX4h1IA0=.0a4f66da-8a44-4ded-a65d-3ed400a8a2cf@github.com> Backport of [JDK-8347911](https://bugs.openjdk.org/browse/JDK-8347911) for parity with Oracle's JDK 8u461. Conflicts: - Copyright years - Missing JDK-8139206: use `IOUtils.readNBytes(...)` instead of the missing `InputStream.readNBytes(...)` Testing: GitHub CI, jdk_imageio test group locally (headless linux/arm64) ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/686 Commit messages: - 8347911: Limit the length of inflated text chunks Changes: https://git.openjdk.org/jdk8u-dev/pull/687/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=687&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347911 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/687.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/687/head:pull/687 PR: https://git.openjdk.org/jdk8u-dev/pull/687 From sgehwolf at openjdk.org Mon Sep 1 08:22:52 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 1 Sep 2025 08:22:52 GMT Subject: [jdk8u-dev] Integrated: 8361212: Remove AffirmTrust root CAs In-Reply-To: References: Message-ID: On Wed, 27 Aug 2025 12:55:57 GMT, Severin Gehwolf wrote: > Backport of JDK-8361212 to remove expired certificates. The patch is almost clean as compared to the JDK 11 version (modulo path suffeling). > > Testing: > > Passed: sun/security/lib/cacerts/VerifyCACerts.java > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca2 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#buypassclass2ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#buypassclass3ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certignarootca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#comodoeccca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#comodorsaca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#emsigneccrootcag3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#emsignrootcag1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#entrustrootcaec1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#entrustrootcag4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAIntero... This pull request has now been integrated. Changeset: 3f2b6ffe Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/3f2b6ffee4b2a077f5fc8e00d58bce906a80cca0 Stats: 503 lines in 12 files changed: 0 ins; 491 del; 12 mod 8361212: Remove AffirmTrust root CAs Reviewed-by: andrew Backport-of: 5173435bfd0db5db0113a6209f2f827b16598596 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/684 From aturbanov at openjdk.org Mon Sep 1 10:42:48 2025 From: aturbanov at openjdk.org (Andrey Turbanov) Date: Mon, 1 Sep 2025 10:42:48 GMT Subject: [jdk8u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources In-Reply-To: References: Message-ID: <59KlsnLyi4hp_QlWRNRE9nKnFTAvXm_4qvXuCb61id4=.e48d03bb-f635-42ba-8315-39ad58651a39@github.com> On Mon, 1 Sep 2025 07:36:51 GMT, Timofei Pushkin wrote: > Backport of [JDK-8274893](https://bugs.openjdk.org/browse/JDK-8274893) for parity with Oracle's JDK 8u461. > > The first commit is a cherry-pick of the backport to JDK 11 with conflicts unresolved, the second resolves the conflicts, the rest resolve issues uncaught by git. > > Resolved: > - `jdk/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java` > - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant > - Missing JDK-8041679: `StringBuffer` is used instead of `StringBuilder` > - `jdk/src/share/classes/javax/swing/text/html/HTMLEditorKit.java` > - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant > - `jdk/src/share/classes/com/sun/media/sound/StandardMidiFileWriter.java` > - Missing JDK-8143909: no `Objects.requireNonNull(...)` in this version > - `jdk/src/solaris/classes/sun/awt/motif/MFontConfiguration.java` > - Missing JDK-8054834: imports from `sun.font` package are still needed in this file > - `jdk/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java` > - Missing JDK-8080835: use `IOUtils.readAllBytes(InputStream is)` instead of the missing `InputStream.readAllBytes()` > - Missing JDK-7196163: try-with-resources cannot be used with pre-existing variables ? fell back to try-finally in such cases > > Testing: GitHub CI, `jdk_imageio` test group locally (headless linux/arm64) jdk/src/share/classes/com/sun/media/sound/JARSoundbankReader.java line 91: > 89: if (stream == null) > 90: return null; > 91: try { There should be try-with-resources ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/686#discussion_r2313598761 From tpushkin at openjdk.org Mon Sep 1 11:02:50 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Mon, 1 Sep 2025 11:02:50 GMT Subject: [jdk8u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources In-Reply-To: <59KlsnLyi4hp_QlWRNRE9nKnFTAvXm_4qvXuCb61id4=.e48d03bb-f635-42ba-8315-39ad58651a39@github.com> References: <59KlsnLyi4hp_QlWRNRE9nKnFTAvXm_4qvXuCb61id4=.e48d03bb-f635-42ba-8315-39ad58651a39@github.com> Message-ID: On Mon, 1 Sep 2025 10:40:38 GMT, Andrey Turbanov wrote: >> Backport of [JDK-8274893](https://bugs.openjdk.org/browse/JDK-8274893) for parity with Oracle's JDK 8u461. >> >> The first commit is a cherry-pick of the backport to JDK 11 with conflicts unresolved, the second resolves the conflicts, the rest resolve issues uncaught by git. >> >> Resolved: >> - `jdk/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java` >> - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant >> - Missing JDK-8041679: `StringBuffer` is used instead of `StringBuilder` >> - `jdk/src/share/classes/javax/swing/text/html/HTMLEditorKit.java` >> - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant >> - `jdk/src/share/classes/com/sun/media/sound/StandardMidiFileWriter.java` >> - Missing JDK-8143909: no `Objects.requireNonNull(...)` in this version >> - `jdk/src/solaris/classes/sun/awt/motif/MFontConfiguration.java` >> - Missing JDK-8054834: imports from `sun.font` package are still needed in this file >> - `jdk/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java` >> - Missing JDK-8080835: use `IOUtils.readAllBytes(InputStream is)` instead of the missing `InputStream.readAllBytes()` >> - Missing JDK-7196163: try-with-resources cannot be used with pre-existing variables ? fell back to try-finally in such cases >> >> Testing: GitHub CI, `jdk_imageio` test group locally (headless linux/arm64) > > jdk/src/share/classes/com/sun/media/sound/JARSoundbankReader.java line 91: > >> 89: if (stream == null) >> 90: return null; >> 91: try { > > There should be try-with-resources There was in the original change but in this JDK try-with-resources on an existing variable is not possible (no JDK-7196163), so I fell back to try-finally. This is not the only place where I've done this, see [832c3c3](https://github.com/openjdk/jdk8u-dev/pull/686/commits/832c3c3bb4c132b025e7d3043b40be0d2d025a95). Alternatives are to either create a copy variable for try-with-resources (which also must be used inside it to prevent a compiler warning) or move all interactions with the variable inside try-with-resources ? both diverge code from the original change and the pre-existing code so I decided against them. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/686#discussion_r2313639165 From aturbanov at openjdk.org Mon Sep 1 11:53:48 2025 From: aturbanov at openjdk.org (Andrey Turbanov) Date: Mon, 1 Sep 2025 11:53:48 GMT Subject: [jdk8u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources In-Reply-To: References: <59KlsnLyi4hp_QlWRNRE9nKnFTAvXm_4qvXuCb61id4=.e48d03bb-f635-42ba-8315-39ad58651a39@github.com> Message-ID: On Mon, 1 Sep 2025 11:00:23 GMT, Timofei Pushkin wrote: >> jdk/src/share/classes/com/sun/media/sound/JARSoundbankReader.java line 91: >> >>> 89: if (stream == null) >>> 90: return null; >>> 91: try { >> >> There should be try-with-resources > > There was in the original change but in this JDK try-with-resources on an existing variable is not possible (no JDK-7196163), so I fell back to try-finally. This is not the only place where I've done this, see [832c3c3](https://github.com/openjdk/jdk8u-dev/pull/686/commits/832c3c3bb4c132b025e7d3043b40be0d2d025a95). > > Alternatives are to either create a copy variable for try-with-resources (which also must be used inside it to prevent a compiler warning) or move all interactions with the variable inside try-with-resources ? both diverge code from the original change and the pre-existing code so I decided against them. Shouldn't we revert formatting changes here, then? ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/686#discussion_r2313743255 From tpushkin at openjdk.org Mon Sep 1 12:54:33 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Mon, 1 Sep 2025 12:54:33 GMT Subject: [jdk8u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8274893](https://bugs.openjdk.org/browse/JDK-8274893) for parity with Oracle's JDK 8u461. > > The first commit is a cherry-pick of the backport to JDK 11 with conflicts unresolved, the second resolves the conflicts, the rest resolve issues uncaught by git. > > Resolved: > - `jdk/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java` > - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant > - Missing JDK-8041679: `StringBuffer` is used instead of `StringBuilder` > - `jdk/src/share/classes/javax/swing/text/html/HTMLEditorKit.java` > - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant > - `jdk/src/share/classes/com/sun/media/sound/StandardMidiFileWriter.java` > - Missing JDK-8143909: no `Objects.requireNonNull(...)` in this version > - `jdk/src/solaris/classes/sun/awt/motif/MFontConfiguration.java` > - Missing JDK-8054834: imports from `sun.font` package are still needed in this file > - `jdk/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java` > - Missing JDK-8080835: use `IOUtils.readAllBytes(InputStream is)` instead of the missing `InputStream.readAllBytes()` > - Missing JDK-7196163: try-with-resources cannot be used with pre-existing variables ? fell back to try-finally in such cases > > Testing: GitHub CI, `jdk_imageio` test group locally (headless linux/arm64) Timofei Pushkin has updated the pull request incrementally with one additional commit since the last revision: Bring back old formatting in JARSoundbankReader ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/686/files - new: https://git.openjdk.org/jdk8u-dev/pull/686/files/605f1e88..3fd18e4f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=686&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=686&range=00-01 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/686.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/686/head:pull/686 PR: https://git.openjdk.org/jdk8u-dev/pull/686 From tpushkin at openjdk.org Mon Sep 1 12:54:33 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Mon, 1 Sep 2025 12:54:33 GMT Subject: [jdk8u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources [v2] In-Reply-To: References: <59KlsnLyi4hp_QlWRNRE9nKnFTAvXm_4qvXuCb61id4=.e48d03bb-f635-42ba-8315-39ad58651a39@github.com> Message-ID: <5NwRHMhOEAw11NFUW9mWvEThvNF7uHgUeqdQD1PQK-s=.2351e95e-95f6-465a-a296-9c2bedf02981@github.com> On Mon, 1 Sep 2025 11:51:18 GMT, Andrey Turbanov wrote: >> There was in the original change but in this JDK try-with-resources on an existing variable is not possible (no JDK-7196163), so I fell back to try-finally. This is not the only place where I've done this, see [832c3c3](https://github.com/openjdk/jdk8u-dev/pull/686/commits/832c3c3bb4c132b025e7d3043b40be0d2d025a95). >> >> Alternatives are to either create a copy variable for try-with-resources (which also must be used inside it to prevent a compiler warning) or move all interactions with the variable inside try-with-resources ? both diverge code from the original change and the pre-existing code so I decided against them. > > Shouldn't we revert formatting changes here, then? I wasn't sure what would be the best here: keeping the existing formatting to changing it to be closer to the backported change ? and went with the latter. Since I don't really have a strong preference, reverted to the old one now as you suggest. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/686#discussion_r2313878810 From evergizova at openjdk.org Mon Sep 1 13:07:32 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 1 Sep 2025 13:07:32 GMT Subject: [jdk8u-dev] RFR: 8297088: Update LCMS to 2.14 [v2] In-Reply-To: References: Message-ID: > I'd like to backport it for parity with Oracle 8u. > 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. > I also fixed the file paths in UPDATING.txt instructions so that they match the paths in OpenJDK8. > > GHA testing revealed no regressions, additionally tested manually with J2Ddemo. Ekaterina Vergizova has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into 8297088 - Backport 01b213899cb8124860441fa26c9652b4a4bff896 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/677/files - new: https://git.openjdk.org/jdk8u-dev/pull/677/files/7536819c..6f31652b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=677&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=677&range=00-01 Stats: 1740 lines in 97 files changed: 279 ins; 1087 del; 374 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/677.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/677/head:pull/677 PR: https://git.openjdk.org/jdk8u-dev/pull/677 From tpushkin at openjdk.org Mon Sep 1 14:48:49 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Mon, 1 Sep 2025 14:48:49 GMT Subject: [jdk8u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources [v2] In-Reply-To: References: Message-ID: On Mon, 1 Sep 2025 12:54:33 GMT, Timofei Pushkin wrote: >> Backport of [JDK-8274893](https://bugs.openjdk.org/browse/JDK-8274893) for parity with Oracle's JDK 8u461. >> >> The first commit is a cherry-pick of the backport to JDK 11 with conflicts unresolved, the second resolves the conflicts, the rest resolve issues uncaught by git. >> >> Resolved: >> - `jdk/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java` >> - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant >> - Missing JDK-8041679: `StringBuffer` is used instead of `StringBuilder` >> - `jdk/src/share/classes/javax/swing/text/html/HTMLEditorKit.java` >> - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant >> - `jdk/src/share/classes/com/sun/media/sound/StandardMidiFileWriter.java` >> - Missing JDK-8143909: no `Objects.requireNonNull(...)` in this version >> - `jdk/src/solaris/classes/sun/awt/motif/MFontConfiguration.java` >> - Missing JDK-8054834: imports from `sun.font` package are still needed in this file >> - `jdk/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java` >> - Missing JDK-8080835: use `IOUtils.readAllBytes(InputStream is)` instead of the missing `InputStream.readAllBytes()` >> - Missing JDK-7196163: try-with-resources cannot be used with pre-existing variables ? fell back to try-finally in such cases >> >> Testing: GitHub CI, `jdk_imageio` test group locally (headless linux/arm64) > > Timofei Pushkin has updated the pull request incrementally with one additional commit since the last revision: > > Bring back old formatting in JARSoundbankReader I believe test failures are not related ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/686#issuecomment-3242631971 From tpushkin at openjdk.org Mon Sep 1 14:49:48 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Mon, 1 Sep 2025 14:49:48 GMT Subject: [jdk8u-dev] RFR: 8347911: Limit the length of inflated text chunks In-Reply-To: <-2zwBZ1FTUa13C6m980zm5KlZvlGKXsXv03jX4h1IA0=.0a4f66da-8a44-4ded-a65d-3ed400a8a2cf@github.com> References: <-2zwBZ1FTUa13C6m980zm5KlZvlGKXsXv03jX4h1IA0=.0a4f66da-8a44-4ded-a65d-3ed400a8a2cf@github.com> Message-ID: On Mon, 1 Sep 2025 07:44:51 GMT, Timofei Pushkin wrote: > Backport of [JDK-8347911](https://bugs.openjdk.org/browse/JDK-8347911) for parity with Oracle's JDK 8u461. > > Conflicts: > - Copyright years > - Missing JDK-8139206: use `IOUtils.readNBytes(...)` instead of the missing `InputStream.readNBytes(...)` > > Testing: GitHub CI, jdk_imageio test group locally (headless linux/arm64) I believe the test failures are not related ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/687#issuecomment-3242633226 From gnu.andrew at redhat.com Mon Sep 1 15:46:41 2025 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Mon, 1 Sep 2025 16:46:41 +0100 Subject: [RAMPDOWN] 8u472 Now in Rampdown Stage Message-ID: 8u472 is now in rampdown for release in October 2025. jdk8u-dev is CLOSED for commits until openjdk8u482 is added to the OpenJDK bug database and https://bugs.openjdk.org/browse/JDK-8366574 is integrated to begin the 8u482 release cycle. For critical fixes (i.e. regressions or urgent fixes like tzdata & cacerts updates) for 8u472, please file a PR against https://github.com/openjdk/jdk8u and use jdk8u-critical-request to obtain approval to push (automatic with the /approval request command [0]). [0] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval Thanks, -- Andrew :) Pronouns: he / him or they / them Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From evergizova at openjdk.org Mon Sep 1 15:59:51 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 1 Sep 2025 15:59:51 GMT Subject: [jdk8u-dev] RFR: 8297088: Update LCMS to 2.14 [v2] In-Reply-To: References: Message-ID: On Fri, 29 Aug 2025 22:40:44 GMT, Andrew John Hughes wrote: > Patch itself looks ok. Could you re-run the Windows x86_64 build? It seems to be failing in an odd way (failing to build FreeType) that I can't see is related to the change. @gnu-andrew, thanks for the review. It looks like the problem with Windows builds were fixed by https://github.com/openjdk/jdk8u-dev/commit/41e6bf7d1f6a0b576c46c1f00e2c4cbc89a48a96 All builds have passed successfully after the merge, and the remaining test failures don't seem to be related to the backport: - security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca - gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java - runtime/7158988/FieldMonitor.java ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/677#issuecomment-3242813045 From andrew at openjdk.org Mon Sep 1 16:23:04 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 1 Sep 2025 16:23:04 GMT Subject: [jdk8u-dev] RFR: 8366574: Bump update version of OpenJDK: 8u482 Message-ID: Rampdown for 8u472 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-September/020424.html). 8u-dev needs to transition to 8u482. PR will also need to wait on `openjdk8u482` being added to the bug database. ------------- Commit messages: - 8366574: Bump update version of OpenJDK: 8u482 Changes: https://git.openjdk.org/jdk8u-dev/pull/688/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=688&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8366574 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/688.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/688/head:pull/688 PR: https://git.openjdk.org/jdk8u-dev/pull/688 From sgehwolf at openjdk.org Mon Sep 1 16:53:48 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 1 Sep 2025 16:53:48 GMT Subject: [jdk8u-dev] RFR: 8366574: Bump update version of OpenJDK: 8u482 In-Reply-To: References: Message-ID: On Mon, 1 Sep 2025 16:19:27 GMT, Andrew John Hughes wrote: > Rampdown for 8u472 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-September/020424.html). 8u-dev needs to transition to 8u482. > > PR will also need to wait on `openjdk8u482` being added to the bug database. LGTM ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/688#pullrequestreview-3174214951 From ktakakuri at openjdk.org Tue Sep 2 09:16:32 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 2 Sep 2025 09:16:32 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v6] In-Reply-To: References: Message-ID: > This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. > > Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. > The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. > So, I propose to judge the buttonModel is an instance of DefaultButtonModel. > > Testing: > java/awt > javax/swing > ButtonGroupLayoutTraversalTest.java > bug8033699.java > DefaultButtonModelCrashTest.java > on Windows x86_64 Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision: - Merge branch 'openjdk:master' into 8154043 - Merge branch 'master' into 8154043 - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f - Fix the copyright years - Merge branch 'openjdk:master' into 8154043 - Chmod ButtonGroupLayoutTraversalTest - Chmod DefaultButtonModelCrashTest - Fix the copyright year - Backport f3abf05b31893b9a066a436e2c4a587f8899ab10 - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/62ac9384...df933477 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/285/files - new: https://git.openjdk.org/jdk8u-dev/pull/285/files/004551a0..df933477 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=285&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=285&range=04-05 Stats: 1740 lines in 97 files changed: 279 ins; 1087 del; 374 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/285.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/285/head:pull/285 PR: https://git.openjdk.org/jdk8u-dev/pull/285 From shade at openjdk.org Tue Sep 2 12:20:50 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 2 Sep 2025 12:20:50 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash In-Reply-To: References: Message-ID: On Thu, 14 Aug 2025 10:25:41 GMT, Kerem Kat wrote: > Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). > > The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. > > I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. > > For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. > > The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. This looks fine. Like the backports to other releases, this looks like a nice safety net. But yes, @gnu-andrew or @jerboaa would need to approve it for JDK 8. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/674#pullrequestreview-3176289185 From sgehwolf at openjdk.org Tue Sep 2 12:26:49 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 2 Sep 2025 12:26:49 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash In-Reply-To: References: Message-ID: On Thu, 14 Aug 2025 10:25:41 GMT, Kerem Kat wrote: > Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). > > The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. > > I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. > > For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. > > The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. jdk8u-dev is currently [closed for pushes](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-September/020424.html). I'll approve once JDK-8366574 is in. In the meantime please merge latest master to avoid the windows build failure in CI. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/674#issuecomment-3245101421 From krk at openjdk.org Tue Sep 2 15:34:08 2025 From: krk at openjdk.org (Kerem Kat) Date: Tue, 2 Sep 2025 15:34:08 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). > > The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. > > I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. > > For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. > > The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into JDK-8212155 - Fix test for JDK 8 - Backport 64ec8b3e5c8a8d44c92591710d73b833f13c1500 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/674/files - new: https://git.openjdk.org/jdk8u-dev/pull/674/files/6dac15dc..bb97234c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=674&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=674&range=00-01 Stats: 1741 lines in 98 files changed: 279 ins; 1087 del; 375 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/674.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/674/head:pull/674 PR: https://git.openjdk.org/jdk8u-dev/pull/674 From serb at openjdk.org Tue Sep 2 22:14:52 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Sep 2025 22:14:52 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties [v3] In-Reply-To: <-fy54zhS5ozkNT-AEjzfN4A97IzGt1IHuYXVzEpBWS0=.0641651e-e085-4e95-9835-b2495e469d5d@github.com> References: <-fy54zhS5ozkNT-AEjzfN4A97IzGt1IHuYXVzEpBWS0=.0641651e-e085-4e95-9835-b2495e469d5d@github.com> Message-ID: On Wed, 20 Aug 2025 16:29:55 GMT, Alexey Bakhtin wrote: >> Add missing properties for the j2gss.dll and sspi_bridge.dll files > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Add CheckWindowsProperty test Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/611#pullrequestreview-3178291736 From sgehwolf at openjdk.org Wed Sep 3 08:27:54 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 3 Sep 2025 08:27:54 GMT Subject: [jdk8u-dev] RFR: 8366574: Bump update version of OpenJDK: 8u482 In-Reply-To: References: Message-ID: <0G6MQ5LodM7tUa9zIp-S12gFiX19K3lJ0zQ3k_Xfe18=.7f7830d9-e373-451b-b833-b56c97fd5e3d@github.com> On Mon, 1 Sep 2025 16:19:27 GMT, Andrew John Hughes wrote: > Rampdown for 8u472 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-September/020424.html). 8u-dev needs to transition to 8u482. > > PR will also need to wait on `openjdk8u482` being added to the bug database. According to my info the version is now there. Please apply for approval. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/688#issuecomment-3248202187 From andrew at openjdk.org Wed Sep 3 08:57:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 3 Sep 2025 08:57:45 GMT Subject: [jdk8u-dev] RFR: 8366574: Bump update version of OpenJDK: 8u482 In-Reply-To: <0G6MQ5LodM7tUa9zIp-S12gFiX19K3lJ0zQ3k_Xfe18=.7f7830d9-e373-451b-b833-b56c97fd5e3d@github.com> References: <0G6MQ5LodM7tUa9zIp-S12gFiX19K3lJ0zQ3k_Xfe18=.7f7830d9-e373-451b-b833-b56c97fd5e3d@github.com> Message-ID: On Wed, 3 Sep 2025 08:24:32 GMT, Severin Gehwolf wrote: > According to my info the version is now there. Please apply for approval. Confirmed on the bug. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/688#issuecomment-3248311190 From krk at openjdk.org Wed Sep 3 09:35:50 2025 From: krk at openjdk.org (Kerem Kat) Date: Wed, 3 Sep 2025 09:35:50 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash [v2] In-Reply-To: References: Message-ID: <_r5Ams5cmb4dWTD1MqSnCkqpGkQwbi5nES63iCmx6y4=.f55cb998-e537-4f62-b292-45dcb0ed54c4@github.com> On Tue, 2 Sep 2025 15:34:08 GMT, Kerem Kat wrote: >> Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). >> >> The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. >> >> I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. >> >> For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. >> >> The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. > > Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into JDK-8212155 > - Fix test for JDK 8 > - Backport 64ec8b3e5c8a8d44c92591710d73b833f13c1500 After merge from master, the windows build error is gone, thanks for the suggestion. New failures seem unrelated to the current PR: ### CAInterop There are `CAInterop.java` failures in different architectures, similar to https://github.com/openjdk/jdk8u-dev/pull/673. The CA roots in question are `actalisauthenticationrootca` and in some cases `entrustrootcag4`. ### macOS x64 jdk/tier1 multiple failures with "Target VM failed to initialize", similar to the closed https://bugs.openjdk.org/browse/JDK-8286193 ### GC segfault Segfault in `CompactibleFreeListSpace::block_size` on Linux x86 hotspot/tier1 gc/6581734/Test6581734.java is tracked in [JDK-8332853](https://bugs.openjdk.org/browse/JDK-8332853). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/674#issuecomment-3248467005 From andrew at openjdk.org Wed Sep 3 10:51:52 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 3 Sep 2025 10:51:52 GMT Subject: [jdk8u-dev] Integrated: 8366574: Bump update version of OpenJDK: 8u482 In-Reply-To: References: Message-ID: <6d8ii8NL57Z-_V2BSIB1d61l8Mg9taS_u5b3qUVceZQ=.c73390f8-6d7f-4aff-821b-ab4d409d2454@github.com> On Mon, 1 Sep 2025 16:19:27 GMT, Andrew John Hughes wrote: > Rampdown for 8u472 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-September/020424.html). 8u-dev needs to transition to 8u482. > > PR will also need to wait on `openjdk8u482` being added to the bug database. This pull request has now been integrated. Changeset: c0a36d8f Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/c0a36d8fbe59b6fcd878cf14fed2c28c1c30c6eb Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8366574: Bump update version of OpenJDK: 8u482 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/688 From duke at openjdk.org Wed Sep 3 12:10:47 2025 From: duke at openjdk.org (duke) Date: Wed, 3 Sep 2025 12:10:47 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash [v2] In-Reply-To: References: Message-ID: On Tue, 2 Sep 2025 15:34:08 GMT, Kerem Kat wrote: >> Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). >> >> The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. >> >> I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. >> >> For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. >> >> The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. > > Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into JDK-8212155 > - Fix test for JDK 8 > - Backport 64ec8b3e5c8a8d44c92591710d73b833f13c1500 @krk Your change (at version bb97234c5ad464aa2597eac33c7922d0d3513c32) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/674#issuecomment-3248977129 From krk at openjdk.org Wed Sep 3 12:15:51 2025 From: krk at openjdk.org (Kerem Kat) Date: Wed, 3 Sep 2025 12:15:51 GMT Subject: [jdk8u-dev] Integrated: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash In-Reply-To: References: Message-ID: On Thu, 14 Aug 2025 10:25:41 GMT, Kerem Kat wrote: > Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). > > The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. > > I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. > > For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. > > The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. This pull request has now been integrated. Changeset: 942d6d06 Author: Kerem Kat Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk8u-dev/commit/942d6d06140b6bfc6fc1daff2f4883e84049b09a Stats: 201 lines in 4 files changed: 194 ins; 0 del; 7 mod 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash Reviewed-by: phh, shade Backport-of: 64ec8b3e5c8a8d44c92591710d73b833f13c1500 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/674 From gnu.andrew at redhat.com Wed Sep 3 15:03:20 2025 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 3 Sep 2025 16:03:20 +0100 Subject: [RAMPDOWN] 8u472 Now in Rampdown Stage In-Reply-To: References: Message-ID: On 16:46 Mon 01 Sep , Andrew Hughes wrote: > 8u472 is now in rampdown for release in October 2025. > > jdk8u-dev is CLOSED for commits until openjdk8u482 is added to the > OpenJDK bug database and https://bugs.openjdk.org/browse/JDK-8366574 > is integrated to begin the 8u482 release cycle. > > For critical fixes (i.e. regressions or urgent fixes like tzdata & > cacerts updates) for 8u472, please file a PR against > https://github.com/openjdk/jdk8u and use jdk8u-critical-request to > obtain approval to push (automatic with the /approval request command > [0]). > > [0] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval > > Thanks, > -- > Andrew :) > Pronouns: he / him or they / them > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > Please contact via e-mail, not proprietary chat networks jdk8u-dev is now open again. Thanks, -- Andrew :) Pronouns: he / him or they / them Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From jjiang at openjdk.org Wed Sep 3 15:40:33 2025 From: jjiang at openjdk.org (John Jiang) Date: Wed, 3 Sep 2025 15:40:33 GMT Subject: [jdk8u-dev] RFR: 8364597: Replace THL A29 Limited with Tencent Message-ID: <5qDOXxI-hUoUCnjhBLXSdu9gAifFz5ZpyZQ-HNPnLkI=.a712610f-2685-4795-b2e8-e6b125616808@github.com> Please review this backport of `JDK-8364597: Replace THL A29 Limited with Tencent`. This backport is not clean, because most files don't exist in jdk8u, and the copyright years in the following files are different between the repos. - jdk/test/jdk/internal/platform/docker/GetFreeSwapSpaceSize.java - jdk/test/jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java ------------- Commit messages: - Backport 4c9eaddaef83c6ba30e27ae3e0d16caeeec206cb Changes: https://git.openjdk.org/jdk8u-dev/pull/689/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=689&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8364597 Stats: 10 lines in 7 files changed: 0 ins; 3 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/689.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/689/head:pull/689 PR: https://git.openjdk.org/jdk8u-dev/pull/689 From andrew at openjdk.org Wed Sep 3 15:57:49 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 3 Sep 2025 15:57:49 GMT Subject: [jdk8u-dev] RFR: 8297088: Update LCMS to 2.14 [v2] In-Reply-To: References: Message-ID: On Mon, 1 Sep 2025 13:07:32 GMT, Ekaterina Vergizova wrote: >> I'd like to backport it for parity with Oracle 8u. >> 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. >> I also fixed the file paths in UPDATING.txt instructions so that they match the paths in OpenJDK8. >> >> GHA testing revealed no regressions, additionally tested manually with J2Ddemo. > > Ekaterina Vergizova has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into 8297088 > - Backport 01b213899cb8124860441fa26c9652b4a4bff896 Issues with Windows build resolved. > > Patch itself looks ok. Could you re-run the Windows x86_64 build? It seems to be failing in an odd way (failing to build FreeType) that I can't see is related to the change. > > @gnu-andrew, thanks for the review. It looks like the problem with Windows builds were fixed by [41e6bf7](https://github.com/openjdk/jdk8u-dev/commit/41e6bf7d1f6a0b576c46c1f00e2c4cbc89a48a96) > > All builds have passed successfully after the merge, and the remaining test failures don't seem to be related to the backport: > > * security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca > > * gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java > > * runtime/7158988/FieldMonitor.java Thanks for re-testing. It's good to hear that this fixed the build as the relationship between the two wasn't clear from the build failure. 8u482 is open now, so please apply for approval to get this in. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/677#pullrequestreview-3181305840 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/677#issuecomment-3249837571 From ktakakuri at openjdk.org Thu Sep 4 12:47:55 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 4 Sep 2025 12:47:55 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v6] In-Reply-To: References: Message-ID: On Tue, 2 Sep 2025 09:16:32 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision: > > - Merge branch 'openjdk:master' into 8154043 > - Merge branch 'master' into 8154043 > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f > - Fix the copyright years > - Merge branch 'openjdk:master' into 8154043 > - Chmod ButtonGroupLayoutTraversalTest > - Chmod DefaultButtonModelCrashTest > - Fix the copyright year > - Backport f3abf05b31893b9a066a436e2c4a587f8899ab10 > - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/ece02b57...df933477 I have merged the latest master branch and confirmed that there are no problems after running :jdk_awt and :jdk_swing tests on Windows. @jerboaa I previously received feedback from another maintainer on this PR. However, there hasn't been any further response for some time, and I'm wondering if there's an opportunity for it to be reviewed. JDK-8154043's bug is impacting several users' applications. If your schedule permits, would it be possible for you to take a look at this PR? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3253529762 From andrew at openjdk.org Thu Sep 4 14:45:50 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 4 Sep 2025 14:45:50 GMT Subject: [jdk8u-dev] RFR: 8364597: Replace THL A29 Limited with Tencent In-Reply-To: <5qDOXxI-hUoUCnjhBLXSdu9gAifFz5ZpyZQ-HNPnLkI=.a712610f-2685-4795-b2e8-e6b125616808@github.com> References: <5qDOXxI-hUoUCnjhBLXSdu9gAifFz5ZpyZQ-HNPnLkI=.a712610f-2685-4795-b2e8-e6b125616808@github.com> Message-ID: <0JrOxSb-8gcgN0Bdo0IHMh9AmuEA26APxYiHfpoGQZc=.148f492b-593a-4ac1-a61f-41ecd3f2b1b7@github.com> On Wed, 3 Sep 2025 15:35:39 GMT, John Jiang wrote: > Please review this backport of `JDK-8364597: Replace THL A29 Limited with Tencent`. > This backport is not clean, because most files don't exist in jdk8u, > and the copyright years in the following files are different between the repos. > - jdk/test/jdk/internal/platform/docker/GetFreeSwapSpaceSize.java > - jdk/test/jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java It looks like you are not running the GitHub Actions tests on your fork. While I don't expect any regression from this change, as it only alters comments, you should enable this for future backports at https://github.com/johnshajiang/jdk8u-dev/actions ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/689#issuecomment-3254069842 From andrew at openjdk.org Thu Sep 4 17:09:46 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 4 Sep 2025 17:09:46 GMT Subject: [jdk8u-dev] RFR: 8364597: Replace THL A29 Limited with Tencent In-Reply-To: <5qDOXxI-hUoUCnjhBLXSdu9gAifFz5ZpyZQ-HNPnLkI=.a712610f-2685-4795-b2e8-e6b125616808@github.com> References: <5qDOXxI-hUoUCnjhBLXSdu9gAifFz5ZpyZQ-HNPnLkI=.a712610f-2685-4795-b2e8-e6b125616808@github.com> Message-ID: <0W4rotd1ZUKdrpjUuMBoVA8WLoZLdnY_BWmt57J4ee0=.d6dce0a4-187a-47d5-b8d5-a39df44bedc4@github.com> On Wed, 3 Sep 2025 15:35:39 GMT, John Jiang wrote: > Please review this backport of `JDK-8364597: Replace THL A29 Limited with Tencent`. > This backport is not clean, because most files don't exist in jdk8u, > and the copyright years in the following files are different between the repos. > - jdk/test/jdk/internal/platform/docker/GetFreeSwapSpaceSize.java > - jdk/test/jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java Rather than treat this as a backport, it seems to make more sense to ensure that all occurrences of 'THL A29' are removed from the code base for each release. As such, along with sanity checking the patch itself, I compared the list of files covered by the patch with those in the repository containing 'THL A29': ~~~ $ grep -r 'THL A29' * 2>&1 | tee /tmp/thl.8u $ diffstat -p0 /tmp/8364597.17u > /tmp/diffstat.8u $ for file in $(cut -d : -f 1 /tmp/thl.8u ); do if ! grep -q ${file} /tmp/diffstat.8u ; then echo "${file} missing"; fi; done ~~~ With this, I confirmed that this change covers all cases. The list was actually so short for this one, that it was clear from observation as well. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/689#pullrequestreview-3186257457 From serb at openjdk.org Thu Sep 4 17:42:00 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 4 Sep 2025 17:42:00 GMT Subject: [jdk8u-dev] RFR: 8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior Message-ID: Hi all, This pull request contains a backport of commit [4abb5e4a](https://github.com/openjdk/jdk/commit/4abb5e4aafe05871a07d510f002a38298fe4dbb2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alex Henrie on 23 Jun 2016 and was reviewed by Kim Barrett and Max Ockner. Thanks! ------------- Commit messages: - Backport 4abb5e4aafe05871a07d510f002a38298fe4dbb2 Changes: https://git.openjdk.org/jdk8u-dev/pull/682/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=682&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8157758 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/682.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/682/head:pull/682 PR: https://git.openjdk.org/jdk8u-dev/pull/682 From andrew at openjdk.org Thu Sep 4 21:44:15 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 4 Sep 2025 21:44:15 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v6] In-Reply-To: References: Message-ID: On Tue, 2 Sep 2025 09:16:32 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision: > > - Merge branch 'openjdk:master' into 8154043 > - Merge branch 'master' into 8154043 > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f > - Fix the copyright years > - Merge branch 'openjdk:master' into 8154043 > - Chmod ButtonGroupLayoutTraversalTest > - Chmod DefaultButtonModelCrashTest > - Fix the copyright year > - Backport f3abf05b31893b9a066a436e2c4a587f8899ab10 > - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/71fe4a29...df933477 Good to go. Please apply for approval. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/285#pullrequestreview-3187333120 From andrew at openjdk.org Thu Sep 4 21:44:29 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 4 Sep 2025 21:44:29 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: References: Message-ID: <4QBeXvV3hhaKzayUcmL9yf4uwDrGfjSx0CbkfiBHk7g=.01b09ef3-c018-46e6-8901-11172bcb92ec@github.com> On Thu, 13 Feb 2025 23:12:54 GMT, Andrew John Hughes wrote: >> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix the copyright years > > The associated CSR [JDK-8182695](https://bugs.openjdk.org/browse/JDK-8182695) is for adding the `getModel()` method in [JDK-8182577](https://bugs.openjdk.org/browse/JDK-8182577) but this patch does not add that method (and should not). It is just bringing over the test case and some minor code fixes. > @gnu-andrew This issue is impacting several users' applications. In conjunction with the related backport of 8074883, I would appreciate it if this could be integrated until the October 2025 release. We understand you are busy, but would you be able to review this? Sorry, I thought this had been abandoned. I'm having a look again now, but have to reacquaint myself with it again. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3255799933 From andrew at openjdk.org Thu Sep 4 21:44:36 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 4 Sep 2025 21:44:36 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: <1zEG61X9kwvXkm75J_ZTz-aOSRdrE9FwEhSDacyiICE=.0d97fea5-08f3-4572-9c96-7f33a7e07997@github.com> References: <1zEG61X9kwvXkm75J_ZTz-aOSRdrE9FwEhSDacyiICE=.0d97fea5-08f3-4572-9c96-7f33a7e07997@github.com> Message-ID: <5mHP7qNy4caccu5ggKtfjUhlhTh19TAk2Ef1jRKXum4=.3b418171-1aca-403e-965d-80aa7c7de0df@github.com> On Fri, 6 Jun 2025 07:02:21 GMT, Kazuhisa Takakuri wrote: > > we should also include the correction to the indentation of group.getElements() and presumably the instanceof test? > > Thanks for pointing that out. I've corrected the indentations. What does "the instanceof test" mean? I think I just meant this in the 8182577 11u patch: ~~~ - if (member.isVisible() && member.isDisplayable() && - member.isEnabled() && member.isFocusable()) { + if (member instanceof JToggleButton && + member.isVisible() && member.isDisplayable() && + member.isEnabled() && member.isFocusable()) { ~~~ Of course, it doesn't have the `instanceof` test in the 8u version, so sorry for the confusion. Anyway, I compared the 11u version of `LayoutFocusTraversalPolicy.java` with your current patched 8u version and it looks good, so you may have just sorted this one out from the start. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3255823238 From andrew at openjdk.org Thu Sep 4 21:44:42 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 4 Sep 2025 21:44:42 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v4] In-Reply-To: References: Message-ID: On Fri, 22 Aug 2025 21:13:28 GMT, Paul Hohensee wrote: > In bug8033699.java, line 2, leave the end copyright date at 2019. Other than that, lgtm. > > Also, please enable GHA on this repo. Good catch. 8226892 was already backported with a later copyright date on this file. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3255826326 From serb at openjdk.org Fri Sep 5 03:37:48 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 5 Sep 2025 03:37:48 GMT Subject: [jdk8u-dev] RFR: 8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [4abb5e4a](https://github.com/openjdk/jdk/commit/4abb5e4aafe05871a07d510f002a38298fe4dbb2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alex Henrie on 23 Jun 2016 and was reviewed by Kim Barrett and Max Ockner. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master - Backport 4abb5e4aafe05871a07d510f002a38298fe4dbb2 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/682/files - new: https://git.openjdk.org/jdk8u-dev/pull/682/files/a4ea7dfb..ba79b13c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=682&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=682&range=00-01 Stats: 1943 lines in 103 files changed: 473 ins; 1087 del; 383 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/682.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/682/head:pull/682 PR: https://git.openjdk.org/jdk8u-dev/pull/682 From ktakakuri at openjdk.org Fri Sep 5 15:02:28 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 5 Sep 2025 15:02:28 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v4] In-Reply-To: References: Message-ID: On Thu, 4 Sep 2025 21:39:04 GMT, Andrew John Hughes wrote: >> In bug8033699.java, line 2, leave the end copyright date at 2019. Other than that, lgtm. >> >> Also, please enable GHA on this repo. > >> In bug8033699.java, line 2, leave the end copyright date at 2019. Other than that, lgtm. >> >> Also, please enable GHA on this repo. > > Good catch. 8226892 was already backported with a later copyright date on this file. @gnu-andrew Thank you for your review. I'm planning to reopen and work on https://github.com/openjdk/jdk8u-dev/pull/212 related to this PR soon, so I'd appreciate it if you could review that as well when the time comes. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3258662383 From ktakakuri at openjdk.org Fri Sep 5 15:15:23 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 5 Sep 2025 15:15:23 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v4] In-Reply-To: References: Message-ID: On Thu, 4 Sep 2025 21:39:04 GMT, Andrew John Hughes wrote: >> In bug8033699.java, line 2, leave the end copyright date at 2019. Other than that, lgtm. >> >> Also, please enable GHA on this repo. > >> In bug8033699.java, line 2, leave the end copyright date at 2019. Other than that, lgtm. >> >> Also, please enable GHA on this repo. > > Good catch. 8226892 was already backported with a later copyright date on this file. @gnu-andrew JDK-8154043 has already been labeled with jdk8u-fix-no, and I can't submit the request again. I want to resubmit it. How should I proceed? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3258715994 From jkratochvil at openjdk.org Sat Sep 6 20:16:53 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sat, 6 Sep 2025 20:16:53 GMT Subject: [jdk8u-dev] RFR: 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag Message-ID: <9OU59-FHZ2M70rEbLCoTEySTkJO7Js9yIF8f_UuGNlo=.344b0a1f-836b-433b-9d4e-b56bad4b5f23@github.com> It is needed in jdk8 as a prerequisite for JDK-6986863. A testcase is included. It is not a clean backport - source files are moved, include files angle vs. quote change, copyright years update. This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. ------------- Commit messages: - 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag Changes: https://git.openjdk.org/jdk8u-dev/pull/690/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=690&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8263622 Stats: 133 lines in 2 files changed: 88 ins; 35 del; 10 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/690.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/690/head:pull/690 PR: https://git.openjdk.org/jdk8u-dev/pull/690 From jkratochvil at openjdk.org Sat Sep 6 20:29:52 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sat, 6 Sep 2025 20:29:52 GMT Subject: [jdk8u-dev] RFR: 6986863: ProfileDeferralMgr throwing ConcurrentModificationException Message-ID: It is needed in jdk8 as a prerequisite for JDK-8347377. A testcase is included. It is not a clean backport - source files are moved, copyright years update, original patch uses extra function getStandardProfileInputStream(), Anton Voznia hasn't implemented it by himself, he borrowed it from another patch https://bugs.openjdk.org/browse/JDK-8039271 and changed it a bit according to the requirements. He didn't include entire fix because it's redundant. This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. It requires https://github.com/openjdk/jdk8u-dev/pull/690 as a prerequisite. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/690 Commit messages: - 6986863: ProfileDeferralMgr throwing ConcurrentModificationException Changes: https://git.openjdk.org/jdk8u-dev/pull/691/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=691&range=00 Issue: https://bugs.openjdk.org/browse/JDK-6986863 Stats: 387 lines in 7 files changed: 204 ins; 115 del; 68 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/691.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/691/head:pull/691 PR: https://git.openjdk.org/jdk8u-dev/pull/691 From jkratochvil at openjdk.org Sat Sep 6 20:37:00 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sat, 6 Sep 2025 20:37:00 GMT Subject: [jdk8u-dev] RFR: 8347377: Add validation checks for ICC_Profile header fields Message-ID: ICC_Profile header is validated too late leading later to unexpected exceptions. A testcase is included. It is not a clean backport - it has to change return switch expressions to their old format, also source files are moved, copyright years updated. This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. It requires https://github.com/openjdk/jdk8u-dev/pull/691 as a prerequisite. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/691 Commit messages: - 8347377: Add validation checks for ICC_Profile header fields Changes: https://git.openjdk.org/jdk8u-dev/pull/692/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=692&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347377 Stats: 347 lines in 4 files changed: 336 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/692.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/692/head:pull/692 PR: https://git.openjdk.org/jdk8u-dev/pull/692 From jkratochvil at openjdk.org Sat Sep 6 20:44:04 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sat, 6 Sep 2025 20:44:04 GMT Subject: [jdk8u-dev] RFR: 8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles Message-ID: Built-in singleton ICC_Profiles could be modified using setData(). Throw an exception for such an attempt. A testcase is included. It is not a clean backport - it has to change return switch expressions to their old format and there are also other 2 minor conflicts. This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. It requires https://github.com/openjdk/jdk8u-dev/pull/692 as a prerequisite. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/692 Commit messages: - 8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles Changes: https://git.openjdk.org/jdk8u-dev/pull/693/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=693&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346465 Stats: 271 lines in 7 files changed: 257 ins; 1 del; 13 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/693.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/693/head:pull/693 PR: https://git.openjdk.org/jdk8u-dev/pull/693 From andrew at openjdk.org Sun Sep 7 14:58:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 7 Sep 2025 14:58:19 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties In-Reply-To: References: Message-ID: On Mon, 25 Aug 2025 17:10:32 GMT, Alexey Bakhtin wrote: >> keep open > >> LGTM. @mrserb Could you please confirm before ramp down phase on August 29? > > @mrserb could you please approve the review? Without it, I can not make a fix request. Thank you @alexeybakhtin this is just waiting for an approval request. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-3263831240 From andrew at openjdk.org Sun Sep 7 15:05:20 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 7 Sep 2025 15:05:20 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v4] In-Reply-To: References: Message-ID: <1M2JGbEUiySp4wo0UrlEWVCIY1YVzRbm3qptP4FHwcg=.9bca9004-dd6f-41aa-82a6-869e10edf6eb@github.com> On Thu, 4 Sep 2025 21:39:04 GMT, Andrew John Hughes wrote: >> In bug8033699.java, line 2, leave the end copyright date at 2019. Other than that, lgtm. >> >> Also, please enable GHA on this repo. > >> In bug8033699.java, line 2, leave the end copyright date at 2019. Other than that, lgtm. >> >> Also, please enable GHA on this repo. > > Good catch. 8226892 was already backported with a later copyright date on this file. > @gnu-andrew JDK-8154043 has already been labeled with jdk8u-fix-no, and I can't submit the request again. I want to resubmit it. How should I proceed? I've approved manually on the bugs. This should be good to go. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3263835116 From serb at openjdk.org Sun Sep 7 23:28:12 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 7 Sep 2025 23:28:12 GMT Subject: [jdk8u-dev] RFR: 8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior [v2] In-Reply-To: References: Message-ID: On Fri, 5 Sep 2025 03:37:48 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [4abb5e4a](https://github.com/openjdk/jdk/commit/4abb5e4aafe05871a07d510f002a38298fe4dbb2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alex Henrie on 23 Jun 2016 and was reviewed by Kim Barrett and Max Ockner. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master > - Backport 4abb5e4aafe05871a07d510f002a38298fe4dbb2 The issue is similar to https://github.com/openjdk/jdk11u-dev/pull/3042 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/682#issuecomment-3264145860 From duke at openjdk.org Mon Sep 8 04:51:21 2025 From: duke at openjdk.org (Min Choi) Date: Mon, 8 Sep 2025 04:51:21 GMT Subject: [jdk8u-dev] RFR: 8345149: javax/sound/midi/Soundbanks/GetSoundBankSecurityException/GetSoundBankSecurityException.java failes with FileSystemException Message-ID: <4c3EWMImHibADVPzaAf7AItE4-rIVPHozAx9AvZLQkI=.860400ce-6565-41fe-9beb-add6835fbaa6@github.com> Added javax/sound/midi/Soundbanks/GetSoundBankSecurityException/GetSoundBankSecurityException.java to ProblemList.txt to exclude on Windows Machines. ------------- Commit messages: - Fix Root Cause (8178401) for JDK-8345149 - Add GetSoundBankSecurityException.java to ProblemList.txt (JDK-8345149) Changes: https://git.openjdk.org/jdk8u-dev/pull/613/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=613&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345149 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/613.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/613/head:pull/613 PR: https://git.openjdk.org/jdk8u-dev/pull/613 From ktakakuri at openjdk.org Mon Sep 8 07:30:22 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 8 Sep 2025 07:30:22 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v4] In-Reply-To: <1M2JGbEUiySp4wo0UrlEWVCIY1YVzRbm3qptP4FHwcg=.9bca9004-dd6f-41aa-82a6-869e10edf6eb@github.com> References: <1M2JGbEUiySp4wo0UrlEWVCIY1YVzRbm3qptP4FHwcg=.9bca9004-dd6f-41aa-82a6-869e10edf6eb@github.com> Message-ID: On Sun, 7 Sep 2025 15:02:24 GMT, Andrew John Hughes wrote: >>> In bug8033699.java, line 2, leave the end copyright date at 2019. Other than that, lgtm. >>> >>> Also, please enable GHA on this repo. >> >> Good catch. 8226892 was already backported with a later copyright date on this file. > >> @gnu-andrew JDK-8154043 has already been labeled with jdk8u-fix-no, and I can't submit the request again. I want to resubmit it. How should I proceed? > > I've approved manually on the bugs. This should be good to go. @gnu-andrew Thank you for your prompt support. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3264957690 From ktakakuri at openjdk.org Mon Sep 8 07:30:23 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 8 Sep 2025 07:30:23 GMT Subject: [jdk8u-dev] Integrated: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 05:47:54 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. > > Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. > The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. > So, I propose to judge the buttonModel is an instance of DefaultButtonModel. > > Testing: > java/awt > javax/swing > ButtonGroupLayoutTraversalTest.java > bug8033699.java > DefaultButtonModelCrashTest.java > on Windows x86_64 This pull request has now been integrated. Changeset: 86ecd5bb Author: Kazuhisa Takakuri URL: https://git.openjdk.org/jdk8u-dev/commit/86ecd5bb248026cc056f21c7368e5b322a244d44 Stats: 304 lines in 5 files changed: 270 ins; 15 del; 19 mod 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. 8182577: Exception when Tab key moves focus to a JCheckbox with a custom ButtonModel Reviewed-by: phh, andrew Backport-of: 8d81ec63b2bafc431cbb8572a3e45e76580ab46f ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/285