[jdk8u-dev] RFR: 8364597: Replace THL A29 Limited with Tencent
Andrew John Hughes
andrew at openjdk.org
Thu Sep 4 17:09:46 UTC 2025
On Wed, 3 Sep 2025 15:35:39 GMT, John Jiang <jjiang at openjdk.org> wrote:
> Please review this backport of `JDK-8364597: Replace THL A29 Limited with Tencent`.
> This backport is not clean, because most files don't exist in jdk8u,
> and the copyright years in the following files are different between the repos.
> - jdk/test/jdk/internal/platform/docker/GetFreeSwapSpaceSize.java
> - jdk/test/jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java
Rather than treat this as a backport, it seems to make more sense to ensure that all occurrences of 'THL A29' are removed from the code base for each release.
As such, along with sanity checking the patch itself, I compared the list of files covered by the patch with those in the repository containing 'THL A29':
~~~
$ grep -r 'THL A29' * 2>&1 | tee /tmp/thl.8u
$ diffstat -p0 /tmp/8364597.17u > /tmp/diffstat.8u
$ for file in $(cut -d : -f 1 /tmp/thl.8u ); do if ! grep -q ${file} /tmp/diffstat.8u ; then echo "${file} missing"; fi; done
~~~
With this, I confirmed that this change covers all cases. The list was actually so short for this one, that it was clear from observation as well.
-------------
Marked as reviewed by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk8u-dev/pull/689#pullrequestreview-3186257457
More information about the jdk8u-dev
mailing list