[jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3]

[Andrew John Hughes]

On Fri, 6 Jun 2025 07:02:21 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> > we should also include the correction to the indentation of group.getElements() and presumably the instanceof test?
> 
> Thanks for pointing that out. I've corrected the indentations. What does "the instanceof test" mean? 

I think I just meant this in the 8182577 11u patch:
~~~
-                            if (member.isVisible() && member.isDisplayable() &&
-                                   member.isEnabled() && member.isFocusable()) {
+                            if (member instanceof JToggleButton &&
+                                 member.isVisible() && member.isDisplayable() &&
+                                 member.isEnabled() && member.isFocusable()) {
~~~
Of course, it doesn't have the `instanceof` test in the 8u version, so sorry for the confusion. Anyway, I compared the 11u version of `LayoutFocusTraversalPolicy.java` with your current patched 8u version and it looks good, so you may have just sorted this one out from the start.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3255823238