[jdk8u-dev] RFR: 8170464: Remove shell script from compiler/c2/cr7005594/Test7005594.java [v3]
Severin Gehwolf
sgehwolf at openjdk.org
Wed Feb 4 17:13:56 UTC 2026
On Tue, 3 Feb 2026 20:50:56 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:
>> This backport converts `Test7005594.java` to be pure Java rather than a mix of Java and shell, which is currently causing test failures.
>>
>> The patch is not clean due to a couple of moves and minor changes now made redundant by the removal of the script. The final Java test file matches that in 11u.
>>
>> 1. File move from [8062854](https://bugs.openjdk.org/browse/JDK-8062854): "move compiler jtreg test to corresponding subfolders and use those in TEST.groups"
>> 2. File move from [8132919](https://bugs.openjdk.org/browse/JDK-8132919): "Put compiler tests in packages"
>> 3. File move from [8187443](https://bugs.openjdk.org/browse/JDK-8187443): "Forest Consolidation: Move files to unified layout"
>> 4. Changes to how Java was invoked in the script in [8135068](https://bugs.openjdk.org/browse/JDK-8135068): "Extract method matchers from CompilerOracle"
>> 5. Changes to how memory was calculated in the script in [8376338](https://bugs.openjdk.org/browse/JDK-8376338): "Test7005594.sh fails when given a memory value with decimals"
>>
>> Created on top of pr/742 to get a Mac run
>
> Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>
> - Merge remote-tracking branch 'dev/master' into JDK-8170464
> - Backport d652c70de6425a67907e00e75521588ec4a2e940
> - Merge remote-tracking branch 'dev/master' into JDK-8374948
> - Revert LOG_LEVEL=debug additions
> - 8374948: [8u] saproc & jsig builds add duplicate linker flags on Darwin/MacOS
> - Backport 1b0f612e5e08cfa1581cf22433b36b5f075c0f23
> - Print spec files on all POSIX platforms
> - Add LOG_LEVEL=debug to all GHA builds
> - Whitespace cleanup
> - 8374899: [8u] Fully handle clang as the toolchain in flags.m4
This looks OK. Thanks!
GHA issues are infra related.
-------------
Marked as reviewed by sgehwolf (Reviewer).
PR Review: https://git.openjdk.org/jdk8u-dev/pull/755#pullrequestreview-3752270602
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/755#issuecomment-3848689448
More information about the jdk8u-dev
mailing list