[jdk8u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources [v3]

[Andrew John Hughes]

On Fri, 26 Dec 2025 11:12:17 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Backport of [JDK-8274893](https://bugs.openjdk.org/browse/JDK-8274893) for parity with Oracle's JDK 8u461.
>> 
>> Resolved conflicts:
>> - `jdk/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java`
>>   - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant
>>   - Missing JDK-8041679: `StringBuffer` is used instead of `StringBuilder`
>> - `jdk/src/share/classes/javax/swing/text/html/HTMLEditorKit.java`
>>   - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant
>> - `jdk/src/share/classes/com/sun/media/sound/StandardMidiFileWriter.java`
>>   - Missing JDK-8143909: no `Objects.requireNonNull(...)` in this version
>> - `jdk/src/solaris/classes/sun/awt/motif/MFontConfiguration.java`
>>   - Missing JDK-8054834: imports from `sun.font` package are still needed in this file
>> - `jdk/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java`
>>   - Missing JDK-8080835: use `IOUtils.readAllBytes(InputStream is)` instead of the missing `InputStream.readAllBytes()`
>> - Missing JDK-7196163: try-with-resources cannot be used with pre-existing variables — fell back to try-finally in such cases
>> 
>> Testing: GitHub CI, `jdk_imageio` test group locally (headless linux/arm64)
>
> Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8274893: Update java.desktop classes to use try-with-resources
>   
>   Backport-of: 70c6df6be431fe11c5441986ed04040f9ec3b750

Mostly looks good to me.  Just a few comments:

* For the case in `com.sun.media.sound.JARSoundbankReader.java`, only a `null` check is outside the `try` block.  Could that not be moved inside and the block converted to try-with-resources?
* For the `is` case in `com.sun.media.sound.SoftSynthesizer.java`, could we not move the `is` declaration into a try-with-resources block?  The only use outside the`try` is a `null` check.

The other cases I think we are stuck with try-finally blocks.

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/686#pullrequestreview-3763372212