[jdk8u-dev] RFR: 8274893: Update java.desktop classes to use try-with-resources [v4]

Timofei Pushkin tpushkin at openjdk.org
Mon Feb 9 21:47:38 UTC 2026


> Backport of [JDK-8274893](https://bugs.openjdk.org/browse/JDK-8274893) for parity with Oracle's JDK 8u461.
> 
> Resolved conflicts:
> - `jdk/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java`
>   - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant
>   - Missing JDK-8041679: `StringBuffer` is used instead of `StringBuilder`
> - `jdk/src/share/classes/javax/swing/text/html/HTMLEditorKit.java`
>   - Missing JDK-8271456: `"ISO-8859-1"` string is used instead of `ISO_8859_1` enum constant
> - `jdk/src/share/classes/com/sun/media/sound/StandardMidiFileWriter.java`
>   - Missing JDK-8143909: no `Objects.requireNonNull(...)` in this version
> - `jdk/src/solaris/classes/sun/awt/motif/MFontConfiguration.java`
>   - Missing JDK-8054834: imports from `sun.font` package are still needed in this file
> - `jdk/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java`
>   - Missing JDK-8080835: use `IOUtils.readAllBytes(InputStream is)` instead of the missing `InputStream.readAllBytes()`
> - Missing JDK-7196163: try-with-resources cannot be used with pre-existing variables — fell back to try-finally in such cases
> 
> Testing: GitHub CI, `jdk_imageio` test group locally (headless linux/arm64)

Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge remote-tracking branch 'openjdk-jdk8/master' into 8274893-jdk8
 - Use try-with-resources in more cases
 - 8274893: Update java.desktop classes to use try-with-resources
   
   Backport-of: 70c6df6be431fe11c5441986ed04040f9ec3b750

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/686/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/686/files/fd9a0235..bdb9a1e0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=686&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=686&range=02-03

  Stats: 8858 lines in 177 files changed: 4452 ins; 2837 del; 1569 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/686.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/686/head:pull/686

PR: https://git.openjdk.org/jdk8u-dev/pull/686


More information about the jdk8u-dev mailing list