[jdk8u-dev] RFR: 8361748: Enforce limits on the size of an XBM image

[Andrew John Hughes]

On Fri, 20 Feb 2026 19:52:47 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> > It would have been preferable to propose these as separate pull requests, both for ease of reviewing, and to maintain a 1:1 relationship in the historical record. Also, the necessary changes for 8u should have been documented in the pull request itself, rather than just the commit. I only found them after checking out the repository in order to obtain the individual commits.
> 
> OK, I will do it that way next time. Paradoxically, I was trying to make it easier to review, because if I made the intermediary adjustments for 8u in the first backport PR, the second backport would not have applied clean.

I guess it depends how one reviews a patch.  In cases where it is 1:1, I download the diff from the PR page and compare it with the one in the later JDK. With this one, I instead had to check out the repository and compare the two backport commits, then the adjustment one.  That's why I put it to one side when I first saw it, because I knew it would take more time to do.

My bigger concern is that things get squashed when committed.  It's actually quite a nice way to break it up on the PR, but once it's committed, all that will be lost and the two changes mixed together.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/757#issuecomment-3941189715