From zzambers at openjdk.org Mon Jan 5 15:32:51 2026 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 5 Jan 2026 15:32:51 GMT Subject: [jdk8u-dev] Withdrawn: 8348598: Update Libpng to 1.6.47 In-Reply-To: <_5O8_UnqnA8NwIe60eGO4D9OijXncd1bQZSQuDzSnow=.2e8f3144-855e-43fd-ad64-a75fcf52b283@github.com> References: <_5O8_UnqnA8NwIe60eGO4D9OijXncd1bQZSQuDzSnow=.2e8f3144-855e-43fd-ad64-a75fcf52b283@github.com> Message-ID: On Tue, 2 Dec 2025 13:39:22 GMT, Zdenek Zambersky wrote: > This backport updates bundled libpng to 1.6.47. > There are some differences to jdk11: > - there is no `libpng.md` in JDK 8, equivalent changes were done to `THIRD_PARTY_README` > - changes to `UPDATING.txt` were excluded (this file is not present in 8) > - changes to `/lib/Awt2dLibraries.gmk` were excluded, as build system of jdk 8 is different and there is no support for `DISABLED_WARNINGS_*` there > > Otherwise, when it comes to library source files (libpng dir), changes applied cleanly (although they have different path). > I have also tried to use diff to compare contents of libpng directory (after update to 1.6.47) in jdk 8 and jdk 11, there are same, except for `UPDATING.txt`, which is only present in jdk 11. > > **Motivation:** > - to fix one build error on macos-15 (it no longer ships with `fp.h`) > > In file included from /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/sun/awt/libpng/png.c:42: > /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/sun/awt/libpng/pngpriv.h:552:16: fatal error: 'fp.h' file not found > 552 | # include > | ^~~~~~ > 1 error generated. > gmake[2]: *** [lib/Awt2dLibraries.gmk:1256: /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/macos-x64/jdk/objs/libsplashscreen/png.o] Error 1 > > - to prepare for [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534) (update to 1.6.51) in the future > > Testing: > - testing in GHA: **OK** (failures of `TestCPUAwareness.java` are [unrelated](https://github.com/openjdk/jdk8u-dev/pull/727)) > - manually tested `jdk/test/java/awt/SplashScreen` (rhel-8 VM / tigervnc): **OK** This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/729 From zzambers at openjdk.org Mon Jan 5 15:32:50 2026 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 5 Jan 2026 15:32:50 GMT Subject: [jdk8u-dev] RFR: 8348598: Update Libpng to 1.6.47 In-Reply-To: <_5O8_UnqnA8NwIe60eGO4D9OijXncd1bQZSQuDzSnow=.2e8f3144-855e-43fd-ad64-a75fcf52b283@github.com> References: <_5O8_UnqnA8NwIe60eGO4D9OijXncd1bQZSQuDzSnow=.2e8f3144-855e-43fd-ad64-a75fcf52b283@github.com> Message-ID: On Tue, 2 Dec 2025 13:39:22 GMT, Zdenek Zambersky wrote: > This backport updates bundled libpng to 1.6.47. > There are some differences to jdk11: > - there is no `libpng.md` in JDK 8, equivalent changes were done to `THIRD_PARTY_README` > - changes to `UPDATING.txt` were excluded (this file is not present in 8) > - changes to `/lib/Awt2dLibraries.gmk` were excluded, as build system of jdk 8 is different and there is no support for `DISABLED_WARNINGS_*` there > > Otherwise, when it comes to library source files (libpng dir), changes applied cleanly (although they have different path). > I have also tried to use diff to compare contents of libpng directory (after update to 1.6.47) in jdk 8 and jdk 11, there are same, except for `UPDATING.txt`, which is only present in jdk 11. > > **Motivation:** > - to fix one build error on macos-15 (it no longer ships with `fp.h`) > > In file included from /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/sun/awt/libpng/png.c:42: > /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/sun/awt/libpng/pngpriv.h:552:16: fatal error: 'fp.h' file not found > 552 | # include > | ^~~~~~ > 1 error generated. > gmake[2]: *** [lib/Awt2dLibraries.gmk:1256: /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/macos-x64/jdk/objs/libsplashscreen/png.o] Error 1 > > - to prepare for [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534) (update to 1.6.51) in the future > > Testing: > - testing in GHA: **OK** (failures of `TestCPUAwareness.java` are [unrelated](https://github.com/openjdk/jdk8u-dev/pull/727)) > - manually tested `jdk/test/java/awt/SplashScreen` (rhel-8 VM / tigervnc): **OK** This PR now seems obsolete in favor of jdk8u PR by @gnu-andrew: https://github.com/openjdk/jdk8u/pull/83 (which updates libpng up to 1.6.51) Closing. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/729#issuecomment-3710906274 From abakhtin at openjdk.org Tue Jan 6 03:14:00 2026 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 6 Jan 2026 03:14:00 GMT Subject: [jdk8u] RFR: 8372534: Update Libpng to 1.6.51 In-Reply-To: References: Message-ID: On Sat, 27 Dec 2025 18:26:18 GMT, Andrew John Hughes wrote: > Update to the latest version of libpng. Change includes both the backport of the latest libpng change, [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534), and previous updates not present in 8u ([JDK-8316030](https://bugs.openjdk.org/browse/JDK-8316030) - 1.6.40, [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004) - 1.6.43, [JDK-8348598](https://bugs.openjdk.org/browse/JDK-8348598) - 1.6.47). The change built fine with GCC 8 on RHEL 8 and `java/awt/SplashScreen` tests passed. > > I also included `UPDATING.txt` introduced in [JDK-8208353](https://bugs.openjdk.org/browse/JDK-8208353) in 11u, but not 8u, and updated in [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685) as part of the JDK-8329004 backport which updates it. > > I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata. Marked as reviewed by abakhtin (Committer). Thank you for the backport. I'm not a reviewer, but it looks good to me. I do not see any regressions. ------------- PR Review: https://git.openjdk.org/jdk8u/pull/83#pullrequestreview-3629185572 PR Comment: https://git.openjdk.org/jdk8u/pull/83#issuecomment-3712934159 From andrew at openjdk.org Tue Jan 6 22:18:02 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 6 Jan 2026 22:18:02 GMT Subject: [jdk8u] RFR: 8372534: Update Libpng to 1.6.51 In-Reply-To: References: Message-ID: <1xZBYdZ08qS6JT3XGZkOQ2PJSvmbL7OnAGGPInehSeY=.81efc9d3-4fbe-44a0-9bde-4d607ae598dc@github.com> On Tue, 6 Jan 2026 03:08:57 GMT, Alexey Bakhtin wrote: > Thank you for the backport. I'm not a reviewer, but it looks good to me. I do not see any regressions. Thanks Alexey. I'll have to move this over to 8u-dev now as we are post-freeze, but still plan to include this in the January release in sync with the later JDK releases. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/83#issuecomment-3716561259 From serb at openjdk.org Wed Jan 7 02:24:50 2026 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 7 Jan 2026 02:24:50 GMT Subject: [jdk8u] RFR: 8372534: Update Libpng to 1.6.51 In-Reply-To: References: Message-ID: On Sat, 27 Dec 2025 18:26:18 GMT, Andrew John Hughes wrote: > Update to the latest version of libpng. Change includes both the backport of the latest libpng change, [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534), and previous updates not present in 8u ([JDK-8316030](https://bugs.openjdk.org/browse/JDK-8316030) - 1.6.40, [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004) - 1.6.43, [JDK-8348598](https://bugs.openjdk.org/browse/JDK-8348598) - 1.6.47). The change built fine with GCC 8 on RHEL 8 and `java/awt/SplashScreen` tests passed. > > I also included `UPDATING.txt` introduced in [JDK-8208353](https://bugs.openjdk.org/browse/JDK-8208353) in 11u, but not 8u, and updated in [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685) as part of the JDK-8329004 backport which updates it. > > I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u/pull/83#pullrequestreview-3633131099 From sgehwolf at openjdk.org Wed Jan 7 10:19:16 2026 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 7 Jan 2026 10:19:16 GMT Subject: [jdk8u-dev] RFR: 8284758: [linux] improve print_container_info In-Reply-To: References: <7KHPPrp_04m38_FLqfv2s2IgVr_DN4DvUxFUonkNXGU=.0e22ac8c-4d3c-4f93-a227-5c2eff93c077@github.com> Message-ID: On Fri, 19 Dec 2025 09:07:26 GMT, Jonathan Dowland wrote: >> Low-risk, for Oracle parity. Mostly a clean-up. This will ease the future backporting of [JDK-8287011]. >> >> Doesn't apply clean: needs adjusting for paths and also context, to reflect 8u's lack of the pid controller ([JDK-8266490]). >> >> [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8287011 (forthcoming) >> [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8266490 (not considered) > > still seeking a review. Thanks! @jmtd Before this one is being merged, please merge latest master once the depending PR is integrated. This should also update the GHA runs. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/724#issuecomment-3718186504 From andrew at openjdk.org Wed Jan 7 17:11:59 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 7 Jan 2026 17:11:59 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v6] In-Reply-To: References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: On Fri, 5 Dec 2025 16:48:16 GMT, Andrew John Hughes wrote: >> This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) >> >> 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. >> >> In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010. >> >> The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up. > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: > > - Merge remote-tracking branch 'dev/master' into JDK-8328999 > - Declare correct_saved_images at start of block > - Merge remote-tracking branch 'dev/master' into JDK-8328999 > - Merge remote-tracking branch 'dev/master' into JDK-8328999 > - Merge remote-tracking branch 'origin/master' into JDK-8328999 > - Merge remote-tracking branch 'dev/master' into JDK-8328999 > - Add missing #endif > - Restore local modifications on Windows to work around missing stdbool.h on VS2010 > - Merge remote-tracking branch 'dev/master' into JDK-8328999 > - Backport bc8aeb6496b7e86d1f616d4c1b7c26f172c1dd8a The two failing tests are exempted from current 8u-dev so another merge should fix this. I'll then finally get this flagged for approval. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/571#issuecomment-3719870963 From sgehwolf at openjdk.org Wed Jan 7 17:38:14 2026 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 7 Jan 2026 17:38:14 GMT Subject: [jdk8u] RFR: 8372534: Update Libpng to 1.6.51 In-Reply-To: References: Message-ID: On Sat, 27 Dec 2025 18:26:18 GMT, Andrew John Hughes wrote: > Update to the latest version of libpng. Change includes both the backport of the latest libpng change, [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534), and previous updates not present in 8u ([JDK-8316030](https://bugs.openjdk.org/browse/JDK-8316030) - 1.6.40, [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004) - 1.6.43, [JDK-8348598](https://bugs.openjdk.org/browse/JDK-8348598) - 1.6.47). The change built fine with GCC 8 on RHEL 8 and `java/awt/SplashScreen` tests passed. > > I also included `UPDATING.txt` introduced in [JDK-8208353](https://bugs.openjdk.org/browse/JDK-8208353) in 11u, but not 8u, and updated in [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685) as part of the JDK-8329004 backport which updates it. > > I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata. Quoting Sergey from https://github.com/openjdk/jdk8u-dev/pull/729: > Please confirm that the splashscreen tests works fine on macOS, Linux, and Windows. test/java/awt/SplashScreen/* ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/83#issuecomment-3719976808 From andrew at openjdk.org Thu Jan 8 00:13:16 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 8 Jan 2026 00:13:16 GMT Subject: [jdk8u] RFR: 8372534: Update Libpng to 1.6.51 In-Reply-To: References: Message-ID: On Sat, 27 Dec 2025 18:26:18 GMT, Andrew John Hughes wrote: > Update to the latest version of libpng. Change includes both the backport of the latest libpng change, [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534), and previous updates not present in 8u ([JDK-8316030](https://bugs.openjdk.org/browse/JDK-8316030) - 1.6.40, [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004) - 1.6.43, [JDK-8348598](https://bugs.openjdk.org/browse/JDK-8348598) - 1.6.47). The change built fine with GCC 8 on RHEL 8 and `java/awt/SplashScreen` tests passed. > > I also included `UPDATING.txt` introduced in [JDK-8208353](https://bugs.openjdk.org/browse/JDK-8208353) in 11u, but not 8u, and updated in [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685) as part of the JDK-8329004 backport which updates it. > > I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata. > Quoting Sergey from [openjdk/jdk8u-dev#729](https://github.com/openjdk/jdk8u-dev/pull/729): > > > Please confirm that the splashscreen tests works fine on macOS, Linux, and Windows. test/java/awt/SplashScreen/* As already stated in the PR header, "The change built fine with GCC 8 on RHEL 8 and java/awt/SplashScreen tests passed". ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/83#issuecomment-3721343222 From andrew at openjdk.org Thu Jan 8 00:36:53 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 8 Jan 2026 00:36:53 GMT Subject: [jdk8u-dev] RFR: 8348598: Update Libpng to 1.6.47 In-Reply-To: <_5O8_UnqnA8NwIe60eGO4D9OijXncd1bQZSQuDzSnow=.2e8f3144-855e-43fd-ad64-a75fcf52b283@github.com> References: <_5O8_UnqnA8NwIe60eGO4D9OijXncd1bQZSQuDzSnow=.2e8f3144-855e-43fd-ad64-a75fcf52b283@github.com> Message-ID: On Tue, 2 Dec 2025 13:39:22 GMT, Zdenek Zambersky wrote: > This backport updates bundled libpng to 1.6.47. > There are some differences to jdk11: > - there is no `libpng.md` in JDK 8, equivalent changes were done to `THIRD_PARTY_README` > - changes to `UPDATING.txt` were excluded (this file is not present in 8) > - changes to `/lib/Awt2dLibraries.gmk` were excluded, as build system of jdk 8 is different and there is no support for `DISABLED_WARNINGS_*` there > > Otherwise, when it comes to library source files (libpng dir), changes applied cleanly (although they have different path). > I have also tried to use diff to compare contents of libpng directory (after update to 1.6.47) in jdk 8 and jdk 11, there are same, except for `UPDATING.txt`, which is only present in jdk 11. > > **Motivation:** > - to fix one build error on macos-15 (it no longer ships with `fp.h`) > > In file included from /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/sun/awt/libpng/png.c:42: > /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/sun/awt/libpng/pngpriv.h:552:16: fatal error: 'fp.h' file not found > 552 | # include > | ^~~~~~ > 1 error generated. > gmake[2]: *** [lib/Awt2dLibraries.gmk:1256: /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/macos-x64/jdk/objs/libsplashscreen/png.o] Error 1 > > - to prepare for [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534) (update to 1.6.51) in the future > > Testing: > - testing in GHA: **OK** (failures of `TestCPUAwareness.java` are [unrelated](https://github.com/openjdk/jdk8u-dev/pull/727)) > - manually tested `jdk/test/java/awt/SplashScreen` (rhel-8 VM / tigervnc): **OK** > This PR now seems obsolete in favor of jdk8u PR by @gnu-andrew: [openjdk/jdk8u#83](https://github.com/openjdk/jdk8u/pull/83) (which updates libpng up to 1.6.51) Closing. Sorry, I didn't see this until now. I was backporting 8372534 all the way down from 26 and was surprised to find 8u was so far behind. I didn't check all the previous bugs for PRs but just backported the necessary changes. Any testing you can do of the 1.6.51 PR would be most welcome. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/729#issuecomment-3721395486 From sgehwolf at openjdk.org Thu Jan 8 10:02:53 2026 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 8 Jan 2026 10:02:53 GMT Subject: [jdk8u] RFR: 8372534: Update Libpng to 1.6.51 In-Reply-To: References: Message-ID: On Sat, 27 Dec 2025 18:26:18 GMT, Andrew John Hughes wrote: > Update to the latest version of libpng. Change includes both the backport of the latest libpng change, [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534), and previous updates not present in 8u ([JDK-8316030](https://bugs.openjdk.org/browse/JDK-8316030) - 1.6.40, [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004) - 1.6.43, [JDK-8348598](https://bugs.openjdk.org/browse/JDK-8348598) - 1.6.47). The change built fine with GCC 8 on RHEL 8 and `java/awt/SplashScreen` tests passed. > > I also included `UPDATING.txt` introduced in [JDK-8208353](https://bugs.openjdk.org/browse/JDK-8208353) in 11u, but not 8u, and updated in [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685) as part of the JDK-8329004 backport which updates it. > > I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata. OK, thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/83#issuecomment-3723111406 From sgehwolf at openjdk.org Thu Jan 8 10:46:42 2026 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 8 Jan 2026 10:46:42 GMT Subject: [jdk8u-dev] RFR: 8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior [v5] In-Reply-To: References: Message-ID: <8i-xrEx9OKosjwXF-FkKzxLD4Q-HO8xCmaE8wE0NTus=.38c11c87-3873-4b1c-97f1-b0bc8402a6ab@github.com> On Tue, 16 Dec 2025 01:07:50 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [4abb5e4a](https://github.com/openjdk/jdk/commit/4abb5e4aafe05871a07d510f002a38298fe4dbb2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alex Henrie on 23 Jun 2016 and was reviewed by Kim Barrett and Max Ockner. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master > - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master > - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master > - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master > - Backport 4abb5e4aafe05871a07d510f002a38298fe4dbb2 This one is needed to compile on newer MacOS X as well (and a stepping stone towards GHA on MacOSX using the MacOSX 15 runner). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/682#issuecomment-3723278133 From sgehwolf at openjdk.org Thu Jan 8 10:50:23 2026 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 8 Jan 2026 10:50:23 GMT Subject: [jdk8u-dev] RFR: 8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior [v5] In-Reply-To: References: Message-ID: On Tue, 16 Dec 2025 01:07:50 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [4abb5e4a](https://github.com/openjdk/jdk/commit/4abb5e4aafe05871a07d510f002a38298fe4dbb2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alex Henrie on 23 Jun 2016 and was reviewed by Kim Barrett and Max Ockner. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master > - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master > - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master > - Merge branch 'openjdk:master' into backport-mrserb-4abb5e4a-master > - Backport 4abb5e4aafe05871a07d510f002a38298fe4dbb2 Note that we don't have MacOSX GHA being run here as the old runners have been removed. Work is under way to re-instate those. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/682#issuecomment-3723288664 From jdowland at openjdk.org Thu Jan 8 13:00:03 2026 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 8 Jan 2026 13:00:03 GMT Subject: [jdk8u-dev] Integrated: 8220658: Improve the readability of container information in the error log In-Reply-To: References: Message-ID: On Thu, 20 Nov 2025 10:58:09 GMT, Jonathan Dowland wrote: > This ([8220658]) is a low-risk change which improves the readability of some debug values reported to humans. I wish to backport this to 8u partly for Oracle parity, and partly because I intend to backport [8284758], which refactors and moves most of the code introduced here to another routine. > > Doing 8220658 first will ease 8284758 (reduced merge conflicts). Not doing 8220658 (and later backporting 8284758) will result in some of this code making it into 8u (the refactored bits) but not all (the improved cpu quota etc reporting) > > Patch is not clean due to path differences but otherwise applied without conflicts or fuzz. Builds and smoke tests fine. I've had some trouble running tier1 locally (OOMed my workstation) so I'm going to watch for the GitHub bot results whilst I retry. > > [8220658]: https://bugs.openjdk.org/browse/JDK-8220658 > [8284758]: https://bugs.openjdk.org/browse/JDK-8284758 This pull request has now been integrated. Changeset: b7c215de Author: Jonathan Dowland URL: https://git.openjdk.org/jdk8u-dev/commit/b7c215de622d41cc5a3c092e48b09b38472224f6 Stats: 54 lines in 1 file changed: 41 ins; 0 del; 13 mod 8220658: Improve the readability of container information in the error log Reviewed-by: sgehwolf Backport-of: 684fe80e4c621852af5b89f7fd3f4e227eed9ebb ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/723 From jdowland at openjdk.org Thu Jan 8 13:09:29 2026 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 8 Jan 2026 13:09:29 GMT Subject: [jdk8u-dev] RFR: 8284758: [linux] improve print_container_info [v2] In-Reply-To: <7KHPPrp_04m38_FLqfv2s2IgVr_DN4DvUxFUonkNXGU=.0e22ac8c-4d3c-4f93-a227-5c2eff93c077@github.com> References: <7KHPPrp_04m38_FLqfv2s2IgVr_DN4DvUxFUonkNXGU=.0e22ac8c-4d3c-4f93-a227-5c2eff93c077@github.com> Message-ID: > Low-risk, for Oracle parity. Mostly a clean-up. This will ease the future backporting of [JDK-8287011]. > > Doesn't apply clean: needs adjusting for paths and also context, to reflect 8u's lack of the pid controller ([JDK-8266490]). > > [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8287011 (forthcoming) > [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8266490 (not considered) Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/724/files - new: https://git.openjdk.org/jdk8u-dev/pull/724/files/fdb4a87d..fdb4a87d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=724&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=724&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/724.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/724/head:pull/724 PR: https://git.openjdk.org/jdk8u-dev/pull/724 From jdowland at openjdk.org Thu Jan 8 14:58:25 2026 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 8 Jan 2026 14:58:25 GMT Subject: [jdk8u-dev] RFR: 8284758: [linux] improve print_container_info [v3] In-Reply-To: <7KHPPrp_04m38_FLqfv2s2IgVr_DN4DvUxFUonkNXGU=.0e22ac8c-4d3c-4f93-a227-5c2eff93c077@github.com> References: <7KHPPrp_04m38_FLqfv2s2IgVr_DN4DvUxFUonkNXGU=.0e22ac8c-4d3c-4f93-a227-5c2eff93c077@github.com> Message-ID: > Low-risk, for Oracle parity. Mostly a clean-up. This will ease the future backporting of [JDK-8287011]. > > Doesn't apply clean: needs adjusting for paths and also context, to reflect 8u's lack of the pid controller ([JDK-8266490]). > > [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8287011 (forthcoming) > [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8266490 (not considered) Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'remotes/jdk8u-dev/master' into 8284758-8u - 8284758: [linux] improve print_container_info Reviewed-by: sgehwolf Backport-of: 6c6d5223dfaae268f968f4292356d4be89adb122 - 8220658: Improve the readability of container information in the error log Backport-of: 2c4b9e0778e170a17b04217bee66bb6c4fb18c0c ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/724/files - new: https://git.openjdk.org/jdk8u-dev/pull/724/files/fdb4a87d..63eb95e0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=724&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=724&range=01-02 Stats: 65153 lines in 356 files changed: 21742 ins; 12776 del; 30635 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/724.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/724/head:pull/724 PR: https://git.openjdk.org/jdk8u-dev/pull/724 From serb at openjdk.org Thu Jan 8 18:27:11 2026 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 8 Jan 2026 18:27:11 GMT Subject: [jdk8u-dev] Integrated: 8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior In-Reply-To: References: Message-ID: On Mon, 25 Aug 2025 17:51:48 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [4abb5e4a](https://github.com/openjdk/jdk/commit/4abb5e4aafe05871a07d510f002a38298fe4dbb2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alex Henrie on 23 Jun 2016 and was reviewed by Kim Barrett and Max Ockner. > > Thanks! This pull request has now been integrated. Changeset: 5e3692f7 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/5e3692f7818b8d31a764beec1f3164dc30046c71 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior Replace shifts of -1 with shifts of ~0u. Backport-of: 4abb5e4aafe05871a07d510f002a38298fe4dbb2 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/682 From andrew at openjdk.org Thu Jan 8 21:57:56 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 8 Jan 2026 21:57:56 GMT Subject: [jdk8u] RFR: 8372534: Update Libpng to 1.6.51 In-Reply-To: References: Message-ID: <6niwTyFn-gfrXAzL_MW4gXnH1y1xV85HydTfZgTkMks=.518ae2fc-4255-47d9-8995-2583463ccca6@github.com> On Sat, 27 Dec 2025 18:26:18 GMT, Andrew John Hughes wrote: > Update to the latest version of libpng. Change includes both the backport of the latest libpng change, [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534), and previous updates not present in 8u ([JDK-8316030](https://bugs.openjdk.org/browse/JDK-8316030) - 1.6.40, [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004) - 1.6.43, [JDK-8348598](https://bugs.openjdk.org/browse/JDK-8348598) - 1.6.47). The change built fine with GCC 8 on RHEL 8 and `java/awt/SplashScreen` tests passed. > > I also included `UPDATING.txt` introduced in [JDK-8208353](https://bugs.openjdk.org/browse/JDK-8208353) in 11u, but not 8u, and updated in [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685) as part of the JDK-8329004 backport which updates it. > > I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/83#issuecomment-3725990707 From andrew at openjdk.org Thu Jan 8 21:57:57 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 8 Jan 2026 21:57:57 GMT Subject: [jdk8u] Integrated: 8372534: Update Libpng to 1.6.51 In-Reply-To: References: Message-ID: <1urEF2CUhqaY5xslP8M5sRHl6chM8F60lFx2xWSom20=.5271ae25-d402-4c0b-b701-57229559f6c9@github.com> On Sat, 27 Dec 2025 18:26:18 GMT, Andrew John Hughes wrote: > Update to the latest version of libpng. Change includes both the backport of the latest libpng change, [JDK-8372534](https://bugs.openjdk.org/browse/JDK-8372534), and previous updates not present in 8u ([JDK-8316030](https://bugs.openjdk.org/browse/JDK-8316030) - 1.6.40, [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004) - 1.6.43, [JDK-8348598](https://bugs.openjdk.org/browse/JDK-8348598) - 1.6.47). The change built fine with GCC 8 on RHEL 8 and `java/awt/SplashScreen` tests passed. > > I also included `UPDATING.txt` introduced in [JDK-8208353](https://bugs.openjdk.org/browse/JDK-8208353) in 11u, but not 8u, and updated in [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685) as part of the JDK-8329004 backport which updates it. > > I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata. This pull request has now been integrated. Changeset: 976d0a19 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u/commit/976d0a196ce036c40147535209b80143e021c2fe Stats: 6267 lines in 23 files changed: 2572 ins; 2571 del; 1124 mod 8372534: Update Libpng to 1.6.51 8316030: Update Libpng to 1.6.40 8329004: Update Libpng to 1.6.43 8348598: Update Libpng to 1.6.47 Reviewed-by: abakhtin, serb Backport-of: be7966c633830516c703f14610e4fef1bbe7f57d ------------- PR: https://git.openjdk.org/jdk8u/pull/83 From andrew at openjdk.org Fri Jan 9 01:50:31 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 9 Jan 2026 01:50:31 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Merge jdk8u482-b06 back into 8u-dev ------------- Commit messages: - Merge jdk8u:master - 8317970: Bump target macosx-x64 version to 11.00.00 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/739/files Stats: 68 lines in 3 files changed: 0 ins; 42 del; 26 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/739.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/739/head:pull/739 PR: https://git.openjdk.org/jdk8u-dev/pull/739 From andrew at openjdk.org Fri Jan 9 02:52:39 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 9 Jan 2026 02:52:39 GMT Subject: [jdk8u-dev] RFR: 8074840: Resolve disabled warnings for libjli and libjli_static In-Reply-To: References: Message-ID: On Mon, 8 Dec 2025 18:55:16 GMT, Zdenek Zambersky wrote: > Backport, which fixes compiler errors/warnings in libjli. > > **Motivation:** > - to fix compilation error (and some warnings) on macos-15 (clang): > > ... > 2025-11-19T17:50:19.3284070Z /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/bin/parse_manifest.c:680:12: note: use '==' to turn this assignment into an equality comparison > 2025-11-19T17:50:19.3285850Z 680 | if (rc = find_file(fd, &entry, manifest_name) != 0) { > 2025-11-19T17:50:19.3286370Z | ^ > 2025-11-19T17:50:19.3287050Z | == > 2025-11-19T17:50:19.3287530Z 4 warnings generated. > 2025-11-19T17:50:19.3289930Z /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/bin/splashscreen_stubs.c:64:30: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion] > 2025-11-19T17:50:19.3291940Z 64 | INVOKE(SplashLoadMemory, NULL)(pdata, size); > 2025-11-19T17:50:19.3292900Z | ^~~~ > ... > > > **Differences in 8:** > - excluded changes in `jdk/make/lib/CoreLibraries.gmk` due to differences in build system (not applicable to 8) > - excluded cast of `STACK_SIZE_MINIMUM` in `java.c`, as [JDK-6762191](https://bugs.openjdk.org/browse/JDK-6762191), which adds that code, is missing in 8 > - excluded modifications to `readAt` function in `parse_manifest.c`, as function was added by [JDK-8073158](https://bugs.openjdk.org/browse/JDK-8073158), which is missing in 8 > - copyright differences due to missing backports or backport applied out of order (some had to be updated manually) > - differences in paths > > Apart from above differences most of remaining code changes applied cleanly (with updated paths). > > **Testing:** > Tier1 in GHA: **OK** (Failures of `TestCPUAwareness.java` are [unrelated](https://github.com/openjdk/jdk8u-dev/pull/727)) Change looks good. Copyright header changes are adjusted appropriately and omissions understandable. The `ergo_i586.c` exclusion seems to be already covered by this `jdk/make/lib/CoreLibraries.gmk` logic in 8u: ~~~ # if the architecture specific ergo file exists then # use it, else use the generic definitions from ergo.c ifneq ($(wildcard $(JDK_TOPDIR)/src/$(OPENJDK_TARGET_OS_API_DIR)/bin/$(ERGO_ARCH_FILE)), ) BUILD_LIBJLI_FILES += $(ERGO_ARCH_FILE) else # !ERGO_ARCH_FILE LIBJLI_CFLAGS += -DUSE_GENERIC_ERGO endif # ERGO_ARCH_FILE ~~~ It only exists for Solaris. It also seems to have been removed in 11u in [JDK-8169001](https://bugs.openjdk.org/browse/JDK-8169001). ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/733#pullrequestreview-3642116219 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/733#issuecomment-3726809836 From aph-open at littlepinkcloud.com Fri Jan 9 09:06:20 2026 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Fri, 9 Jan 2026 09:06:20 +0000 Subject: Inquiry Regarding JDK-8197531 in jdk8u In-Reply-To: <59a13a2b2b7525a709ae34d37afa4c425a5ae904.5ee1c960.1546.493b.90f1.e88fb9ab64cc@feishu.cn> References: <59a13a2b2b7525a709ae34d37afa4c425a5ae904.5ee1c960.1546.493b.90f1.e88fb9ab64cc@feishu.cn> Message-ID: On 09/01/2026 07:08, ??? wrote: > I hope this message finds you well. I am writing to inquire about issue > JDK-8197531, which currently remains unresolved in the jdk8u releases. > Could you please provide information on whether there are any plans to > address this issue in future jdk8u updates? There are no such plans. Can you please explain why you need this backport? You'll need to subscribe to the list at https://mail.openjdk.org/mailman/listinfo/jdk8u-dev -- Andrew Haley (he/him) Java Platform Lead Engineer https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From jdowland at openjdk.org Fri Jan 9 09:38:32 2026 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 9 Jan 2026 09:38:32 GMT Subject: [jdk8u-dev] RFR: 8284758: [linux] improve print_container_info [v3] In-Reply-To: References: <7KHPPrp_04m38_FLqfv2s2IgVr_DN4DvUxFUonkNXGU=.0e22ac8c-4d3c-4f93-a227-5c2eff93c077@github.com> Message-ID: <7doqKuef7tG9-_8y8v1GFSKLt18wNEqn4bjcj_zH0lo=.92fe686b-9192-4b06-b3cf-b0332d30687b@github.com> On Thu, 8 Jan 2026 14:58:25 GMT, Jonathan Dowland wrote: >> Low-risk, for Oracle parity. Mostly a clean-up. This will ease the future backporting of [JDK-8287011]. >> >> Doesn't apply clean: needs adjusting for paths and also context, to reflect 8u's lack of the pid controller ([JDK-8266490]). >> >> [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8287011 (forthcoming) >> [JDK-8287011]: https://bugs.openjdk.org/browse/JDK-8266490 (not considered) > > Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge remote-tracking branch 'remotes/jdk8u-dev/master' into 8284758-8u > - 8284758: [linux] improve print_container_info > > Reviewed-by: sgehwolf > Backport-of: 6c6d5223dfaae268f968f4292356d4be89adb122 > - 8220658: Improve the readability of container information in the error log > > Backport-of: 2c4b9e0778e170a17b04217bee66bb6c4fb18c0c The GHA failures are all `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#microsoftrsa2017`, unrelated to this change. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/724#issuecomment-3728088557 From andrew at openjdk.org Fri Jan 9 12:12:05 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 9 Jan 2026 12:12:05 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: On Fri, 9 Jan 2026 01:44:55 GMT, Andrew John Hughes wrote: > Merge jdk8u482-b06 back into 8u-dev This pull request has now been integrated. Changeset: 673e0d11 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/673e0d119bff5805792f8fe0b543101825a3e94b Stats: 68 lines in 3 files changed: 0 ins; 42 del; 26 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/739 From andrew at openjdk.org Fri Jan 9 16:11:01 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 9 Jan 2026 16:11:01 GMT Subject: [jdk8u-dev] RFR: 8374899: [8u] Fully handle clang as the toolchain in flags.m4 Message-ID: There are a number of cases in `flags.m4` where the toolchain is checked and `clang` (now the default on all supported versions of XCode on MacOS) is not handled. In particular, this means `-std=gnu++98` is never added and [attempts to build with MacOS 15](https://github.com/openjdk/jdk8u-dev/pull/738) fail as it is trying to meet the demands of C++11. This PR updates the file to handle clang with gcc in most places as there is more commonality between the two than difference. It doesn't attempt to remove the gcc on MacOS support and so some areas will differ from 11u and later where MacOS is assumed to be clang-only. The changes are as follows: 1. Handle linker flags under one shared gcc & clang block as there is mostly duplication between the two with the only difference being `PICFLAG` and `PIEFLAG`. 2. Handle the `-O` flag for both gcc & clang together as they only differ by OS. 3. Handle `clang` in `FLAGS_SETUP_COMPILER_FLAGS_FOR_JDK` 4. Move the Linux defines (`-D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE`) to where the BSD, MacOS & AIX ones are added. This presumably means these were not previously being added for Linux on clang. This mirrors 11u handling. The changes in #3 mean that clang builds will now run the compiler tests for `-std=gnu++98`, `-Wformat-overflow` and `-ffp-contract` as well as the warning & `-fstack-protector` flags added in this block. Some of this may need to be exempted depending on testing. As MacOS GHA builds do not currently run, I will make #738 depend on this PR to test there. This also adds `LOG_LEVEL=debug` to the remaining OpenJDK GHA builds where it was absent (x86 Linux, Windows & Mac). This will mean noisier logs, but more useful ones when there is actually a failure. The current failing Mac ones don't tell us the commands being passed to the compiler. The same option has been present for x86_64 and alt Linux builds for some time. ------------- Commit messages: - Add LOG_LEVEL=debug to all GHA builds - Whitespace cleanup - 8374899: [8u] Fully handle clang as the toolchain in flags.m4 Changes: https://git.openjdk.org/jdk8u-dev/pull/740/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=740&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8374899 Stats: 60 lines in 2 files changed: 6 ins; 31 del; 23 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/740.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/740/head:pull/740 PR: https://git.openjdk.org/jdk8u-dev/pull/740 From andrew at openjdk.org Fri Jan 9 16:11:02 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 9 Jan 2026 16:11:02 GMT Subject: [jdk8u-dev] RFR: 8374899: [8u] Fully handle clang as the toolchain in flags.m4 In-Reply-To: References: Message-ID: <1tysE7zedey_OfibQZeMboyLWzHA_9Z-6cC6uizvUUs=.5fc24f72-2f72-48fd-8fae-eed06e4328a9@github.com> On Fri, 9 Jan 2026 15:59:40 GMT, Andrew John Hughes wrote: > There are a number of cases in `flags.m4` where the toolchain is checked and `clang` (now the default on all supported versions of XCode on MacOS) is not handled. In particular, this means `-std=gnu++98` is never added and [attempts to build with MacOS 15](https://github.com/openjdk/jdk8u-dev/pull/738) fail as it is trying to meet the demands of C++11. > > This PR updates the file to handle clang with gcc in most places as there is more commonality between the two than difference. It doesn't attempt to remove the gcc on MacOS support and so some areas will differ from 11u and later where MacOS is assumed to be clang-only. > > The changes are as follows: > > 1. Handle linker flags under one shared gcc & clang block as there is mostly duplication between the two with the only difference being `PICFLAG` and `PIEFLAG`. > 2. Handle the `-O` flag for both gcc & clang together as they only differ by OS. > 3. Handle `clang` in `FLAGS_SETUP_COMPILER_FLAGS_FOR_JDK` > 4. Move the Linux defines (`-D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE`) to where the BSD, MacOS & AIX ones are added. This presumably means these were not previously being added for Linux on clang. This mirrors 11u handling. > > The changes in #3 mean that clang builds will now run the compiler tests for `-std=gnu++98`, `-Wformat-overflow` and `-ffp-contract` as well as the warning & `-fstack-protector` flags added in this block. Some of this may need to be exempted depending on testing. > > As MacOS GHA builds do not currently run, I will make #738 depend on this PR to test there. > > This also adds `LOG_LEVEL=debug` to the remaining OpenJDK GHA builds where it was absent (x86 Linux, Windows & Mac). This will mean noisier logs, but more useful ones when there is actually a failure. The current failing Mac ones don't tell us the commands being passed to the compiler. The same option has been present for x86_64 and alt Linux builds for some time. I think this may have to be a regular PR to generate the pr/740 branch. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/740#issuecomment-3729557665 From andrew at openjdk.org Fri Jan 9 16:25:28 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 9 Jan 2026 16:25:28 GMT Subject: [jdk8u-dev] RFR: 8374899: [8u] Fully handle clang as the toolchain in flags.m4 [v2] In-Reply-To: References: Message-ID: > There are a number of cases in `flags.m4` where the toolchain is checked and `clang` (now the default on all supported versions of XCode on MacOS) is not handled. In particular, this means `-std=gnu++98` is never added and [attempts to build with MacOS 15](https://github.com/openjdk/jdk8u-dev/pull/738) fail as it is trying to meet the demands of C++11. > > This PR updates the file to handle clang with gcc in most places as there is more commonality between the two than difference. It doesn't attempt to remove the gcc on MacOS support and so some areas will differ from 11u and later where MacOS is assumed to be clang-only. > > The changes are as follows: > > 1. Handle linker flags under one shared gcc & clang block as there is mostly duplication between the two with the only difference being `PICFLAG` and `PIEFLAG`. > 2. Handle the `-O` flag for both gcc & clang together as they only differ by OS. > 3. Handle `clang` in `FLAGS_SETUP_COMPILER_FLAGS_FOR_JDK` > 4. Move the Linux defines (`-D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE`) to where the BSD, MacOS & AIX ones are added. This presumably means these were not previously being added for Linux on clang. This mirrors 11u handling. > > The changes in #3 mean that clang builds will now run the compiler tests for `-std=gnu++98`, `-Wformat-overflow` and `-ffp-contract` as well as the warning & `-fstack-protector` flags added in this block. Some of this may need to be exempted depending on testing. > > As MacOS GHA builds do not currently run, I will make #738 depend on this PR to test there. > > This also adds `LOG_LEVEL=debug` to the remaining OpenJDK GHA builds where it was absent (x86 Linux, Windows & Mac). This will mean noisier logs, but more useful ones when there is actually a failure. The current failing Mac ones don't tell us the commands being passed to the compiler. The same option has been present for x86_64 and alt Linux builds for some time. Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: Helps if configure is regenerated ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/740/files - new: https://git.openjdk.org/jdk8u-dev/pull/740/files/a89902a9..a363af1d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=740&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=740&range=00-01 Stats: 120 lines in 1 file changed: 8 ins; 31 del; 81 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/740.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/740/head:pull/740 PR: https://git.openjdk.org/jdk8u-dev/pull/740 From andrew at openjdk.org Fri Jan 9 23:06:11 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 9 Jan 2026 23:06:11 GMT Subject: [jdk8u-dev] RFR: 8374917: [8u] C++ flags get passed to C compiles in the HotSpot build Message-ID: In gcc, this has been throwing a warning for a long time: ~~~ cc1: warning: command line option '-std=gnu++98' is valid for C++/ObjC++ but not for C ~~~ With clang builds, this is instead an error. ~~~ 2026-01-09T18:17:34.1713580Z error: invalid argument '-std=gnu++98' not allowed with 'C' ~~~ This escalates the problem for newer MacOS builds which need the `-std` flag for the C++ code to compile. It also causes Linux+clang builds to fail. This fix does the minimum to get C++ flags out of the C code builds (the serviceability agent & jsig): * `NO_DELETE_NULL_POINTER_CHECKS_CFLAG`, `NO_LIFETIME_DSE_CFLAG` and `CXXSTD_CXXFLAG` are moved from `EXTRA_CFLAGS` to `EXTRA_CXXFLAGS`. The last of these is essential to fix the problem described above. The others should be safe for the little C code in the HotSpot build; `fno-lifetime-dse` is a C++ flag anyway and the null pointer checks in question are comparisons of `this` with `NULL` from what I can see (again C++ only). Both have been removed in 21u and later, with the required fixes being in the C1 & ADLC code (see [JDK-8316893](https://bugs.openjdk.org/browse/JDK-8316893) and [JDK-8245051](https://bugs.openjdk.org/browse/JDK-8245051)) * The same for `HOST_CFLAGS` and `HOST_CXXFLAGS` used by the ADLC build. * `CFLAGS` and `LFLAGS` in `hotspot/make//makefiles/adlc.make`are switched to use `HOST_CXXFLAGS` as this compiles C++ code * `CFLAGS` and `LFLAGS` in `hotspot/make//makefiles/vm.make`are switched to use `EXTRA_CXXFLAGS` as this compiles C++ code * `CXXFLAGS` are removed from `CC_COMPILE` in `hotspot/make//makefiles/rules.make`. We leave `CXX_COMPILE` untouched to reduce risk. `CXXFLAGS` is rarely used (though most of the code is C++) while `CFLAGS` is used for most flags. `EXTRA_CXXFLAGS` and `HOST_CXXFLAGS` were unused prior to this change. So the risk of changing these is low, while we leave `CFLAGS` untouched. We also move `NO_DELETE_NULL_POINTER_CHECKS_CFLAG`, `NO_LIFETIME_DSE_CFLAG` and `CXXSTD_CXXFLAG` to `hotspot-spec.gmk.in` from `spec.gmk.in`. They are now no longer used by the JDK build (which instead adds them to `CCXXFLAGS_JDK` as can be seen in https://github.com/openjdk/jdk8u-dev/pull/740) and this makes it easier to check the values and their usage in a single generated file. I've built this locally on GNU/Linux with both gcc (8.5.0) and clang (20.1.8). This fix, along with https://github.com/openjdk/jdk8u-dev/pull/740 and a few additional warning removal flags, allowed the clang build to complete. I compared the flags in the logs with a previous build from the 8u repository and all desired flags are preserved as before. Builders may need to adjust their compilation flags if they are relying on `--with-extra-cxxflags` passing flags to the C code part of the HotSpot build instead of `--with-extra-cflags`. This is likely worth a release note. ------------- Commit messages: - 8374917: [8u] C++ flags get passed to C compiles in the HotSpot build Changes: https://git.openjdk.org/jdk8u-dev/pull/741/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=741&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8374917 Stats: 33 lines in 14 files changed: 4 ins; 4 del; 25 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/741.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/741/head:pull/741 PR: https://git.openjdk.org/jdk8u-dev/pull/741 From andrew at openjdk.org Sat Jan 10 20:30:07 2026 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 10 Jan 2026 20:30:07 GMT Subject: [jdk8u-dev] RFR: 8374948: [8u] saproc & jsig builds add duplicate linker flags on Darwin/MacOS Message-ID: This patch breaks out the Mac minimum version argument into its own variable, `MAC_FLAGS`, in `gcc.make`, so it can be added independently in `saproc.make` and `jsig.make`. This prevents duplicate linker flags and C++-only flags being added to the C build for jsig and saproc. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/740 Commit messages: - 8374948: [8u] saproc & jsig builds add duplicate linker flags on Darwin/MacOS Changes: https://git.openjdk.org/jdk8u-dev/pull/742/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=742&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8374948 Stats: 9 lines in 3 files changed: 2 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/742.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/742/head:pull/742 PR: https://git.openjdk.org/jdk8u-dev/pull/742