[jdk8u-dev] RFR: 8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build [v3]

[Severin Gehwolf]

On Sat, 27 Sep 2025 02:51:26 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> Test tools/launcher/VersionCheck.java fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'. This failure fixed by [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) in jdk15, only a subset of [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) to fix this test failure. So it's not suitable to backport [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) to jdk8u-dev, then I create this PR to fix this testbug.
>> 
>> This PR skip all the `*.debuginfo` files to check the '-version' or '-J-version'. Change has been verified localy, test-fix only, no risk.
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into jbs8353657
>  - Use NIX_DBGINFO_EXT instead of DEBUGINFO_FILE_EXT
>  - 8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build

Changes requested by sgehwolf (Reviewer).

jdk/test/tools/launcher/VersionCheck.java line 250:

> 248:                 return false;
> 249:             }
> 250:             if(name.endsWith(NIX_DBGINFO_EXT)) {

Suggestion:

            if (name.endsWith(NIX_DBGINFO_EXT)) {

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/685#pullrequestreview-3655308008
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/685#discussion_r2686005611