[jdk8u-dev] RFR: 8376352: [8u] Build failure on Windows 32-bit after January 2026 CPU integration

[Andrew John Hughes]

On Mon, 26 Jan 2026 16:19:22 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> We see a couple of GHA build failures after the `8u482-ga` merge on Windows 32 bit. See the bug for the build failure traces. This patch proposes to fix it by:
> 
> 1. Defining `ASSOCF_NONE` according to the [doc](https://learn.microsoft.com/en-us/windows/win32/shell/assocf_str) if not already defined. 32-bit Windows only.
> 2. Moving the declaration of `intSize` to the top of the function to make VS Studio 2010 compiles happy.
> 
> Those should be low risk and get GHA builds (on Windows 32 bit) working again. Note those builds run on every new PR. Please review!

Did you debug this on an actual Win32 setup or just via GitHub? I was going to try the local definition approach for `ASSOCF_NONE` but was in the process of trying to get VS2010 installed locally to see if I could see what was actually going on with the headers here. The MS documentation suggests it should be available, unless I'm missing something.  I just want to make sure we are fixing this in the right way.

The definition placement looks correct. This is a recurring one we really should look at checking on Linux to catch it earlier in development without requiring Windows & VS2010.  This again was shared code where it could have been caught.

Setting to request changes mainly to get the bug situation cleaned up.

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/752#pullrequestreview-3711828863