<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div dir="ltr">
<div style=""></div>
<div style="">
<div dir="ltr">Agreed, In addition to that, I also think (as already mentioned, sorry</div>
<div dir="ltr">,) the runFinalizerOnExit() should be a NOP or allow a system property to turn it into a nop.</div>
<div dir="ltr"><br>
</div>
<div dir="ltr">The risk of code (yeah I know you did not find any) calling that setter (and not liking the exception for example in startup thread) is real, there is no reason to add more incompatibility risk to 8u. Just remove it for new releases.</div>
<div dir="ltr"><br>
</div>
<div dir="ltr"><span style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); background-color: rgb(255, 255, 255); display: inline !important;">Making this a Nop is perfectly within its original spec. (And less code than the throw)</span></div>
<div dir="ltr"><br>
</div>
<div dir="ltr">(Mood: I just spent two days in Code I never wanted to touch again for fixing the issues from a 11u backport, before I could ship the eagerly july security update. It would be worse with the 8 generation systems. I hope this is not a theme for
the MR?)</div>
<div dir="ltr"><br>
</div>
<div dir="ltr">Gruss</div>
<div dir="ltr">Bernd</div>
<div id="ms-outlook-mobile-signature">
<div style="direction:ltr">-- </div>
<div style="direction:ltr">http://bernd.eckenfels.net</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> jdk8u-dev <jdk8u-dev-retn@openjdk.org> im Auftrag von Thorsten Glaser <t.glaser@tarent.de><br>
<b>Gesendet:</b> Friday, July 29, 2022 2:44:19 AM<br>
<b>An:</b> David Holmes <dholmes@openjdk.org><br>
<b>Cc:</b> jdk8u-dev@openjdk.org <jdk8u-dev@openjdk.org><br>
<b>Betreff:</b> Re: [jdk8u-dev] RFR: 8287132: Retire Runtime.runFinalizersOnExit so that it always throws UOE</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Fri, 29 Jul 2022, David Holmes wrote:<br>
<br>
> Patch: <a href="https://git.openjdk.org/jdk8u-dev/pull/92.diff">https://git.openjdk.org/jdk8u-dev/pull/92.diff</a><br>
<br>
From a distro maintainer PoV I do have a complaint about this.<br>
<br>
Currently, JVM_Exit is an exported symbol of the shlib:<br>
<br>
$ nm -D /usr/lib/jvm/java-1.8.0-openjdk-i386/jre/lib/i386/server/libjvm.so | fgrep Exit
<br>
005cc5c0 T JVM_Exit<br>
[…]<br>
<br>
This patch will remove that, IIUC. This is an ABI break.<br>
<br>
ABI breaks need the shlib major version to increase.<br>
This shlib is unversioned, so this cannot be done.<br>
<br>
Therefore this cannot be done in OpenJDK 8 at all, or in any<br>
released version really.<br>
<br>
To make this possible, add a dummy JVM_Exit() call, instead of<br>
removing it altogether. Perhaps like this?<br>
<br>
JVM_ENTRY_NO_ENV(void, JVM_Exit(jint code))<br>
before_exit(thread);<br>
vm_exit(code);<br>
JVM_END<br>
<br>
I understand this is the same as JVM_Halt(), but this duplication<br>
is necessary, mandatory even to avoid breaking existing applications.<br>
<br>
bye,<br>
//mirabilos<br>
-- <br>
Infrastrukturexperte • tarent solutions GmbH<br>
Am Dickobskreuz 10, D-53121 Bonn • <a href="http://www.tarent.de/">http://www.tarent.de/</a><br>
Telephon +49 228 54881-393 • Fax: +49 228 54881-235<br>
HRB AG Bonn 5168 • USt-ID (VAT): DE122264941<br>
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg<br>
<br>
****************************************************<br>
/⁀\ The UTF-8 Ribbon<br>
╲ ╱ Campaign against Mit dem tarent-Newsletter nichts mehr verpassen:<br>
╳ HTML eMail! Also, <a href="https://www.tarent.de/newsletter">https://www.tarent.de/newsletter</a><br>
╱ ╲ header encryption!<br>
****************************************************<br>
</div>
</span></font></div>
</body>
</html>