Proposal to revise forest graph and integration practices for JDK 9

David Holmes david.holmes at oracle.com
Wed Nov 27 00:57:34 PST 2013


On 27/11/2013 3:35 AM, Jeremy Manson wrote:
> On Tue, Nov 26, 2013 at 8:28 AM, Joe Darcy <joe.darcy at oracle.com
> <mailto:joe.darcy at oracle.com>> wrote:
>
>     On 11/25/2013 10:37 PM, Jeremy Manson wrote:
>>     Is it worth formalizing the permission system?  That is, only a
>>     select group of people would be allowed to give permission to
>>     check into any given directory, and said permission can be granted
>>     by those people to others, on a change by change basis?
>
>     Before any such system is formalized, a precursor would just be
>     documenting the reviewers that should be involved in particular
>     areas,"Changes in crypto need Alice's or Bob's review," etc. IIRC,
>     there have been some partial efforts on this front previously. My
>     impression is that usually the right reviews happen, but that it can
>     take a while and it is not always clear who should be asked.
>
>
> It seems to me that this is a simple extension of the notion of OpenJDK
> Reviewer.  Each directory presumably "belongs" to one of the groups
> mentioned in the census: http://openjdk.java.net/census.  There are (I
> assume) reviewers in each group.  If you touch a directory with a
> change, you need to get permission from one of the reviewers in the
> appropriate group.  You may need to get more than one permission.

The problem is that projects (not groups) own whole forests not just 
individual repos. So while you would think the Hotspot group is 
responsible for the hotspot repo that is not in fact the case. The hsx 
project is responsible for the hsx forest - but that forest can't 
integrate into the jdk8 (or now jdk9) forest without approval of the 
jdk8/jdk9 project. So for the JDK9 forest(s) the jdk9 project owns them 
and has to establish the rules as to who can perform Reviews for 
different areas.

 From other responses it seems that self-regulation rather then formal 
rules is to be the preferred process.

David

> Jeremy


More information about the jdk9-dev mailing list