RFR [9] Modular Source Code

[Alan Bateman]

On 15/08/2014 11:13, Magnus Ihse Bursie wrote:
> :
>
> In NetworkingLibraries.gmk:
>
>  * There are multiple instances of this pattern:
>    ifneq ($(OPENJDK_TARGET_OS), solaris)
>      LIBNET_EXCLUDE_FILES += solaris_close.c
>    endif
> The correct solution is to move the corresponding files away from the 
> "unix" directory and into more specific libraries (linux, solaris and 
> macosx) and include
> these directories automatically depending on platform. This will allow 
> us to remove the exclude expression.
>
It's good that you giving these changes a thorough review. I agree that 
this and all the other $OS specific source that you have listed move and 
the EXCLUDES dropped. As I said in the previous reply then this is not 
necessary for this initial push. Instead the intention was to establish 
the new layout and for each area to gradually move any remaining 
Solaris, Linux and OS X sources from src/$MODULE/unix to 
src/$MODULE/$OS. It does mean that about 1% of the source files will 
need to move again once the changes are in jdk9/dev but I don't expect 
this to be disruptive.

-Alan.