RFR [JEP 220] Modular Run-Time Images

[Jan Lahoda]

javac changes seem generally OK to me with a few nits below (I am OK if 
these are handled separately as needed).

Jan

-ClassFinder, above getSupplementaryFlags: typo "superceded"?

-Locations, method systemClasses, in the jimage branch, there is:

   Collection<File> images = files
           .filter(f -> f.getFileName().toString().endsWith(".jimage"))
           .map(Path::toFile)
           .collect(Collectors.toList());
   if (!images.isEmpty()) {
       return Collections.singleton(JRT_MARKER_FILE);
   }

this could use Stream.anyMatch(f -> 
f.getFileName().toString().endsWith(".jimage")) instead of collecting to 
list and using List.isEmpty?

-JRTIndex.java:
--I would prefer to use Reference instead of SoftReference wherever 
possible.
--in getEntry method, there is:

  subdirs.add(new RelativeDirectory(rd, entry.getFileName().toString()));

this recomputes entry.getFileName().toString() which is already in a 
local var ("name").

-test/tools/javac/T6558476.java: just a copyright year change

-in test/tools/javac/api/T6412669.java there is:

fm.setLocation(StandardLocation.CLASS_PATH, Arrays.asList(testClasses));

which may have a wrong ident

-in test/tools/javac/api/T6877206.java there is a comment referring to 
ct.sym/rt.jar, which does not seem to be valid anymore

-test/tools/javac/diags/examples/NotInProfile.java - why this change?

-in test/tools/javac/profiles/ProfileOptionTest.java there is comment:
// no equivalent -source?
is that still true/valid?

-in test/tools/lib/ToolBox.java there are stray changes like:
-        for (String p : paths)
+        for (String p: paths)

On 20.11.2014 22:41, Chris Hegarty wrote:
>
>> From: Chris Hegarty <chris.hegarty at oracle.com>
>> Subject: RFR [JEP 220] Modular Run-Time Images
>> Date: 20 November 2014 21:39:14 GMT
>> To: jigsaw-dev <jigsaw-dev at openjdk.java.net>, jdk9-dev <jdk9-dev at openjdk.java.net>, build-dev <build-dev at openjdk.java.net>, Alan Bateman <alan.bateman at oracle.com>, Alex Buckley <alex.buckley at oracle.com>, Chris Hegarty <chris.hegarty at oracle.com>, Erik Joelsson <erik.joelsson at oracle.com>, Jonathan Gibbons <jonathan.gibbons at oracle.com>, Karen Kinnear <karen.kinnear at oracle.com>, "Jim Laskey (Oracle)" <James.Laskey at oracle.com>, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com>, Mandy Chung <mandy.chung at oracle.com>, Mark Reinhold <mark.reinhold at oracle.com>, Paul Sandoz <paul.sandoz at oracle.com>, "A. Sundararajan" <sundararajan.athijegannathan at oracle.com>
>>
>> This is a review request for the changes for JEP 220: Modular Run-Time Images [1].
>>
>> There are a number of individuals responsible for these changes. Some, possibly not all, are explicitly listed in the 'To' section of this mail, and they will help address any comments arising from this review request.
>>
>> The new run-time image structure is defined in JEP 220 [1], and can be seen as a result of building the staging forest [2], or in the early access builds [3].
>>
>> Webrevs:
>>    http://cr.openjdk.java.net/~chegar/8061971/00/
>>
>> Due to the significant impact of these changes, a JDK 9 promotion has been tentatively reserved for their integration. All comments are welcome, although given the nature of the changes then we might have to create separate issues in JIRA to address some of them later in jdk9/dev.
>>
>> -Chris.
>>
>> [1] http://openjdk.java.net/jeps/220
>> [2] http://hg.openjdk.java.net/jigsaw/m2/
>> [3] http://openjdk.java.net/projects/jigsaw/ea
>