[9-dev] Where is webrev?

[Mike Duigou]

I tried it and it seemed to "just work" as a bash script though I didn't have any way to ensure that I had tested all code paths. Wanting to reduce the code paths was in part why I pruned the source of dead features a while back. Depending on how long we think webrev will actually survive it may or may not be worth the effort to convert it.

Mike

On Feb 12 2014, at 09:56 , Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:

> What would it take to translate webrev from ksh to bash, which seems to be the default shell used by OpenJDK these days? (e.g. for the build)
> 
> -- Jon
> 
> 
> On 02/12/2014 09:50 AM, Mike Duigou wrote:
>> It might be better worth including a link directly to the file
>> 
>> http://hg.openjdk.java.net/code-tools/webrev/raw-file/tip/webrev.ksh
>> 
>> to save people a few steps.
>> 
>> Mike
>> 
>> On Feb 12 2014, at 09:33 , Iris Clark <iris.clark at oracle.com> wrote:
>> 
>>> http://openjdk.java.net/guide/webrevHelp.html
>>> 
>>> Updated.  Let me know if I should make further changes to the page.
>>> 
>>> iris
>>> 
>>> -----Original Message-----
>>> From: David Holmes
>>> Sent: Monday, February 10, 2014 10:42 PM
>>> To: sergey malenkov; jdk9-dev at openjdk.java.net
>>> Subject: Re: [9-dev] Where is webrev?
>>> 
>>> On 11/02/2014 4:38 PM, sergey malenkov wrote:
>>>> The webrev script is not available at ./make/scripts/webrev.ksh.
>>>> http://openjdk.java.net/guide/webrevHelp.html
>>> It was moved to the codetools repo:
>>> 
>>> http://openjdk.java.net/projects/code-tools/
>>> 
>>> The guide needs updating.
>>> 
>>> David
>>> 
>>>> Thanks,
>>>> SAM
>