RFR: Hole for alternative plugin implementation

[Mario Torre]

Hi David,

In general I fully agree with you, but in this specific case I would
go for it nevertheless, since this is meant as a replacement for the
plugin (oh which none exist).

I think it make sense to have the Free plugin in OpenJDK so that
anyone can benefit and not just IcedTea derived distribution.

The only alternative I see is to make a proper plugin API, do you
think this would be a better option?

Cheers,
Mario


2014/1/24 David Holmes <david.holmes at oracle.com>:
> Hi Omair,
>
> I don't think supporting the ability to extend sun.* classes publicly is a
> good solution for this (or any) RFE. Further I would not expect it to even
> be possible later in JDK 9 due to the expected modularity controls.
>
> Just my personal opinion.
>
> David
>
>
> On 24/01/2014 9:38 AM, Omair Majid wrote:
>>
>> Hi,
>>
>> Over in the IcedTea project, we have an alternative (and Open Source)
>> implementation of javaws/plugin called IcedTea-Web [1]. IcedTea-Web has
>> always been built and run against IcedTea. However, that has required
>> IcedTea to carry patches that are not part of OpenJDK.
>>
>> It would be much better if these patches were part of OpenJDK, I think.
>> It would mean OpenJDK could work with an Open Source/Free Software
>> plugin, IcedTea-Web wouldn't need a patched IcedTea and IcedTea wouldn't
>> have to carry this patch locally.
>>
>> The webrev is at:
>> http://cr.openjdk.java.net/~omajid/webrevs/applet-hole/00/
>>
>> This is a very small patch and it only relaxes visibility for methods
>> and members declared in two sun.applet.* classes. I think it's a very
>> safe change.
>>
>> The change has been quite stable, we have been using this patch in
>> IcedTea 7 (without any modifications) since 2010.  The history of the
>> patch before that was slightly more complex. Andrew Hughes added it to
>> IcedTea 7 but it was taken from IcedTea6. The log for
>> icedtea6/patches/applet_hole.patch shows the following people have
>> contributed to it:
>>
>> Andrew John Hughes
>> Deepak Bhole
>> Omair Majid
>> Thomas Fitzsimmons
>>
>> Since all are/were Red Hat employees, the patch is covered by the CLA.
>>
>> So, what do you all think about this? Are there any concerns or
>> suggestions? I will be happy to rework the patch as needed.
>>
>> Thanks,
>> Omair
>>
>> [1] http://icedtea.classpath.org/wiki/IcedTea-Web
>>
>



-- 
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

IcedRobot: www.icedrobot.org
Proud GNU Classpath developer: http://www.classpath.org/
Read About us at: http://planet.classpath.org
OpenJDK: http://openjdk.java.net/projects/caciocavallo/

Please, support open standards:
http://endsoftpatents.org/