RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs

[Bengt Rutisson]

Hi David,

On 2014-10-01 15:59, David Chase wrote:
> I thought we had that in what I know of as “webrev-new”, see for example:
>
> http://cr.openjdk.java.net/~drchase/8037816/webrev-9.05-09b/src/cpu/x86/vm/c1_LinearScan_x86.cpp.sdiff.html

This looks like the version I know as "Tom's webrev" :)

I think it is nice too. But it does not have next/prev for frames. The 
main problem with it, though, is that as far as I know there is no 
official policy that this is the preferred tool. I'd like to get this 
feature in to the official tool, which as far as I know is in the 
code-tools repo.

>
> But yours is also nice :-).

Thanks. :)

Bengt

>
> David
>
> On 2014-10-01, at 4:56 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
>
>> Hi everyone,
>>
>> (This is a patch for webrev, but I am cross posting to the JDK 9 dev list since I'm not sure how many are on the webrev-dev list and most JDK developers might have opinions about this change.)
>>
>> Can I get a couple of reviews for this small enhancement to the webrev tool?
>>
>> CODETOOLS-7901044: Add next/prev links to navigate between diffs
>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044
>>
>> Webrev:
>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/
>>
>>
>> Background:
>> When browsing review requests that span many files it is quite time consuming to have to go back to the index page to view to the next or previous file. This patch adds links to the next and previous files in the diff views (including frames).
>>
>> The above webrev is generated with this new version, but since it only contains a single file it is not that interesting. Here is an example of what the new webrev looks like for a larger change (the G1 class unloading change):
>>
>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/
>>
>> Thanks,
>> Bengt
>>