RFR (S): 8078520: [TESTBUG] fix 'test/tools/launcher/ExecutionEnvironment.java' to run on arbitrary *nix systems

[Volker Simonis]

Great!

Thanks a lot,
Volker


On Thu, Apr 23, 2015 at 7:22 PM, Kumar Srinivasan
<kumar.x.srinivasan at oracle.com> wrote:
> Hi Volker,
>
> Looks fine.
>
> You can put me (ksrini) down as reviewer.
>
> Thanks
> Kumar
>
>
> On 4/23/2015 8:24 AM, Volker Simonis wrote:
>>
>> Hi,
>>
>> could somebody please review the following little change which
>> improves 'test/tools/launcher/ExecutionEnvironment.java':
>>
>> https://bugs.openjdk.java.net/browse/JDK-8078520
>> http://cr.openjdk.java.net/~simonis/webrevs/2015/8078520/
>>
>> The test 'test/tools/launcher/ExecutionEnvironment.java' needs a
>> special handling on Solaris. But instead of doing:
>>
>> if (TestHelper.isSolaris) { ... } else { ... }
>>
>> it currently goes the other way round:
>>
>> if (TestHelper.isLinux || TestHelper.isMacOSX || TestHelper.isAIX) {
>> ... } else { /* Solaris */ ... }
>>
>> I've fixed the test to explicitly check for Solaris. This will make it
>> possible to also run the test on other operating systems without the
>> need to explicitly name them.
>>
>> Thank you and best regards,
>> Volker
>
>