RFR(S): 8133830: Fix for small leak in TimeZone_md.c:

Andrew Hughes gnu.andrew at redhat.com
Wed Aug 26 18:32:44 UTC 2015


----- Original Message -----
> Hi Christoph,
> 
> the change looks good, Reviewed.
> 
> In case this code gets reengineered, you could add a comment that
> memory of getenv must not be freed.
> 
> Thanks for fixing this,
>   Goetz.
> 
> 
> -----Original Message-----
> From: Langer, Christoph
> Sent: Donnerstag, 20. August 2015 12:12
> To: 'jdk9-dev at openjdk.java.net' <jdk9-dev at openjdk.java.net>
> Subject: RE: RFR(S): 8133830: Fix for small leak in TimeZone_md.c:
> 
> Hi all,
> 
> as per the discussion in thread "Fix for small leak in TimeZone_md.c", I
> would like to get the following tiny change reviewed:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8133830
> Webrev: http://cr.openjdk.java.net/~asiebenborn/christoph/webrev/
> 
> As said before, I also need a sponsor since I can't commit yet.
> 
> Thanks
> Christoph
> 

I'm happy to sponsor this if still needed. This version is almost
so trivial now as to barely need review :)

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07



More information about the jdk9-dev mailing list