RFR(XXS): 8145212: ISO-8859-1 isn't properly handled as 'fastEncoding' in jni_util.c

[Martin Buchholz]

This seems obviously and embarrassingly correct - approved!


On Mon, Dec 14, 2015 at 6:45 AM, Volker Simonis
<volker.simonis at gmail.com> wrote:
> Hi,
>
> could somebody please review this trivial fix:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2015/8145212/
> https://bugs.openjdk.java.net/browse/JDK-8145212
>
> The current code only recognizes "8859_1", "ISO8859_1" and "ISO8859-1"
> as iso88591 but on Linux, AIX and potentially other OSs a call to
> setlocale(LC_CTYPE, NULL) returns the more standard conformant name
> "ISO-8859-1".
>
> Notice that this change will trigger "8145015: jni_GetStringCritical
> asserts for empty strings" [1] on Linux with an ISO-8859-1 locale if
> running any AWT code. So I think the best would be to push this fix
> directly to jdk9/hs-rt right after the fix for 8145015 has landed
> there. What do you think?
>
> Thank you and best regards,
> Volker
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8145015