RFR: AARCH64: Top-level JDK changes

[Magnus Ihse Bursie]

On 2015-01-14 23:02, Dean Long wrote:
> On 1/14/2015 5:27 AM, Magnus Ihse Bursie wrote:
>> On 2015-01-13 09:32, Dean Long wrote:
>>> On 1/12/2015 3:49 AM, Magnus Ihse Bursie wrote:
>>>> On 2015-01-12 05:31, Dean Long wrote:
>>>>> I found a small problem with the new config.sub wrapper.  It works 
>>>>> with the bash shell but not with the dash shell.
>>>>> The problem seems to be with this line:
>>>>>
>>>>>     result=`. $DIR/autoconf-config.sub $sub_args "$@"`
>>>>>
>>>>> "dash" doesn't seem to support args passed with ".", so $sub_args 
>>>>> "$@" are ignored.
>>>>
>>>> bash is the required shell for running configure. We do not support 
>>>> non-bash shells. In fact, we go to lengths to try to ensure that we 
>>>> are indeed running under bash.
>>>>
>>>> /Magnus
>>> I was thinking 'bash configure' was enough, but it turns out 
>>> 'CONFIG_SHELL=bash bash configure' gives better results.
>>
>> Hm, that's interesting. We were attempting to automatically use bash 
>> in the real configure script, regardless of what shell the user had 
>> to start the top-level configure wrapper.
>>
>> If you try the patch below, does it work better when you run "dash 
>> configure"?
>>
>> diff --git a/common/autoconf/configure b/common/autoconf/configure
>> --- a/common/autoconf/configure
>> +++ b/common/autoconf/configure
>> @@ -36,6 +36,13 @@
>>    shift
>>  fi
>>
>> +if test "x$BASH" = x; then
>> +  echo "Error: This script must be run using bash." 1>&2
>> +  exit 1
>> +fi
>> +# Force autoconf to use bash
>> +export CONFIG_SHELL=$BASH
>> +
>>  conf_script_dir="$TOPDIR/common/autoconf"
>>
>>  if [ "$CUSTOM_CONFIG_DIR" = "" ]; then
>>
>> /Magnus
>>
>
> Yes, that patch solves the problem.

Thank you for testing it! I have opened 
https://bugs.openjdk.java.net/browse/JDK-8069057 and will integrate the 
fix to jdk9-dev.

/Magnus