And then there were none: -Xlint:all enabled int the build of JDK 9 jdk repo

[joe darcy]

On 1/16/2015 10:45 AM, Jonathan Gibbons wrote:
> On 01/15/2015 07:36 PM, joe darcy wrote:
>> Hello,
>>
>> After a small language change to make the effort tractable [1], and 
>> another round of code cleanup [2], the deprecation warnings have been 
>> eliminated from the build of the jdk repository of JDK 9 [3].
>>
>> That means that coming after the previous waves of warnings cleanup, 
>> *all* the lint warnings are now enabled in the build of the jdk repo!
>>
>> The effort of clearing all these lint warnings has taken place over 
>> many months building on the contribution of many people. I'd like to 
>> especially recognize Stuart Marks and Alan Bateman for early work 
>> cleaning up the libraries, Jan Lahoda for implementing the supporting 
>> language change, Jason Uh for help running build jobs, and Phil Race 
>> for many reviews of changes to client code.
>>
>> Thanks,
>>
>> -Joe
>>
>> [1] JEP 211: Elide Deprecation Warnings on Import Statements, 
>> http://openjdk.java.net/jeps/211
>>
>> [2] JDK-8066616 Suppress deprecation warnings in jdk libraries, 
>> https://bugs.openjdk.java.net/browse/JDK-8066616
>>
>> [3] http://hg.openjdk.java.net/jdk9/dev/rev/f1dc16345985
>>
>
>
> Joe,
>
> This is indeed good news, and shows that if you keep chipping away at 
> the backlog, you can get to a satisfactory conclusion.
>
> Now that we have achieved this goal, we need to be able to stay there. 
> I presume that along with -Xlint:all, we also have -Werror, to make 
> fatail errors from any future lapses.

Indeed!

>
> Also, what is the "score sheet" across the other repos in the forest?
>

Langtools is compiled with -Xlint:all,-deprecation -Werror. I have not 
looked in detail, but I wouldn't be surprised if the langtools 
deprecation warnings couldn't be resolved until JDK 10, using a 
bootstrap to JDK 9, to take advantage of the language change to elide 
deprecation warnings on import statements.

I have a question out to build-dev to see how to officially run the 
builds of other repos with different javac options, but in the mean time 
I've done a stand-alone compile of the sources in the jaxp repo:

5230 total warnings

     [cast]    160
     [dep-ann]    109
     [deprecation] 91
     [fallthrough]    46
     [rawtypes]    2238
     [serial]    280
     [static]    21
     [unchecked]    2285

So we know from a while-JDK perspective, there is still plenty of 
warnings cleanup work left to do.

Thanks,

-Joe