CFV: New JDK 9 Reviewer: Dmitry Samersoff

Fri Nov 6 10:44:51 UTC 2015

Vote: yes

Regards,
Volker


On Fri, Nov 6, 2015 at 11:40 AM, Jaroslav Bachorik
<jaroslav.bachorik at oracle.com> wrote:
> I hereby nominate Dmitry Samersoff to jdk9 Reviewer.
>
> Dmitry is a long standing member of the Hotspot Serviceability team. He has
> contributed over 50 changesets in hotspot as well as in jdk, including
> implementation of JDP (Java Discovery Protocol), part of DCMD (diagnostic
> commands) and various fixes and improvements in the areas of JDI, JDWP and
> SA (Serviceability agent). He also participated in many reviews as well.
> Some of his more significant contributions are listed below.
>
> Votes are due by 13 Nov 2015.
>
> Only current jdk9 Reviewers [1] are eligible to vote on this
> nomination. Votes must be cast in the open by replying to this mailing list.
>
> For Three-Vote Consensus voting instructions, see [2].
>
> -JB-
>
> [1] http://openjdk.java.net/census
> [2] http://openjdk.java.net/projects/#reviewer-vote
>
> /hotspot/
> =================================================================
> http://hg.openjdk.java.net/jdk9/hs/hotspot/revf1e0206e75e1
> 8086134: Deadlock detection fails to attach to core file
> Summary: Test reimplemented for jtreg
> Reviewed-by: jbachorik
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev56a527afc34a
> 8059036: Implement Diagnostic Commands for heap and finalizerinfo
> Summary: Implement Diagnostic Commands for heap and finalizerinfo
> Reviewed-by: sla, plevart, mchung
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev24a8cbde76d8
> 8059038: Create new launcher for SA tools
> Summary: Proivide jhsdb command to launch sa based tools
> Reviewed-by: sspitsyn, jbachorik
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev2fb3ff31ff00
> 8044416: serviceability/sa/jmap-hashcode/Test8028623.java fails with
> AssertionFailure: can not get class data for
> java/lang/UNIXProcess$Platform$$Lambda
> Summary: Lambda object is not counted when SA builds class data cache but is
> reached inside live region.
> Reviewed-by: sla, jbachorik
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/reva814058f5215
> 7076820: assert(addr != 0) failed: address sanity check in
> PerfMemory::detach with -XX:-UsePerfData
> Summary: Explicitly checks for UsePerfData and if it's false make
> Perf:detach a NOP.
> Reviewed-by: dholmes, jbachorik
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev9c8575a9f888
> 8059131: sawindbg.dll is not compiled with /SAFESEH
> Summary: Make variable SAFESEH_FLAG replaced with /SAFESEH link option.
> Reviewed-by: mgronlun, sla
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev474605fb56a4
> 8054194: jstack crash: assert(handle != NULL) failed: JNI handle should not
> be null
> Summary: Add better error check to sa to avoid secondary crash
> Reviewed-by: sla, jbachorik, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev04f50665db45
> 8025667: Warning from b62 for hotspot.agent.src.os.solaris.proc: use after
> free
> Summary: move free call few lines down
> Reviewed-by: dholmes, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev370ff4c8bd7b
> 8049046: Deprecated Function in
> hotspot/src/os/solaris/vm/attachListener_solaris.cpp
> Summary: replace door_cred with door_ucred call
> Reviewed-by: dholmes, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/revb19ccfb09cf2
> 8038392: Generating prelink cache breaks JAVA 'jinfo' utility normal
> behaviour
> Summary: Better parsing of /proc/pid/maps in sa
> Reviewed-by: sspitsyn, sla
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/revc597dc3eb862
> 6904403: assert(f == k->has_finalizer(),"inconsistent
> has_finalizer") with debug VM
> Summary: Don't assert if one of classes in hierarhy was redefined
> Reviewed-by: coleenp, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev16432bba405a
> 8042155: [TESTBUG] Tests for stack guard pages have to be cleaned up
> Summary: Tests for 6929067 and 8009062 should be composed to single test
> that provide better testing for stack guard pages behaviour
> Reviewed-by: coleenp, dcubed, dsimms
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev02577a0ee207
> 8029139: [TESTBUG] runtime/InitialThreadOverflow/testme.sh fails with exit
> code 127
> Summary: The test launcher compiles against TESTJAVA but LD_LIBRARY_PATH set
> to COMPILE java.
> Reviewed-by: sla, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev53c2400d387e
> 8037279: runtime/6929067/Test6929067.sh crashes on 32bit linux
> Summary: The test compile launcher with TESTJAVA but attempt to load vm from
> COMPILEJAVA
> Reviewed-by: sla, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/reve8c381b5f4e2
> 7189721: nightly tests failed on JDI attaching
> Summary: If for some reason elf section with section names is not loaded to
> cache it attempts to read data using NULL section pointer.
> Reviewed-by: sspitsyn, sla, kevinw
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/revd7cb88bd7046
> 7127191: SA JSDB does not display native symbols correctly for transported
> Linux cores
> Summary: Better handle SA_ALTROOT
> Reviewed-by: sla, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev46eeb3056482
> 8023667: SA: ExceptionBlob and other C2 classes not available in client VM
> Summary: Ignore error of intialization of C2 only variables
> Reviewed-by: sla, dholmes
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev4fe850c65ed1
> 7010732: SA_ALTROOT only works if running the SA tools from their build
> directory.
> Summary: fixed SA packaging scripts
> Reviewed-by: sla, kevinw
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/revb8a500a7b9bf
> 8032247: SA: Constantpool lookup for invokedynamic is not implemented
> Summary: implement constant pool lookup for invokedynamic
> Reviewed-by: sla, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev19682558f2e1
> 8030941: Darwin mapfile-vers doesnt work for other BSDs
> Summary: Changed makefile to use generic mapfile for non Darwin BSDs
> Reviewed-by: dholmes, sla
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev27c84ba76954
> 6969276: minor memory leak detected by cppcheck in
> agent/src/os/linux/symtab.c
> Summary: missed free call on error return
> Reviewed-by: sla, sspitsyn, igerasim
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev03e9e2e3028b
> 8028408: unused-value warning on forte.cpp when build on Mac
> Summary: cast argument to void in function type definition
> Reviewed-by: sla, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev996d1f2f056f
> 8026930: In ManagementAgent.start it should be possible to set the jdp.name
> parameter (hotspot part)
> Summary: Pass one more property from Agent to JdpController
> Reviewed-by: jbachorik, sla
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev1bee3014cf2a
> 8025812: tmtools/jmap/heap_config tests fail on Linux-ia32 because it Cant
> attach to the core file
> Summary: Coredump store memsz elf field rounded up to page
> Reviewed-by: dholmes, sla
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev1f42d3ec1759
> 7133122: SA throws sun.jvm.hotspot.debugger.UnmappedAddressException when it
> should not
> Summary: replace PT_LOAD segment with library segment when necessary
> Reviewed-by: dholmes, sla
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev1c6b721a3fbf
> 8022617: Openjdk hotspot build is broken on BSD platforms using gcc
> Summary: Enforce of preprocessing of all assembly sources by
> assembler-with-cpp
> Reviewed-by: dholmes, erikj
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/revd8e99408faad
> 8009062: poor performance of JNI AttachCurrentThread after fix for 7017193
> Summary: don't re-evaluate stack bounds for main thread before install guard
> page
> Reviewed-by: coleenp, dholmes, dlong
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev22a5aff0df0b
> 8019396: SA-JDI OSThread class initialization throws an exception
> Summary: Method sun.jvm.hotspot.runtime.OSThread.initialize throws a
> sun.jvm.hotspot.types.WrongTypeException
> Reviewed-by: dholmes, mgerdin
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev8f696cf1a0fb
> 8002048: Protocol to discovery of manageable Java processes on a network
> Summary: Introduce a protocol to discover manageble Java instances across a
> network subnet, JDP
> Reviewed-by: sla, dfuchs
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/revff29ce866f23
> 7118280: The gbyc00102 JCK7 test causes an assert in JVM 7.0 fastdebug mode
> Summary: Assert doesn't respect invokedynamic opcode
> Reviewed-by: dcubed, phh
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev645162d94294
> 7110104: It should be possible to stop and start JMX Agent at runtime
> Summary: Added a capability to start and stop JMX Agent by jcmd
> Reviewed-by: acorn, mchung
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/reva42c07c38c47
> 7132515: Add dcmd to manage UnlockingCommercialFeature flag
> Summary: Added dcmd to unlock or check status of UnlockingCommercialFeature
> flag
> Reviewed-by: fparain, rottenha
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/revbf864f701a4a
> 7066129: GarbageCollectorMXBean#getLastGcInfo leaks native memory
> Summary: Make GCStatInfo a resource object
> Reviewed-by: phh, coleenp
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/revdddc5753c53a
> 7019808: build fails on Fedora 14: SELinux run-time check: execution of
> stack in libjvm.so
> Summary: executable flag is set in the elf header of libjvm.so during build,
> instruct ld to don't do it.
> Reviewed-by: acorn, phh
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev677234770800
> 7017193: Small memory leak in get_stack_bounds os::create_stack_guard_pages
> Summary: getline() returns -1 but still allocate memory for str
> Reviewed-by: dcubed, coleenp
>
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev642e54d1850a
> 6989076: JVM crashes in klassItable::initialize_itable_for_interface
> Summary: hotspot should check protection attribute besides the name and
> signature of the method when constructing vtable.
> Reviewed-by: dcubed
>
>
> /jdk/
> ========================================================================
> http://hg.openjdk.java.net/jdk9/hs/jdk/reva0917b713fda
> 8086134: Deadlock detection fails to attach to core file
> Summary: Test reimplemented for jtreg
> Reviewed-by: jbachorik
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev0edb1c267b49
> 8132648: sun/tools/jhsdb/BasicLauncherTest fails with
> java.lang.RuntimeException
> Summary: Added check for standard conditions causing attach to fail
> Reviewed-by: jbachorik, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev9b17d0a2720f
> 8059036: Implement Diagnostic Commands for heap and finalizerinfo
> Summary: Implement Diagnostic Commands for heap and finalizerinfo
> Reviewed-by: sla, plevart, mchung
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revbf17c0a1c746
> 8059038: Create new launcher for SA tools
> Summary: Proivide jhsdb command to launch sa based tools
> Reviewed-by: sspitsyn, jbachorik
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev9fa549e06f83
> 8074146: jdb has succeded to read an unreadable file
> Summary: Remove this testcase
> Reviewed-by: sla, egahlin
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev58ec14da9fe8
> 8042397: tmtools/jmap/heap_config/jmap_heap_config_OldSize fails
> Summary: rewrite the test to jtreg
> Reviewed-by: ykantser, jbachorik
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev1da36a71eb7d
> 8067030: JDWP crash in transport_startTransport on OOM
> Summary: Check for result of jvmtiAllocate
> Reviewed-by: jbachorik, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev7c99f1d28c75
> 8059037: JdpTest.sh hangs when trying to kill the test VM
> Summary: Removed shell tests enable java ones
> Reviewed-by: sla, miauno
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev8c8a7b6f49de
> 8049226: com/sun/jdi/OptionTest.java test times out again
> Summary: Don't call jni_FatalError if transport initialization fails
> Reviewed-by: sspitsyn, sla
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev5e7143c1abc1
> 8044762: com/sun/jdi/OptionTest.java test time out
> Summary: gdata could be NULL in debugInit_exit
> Reviewed-by: dcubed
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revb2023f11a0e5
> 8041498: Remove npt library
> Summary: Get rid of npt library and move utf-related code to share/backend
> Reviewed-by: sla
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev5d191d40073f
> 8043716: JDI test com/sun/jdi/ProcessAttachTest.sh and other 3 jdi tests
> failed in nightly
> Summary: InetAddress.getLocalHost() returns configured host name instead of
> localhost.
> Reviewed-by: dcubed
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev030dae646c6b
> 8041435: Make JDWP socket connector accept only local connections by default
> Summary: Bind to localhost only if no address specified. Require * to bind
> to all available addresses
> Reviewed-by: dcubed, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev0b2627ad873c
> 8039368: Remove testcase from npt utf.c
> Summary: don't compile testcase by default
> Reviewed-by: sla, vkempik
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev79906d84de14
> 8022323: [JavaSecurityScanner] review package com.sun.management.* Native
> methods should be private
> Summary: create java methods that calls native one
> Reviewed-by: sla, dholmes
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revfdba918439a3
> 8002116: This JdbReadTwiceTest.sh gets an exit 1
> Summary: Explicitly check readability of file in question
> Reviewed-by: sla, dholmes, olagneau
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revf8c54a1c47d5
> 8024049: com/sun/jdi/ProcessAttachTest.sh shortens 7-digit pid to 6-digit
> Summary: replace cut call to awk
> Reviewed-by: sla, olagneau
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev392acefef659
> 8024071: In ManagementAgent.start it should be possible to set the jdp.name
> parameter.
> Summary: Pass one more property from Agent to JdpController
> Reviewed-by: jbachorik, sla
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev88436832cfd0
> 8004213: JDP packet needs pid, broadcast interval and rmi server hostname
> fields
> Summary: Add some extra fileds to jdp packet
> Reviewed-by: allwin, sla, hirt
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/reva06b764cc2d0
> 8008589: Better MBean permission validation
> Summary: Better MBean permission validation
> Reviewed-by: skoivu, dfuchs, mchung, sjiang
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev5d6dc0cba08f
> 8009213: sun/management/jdp/JdpTest.sh fails with exit code 1
> Summary: There's no guarantee that the java process has executed far enough
> to be found by jps when we try to obtain it's pid.
> Reviewed-by: sla
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revfce446b29577
> 8011038: sourceObj validation during desereliazation of RelationNotification
> should be relaxed
> Summary: sourceObj could be set to null by setSource() relax a validation of
> deserialized object.
> Reviewed-by: sjiang, skoivu, dfuchs
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev0bddd4e8bfb6
> 8008124: Better compliance testing
> Summary: Better compliance testing
> Reviewed-by: dfuchs, jfdenise, skoivu, alanb
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev107f21efda78
> 8008120: Improve JMX class checking
> Summary: Improve JMX class checking
> Reviewed-by: mchung, dfuchs, alanb, skoivu
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev2eac60e99307
> 8007471: Improve MBean notifications
> Summary: Improve MBean notifications
> Reviewed-by: dfuchs, mchung, alanb, skoivu
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revdf1b35c7901d
> 8015604: JDP packets containing ideographic characters are broken
> Summary: Code uses string length rather than byte array length and non ascii
> entry brakes packet.
> Reviewed-by: dholmes, jbachorik, sla
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revcf01f2847551
> 8006435: Improvements in JMX
> Summary: Improvements in JMX
> Reviewed-by: dfuchs, skoivu, alanb, mchung
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev8181be9a3538
> 8008095: TEST_BUG: JDK-8002048 one more testcase failure on Solaris
> Summary: fixed couple of more Solaris shell incompatibilities
> Reviewed-by: chegar
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revf7fb173ac833
> 8007786: JDK-8002048 testcase doesn't work on Solaris
> Summary: test built in into Solaris shell doesn't have -e operator
> Reviewed-by: sla, sspitsyn
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev1df991184045
> 8007536: Incorrect copyright header in JDP files
> Summary: Copyright header in JDP files missed the "classpath exception"
> rule.
> Reviewed-by: mikael
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev0e7d5dd84fdf
> 8007277: JDK-8002048 testcase fails to compile
> Summary: sun.* classes is not included to ct.sym file and symbol file have
> to be ignored
> Reviewed-by: alanb
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev962d6612cace
> 8002048: Protocol to discovery of manageable Java processes on a network
> Summary: Introduce a protocol to discover manageble Java instances across a
> network subnet, JDP
> Reviewed-by: sla, dfuchs
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev3a825f6cbc71
> 7169888: Narrowing resource definitions in JMX RMI connector
> Summary: CPU bug, we can't put offending calls outside doPrivileged, but
> narrow granted permissions.
> Reviewed-by: ahgross, fparain
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev263f15439f4b
> 7158796: Tighten properties checking in EnvHelp
> Summary: Move getProperty call out of computeBooleanFromString
> Reviewed-by: skoivu, sla
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev0c1c4b185451
> 7186723: TEST_BUG: Race condition in
> sun/management/jmxremote/startstop/JMXStartStopTest.sh
> Summary: Make test self-terminating and independent to cygwin/mks kill
> behaviour
> Reviewed-by: sspitsyn, alanb
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revbf85c3ab2637
> 7183753: [TEST] Some colon in the diff for this test
> Summary: Reference output file contains extra colon
> Reviewed-by: sspitsyn, mgronlun
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/revc0a5140c641c
> 7149181: sun/management/jmxremote/startstop/JMXStartStopTest.sh failing on
> all platforms
> Summary: Disable test until JDK and hotspot changes meet each other.
> Reviewed-by: alanb, acorn
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev1e737abbff6f
> 7110104: It should be possible to stop and start JMX Agent at runtime
> Summary: Added a capability to start and stop JMX Agent by jcmd
> Reviewed-by: acorn, mchung
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev25050030a320
> 6964714: NetworkInterface getInetAddresses enumerates IPv6 addresses if
> java.net.preferIPvStack property set
> Summary: User can disable ipv6 explicitly, have to check it
> Reviewed-by: chegar, alanb
>
> http://hg.openjdk.java.net/jdk9/hs/jdk/rev887e525597f8
> 6931566: NetworkInterface is not working when interface name is more than 15
> characters long
> Summary: Separate Linux and Solaris code, use lifreq under Solaris
> Reviewed-by: chegar