Copyright cleanup project

[joe darcy]

Hi Sergey,

On 11/10/2015 11:12 AM, Sergey Bylokhov wrote:
> On 10.11.15 2:37, Joseph D. Darcy wrote:
>>
>> Various inconsistencies in these copyrights and licenses have been
>> noticed. For example, sometimes the year range is formatted differently
>> or there are extraneous extra lines in the license block. In some other
>> cases, a properly formatted copyright and license is present, but an
>> inappropriate license is used; for example, a test file has GPL with
>> ClassPath exception where GPL is more appropriate.
>>
>> To help correct and regularize the licenses and copyrights, Vassili
>> Igouchkine has developed tooling to analyze these portions of the source
>> files. Vassili will be sending out code reviews for changes addressing
>> the sorts of problems outlined above. The changes will target JDK 9 and
>> be sent to aliases appropriate for the code being modified. In
>> particular, precise checks will be applied to files where Oracle is the
>> copyright holder. In the future, Vassili plans to develop a programmatic
>> check for the licenses and copyrights that can catch both syntactic
>> problems and well as improper licensing. The check will be something
>> developers can run on their changesets before pushing. (This is not the
>> sort of check believed to be suitable for inclusion in jcheck.)
>
> Just curious. Does the make/scripts/lic_check.sh have the similar checks?

That script as it stands is at best a partial solution. In particular, 
there is no outer framework to encode src/foo/* should be GPL and 
src/bar/* should be GPL with the classpath exception, etc.

> Why not integrate it to jcheck or it will be run regularly by someone?

The general licensing correctness properties can be complicated and the 
sort of checks imposed by jcheck should be simple to avoid locking the 
forest unnecessarily. However, running the license check on a CI server 
would be a fine practice.

Cheers,

-Joe