RFR: 8164052 Fix legal notices in JDK tests
Jonathan Gibbons
jonathan.gibbons at oracle.com
Tue Aug 16 17:09:20 UTC 2016
In StrongSeedReader, you don't need, and stylististically should not,
use "/**" for jtreg test description comments.
-- Jon
On 08/16/2016 09:43 AM, Iris Clark wrote:
> Hi, Shura.
>
>> http://cr.openjdk.java.net/~shurailine/8164052/webrev_00/
> I did a quick review of the .patch file.
>
> The changes in test/java/net/httpclient/security/Driver.java and friends are
> interesting. I can't say that I've ever seen that particular failure, though
> there are many variants.
>
> test/sun/security/provider/SecureRandom/StrongSeedReader.java, line 24: This
> change is puzzling. If I'm understanding the spacing correctly, a space
> has been added at the beginning of the line throwing off the comment
> alignment.
>
> Everything else looks reasonable/expected.
>
> Thanks,
> iris
>
> -----Original Message-----
> From: Alexandre (Shura) Iline
> Sent: Monday, August 15, 2016 11:40 AM
> To: jdk9-dev at openjdk.java.net
> Subject: RFR: 8164052 Fix legal notices in JDK tests
>
> Hi,
>
> Please review this bulk update of JDK test sources which is fixing legal notices formatting and content.
>
> http://cr.openjdk.java.net/~shurailine/8164052/webrev_00/
>
> I am sending this to the jdk9-dev at openjdk.java.net hoping that would be enough. Otherwise I would send the request to multiple aliases which have tests in idk repository.
>
> Shura
>
More information about the jdk9-dev
mailing list