RFR(xs): 8164835: add a few tools tests to the problem list
joe darcy
joe.darcy at oracle.com
Fri Aug 26 05:33:07 UTC 2016
Ah, okay -- missed that detail; a hazard of late-night reviewing!
Thanks,
-Joe
On 8/25/2016 10:15 PM, Stuart Marks wrote:
> There are two separate tests to be problem-listed, TestLoad.java and
> TestScan.java. I'm covering them with the same bug, though.
>
> s'marks
>
> On 8/25/16 10:02 PM, joe darcy wrote:
>> Hi Stuart,
>>
>> I'll approve an amended version of the patch that doesn't list
>> TestScan.java on
>> two separate lines :-)
>>
>> Thanks,
>>
>> -Joe
>>
>>
>> On 8/25/2016 9:56 PM, Stuart Marks wrote:
>>> Please review a small change appended below to add to the problem
>>> list a few
>>> tests that were tickled by jdeprscan. Note, the diff may look weird
>>> because of
>>> line wrapping, but the file has really long lines.
>>>
>>> Thanks,
>>>
>>> s'marks
>>>
>>> # HG changeset patch
>>> # User smarks
>>> # Date 1472187222 25200
>>> # Thu Aug 25 21:53:42 2016 -0700
>>> # Node ID 3397ac219627fe059b93640d886e2d072a48e7ad
>>> # Parent 871b60b0c0917d9c657744a57dfa525b96bf5149
>>> 8164835: add a few tools tests to the problem list
>>> Reviewed-by: darcy
>>>
>>> diff -r 871b60b0c091 -r 3397ac219627 test/ProblemList.txt
>>> --- a/test/ProblemList.txt Thu Aug 25 17:58:39 2016 -0700
>>> +++ b/test/ProblemList.txt Thu Aug 25 21:53:42 2016 -0700
>>> @@ -78,3 +78,10 @@
>>> #
>>> # jdeps
>>>
>>> +###########################################################################
>>>
>>> +#
>>> +# jdeprscan
>>> +
>>> +tools/all/RunCodingRules.java 8164836 generic-all fix @DefinedBy
>>> +tools/jdeprscan/tests/jdk/jdeprscan/TestLoad.java 8164837 windows-all
>>> probably line breaks or encoding
>>> +tools/jdeprscan/tests/jdk/jdeprscan/TestScan.java 8164837 windows-all
>>> probably line breaks or encoding
>>
More information about the jdk9-dev
mailing list