RFR #2 (M) 8148146: Integrate new internal Unsafe entry points, and basic intrinsic support for VarHandles

[Andrew Dinn]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 17/02/16 11:24, Aleksey Shipilev wrote:
> On 02/17/2016 12:29 AM, Andrew Dinn wrote:
>> Unfortunately, the graphs are not quite the same and that
>> affects the generated code on AArch64 even though it has no
>> visible effect on x86. The critical difference is that for
>> volatile puts and gets you have omitted to insert the
>> MemBarRelease and MemBarAcquire nodes.
> 
> Dang. You are right, I have mistranslated the original code.
> Thanks for catching this one!
> 
> New version that includes a variant of your fix, and also trims 
> down on Unsafe changes, as John suggested in a separate thread: 
> http://cr.openjdk.java.net/~shade/8148146/webrev.hs.02/ 
> http://cr.openjdk.java.net/~shade/8148146/webrev.jdk.02/
> 
> This version still passes JPRT, microbenchmark results are fine. I 
> am respinning other tests to see if anything is broken.

Thanks, Aleksey. I'll rerun with this new patch and report back.

> P.S. Andrew, if you have before/after builds for AArch64 and a 
> suitable physical rig, you might be interested to run Unsafe 
> benchmarks (this is a JMH runnable JAR): 
> http://cr.openjdk.java.net/~shade/varhandles/unsafe-bench.jar

Sure, I'll do that too.

regards,


Andrew Dinn
- -----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul
Argiry (US)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWxFmwAAoJEGnaNq4xxcSzJgwH/1lGXyxT922uAybjNkv7nhox
FbjH/yZndlTlEEq7LkWVISolHg2nudvD65d0PBPMuBU90jRayhLrF3rHCjJy7k6M
aD5Elk/rje/p88ZD54sPwfDGJdVGFXQCAx0u/eV6jOhbvGNARlH0EnVtnsV1ADpC
BVOsfKOMb55PJWWslaZ9p0vL4zUHDanbcQgUWBpFMg44CDyln4UmyY/xRtPNbWKQ
lG7wYc0XAwmG4EKLFDRa2N6PmKSfwubXDOToXR03R/tU5orhWVm7wq+C0FZewodN
+91GQvIPlQS4iQ/TZpjX8jAgowFBNxHHAerv1LJcZC7Ji7zGmJnG/Dn5NDKutOw=
=oLN2
-----END PGP SIGNATURE-----