RFR #2 (M) 8148146: Integrate new internal Unsafe entry points, and basic intrinsic support for VarHandles

[Aleksey Shipilev]

On 02/17/2016 10:16 PM, Vladimir Kozlov wrote:
> In general it looks good to me. 

Thanks Vladimir!

> My main question is about implementation of new functionality on
> other platforms. When it will be done? Yes, it works now because you
> have guard match_rule_supported(). But we usually do implementation
> on platforms at least as separate RFE. What is your plan?

We have multiple subtasks for AArch64, SPARC and Power under VarHandles
umbrella:
  https://bugs.openjdk.java.net/browse/JDK-8080588

Hopefully we will address them after/concurrently-with the bulk of
VarHandles changes settle into mainline. But we need to get some basic
code in mainline to build on.


> SAP guys should also test it on PPC64.

Volker, Goetz, I would appreciate if you can give it a spin!


> What test/compiler/unsafe/generate-unsafe-tests.sh is for? It is not
> used by regression testing as far as I see.

The script (re)generates the tests from the template, and is supposed to
be run manually when test template had changed. The
test/compiler/unsafe/ tests you see in the webrev were generated by that
script.

> And please, push it into hs-comp for nightly testing.

That's was the plan, I should have said that from the beginning.

Cheers,
-Aleksey