RFR: 8136494 Update "@since 1.9" to "@since 9" to match java.specification.version

[Iris Clark]

Thanks!

iris

 

From: Lance @ Oracle 
Sent: Tuesday, January 19, 2016 3:08 PM
To: Iris Clark
Cc: jdk9-dev at openjdk.java.net; verona-dev at openjdk.java.net
Subject: Re: RFR: 8136494 Update "@since 1.9" to "@since 9" to match java.specification.version

 

Hi iris

 

Looks fine

 

Best

Lance

HYPERLINK "http://oracle.com/us/design/oracle-email-sig-198324.gif"
Lance Andersen| Principal Member of Technical Staff | HYPERLINK "tel:+1.781.442.2037"+1.781.442.2037
Oracle Java Engineering 
HYPERLINK "x-apple-data-detectors://34/0"1 Network Drive
HYPERLINK "x-apple-data-detectors://34/0"Burlington, MA 01803
HYPERLINK "mailto:Lance.Andersen at oracle.com"Lance.Andersen at oracle.com

Sent from my iPad


On Jan 19, 2016, at 6:00 PM, Iris Clark <HYPERLINK "mailto:iris.clark at oracle.com"iris.clark at oracle.com> wrote:

Hi, Lance.

Just getting back to this bug.

Here's the updated webrev:

 http://cr.openjdk.java.net/~iris/verona/8136494/webrev.1/

I've sync'd with jdk9/dev as of this morning and verified
that only expected changes are in the new patch.

Thanks,
iris

-----Original Message-----
From: Iris Clark 
Sent: Thursday, January 07, 2016 9:06 AM
To: Lance Andersen
Cc: HYPERLINK "mailto:jdk9-dev at openjdk.java.net"jdk9-dev at openjdk.java.net; HYPERLINK "mailto:verona-dev at openjdk.java.net"verona-dev at openjdk.java.net
Subject: RE: RFR: 8136494 Update "@since 1.9" to "@since 9" to match java.specification.version

Hi, Lance.

Thanks for the review.

I was a bit puzzled by the code you quoted back since it relates to the recent move of VM class, which I didn't touch.   It appears that my forest was not sufficiently up-to-date with respect to dev when I did the webrev.  The build I launched after I sent out the RFR failed. 

I'll fix the forest/webrev later today.

Regards,
iris


From: Lance Andersen
Sent: Thursday, January 07, 2016 4:35 AM
To: Iris Clark
Cc: HYPERLINK "mailto:jdk9-dev at openjdk.java.net"jdk9-dev at openjdk.java.net; HYPERLINK "mailto:verona-dev at openjdk.java.net"verona-dev at openjdk.java.net
Subject: Re: RFR: 8136494 Update "@since 1.9" to "@since 9" to match java.specification.version

Hi Iris,

I think the changes are OK.  I would suggest  making your description clear for your changes such as:

------

@@ -1019,7 +1019,7 @@
     * may be controlled by the {@code -XX:AutoBoxCacheMax=<size>} option.
     * During VM initialization, java.lang.Integer.IntegerCache.high property
     * may be set and saved in the private system properties in the
-     * jdk.internal.misc.VM class.
+     * sun.misc.VM class.
     */

-------

for your push.

Best
Lance