JDK 9 build with GCC 6.1.1
joe darcy
joe.darcy at oracle.com
Fri Jun 24 16:39:52 UTC 2016
Hello,
Yes, please leave fdlibm alone. There is a chance I'll finish porting
fdlibm to more idiomatic Java code later in JDK 9 (JDK-8134780).
Thanks,
-Joe
On 6/24/2016 9:35 AM, Martin Buchholz wrote:
> For code maintained by openjdk, it seems best to fix misleading
> indentation warnings, as you are doing.
> For code maintained elsewhere (LCMS), it seems best to suppress
> warnings as you are doing, or fix them in LCMS upstream.
>
> In the code below you are changing the behavior of the code, which is
> very likely a mistake. fdlibm is an imported ancient library we
> should probably not be reformatting.
>
> --- old/src/java.base/share/native/libfdlibm/k_rem_pio2.c2016-06-25
> 00:08:16.467503269 +0900
> +++ new/src/java.base/share/native/libfdlibm/k_rem_pio2.c2016-06-25
> 00:08:16.122504578 +0900
> @@ -198,7 +198,9 @@
> /* compute q[0],q[1],...q[jk] */
> for (i=0;i<=jk;i++) {
> - for(j=0,fw=0.0;j<=jx;j++) fw += x[j]*f[jx+i-j]; q[i] = fw;
> + for (j=0,fw=0.0;j<=jx;j++) {
> + fw += x[j]*f[jx+i-j]; q[i] = fw;
> + }
> }
>
>
> On Fri, Jun 24, 2016 at 8:14 AM, Yasumasa Suenaga <yasuenag at gmail.com
> <mailto:yasuenag at gmail.com>> wrote:
>
> Hi all,
>
> I've tried to OpenJDK 9 build at Fedora 24 x64.
> Fedora 24 has GCC 6.1.1, and OpenJDK 9 build was failed.
>
> I fixed build error and several issues (VM crash and internal
> error) as below:
>
> hotspot:
> http://cr.openjdk.java.net/~ysuenaga/jdk9-for-gcc6/hotspot/
> <http://cr.openjdk.java.net/%7Eysuenaga/jdk9-for-gcc6/hotspot/>
> jdk: http://cr.openjdk.java.net/~ysuenaga/jdk9-for-gcc6/jdk/
> <http://cr.openjdk.java.net/%7Eysuenaga/jdk9-for-gcc6/jdk/>
>
> Does someone work for it?
> If no one works for it, I will file it to JBS and will send review
> request.
>
>
> Thanks,
>
> Yasumasa
>
>
More information about the jdk9-dev
mailing list