RFR [9] 8074716: IntelliJ IDEA project support
Staffan Larsen
staffan.larsen at oracle.com
Thu May 12 07:49:02 UTC 2016
This looks good to me.
One nuisance is that most jtreg tests do not use package names, so marking “jdk/test/“ as a Test Sources Root is not really correct. But finding out which folders should actually be marked as Test Sources Root is probably not easy.
/Staffan
> On 10 maj 2016, at 15:46, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
>
> Regarding jtreg, I removed jtreg support somewhere along the lines because it was not functioning properly (due to an IntelliJ issue that should be patched in the next release). I'll add back the support once I can make sure that things are working consistently.
>
> Cheers
> Maurizio
>
> On 04/05/16 10:18, Roger Riggs wrote:
>> Looks fine, it may need tweaks over time.
>>
>> Thanks, Roger
>>
>>
>> On 5/4/2016 8:21 AM, Chris Hegarty wrote:
>>> Thanks for looking at this Roger.
>>>
>>> Webrev updated in-place:
>>> http://cr.openjdk.java.net/~chegar/idea/
>>> On 2 May 2016, at 19:05, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>>>
>>>> Hi Chris,
>>>>
>>>> For navigation, it seems to work fine.
>>>>
>>>> It does add test source folders for test directories that do not exist (corba/test and jaxws/test).
>>>> Perhaps, omit them from the template.jdk.iml.
>>> Thanks, updated.
>>>
>>>> And it adds source folders to a quite a number of directories under build/<xxx>/support/gensrc
>>>> that do not exist. But I suppose it can not know they will never exist.
>>> Right, they don’t negatively affect the project.
>>>
>>>> idea.sh: 46 "--version" -> "--verbose"
>>>>
>>>> idea.gmk: 8 "specificaton" -> "specification"
>>>>
>>>> template/vcs.xml: uneven indentation
>>> Fixed.
>>>
>>>> I did not get the jtreg run option to work, it seemed to compile files with the wrong compiler
>>>> and tried to compile module-info.java files.
>>> I’ll take a closer look into this.
>>>
>>>> Still, I appreciate being able to use it for navigation and editing.
>>> Great. Thanks,
>>>
>>> -Chris.
>>>
>>>> Thanks, Roger
>>>>
>>>>
>>>>
>>>> On 4/29/2016 9:12 AM, Chris Hegarty wrote:
>>>>> A while back Maurizio announced a beta version of IntelliJ IDEA project
>>>>> support for OpenJDK [1]. We got some great feedback and have made
>>>>> several improvements since then. We believe that it is now suitable for
>>>>> integration into the mainline JDK 9 forests. To that end, please review
>>>>> the following changes:
>>>>>
>>>>> http://cr.openjdk.java.net/~chegar/idea/
>>>>>
>>>>> Summary:
>>>>>
>>>>> - To create a new project run 'bash common/bin/idea.sh [MODULE-NAME ]+'
>>>>> ( a configuration must exist, as the script leverages its state )
>>>>> This creates a project in the .idea directory of top-level repository.
>>>>> An optional, space separated, list of modules can be provided, in
>>>>> which case the project will contain sources for only the given modules.
>>>>> Otherwise, the project will contain the sources for all JDK modules.
>>>>> The project can be opened by pointing IntelliJ at the top-level
>>>>> directory.
>>>>>
>>>>> - A project generation script is necessary, to include platform
>>>>> specific code, and code generated into platform / spec specific
>>>>> locations. It is not practicable to create a static standard project.
>>>>>
>>>>> Further details on building and running tests were included in
>>>>> Maurizio's initial mail [1], so I won't repeat them here.
>>>>>
>>>>> -Chris.
>>>>>
>>>>> [1] http://mail.openjdk.java.net/pipermail/discuss/2015-January/003645.html
>>
>
More information about the jdk9-dev
mailing list