CFV: New JDK 9 Reviewer: Yasumasa Suenaga

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Tue May 17 14:50:58 UTC 2016


I meant to include the list of contributions as well. Find it at the bottom of 
this mail.

I actually think the CFV must include this list, or a link to it.
/Jesper

Den 17/5/16 kl. 16:48, skrev Jesper Wilhelmsson:
> Dmitry,
>
> When I looked at the list of contributions from Yasumasa I found 35 changesets.
> However, two of these were backed out so I don't think they can be included.
>
> Out of the 33 remaining, six are duplicates. With duplicate I mean that parts of
> the same change has been pushed to different repositories (e.g. jdk + hotspot).
> I don't think duplicates should be counted as two significant changes, but only
> one. In the CFV's I send out I always filter out duplicates.
>
> That leaves us with 27 changes which is unfortunately not enough to reach
> Reviewer status.
>
> Also, in general we recommend to hold off on the CFV until a contributor has
> made at least 40+ changes. This is because there are always a few changes that
> when put on the spot is difficult to consider as "significant" - especially
> since there is no real definition of what significant means. Looking through the
> list there are at least a few that I would not consider significant and since
> Yasumasa is so close to the threshold this matters.
>
> I would suggest to pull back this CFV until Yasumasa has a few more
> contributions in there.
>
> Thanks,
> /Jesper
>
>
> Den 17/5/16 kl. 13:20, skrev Dmitry Samersoff:
>> I hereby nominate Yasumasa Suenaga (ysuenaga) to JDK 9 Reviewer.
>>
>> Yasumasa has contributed 34 changeset to jdk 9. In particular, he has
>> been actively working in serviceability area, on serviceability tools
>> and diagnostic commands.
>>
>> Votes are due by 31 May 2016.
>>
>> Only current jdk9 Reviewers [1] are eligible to vote on this nomination.
>> Votes must be cast in the open by replying to this mailing list.
>>
>> For Three-Vote Consensus voting instructions, see [2].
>>
>> Dmitry.
>>
>> [1] http://openjdk.java.net/census
>> [2] http://openjdk.java.net/projects/#reviewer-vote
>>


(1) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/7aaaac143eb0
8081295: Build failed with GCC 5.1.1

(2) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/2559e1d816ae
8017773: OpenJDK7 returns incorrect TrueType font metrics

(3) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/37ac8a27a427
8057746: Cannot handle JdpException in JMX agent initialization.

(4) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/7a1afd6e36f0
8057556: JDP should better handle non-active interfaces

(5) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/3b81fac25d26
8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters

(6) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/ae70ccde5447
8156133: FindCrashesAction in HSDB does not work except Solaris platform

(7) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/22bf25cb9859
8156033: jhsdb jmap cannot set heapdump name

(8) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/7647b778662d
8153073: UL: Set filesize option with k/m/g

(9) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/d525d1232cdc
8155089: UL: Remove trailing comma from log decoration list

(10) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/ce1d4d0683ed
8152435: (CL)HSDB should be started with no argument

(11) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/a074585a9f08
8148659: Add all option to JSnap

(12) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/3635f6de52cf
8151709: jhsdb should show help message in SALauncher.

(13) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/508fcb923812
8151181: Add JSnap to jhsdb

(14) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/c364db766187
8147388: Add diagnostic commands to attach JVMTI agent.

(15) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/2b1a65dd865e
8144332: HSDB could not terminate when close button is pushed.

(16) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/4ca934c7547a
8144965: Show oop pointer in call frame at HSDB.

(17) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/37a97bb8b1ca
8140556: Add force rotation option to VM.log jcmd

(18) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/f08536ebf811
8072913: [REDO] GCCause should distinguish jcmd GC.run from System.gc()

(19) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/b1379cdd6933
8081475: SystemTap does not work when JDK is compiled with GCC 5

(20) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/e51e9b3040c3
8076212: AllocateHeap() and ReallocateHeap() should be inlined.

(21) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/904b2fb4a2f6
8150723: HSDB toolbar icons are missing.

(22) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/7923f573ee4c
8049253: Better GC validation

(23) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/30ed7423ae23
8059586: hs_err report should treat redirected core pattern

(24) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/b5748753ad2f
7090324: gclog rotation via external tool

(25) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/8ddc26f62476
6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending 
exceptions"

(26) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/c798c277ddd1
7015169: GC Cause not always set

(27) http://closedjdk.us.oracle.com/jdk9/hs/closed/rev/fc4b036db111
8036003: Add --with-debug-symbols=[none|internal|external|zipped]


—— Duplicates

(28) http://hg.openjdk.java.net/jdk9/hs/./rev/50a1521b75f9
8150723: HSDB toolbar icons are missing.

(29) http://hg.openjdk.java.net/jdk9/hs/./rev/aa66642d2fff
8036003: Add --with-debug-symbols=[none|internal|external|zipped]

(30) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/2053d6544876
8156033: jhsdb jmap cannot set heapdump name

(31) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/8fa63e27e764
8151674: STW phases at Concurrent GC should count in PerfCounter

(32) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/a67d225b677f
8151709: jhsdb should show help message in SALauncher.

(33) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/cba76eb01f49
8151181: Add JSnap to jhsdb


——— Backed out

(34) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/252b571bbb86
8151674: STW phases at Concurrent GC should count in PerfCounter

(35) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/5abc906fe3a8
8068589: GCCause should distinguish jcmd GC.run from System.gc()



More information about the jdk9-dev mailing list