CFV: New JDK 9 Committer: Amit Sapre

[David Holmes]

Vote: veto

Hi Jesper,

As discussed on IM I feel that the changes submitted to date fail to 
meet the criteria of "at least 8 significant contributions" and so this 
nomination is premature. I've outlined my view on each change below.

Please note that "significance" here is being taken as a measure of 
non-triviality of the fix (it's difficulty/complexity) not the 
importance of the issue being addressed.

On 8/11/2016 8:12 AM, Jesper Wilhelmsson wrote:
> I hereby nominate Amit Sapre (asapre) to JDK 9 Committer.
>
> Amit is part of the Monitoring and Management team and has contributed
> 11 changesets to JDK 9 [3].
>
> Votes are due by November 21, 2016.
>
> Only current JDK 9 Committers [1] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Three-Vote Consensus voting instructions, see [2].

Nit: that should be Lazy Consensus voting for Committers.

> Thanks,
> /Jesper
>
> [1] http://openjdk.java.net/census
> [2] http://openjdk.java.net/projects/#reviewer-vote
> [3] List of changes:
>
> (1) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/21d90fa8d825
> 8006078: [findbugs] java.lang.management.ThreadInfo returns mutable objects

Trivial fix to clone returned arrays.

> (2) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/016c12cbe397
>     http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/0207c729b674
> 8151099: java.lang.management.ManagementFactory.getPlatformMXBeans()
> should work even if jdk.management is not present.

OK.

> (3) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/ff9c1d07969e
> 8167294: MXBean javadoc should be updated to take modules into account

Minor doc update.

> (4) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/eb84b64427a4
> 8164730: Make it clear that 'cl' parameter passed to RMIConnector.OISWL
> is never null.

OK (2) - trivial fix but more elaborate test.

> (5) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/38f2b4b3828d
> 8165579: Add missing javadoc information for javax.management.MBeanServer

Trivial doc adjustments.

> (6) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/f7eb17f55377
> 8164609: javax/management/remote/mandatory/notif/DeadListenerTest.java
> fails with Assertion Error

Trivial test fix.

> (7) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/1743b2c51f51
> 8066635: Fix deprecation warnings in java.management module

OK (3)

> (8) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/5d5653c5bcab
> 8162530:
> src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c
> doesn't handle JNI exceptions properly

Simple code fix to add exception checks in a few places.

> (9) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/8f1d366691a2
> 8162702: com.sun.management.internal.GcInfoBuilder.getPoolNames should
> not return reference of it's private member

Trivial change to clone returned array.	

> (10) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/9a0ef04757f9
> 8162524: src/jdk.management/share/native/libmanagement_ext/Flag.c
> doesn't handle JNI exceptions

Simple code fix to check for NULL return.

> (11) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/2047f466a705
> 8158350: Table in ThreadInfo.from(CompositeData) may need updates for
> new stack trace attributes

Simple doc update.

Thanks,
David