CFV: New JDK 9 Committer: Sharath Ballal

[David Holmes]

Vote: veto

Hi Jesper,

As discussed on IM I feel that the changes submitted to date fail to 
meet the criteria of "at least 8 significant contributions" and so this 
nomination is premature. I've outlined my view on each change below.

Please note that "significance" here is being taken as a measure of 
non-triviality of the fix (it's difficulty/complexity) not the 
importance of the issue being addressed.


On 8/11/2016 8:12 AM, Jesper Wilhelmsson wrote:
> I hereby nominate Sharath Ballal (sballal) to JDK 9 Committer.
>
> Sharath is part of the Monitoring and Management team and has
> contributed 13 changesets to JDK 9 [3].
>
> Votes are due by November 21, 2016.
>
> Only current JDK 9 Committers [1] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Three-Vote Consensus voting instructions, see [2].
>
> Thanks,
> /Jesper
>
> [1] http://openjdk.java.net/census
> [2] http://openjdk.java.net/projects/#reviewer-vote
> [3] List of changes:
>
> (1) http://hg.openjdk.java.net/jdk9/hs/rev/106f2f8b0ec9
>     http://hg.openjdk.java.net/jdk9/hs/jdk/rev/02651d14d282
>     http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/2e21095f80c6
> 8158050: Remove SA-JDI

Ok.

> (2) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/71457eaca096
> 8168397: sun/tools/jhsdb/HeapDumpTest.java timesout on MacOS X on non
> images build

Trivial edit of ProblemList.txt

> (3) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/7a5fa747419d
>     http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/ad402ced3a63
> 8160376: DebuggerException: Can't attach symbolicator to the process

Simple build change and ProblemList update.

> (4) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/9d4a52d62493
> 8166657: Remove exports com.sun.tools.jdi to jdk.hotspot.agent

Trivial edit of module-info.java

> (5) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/03e9322dc0a5
> 8164943: sun/tools/jhsdb/HeapDumpTest failed with Can't find library:
> /test/lib/share/classes

Simple test annotation change.

> (6) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/659f01da7ec0
>     http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/b50061da090e
> 8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of
> timeout.

Ok (2)

> (7) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/ecc9399771ac
>     http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/a2812668bf38
> 8160817: Add jsadebugd functionality to jhsdb

Ok (3)


> (8) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/73608cd4f89a
> 8154144: Tests in com/sun/jdi fails intermittently with "jdb input
> stream closed prematurely"

Ok (4)

> (9) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/b58e7a5634e8
>     http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/7fbe91178ff9
> 8147456: Parsing of argument for -agentpath can write outside of
> allocated memory

Ok (5)

> (10) http://hg.openjdk.java.net/jdk9/hs/jdk/rev/e260a6ff2110
> 6659240: Exceptions thrown by MXBeans wrongly documented in
> j.l.m.ManagementFactory

Simple doc fix.

> (11) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/776d89e316b6
> 8165537: runtime/SharedArchiveFile/SASymbolTableTest.java fails with
> NullPointerException

Ok (6)

> (12) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/c54ebf67ef13
> 8165114: stale reference to hotspot test Test8028623.java

Trivial edit of TEST.groups

> (13) http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/37ce5a8e59cc
> 8163269: Testcase missed in push for JDK-8160817

Missed test case from previous push, so doesn't count as another 
contribution.

Thanks,
David