RFR: JDK9 message drop interim L10n resource update

[Leo Jiang]

Oh, I got what's you mean. For this issue, it was caused by the tools in the translation workflow. We have discussed 
with them but can't fix this. Let me try to figure out a solution if we can do it on our side.

Thanks,
Leo

On 11/16/2016 03:02 PM, Robert Field wrote:
> Yes, thank you shinyafox!
>
> Leo, I had the same problem attempting to review this time and previously (and I have brought it up before).
> Somewhere in the translation process multi-line properties are all strung together onto a single line.
> In the case of the help properties this is a problem.  But for the startup.feedback properties it is a serious problem —
> this property is 87 lines of commands, translated incorrectly they could cause startup errors and unexpected behavior.
> But, as-is, they can’t reasonably be reviewed because these 87 lines have turned into two lines, so you can’t see what
> has changed.
>
> Thanks,
> Robert
>
>
>> On Nov 15, 2016, at 10:34 PM, Leo Jiang <li.jiang at oracle.com <mailto:li.jiang at oracle.com>> wrote:
>>
>> Hi Shinya,
>>
>> Thank you for your review and your patch.
>>
>> If you can highlight the errors, it's enough for me to report them to translation team.
>>
>> BTW, sorry, I can't catch you what's you mean "breaking lines like startup.feedback does so in
>> jdk/internal/jshell/tool/resources/l10n.properties." Would you explain it more clear?
>>
>> Thanks,
>> Leo
>>
>>
>> On 11/16/2016 12:47 PM, ShinyaYoshida wrote:
>>> Hi Leo,
>>> Thank you for updating translation.
>>> In jshell, the most becomes better than previous one!
>>>
>>> I've noticed incorrect word order in jshell translation:
>>> jshell> /set feedback verbose
>>> |  フィードバック・モード: verbose
>>>
>>> jshell> int n = 0
>>> n ==> 0
>>> |  次を作成しました: 変数 n : int
>>>
>>> jshell> n = 0
>>> n ==> 0
>>> |  nに割り当てられました : int
>>>
>>> jshell> n
>>> n ==> 0
>>> |  nの値: int
>>>
>>> jshell> void m(C c) {}
>>> |  次を作成しました: メソッド m(C)まで、参照できません。しかし、 class Cが宣言される
>>>
>>> (1): The type name goes far from the variable name.
>>> (2): "まで、参照できません。しかし、 class Cが宣言される" has incorrect order.
>>>
>>> They should be following:
>>> jshell> /set feedback verbose
>>> |  フィードバック・モード: verbose
>>>
>>> jshell> int n = 0
>>> n ==> 0
>>> |  次を作成しました: 変数 n : int
>>>
>>> jshell> n = 0
>>> n ==> 0
>>> |  n : intに割り当てられました
>>>
>>> jshell> n
>>> n ==> 0
>>> |  n : intの値
>>>
>>> jshell> void m(C c) {}
>>> |  次を作成しました: メソッド m(C)。しかし、 class Cが宣言されるまで、参照できません
>>>
>>> Here is fix: http://cr.openjdk.java.net/~shinyafox/kulla/8169618/l10n_ja.properties.patch.wdiff
>>> This is a wdiff against your udiff at the last 3 lines of
>>> langtools/src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_ja.properties.
>>>
>>> For maintainability, I'd like to suggest breaking lines like startup.feedback does so
>>> in jdk/internal/jshell/tool/resources/l10n.properties.
>>>
>>> Regards,
>>> shinyafox(Shinya Yoshida)
>>>
>>>
>>> 2016-11-14 15:09 GMT+09:00 Leo Jiang <li.jiang at oracle.com <mailto:li.jiang at oracle.com> <mailto:li.jiang at oracle.com>>:
>>>
>>>    Hi,
>>>
>>>    Please review:
>>>    Webrev:
>>>    http://cr.openjdk.java.net/~ljiang/8169618/webrev/read/<http://cr.openjdk.java.net/~ljiang/8169618/webrev/read/>
>>>
>>>    for bug:
>>>    https://bugs.openjdk.java.net/browse/JDK-8169618 <https://bugs.openjdk.java.net/browse/JDK-8169618>
>>>
>>>    Please help us to review
>>>     - over-translate, e.g. keywords should be not translated
>>>     - not-translate, e.g. some sentences or strings are not translated while they should be.
>>>     - any programming syntax error
>>>     - multiple lines property with correct line ending '\n\'
>>>     - the position of placefolder after translation
>>>     - any other issues.
>>>
>>>    Thanks,
>>>    Leo
>