java launcher option -d32/-d64

[Jesper Wilhelmsson]

Den 21/9/16 kl. 15:14, skrev Kumar Srinivasan:
>
> On 9/21/2016 1:17 AM, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> I think this is a good change. If a flag doesn't make sense anymore we must
>> have the guts to remove it. We have way too many command line flags to be
>> sentimental about them.
>>
>> Updating all our tests that use the flag must of course be part of the work
>> done to remove the flag. This is something that Kumar needs to take into
>> account and staff when planning this work.
>>
>> Updating scripts and other frameworks that are not part of our shared source
>> base can obviously not be part of the work, but will have to be done by the
>> maintainers of the scripts and frameworks. This is unfortunate but we can't
>> let that stand in the way of a good change. Especially in a major release I
>> think this is the kind of changes one have to allow.
>>
>> One question though, should the flag be deprecated for one release before
>> removing?
>
> That is the standard rule, ie. deprecate for one major release, launcher
> perhaps should perhaps accept the flags for jdk9 with a warning, and
> remove it in jdk10.

That would give people some time to clean up their scripts at least. I think 
that is a good approach.

Make sure you run through all tests in jdk/test and hotspot/test before pushing. 
(And there are likely other test lists that needs to be verified as well.) I'd 
assume that many of our tests will be surprised by the new warning.

Thanks,
/Jesper

>
> Kumar
>
>>
>> /Jesper
>>
>>
>> Den 21/9/16 kl. 05:08, skrev David Holmes:
>>> On 21/09/2016 8:29 AM, Kumar Srinivasan wrote:
>>>> Hi Claes,
>>>>
>>>>> Hi Kumar,
>>>>>
>>>>> what do you intend the outcome to be if someone specifies -d32 or -d64,
>>>>> respectively? Simply ignore it, print a warning - or fail?
>>>>
>>>> Fail.
>>>
>>> That could cause problems for a lot of existing tests I think.
>>>
>>> David
>>>
>>>>>
>>>>> I know a number of scripts and tools which use -d64 for backwards
>>>>> compatibility with JDK 7, so if it's not too much trouble to keep at
>>>>> least the -d64 flag until 10, i.e., simply accept the option and do
>>>>> nothing, I for one would have less things to worry about.
>>>>
>>>> I thought as much, but wanted to check anyway, will keep in mind.
>>>>
>>>> Kumar
>>>>
>>>>>
>>>>> Thanks!
>>>>>
>>>>> /Claes
>>>>>
>>>>> On 2016-09-20 23:53, Kumar Srinivasan wrote:
>>>>>> Hello,
>>>>>>
>>>>>> The java launcher supports the options -d32 and -d64, primarily to
>>>>>> allow the user to choose and launch 32bit or 64bit JRE, in a
>>>>>> Solaris dual mode. However, since jdk8, the only supported configuration
>>>>>> for
>>>>>> Solaris is 64bit .
>>>>>>
>>>>>> Therefore, Is there a need for the launcher to support them  ? If so
>>>>>> please let me know, as soon as possible, otherwise I will plan on
>>>>>> removing
>>>>>> the support for these options in jdk9.
>>>>>>
>>>>>> Thanks
>>>>>> Kumar
>>>>>>
>>>>
>