From npathak2 at ncsu.edu Tue Aug 1 23:36:12 2017 From: npathak2 at ncsu.edu (Neetish Pathak) Date: Tue, 1 Aug 2017 16:36:12 -0700 Subject: TLS 1.3 support in JDK Message-ID: Hello all, I am new to JDK development mailing list. 21 drafts fro TLS 1.3 have come out so far. Is there any ongoing work on including TLS 1.3 in JDK. If so, please refer. TLS 1.3 has been implemented in OpenSSL. Is there any way to use OpenSSL in java in place of in-built SSL library. Thanks Best Regards, Neetish From david.holmes at oracle.com Wed Aug 2 01:09:28 2017 From: david.holmes at oracle.com (David Holmes) Date: Wed, 2 Aug 2017 11:09:28 +1000 Subject: TLS 1.3 support in JDK In-Reply-To: References: Message-ID: <77390d7b-9843-db7f-465d-5b685a389ac6@oracle.com> Hi, On 2/08/2017 9:36 AM, Neetish Pathak wrote: > Hello all, > I am new to JDK development mailing list. 21 drafts fro TLS 1.3 have come > out so far. Is there any ongoing work on including TLS 1.3 in JDK. If so, > please refer. > > TLS 1.3 has been implemented in OpenSSL. Is there any way to use OpenSSL in > java in place of in-built SSL library. I suggest asking in security-dev at openjdk.java.net. David > Thanks > Best Regards, > Neetish > From philip.race at oracle.com Wed Aug 2 01:45:37 2017 From: philip.race at oracle.com (philip.race at oracle.com) Date: Wed, 2 Aug 2017 01:45:37 GMT Subject: jdk9-b181: dev Message-ID: <201708020145.v721jbsg018658@scaaa563.us.oracle.com> http://hg.openjdk.java.net/jdk9/jdk9/rev/b656dea9398e http://hg.openjdk.java.net/jdk9/jdk9/nashorn/rev/47f8d75b8765 http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/5ecbed313125 http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/bd66ea2fdde3 http://hg.openjdk.java.net/jdk9/jdk9/jaxws/rev/4f852cc3a1c9 http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/ea18d767c9ec http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/4a443796f6f5 http://hg.openjdk.java.net/jdk9/jdk9/corba/rev/ba71941ad9db --- All the fixes will be tested during promotion (no PIT testing at this point): List of all fixes: =================== JDK-8185133 hotspot Reference pending list root might not get marked From david.holmes at oracle.com Fri Aug 4 01:57:03 2017 From: david.holmes at oracle.com (David Holmes) Date: Fri, 4 Aug 2017 11:57:03 +1000 Subject: RFR 8158039 VarHandle float/double field/array access should support CAS/set/add atomics In-Reply-To: References: Message-ID: <0743397d-3fcb-5918-2816-c968f5fd52ed@oracle.com> Catching up after very long vacation. For the record I still think this is misguided. The only atomic op you can do with float/double is a CAS (and that doesn't operate at the semantic level only raw bits). Everything else has to be emulated by CAS-loop as no hardware support for atomic FP ops exists. We made a deliberate choice not to support float/double in j.u.c.atomic back with JSR-166 and _nothing_ has changed since then. Regards, David ----- Paul Sandoz paul.sandoz at oracle.com Tue Jun 14 00:12:14 UTC 2016 > Hi, > > Here is an updated webrev. > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8158039-float-double-field-array-cas.jdk/webrev/ > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8158039-float-double-field-array-cas.hotspot/webrev/ > > Changes > > - the Unsafe.getAndAdd for float/double operate in the bit-domain. > > - documentation added to the factory methods: > > 1221 *

> 1222 * If the field type is {@code float} or {@code double} then numeric > 1223 * and atomic update access modes compare values using their bitwise > 1224 * representation (see {@link Float#floatToRawIntBits} and > 1225 * {@link Double#doubleToRawLongBits}, respectively). > 1226 *

> 1227 * @apiNote > 1228 * Bitwise comparison of {@code float} values or {@code double} values, > 1229 * as performed by the numeric and atomic update access modes, differ > 1230 * from the primitive {@code ==} operator and the {@link Float#equals} > 1231 * and {@link Double#equals} methods, notably with respect to > 1232 * {@code NaN}. There are many possible NaN values that are considered > 1233 * to be {@code NaN} in Java, although no IEEE 754 floating-point > 1234 * operation provided by Java can distinguish between them. As such > 1235 * care should be taken when performing a compare and set or a compare > 1236 * and exchange operation with NaN values since the operation may > 1237 * unexpectedly fail. Failure can occur if the expected or witness > 1238 * value is a NaN value and it is transformed (perhaps in a platform > 1239 * specific manner) into another NaN value, and thus has a different > 1240 * bitwise representation (see {@link Float#intBitsToFloat} or > 1241 * Double#longBitsToDouble for more details). > > (I also updated the documentation on array/ByteBuffer view methods but did not bother with the api note) > > Paul. From david.holmes at oracle.com Fri Aug 4 01:58:54 2017 From: david.holmes at oracle.com (David Holmes) Date: Fri, 4 Aug 2017 11:58:54 +1000 Subject: RFR 8158039 VarHandle float/double field/array access should support CAS/set/add atomics In-Reply-To: <0743397d-3fcb-5918-2816-c968f5fd52ed@oracle.com> References: <0743397d-3fcb-5918-2816-c968f5fd52ed@oracle.com> Message-ID: <83f820ea-f12e-6657-c558-0215d6bf402a@oracle.com> Please ignore :) I was "catching up" with year old email. :D Same sentiment applies though. David On 4/08/2017 11:57 AM, David Holmes wrote: > Catching up after very long vacation. > > For the record I still think this is misguided. The only atomic op you > can do with float/double is a CAS (and that doesn't operate at the > semantic level only raw bits). Everything else has to be emulated by > CAS-loop as no hardware support for atomic FP ops exists. > > We made a deliberate choice not to support float/double in j.u.c.atomic > back with JSR-166 and _nothing_ has changed since then. > > Regards, > David > ----- > > Paul Sandoz paul.sandoz at oracle.com > Tue Jun 14 00:12:14 UTC 2016 >> Hi, >> >> Here is an updated webrev. >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8158039-float-double-field-array-cas.jdk/webrev/ >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8158039-float-double-field-array-cas.hotspot/webrev/ >> >> >> Changes >> >> - the Unsafe.getAndAdd for float/double operate in the bit-domain. >> >> - documentation added to the factory methods: >> >> 1221 *

>> 1222 * If the field type is {@code float} or {@code double} >> then numeric >> 1223 * and atomic update access modes compare values using >> their bitwise >> 1224 * representation (see {@link Float#floatToRawIntBits} and >> 1225 * {@link Double#doubleToRawLongBits}, respectively). >> 1226 *

>> 1227 * @apiNote >> 1228 * Bitwise comparison of {@code float} values or {@code >> double} values, >> 1229 * as performed by the numeric and atomic update access >> modes, differ >> 1230 * from the primitive {@code ==} operator and the {@link >> Float#equals} >> 1231 * and {@link Double#equals} methods, notably with >> respect to >> 1232 * {@code NaN}. There are many possible NaN values that >> are considered >> 1233 * to be {@code NaN} in Java, although no IEEE 754 >> floating-point >> 1234 * operation provided by Java can distinguish between >> them. As such >> 1235 * care should be taken when performing a compare and set >> or a compare >> 1236 * and exchange operation with NaN values since the >> operation may >> 1237 * unexpectedly fail. Failure can occur if the expected >> or witness >> 1238 * value is a NaN value and it is transformed (perhaps in >> a platform >> 1239 * specific manner) into another NaN value, and thus has >> a different >> 1240 * bitwise representation (see {@link >> Float#intBitsToFloat} or >> 1241 * Double#longBitsToDouble for more details). >> >> (I also updated the documentation on array/ByteBuffer view methods but >> did not bother with the api note) >> >> Paul. > From roman.shevchenko at jetbrains.com Tue Aug 8 18:20:39 2017 From: roman.shevchenko at jetbrains.com (Roman Shevchenko) Date: Tue, 8 Aug 2017 20:20:39 +0200 Subject: quoting and escaping in java @argfiles Message-ID: Hello, is it possible to use @argfiles to pass main class parameters which may contain any sort of special cases described in [1] (double quotes, leading hash signs, etc.)? A backslash doesn't seem to work as a general escape symbol - e.g. the line `\#not-a-comment` is still ignored by the launcher. [1] https://docs.oracle.com/javase/9/tools/java.htm#JSWOR-GUID-4856361B-8BFD-4964-AE84-121F5F6CF111 -- Roman Shevchenko JetBrains http://www.jetbrains.com The Drive to Develop From jonathan.gibbons at oracle.com Tue Aug 8 18:36:53 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 08 Aug 2017 11:36:53 -0700 Subject: quoting and escaping in java @argfiles In-Reply-To: References: Message-ID: <598A04C5.1010207@oracle.com> Yes, @-files should support this. Escape sequences are only allowed in quoted strings, and strings can be quoted with either single or double quotes (' or "). It is not clear from the example in your message whether the back-ticks (`) were meant to enclose the example or as part of the example. -- Jon On 08/08/2017 11:20 AM, Roman Shevchenko wrote: > Hello, > > is it possible to use @argfiles to pass main class parameters which may > contain any sort of special cases described in [1] (double quotes, leading > hash signs, etc.)? A backslash doesn't seem to work as a general escape > symbol - e.g. the line `\#not-a-comment` is still ignored by the launcher. > > [1] > https://docs.oracle.com/javase/9/tools/java.htm#JSWOR-GUID-4856361B-8BFD-4964-AE84-121F5F6CF111 > From roman.shevchenko at jetbrains.com Tue Aug 8 19:24:05 2017 From: roman.shevchenko at jetbrains.com (Roman Shevchenko) Date: Tue, 8 Aug 2017 21:24:05 +0200 Subject: quoting and escaping in java @argfiles In-Reply-To: <598A04C5.1010207@oracle.com> References: <598A04C5.1010207@oracle.com> Message-ID: I see. It didn?t occur to me that the escaping only works inside the quotes. Back-ticks were meant to enclose the example, Markdown-style. Thanks! > On 8. Aug 2017, at 20:36, Jonathan Gibbons wrote: > > Yes, @-files should support this. > > Escape sequences are only allowed in quoted strings, and strings can be quoted with either > single or double quotes (' or "). > > It is not clear from the example in your message whether the back-ticks (`) were meant to enclose > the example or as part of the example. > > -- Jon > > On 08/08/2017 11:20 AM, Roman Shevchenko wrote: >> Hello, >> >> is it possible to use @argfiles to pass main class parameters which may >> contain any sort of special cases described in [1] (double quotes, leading >> hash signs, etc.)? A backslash doesn't seem to work as a general escape >> symbol - e.g. the line `\#not-a-comment` is still ignored by the launcher. >> >> [1] >> https://docs.oracle.com/javase/9/tools/java.htm#JSWOR-GUID-4856361B-8BFD-4964-AE84-121F5F6CF111 >> > From jonathan.gibbons at oracle.com Tue Aug 8 19:34:08 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 08 Aug 2017 12:34:08 -0700 Subject: quoting and escaping in java @argfiles In-Reply-To: References: <598A04C5.1010207@oracle.com> Message-ID: <598A1230.3050209@oracle.com> The "escape in quotes" rule is meant to simplify the use of file paths on Windows, like C:\Users\jjg\Desktop such that you can use \ in a path without having to quote it. -- Jon On 08/08/2017 12:24 PM, Roman Shevchenko wrote: > I see. It didn?t occur to me that the escaping only works inside the > quotes. > > Back-ticks were meant to enclose the example, Markdown-style. > > Thanks! > >> On 8. Aug 2017, at 20:36, Jonathan Gibbons >> > wrote: >> >> Yes, @-files should support this. >> >> Escape sequences are only allowed in quoted strings, and strings can >> be quoted with either >> single or double quotes (' or "). >> >> It is not clear from the example in your message whether the >> back-ticks (`) were meant to enclose >> the example or as part of the example. >> >> -- Jon >> >> On 08/08/2017 11:20 AM, Roman Shevchenko wrote: >>> Hello, >>> >>> is it possible to use @argfiles to pass main class parameters which may >>> contain any sort of special cases described in [1] (double quotes, >>> leading >>> hash signs, etc.)? A backslash doesn't seem to work as a general escape >>> symbol - e.g. the line `\#not-a-comment` is still ignored by the >>> launcher. >>> >>> [1] >>> https://docs.oracle.com/javase/9/tools/java.htm#JSWOR-GUID-4856361B-8BFD-4964-AE84-121F5F6CF111 >>> >> > From sean.coffey at oracle.com Wed Aug 9 13:14:21 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 9 Aug 2017 14:14:21 +0100 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov Message-ID: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> I hereby nominate Dmitry Markov (dmarkov) to JDK 9 Reviewer. Dmitry Markov is an engineer in the Oracle JDK sustaining team. He has contributed several changes to the JDK 9 Project [3] and is already a Reviewer in the JDK 10 Project. Votes are due by 15:00 GMT, 23rd August 2017. Only current JDK 9 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [2]. regards, Sean. [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#reviewer-vote [3] http://hg.openjdk.java.net/jdk9/jdk9/jdk/log?revcount=100&rev=(keyword(%22dmitry.markov at oracle.com%22)+or+author(dmarkov)) From daniel.fuchs at oracle.com Wed Aug 9 13:30:45 2017 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Wed, 9 Aug 2017 14:30:45 +0100 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov In-Reply-To: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> References: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> Message-ID: <054d14f7-d4af-d15d-07ee-b3449c4839ed@oracle.com> Vote: yes -- daniel On 09/08/2017 14:14, Se?n Coffey wrote: > I hereby nominate Dmitry Markov (dmarkov) to JDK 9 Reviewer. From mark.reinhold at oracle.com Wed Aug 9 15:26:48 2017 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 9 Aug 2017 08:26:48 -0700 (PDT) Subject: JDK 9: First Release Candidate Message-ID: <20170809152648.DDEDF98C6C@eggemoggin.niobe.net> There are no unresolved P1 bugs in build 181, so that is our first JDK 9 Release Candidate. Binaries available here, as usual: http://jdk.java.net/9 - Mark From serguei.spitsyn at oracle.com Wed Aug 9 21:06:09 2017 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 9 Aug 2017 14:06:09 -0700 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov In-Reply-To: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> References: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> Message-ID: Vote: yes From sean.coffey at oracle.com Wed Aug 9 21:12:10 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 9 Aug 2017 22:12:10 +0100 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov In-Reply-To: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> References: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> Message-ID: <671958b6-70b2-afb0-1214-c3157ef343a1@oracle.com> Vote: yes regards, Sean. On 09/08/2017 14:14, Se?n Coffey wrote: > I hereby nominate Dmitry Markov (dmarkov) to JDK 9 Reviewer. > > Dmitry Markov is an engineer in the Oracle JDK sustaining team. He has > contributed several changes to the JDK 9 Project [3] and is already a > Reviewer in the JDK 10 Project. > > Votes are due by 15:00 GMT, 23rd August 2017. > > Only current JDK 9 Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > http://hg.openjdk.java.net/jdk9/jdk9/jdk/log?revcount=100&rev=(keyword(%22dmitry.markov at oracle.com%22)+or+author(dmarkov)) > From xuelei.fan at oracle.com Wed Aug 9 22:59:59 2017 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 9 Aug 2017 15:59:59 -0700 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov In-Reply-To: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> References: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> Message-ID: <6a55ed0d-afc8-1293-12ea-c6da91c7b44c@oracle.com> Vote: Yes. Xuelei On 8/9/2017 6:14 AM, Se?n Coffey wrote: > I hereby nominate Dmitry Markov (dmarkov) to JDK 9 Reviewer. > > Dmitry Markov is an engineer in the Oracle JDK sustaining team. He has > contributed several changes to the JDK 9 Project [3] and is already a > Reviewer in the JDK 10 Project. > > Votes are due by 15:00 GMT, 23rd August 2017. > > Only current JDK 9 Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > http://hg.openjdk.java.net/jdk9/jdk9/jdk/log?revcount=100&rev=(keyword(%22dmitry.markov at oracle.com%22)+or+author(dmarkov)) > > From ivan.gerasimov at oracle.com Thu Aug 10 01:21:31 2017 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 9 Aug 2017 18:21:31 -0700 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov In-Reply-To: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> References: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> Message-ID: Vote: Yes On 8/9/17 6:14 AM, Se?n Coffey wrote: > I hereby nominate Dmitry Markov (dmarkov) to JDK 9 Reviewer. > > Dmitry Markov is an engineer in the Oracle JDK sustaining team. He has > contributed several changes to the JDK 9 Project [3] and is already a > Reviewer in the JDK 10 Project. > > Votes are due by 15:00 GMT, 23rd August 2017. > > Only current JDK 9 Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > http://hg.openjdk.java.net/jdk9/jdk9/jdk/log?revcount=100&rev=(keyword(%22dmitry.markov at oracle.com%22)+or+author(dmarkov)) > > -- With kind regards, Ivan Gerasimov From vincent.x.ryan at oracle.com Thu Aug 10 12:31:25 2017 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 10 Aug 2017 13:31:25 +0100 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov In-Reply-To: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> References: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> Message-ID: <9FB4BBD1-A8C1-4AAB-8C82-44B5402261A2@oracle.com> Vote: YES > On 9 Aug 2017, at 14:14, Se?n Coffey wrote: > > I hereby nominate Dmitry Markov (dmarkov) to JDK 9 Reviewer. > > Dmitry Markov is an engineer in the Oracle JDK sustaining team. He has contributed several changes to the JDK 9 Project [3] and is already a Reviewer in the JDK 10 Project. > > Votes are due by 15:00 GMT, 23rd August 2017. > > Only current JDK 9 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] http://hg.openjdk.java.net/jdk9/jdk9/jdk/log?revcount=100&rev=(keyword(%22dmitry.markov at oracle.com%22)+or+author(dmarkov)) > From Sergey.Bylokhov at oracle.com Fri Aug 11 03:25:07 2017 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 10 Aug 2017 20:25:07 -0700 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov In-Reply-To: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> References: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> Message-ID: <937c7c8e-0cfd-002d-8202-2bdb253610fa@oracle.com> Vote: Yes On 09.08.2017 6:14, Se?n Coffey wrote: > I hereby nominate Dmitry Markov (dmarkov) to JDK 9 Reviewer. > > Dmitry Markov is an engineer in the Oracle JDK sustaining team. He has > contributed several changes to the JDK 9 Project [3] and is already a > Reviewer in the JDK 10 Project. > > Votes are due by 15:00 GMT, 23rd August 2017. > > Only current JDK 9 Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > http://hg.openjdk.java.net/jdk9/jdk9/jdk/log?revcount=100&rev=(keyword(%22dmitry.markov at oracle.com%22)+or+author(dmarkov)) > > -- Best regards, Sergey. From Roger.Riggs at Oracle.com Fri Aug 11 15:10:39 2017 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Fri, 11 Aug 2017 11:10:39 -0400 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov In-Reply-To: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> References: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> Message-ID: <69f559c9-2c8c-339f-942c-1522b8588774@Oracle.com> Vote: yes On 8/9/2017 9:14 AM, Se?n Coffey wrote: > I hereby nominate Dmitry Markov (dmarkov) to JDK 9 Reviewer. > From vladimir.x.ivanov at oracle.com Mon Aug 14 12:00:07 2017 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Mon, 14 Aug 2017 15:00:07 +0300 Subject: CFV: New JDK 9 Reviewer: Dmitry Markov In-Reply-To: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> References: <613dc2c2-bad5-5b41-3bfb-b873e1193659@oracle.com> Message-ID: Vote: yes Best regards, Vladimir Ivanov On 8/9/17 4:14 PM, Se?n Coffey wrote: > I hereby nominate Dmitry Markov (dmarkov) to JDK 9 Reviewer. From david.holmes at oracle.com Mon Aug 21 01:19:51 2017 From: david.holmes at oracle.com (David Holmes) Date: Mon, 21 Aug 2017 11:19:51 +1000 Subject: -Xlog,..,file=filename with absolute path on windows? In-Reply-To: <026f01d319ee$4e62b940$eb282bc0$@apache.org> References: <026f01d319ee$4e62b940$eb282bc0$@apache.org> Message-ID: Hi Uwe, On 21/08/2017 5:55 AM, Uwe Schindler wrote: > Hi, > > I am currently adapting Apache Solr's startup scripts for Java 9. Linux was already done at the beginning of this year and works perfectly, but Windows brings some problems. I already fixed version number parsing, but I stumbled on the following: In the Windows ".cmd" shell script it uses the following to enable Garbage collection logging to a separate file, if Java 9 is detected: > set GC_LOG_OPTS="-Xlog:gc*:file=!SOLR_LOGS_DIR!\solr_gc.log:time,uptime:filecount=9,filesize=20000" > > The problem is now that "!SOLR_LOGS_DIR!" is already expanded to an absolute Windows Path by the shell and therefore starts with "C:\". The problem is now the colon, which breaks the log parsing. When Java 9 starts it exits with the following parsing error: > Invalid -Xlog option '-Xlog:gc*:file=C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1\solr\server\logs\solr_gc.log:time,uptime:filecount=9,filesize=20000' > > If I replace with a simple file name, without path/drive letter it works. How to escape the colon in the drive letter correctly, to me this looks like a bummer? You can fix this by quoting the filename, with shell escapes eg: java -Xlog:gc*:file=\"C:\solr_gc.log\":time,uptime:filecount=9 -version Doing that within an env var may be a bit trickier. David > Uwe > > ----- > Uwe Schindler > uschindler at apache.org > ASF Member, Apache Lucene PMC / Committer > Bremen, Germany > http://lucene.apache.org/ > > From david.holmes at oracle.com Mon Aug 21 06:54:40 2017 From: david.holmes at oracle.com (David Holmes) Date: Mon, 21 Aug 2017 16:54:40 +1000 Subject: -Xlog,..,file=filename with absolute path on windows? In-Reply-To: <034301d31a43$ba5e9c90$2f1bd5b0$@apache.org> References: <026f01d319ee$4e62b940$eb282bc0$@apache.org> <034301d31a43$ba5e9c90$2f1bd5b0$@apache.org> Message-ID: Hi Uwe, On 21/08/2017 4:07 PM, Uwe Schindler wrote: > Hi David, > >> Hi Uwe, >> >> On 21/08/2017 5:55 AM, Uwe Schindler wrote: >>> Hi, >>> >>> I am currently adapting Apache Solr's startup scripts for Java 9. Linux was >> already done at the beginning of this year and works perfectly, but Windows >> brings some problems. I already fixed version number parsing, but I >> stumbled on the following: In the Windows ".cmd" shell script it uses the >> following to enable Garbage collection logging to a separate file, if Java 9 is >> detected: >>> set GC_LOG_OPTS="- >> Xlog:gc*:file=!SOLR_LOGS_DIR!\solr_gc.log:time,uptime:filecount=9,filesize=2 >> 0000" >>> >>> The problem is now that "!SOLR_LOGS_DIR!" is already expanded to an >> absolute Windows Path by the shell and therefore starts with "C:\". The >> problem is now the colon, which breaks the log parsing. When Java 9 starts it >> exits with the following parsing error: >>> Invalid -Xlog option '-Xlog:gc*:file=C:\Users\Uwe >> Schindler\Projects\lucene\trunk- >> lusolr1\solr\server\logs\solr_gc.log:time,uptime:filecount=9,filesize=20000' >>> >>> If I replace with a simple file name, without path/drive letter it works. How >> to escape the colon in the drive letter correctly, to me this looks like a >> bummer? >> >> You can fix this by quoting the filename, with shell escapes eg: >> >> java -Xlog:gc*:file=\"C:\solr_gc.log\":time,uptime:filecount=9 -version >> >> Doing that within an env var may be a bit trickier. > > This approach worked quite easy. As Windows shell does not additionally handle quote escaping, so it seems to be passed as is to Java: > > set GC_LOG_OPTS="-Xlog:gc*:file=\"!SOLR_LOGS_DIR!\solr_gc.log\":time,uptime:filecount=9,filesize=20000" > > I was not aware that Java's command line parser does some escaping logic on its own, so I have no explanation what really happens internally, but this helps (at least on windows, where filenames may contain colons). > > It would be good to add this to the documentation, because there is nothing about escaping file names with spaces or colons. Spaces is no problem, if you add shell quoted around the whole arg (see above), as you should always do on all platforms, but the colon is tricky. I agree. Not sure if this was discussed when the unified logging system went in. > > Finally: Who parses what (cmd.exe, Windows ShellExecute, java)? If anybody knows he/she might explain. Some parsing happens at each level - hence need to quote args with spaces at the shell-level, or to use \ escapes. The -Xlog is passed through to the JVM from the launcher. It is the logging subsystem that allows for values to be quoted e.g x=y or x="y" But only double-quote quoting is supported. David > Uwe > From sean.coffey at oracle.com Fri Aug 25 10:15:44 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 25 Aug 2017 11:15:44 +0100 Subject: Result: New JDK 9 Reviewer: Dmitry Markov Message-ID: Voting for Dmitry Markov [1] is now closed. Yes: 9 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. regards, Sean. [1] http://mail.openjdk.java.net/pipermail/jdk9-dev/2017-August/005938.html From peter.major at forgerock.com Tue Aug 29 05:45:12 2017 From: peter.major at forgerock.com (Peter Major) Date: Tue, 29 Aug 2017 06:45:12 +0100 Subject: wscompile issues Message-ID: <277ced79-f3d2-1ae3-1c5e-dfed8ed84d93@forgerock.com> Hi, I'm not quite sure if this is the right mailing list to ask, but I'm wondering whether there is a bug in wscompile in the build 9+181 version. In a project of mine, I have a java ant task calling com.sun.xml.rpc.tools.wscompile.Main directly to generate some classes, however it seems like that although I can influence the --add-modules parameter for the java process itself, when wscompile eventually will try to compile the classes it generated, it will fail to specify java.xml.ws module, and as such the compilation fails with something like: ???? [java] /Users/aldaris/projects/foo/target/generated-sources/wscompile/com/mycompany/FooBar_Tie.java:91: error: cannot access Detail ???? [java]???????????????? e.getFaultString(), e.getFaultActor(), e.getDetail()); ???? [java]?????????????????????????????????????????????????????????????????? ^ ???? [java]?? class file for javax.xml.soap.Detail not found ???? [java] Note: Some input files use unchecked or unsafe operations. ???? [java] Note: Recompile with -Xlint:unchecked for details. ???? [java] 1 error ???? [java] error: compilation failed, errors should have been reported Is this a bug in the JDK or am I just missing something glaringly obvious? Thanks for your help. Regards, Peter Major From david.holmes at oracle.com Thu Aug 31 21:36:23 2017 From: david.holmes at oracle.com (David Holmes) Date: Fri, 1 Sep 2017 07:36:23 +1000 Subject: wscompile issues In-Reply-To: <277ced79-f3d2-1ae3-1c5e-dfed8ed84d93@forgerock.com> References: <277ced79-f3d2-1ae3-1c5e-dfed8ed84d93@forgerock.com> Message-ID: <11dc4684-6447-7fb9-fbe8-1df6319c755c@oracle.com> Hi Peter, Moving this over to jigsaw-dev. David On 29/08/2017 3:45 PM, Peter Major wrote: > Hi, > > > I'm not quite sure if this is the right mailing list to ask, but I'm > wondering whether there is a bug in wscompile in the build 9+181 version. > > In a project of mine, I have a java ant task calling > com.sun.xml.rpc.tools.wscompile.Main directly to generate some classes, > however it seems like that although I can influence the --add-modules > parameter for the java process itself, when wscompile eventually will > try to compile the classes it generated, it will fail to specify > java.xml.ws module, and as such the compilation fails with something like: > > ???? [java] > /Users/aldaris/projects/foo/target/generated-sources/wscompile/com/mycompany/FooBar_Tie.java:91: > error: cannot access Detail > ???? [java]???????????????? e.getFaultString(), e.getFaultActor(), > e.getDetail()); > > [java]?????????????????????????????????????????????????????????????????? ^ > ???? [java]?? class file for javax.xml.soap.Detail not found > ???? [java] Note: Some input files use unchecked or unsafe operations. > ???? [java] Note: Recompile with -Xlint:unchecked for details. > ???? [java] 1 error > ???? [java] error: compilation failed, errors should have been reported > > > Is this a bug in the JDK or am I just missing something glaringly obvious? > > Thanks for your help. > > > Regards, > > Peter Major >