RFR 7902157: Resolving various test issues when building/testing with maven

Erik Greijus erik.greijus at oracle.com
Thu Apr 19 15:22:20 UTC 2018


Yes, there is a comment in the bug stating that the initialization issues were solved by means of a different maven configuration.

The remaining changes though, were needed for successful compilation and test runs

Thanks
/Erik

> 19 apr. 2018 kl. 16:58 skrev Alexandre (Shura) Iline <alexandre.iline at oracle.com>:
> 
> Not all changes seem to be related to a different initialization order. For, example, missing imports are not.
> 
> There is nothing at all wrong with the changes - it is fine to use them in, it’s just I find the bug description confusing or otherwise inconsistent with the suggested fix.
> 
> It would be interesting, for future,  to better understand how exactly the initiation order differs, why and to what extend it affects the tests.
> 
> Shura
> 
>> On Apr 17, 2018, at 10:22 PM, Erik Greijus <erik.greijus at oracle.com> wrote:
>> 
>> Hello all,
>> 
>> Please have a look at this review.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902157 <https://bugs.openjdk.java.net/browse/CODETOOLS-7902157>
>> Webrev: http://cr.openjdk.java.net/~shurailine/7902157/webrev.00 <http://cr.openjdk.java.net/~shurailine/7902157/webrev.00>
>> 
>> Thanks
>> /Erik
> 



More information about the jemmy-dev mailing list