From patrick at reini.net  Tue Jun  5 08:27:19 2018
From: patrick at reini.net (Patrick Reinhart)
Date: Tue, 5 Jun 2018 10:27:19 +0200
Subject: RFR: CODETOOLS-7902180 Fixes version value on maven central
Message-ID: <8239bed7-190e-65d5-eab5-cb0ebe0fad23@reini.net>

This update fixes the version value when deployed on Maven central. Also
I added the Automatic-Module-Name manifest values and fixes the missing
version class for the jemmy-core library.

http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/

-Patrick



From erik.greijus at oracle.com  Tue Jun  5 08:31:17 2018
From: erik.greijus at oracle.com (Erik Greijus)
Date: Tue, 5 Jun 2018 10:31:17 +0200
Subject: RFR: CODETOOLS-7902180 Fixes version value on maven central
In-Reply-To: <8239bed7-190e-65d5-eab5-cb0ebe0fad23@reini.net>
References: <8239bed7-190e-65d5-eab5-cb0ebe0fad23@reini.net>
Message-ID: <FF183506-1827-455C-82FD-110F2E42E328@oracle.com>

Looks great Patrick,

I also like that you broke out the versioning to be independent.

Best regards
/Erik

> 5 juni 2018 kl. 10:27 skrev Patrick Reinhart <patrick at reini.net>:
> 
> This update fixes the version value when deployed on Maven central. Also
> I added the Automatic-Module-Name manifest values and fixes the missing
> version class for the jemmy-core library.
> 
> http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/
> 
> -Patrick
> 
> 


From martijnverburg at gmail.com  Tue Jun  5 08:51:06 2018
From: martijnverburg at gmail.com (Martijn Verburg)
Date: Tue, 5 Jun 2018 09:51:06 +0100
Subject: RFR: CODETOOLS-7902180 Fixes version value on maven central
In-Reply-To: <FF183506-1827-455C-82FD-110F2E42E328@oracle.com>
References: <8239bed7-190e-65d5-eab5-cb0ebe0fad23@reini.net>
 <FF183506-1827-455C-82FD-110F2E42E328@oracle.com>
Message-ID: <CAP7YuASeSdP=A4kr66R+qv_ASEFST4HY3PmY6JnQL3xgVWsJwg@mail.gmail.com>

Hi Patrick,

Let me know when this is ready to put on the build farm and we can work
through it and actually produce releases

Cheers,
Martijn

On 5 June 2018 at 09:31, Erik Greijus <erik.greijus at oracle.com> wrote:

> Looks great Patrick,
>
> I also like that you broke out the versioning to be independent.
>
> Best regards
> /Erik
>
> > 5 juni 2018 kl. 10:27 skrev Patrick Reinhart <patrick at reini.net>:
> >
> > This update fixes the version value when deployed on Maven central. Also
> > I added the Automatic-Module-Name manifest values and fixes the missing
> > version class for the jemmy-core library.
> >
> > http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/
> >
> > -Patrick
> >
> >
>
>

From patrick at reini.net  Tue Jun  5 19:08:29 2018
From: patrick at reini.net (Patrick Reinhart)
Date: Tue, 5 Jun 2018 21:08:29 +0200
Subject: RFR: CODETOOLS-7902180 Fixes version value on maven central
In-Reply-To: <CAP7YuASeSdP=A4kr66R+qv_ASEFST4HY3PmY6JnQL3xgVWsJwg@mail.gmail.com>
References: <8239bed7-190e-65d5-eab5-cb0ebe0fad23@reini.net>
 <FF183506-1827-455C-82FD-110F2E42E328@oracle.com>
 <CAP7YuASeSdP=A4kr66R+qv_ASEFST4HY3PmY6JnQL3xgVWsJwg@mail.gmail.com>
Message-ID: <2BB8757F-A23C-4FDF-8A69-D495ED64A36B@reini.net>

Hi Martijn,

I would say, we can start as soon the actual proposed fix went in.

-Patrick


> Am 05.06.2018 um 10:51 schrieb Martijn Verburg <martijnverburg at gmail.com>:
> 
> Hi Patrick,
> 
> Let me know when this is ready to put on the build farm and we can work through it and actually produce releases
> 
> Cheers,
> Martijn
> 
> On 5 June 2018 at 09:31, Erik Greijus <erik.greijus at oracle.com <mailto:erik.greijus at oracle.com>> wrote:
> Looks great Patrick,
> 
> I also like that you broke out the versioning to be independent.
> 
> Best regards
> /Erik
> 
> > 5 juni 2018 kl. 10:27 skrev Patrick Reinhart <patrick at reini.net <mailto:patrick at reini.net>>:
> >
> > This update fixes the version value when deployed on Maven central. Also
> > I added the Automatic-Module-Name manifest values and fixes the missing
> > version class for the jemmy-core library.
> >
> > http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/ <http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/>
> >
> > -Patrick
> >
> >
> 
> 


From patrick at reini.net  Wed Jun  6 20:31:44 2018
From: patrick at reini.net (Patrick Reinhart)
Date: Wed, 6 Jun 2018 22:31:44 +0200
Subject: RFR: CODETOOLS-7902180 Fixes version value on maven central
In-Reply-To: <FF183506-1827-455C-82FD-110F2E42E328@oracle.com>
References: <8239bed7-190e-65d5-eab5-cb0ebe0fad23@reini.net>
 <FF183506-1827-455C-82FD-110F2E42E328@oracle.com>
Message-ID: <f656d452-deb8-4f28-1c44-0a15ba4dfdd0@reini.net>

Any commit sponsors around?

-Patrick

Am 05.06.2018 um 10:31 schrieb Erik Greijus:
> Looks great Patrick,
>
> I also like that you broke out the versioning to be independent.
>
> Best regards
> /Erik
>
>> 5 juni 2018 kl. 10:27 skrev Patrick Reinhart <patrick at reini.net>:
>>
>> This update fixes the version value when deployed on Maven central. Also
>> I added the Automatic-Module-Name manifest values and fixes the missing
>> version class for the jemmy-core library.
>>
>> http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/
>>
>> -Patrick
>>
>>



From patrick at reini.net  Tue Jun 12 17:51:10 2018
From: patrick at reini.net (Patrick Reinhart)
Date: Tue, 12 Jun 2018 19:51:10 +0200
Subject: RFR: CODETOOLS-7902180 Fixes version value on maven central
In-Reply-To: <f656d452-deb8-4f28-1c44-0a15ba4dfdd0@reini.net>
References: <8239bed7-190e-65d5-eab5-cb0ebe0fad23@reini.net>
 <FF183506-1827-455C-82FD-110F2E42E328@oracle.com>
 <f656d452-deb8-4f28-1c44-0a15ba4dfdd0@reini.net>
Message-ID: <07a8359e-58d1-36e4-f565-423f13102d9e@reini.net>

Hi Shura,

I would need a commit sponsor for the maven update that will correct the
version information within the maven pom.xml files. Due the fact that we
only can publish a version once, I needed to increase the version number
to 1.0.2.? In the version 1.0.1 there respective jemmy.properties where
not updated. (We may change the version parsing of those files so we
would update those as it is done today for the build date)

-Patrick

http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/

Am 06.06.2018 um 22:31 schrieb Patrick Reinhart:
> Any commit sponsors around?
>
> -Patrick
>
> Am 05.06.2018 um 10:31 schrieb Erik Greijus:
>> Looks great Patrick,
>>
>> I also like that you broke out the versioning to be independent.
>>
>> Best regards
>> /Erik
>>
>>> 5 juni 2018 kl. 10:27 skrev Patrick Reinhart <patrick at reini.net>:
>>>
>>> This update fixes the version value when deployed on Maven central. Also
>>> I added the Automatic-Module-Name manifest values and fixes the missing
>>> version class for the jemmy-core library.
>>>
>>> http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/
>>>
>>> -Patrick
>>>
>>>
>
???



From alexandre.iline at oracle.com  Mon Jun 18 07:38:44 2018
From: alexandre.iline at oracle.com (alexandre.iline at oracle.com)
Date: Mon, 18 Jun 2018 07:38:44 +0000
Subject: hg: code-tools/jemmy/v3: 7902180: Fixes version value on maven central
Message-ID: <201806180738.w5I7ciZR023954@aojmv0008.oracle.com>

Changeset: 72b4d8016653
Author:    shurailine
Date:      2018-06-18 10:38 +0300
URL:       http://hg.openjdk.java.net/code-tools/jemmy/v3/rev/72b4d8016653

7902180: Fixes version value on maven central
Contributed-by: patrick at reini.net

! SWT/JemmySWT/pom.xml
! SWT/JemmySWT/src/org/jemmy/swt/jemmy.properties
! core/JemmyAWTInput/pom.xml
! core/JemmyAWTInput/src/org/jemmy/input/jemmy.properties
! core/JemmyBrowser/pom.xml
! core/JemmyBrowser/src/org/jemmy/browser/jemmy.properties
! core/JemmyCore/pom.xml
! core/JemmyCore/src/org/jemmy/jemmy.properties
! pom.xml


From alexandre.iline at oracle.com  Mon Jun 18 07:39:17 2018
From: alexandre.iline at oracle.com (Alexandre (Shura) Iline)
Date: Mon, 18 Jun 2018 10:39:17 +0300
Subject: RFR: CODETOOLS-7902180 Fixes version value on maven central
In-Reply-To: <07a8359e-58d1-36e4-f565-423f13102d9e@reini.net>
References: <8239bed7-190e-65d5-eab5-cb0ebe0fad23@reini.net>
 <FF183506-1827-455C-82FD-110F2E42E328@oracle.com>
 <f656d452-deb8-4f28-1c44-0a15ba4dfdd0@reini.net>
 <07a8359e-58d1-36e4-f565-423f13102d9e@reini.net>
Message-ID: <8F13397D-0998-4C1A-B6BA-58582F84AECB@oracle.com>

Done

http://hg.openjdk.java.net/code-tools/jemmy/v3/rev/72b4d8016653

> On Jun 12, 2018, at 8:51 PM, Patrick Reinhart <patrick at reini.net> wrote:
> 
> Hi Shura,
> 
> I would need a commit sponsor for the maven update that will correct the
> version information within the maven pom.xml files. Due the fact that we
> only can publish a version once, I needed to increase the version number
> to 1.0.2.  In the version 1.0.1 there respective jemmy.properties where
> not updated. (We may change the version parsing of those files so we
> would update those as it is done today for the build date)
> 
> -Patrick
> 
> http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/
> 
> Am 06.06.2018 um 22:31 schrieb Patrick Reinhart:
>> Any commit sponsors around?
>> 
>> -Patrick
>> 
>> Am 05.06.2018 um 10:31 schrieb Erik Greijus:
>>> Looks great Patrick,
>>> 
>>> I also like that you broke out the versioning to be independent.
>>> 
>>> Best regards
>>> /Erik
>>> 
>>>> 5 juni 2018 kl. 10:27 skrev Patrick Reinhart <patrick at reini.net>:
>>>> 
>>>> This update fixes the version value when deployed on Maven central. Also
>>>> I added the Automatic-Module-Name manifest values and fixes the missing
>>>> version class for the jemmy-core library.
>>>> 
>>>> http://cr.openjdk.java.net/~reinhapa/reviews/CODETOOLS-7902180/webrev/
>>>> 
>>>> -Patrick
>>>> 
>>>> 
>> 
>    
> 
> 


From patrick at reini.net  Mon Jun 18 08:33:44 2018
From: patrick at reini.net (Patrick Reinhart)
Date: Mon, 18 Jun 2018 10:33:44 +0200
Subject: RFR: CODETOOLS-7902180 Fixes version value on maven central
In-Reply-To: <8F13397D-0998-4C1A-B6BA-58582F84AECB@oracle.com>
References: <8239bed7-190e-65d5-eab5-cb0ebe0fad23@reini.net>
 <FF183506-1827-455C-82FD-110F2E42E328@oracle.com>
 <f656d452-deb8-4f28-1c44-0a15ba4dfdd0@reini.net>
 <07a8359e-58d1-36e4-f565-423f13102d9e@reini.net>
 <8F13397D-0998-4C1A-B6BA-58582F84AECB@oracle.com>
Message-ID: <e75abb4d461a610d64ad4bc1b7f1ab7b@reini.net>

On 2018-06-18 09:39, Alexandre (Shura) Iline wrote:
> Done
> 
> http://hg.openjdk.java.net/code-tools/jemmy/v3/rev/72b4d8016653
> 

Thanks,

-Patrick