From alexandre.iline at oracle.com Tue May 1 05:58:54 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Mon, 30 Apr 2018 22:58:54 -0700 Subject: RFR 7902160: Jemmy JInternalFrameOperator: Dependency with orders of Minimize, Maximize and Close buttons In-Reply-To: References: Message-ID: This looks good. Shura > On Apr 24, 2018, at 11:24 PM, Muneer Kolarkunnu wrote: > > Hi All, > > Please review an enhancement task: https://bugs.openjdk.java.net/browse/CODETOOLS-7902160 > Webrev : http://cr.openjdk.java.net/~akolarkunnu/7902160/webrev.00/ > > Regards, > Muneer From alexandre.iline at oracle.com Thu May 3 02:54:44 2018 From: alexandre.iline at oracle.com (alexandre.iline at oracle.com) Date: Thu, 03 May 2018 02:54:44 +0000 Subject: hg: code-tools/jemmy/v2: 7902160: Jemmy JInternalFrameOperator: Dependency with orders of Minimize, Message-ID: <201805030254.w432sicb011420@aojmv0008.oracle.com> Changeset: b39eb1713cff Author: akolarkunnu Date: 2018-05-02 19:25 -0700 URL: http://hg.openjdk.java.net/code-tools/jemmy/v2/rev/b39eb1713cff 7902160: Jemmy JInternalFrameOperator: Dependency with orders of Minimize, Maximize and Close buttons Summary: Finding the buttons based on tooltip text instead of indices Reviewed-by: shurailine Contributed-by: abdul.kolarkunnu at oracle.com ! src/org/netbeans/jemmy/operators/JInternalFrameOperator.java ! test/org/netbeans/jemmy/operators/JInternalFrameOperatorTest.java From martijnverburg at gmail.com Thu May 3 20:12:45 2018 From: martijnverburg at gmail.com (Martijn Verburg) Date: Thu, 3 May 2018 21:12:45 +0100 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> Message-ID: Hi all, I've made a little further progress with the new Maven based Jemmy build ( https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/). I have a few questions / comments. 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. * In terms of SNAPSHOTS we could could likely push on every build * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release My suggestion is that you: 1.) Change the version numbers to 1.0.0-SNAPSHOT 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) 3.) We perform a formal release (1.0.0) and push that to Maven Central 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! Cheers, Martijn On 13 April 2018 at 08:40, Erik Greijus wrote: > > > > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg : > > > > Hi all, > > > > The Jemmy build project is here: > > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ > > > > If managed to get a mostly successful run and have produced a > jemmy.tar.gz > > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, > > JemmyBrowser.jar). Now for some questions :-) > > > > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, > do > > platform specific jemmy's need to be built? > > Yes. The JemmySWT jar should have been built as well > (./SWT/JemmySWT/target/...) > > > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see > if > > I can get that Jenkins node to fire up an X11 so that those tests can > pass. > > That would be good. > > > 3.) Can folks please grab the tar.gz from the latest artifacts link > > lastSuccessfulBuild/artifact/> > > and let me know if that's how they expect it to be named and whether the > > layout of the contents is acceptable > > I miss the JemmySWT jar file mentioned above. > > > 4.) Versioning / naming - should I be building off a known good tag? Do > we > > want the tip/commit number to be part of the artifact name? > > > > It should build on an SCM change and weekly as well > > > > > > Cheers, > > Martijn > > > > On 11 April 2018 at 09:56, Martijn Verburg > wrote: > > > >> Cool, I'll go with what I have as a working build for now and adjust to > >> use the test target when that change comes in, and then perhaps move to > the > >> Maven build later. > >> > >> Cheers, > >> Martijn > >> > >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < > >> alexandre.iline at oracle.com> wrote: > >> > >>> > >>> > >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > > >>> wrote: > >>> > >>> Hi Alexandre, > >>> > >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( > >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/) in particular > >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that > issue > >>> up (we did have broken binaries for a bit). > >>> > >>> If I now run > >>> > >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu > >>> ild-dependecies-impl > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/ > AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te > >>> st-dependecies-impl > >>> > >>> Then I get a passing build! > >>> > >>> --------- > >>> > >>> Onto the next issue! If I run just: > >>> > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/ > AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test > >>> > >>> Then I get compile errors like: > >>> > >>> compile-test: > >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work > >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot > find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem("Table")). > >>> wrap().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot > find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap > >>> ().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> > >>> > >>> > >>> This, I believe, is a bug which is going to be addressed by the review > in > >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 > >>> 018-April/000080.html > >>> > >>> Shura > >>> > >>> > >>> ------------ > >>> > >>> A *README.txt* for building at the root of the project and a > .*hgignore* > >>> file would also be nice to haves. > >>> > >>> ------------ > >>> > >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy > >>> building nightly on our build farm. I'm also very interested in > seeing the > >>> Maven support go in :-). > >>> > >>> Cheers, > >>> Martijn > >>> > >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < > >>> alexandre.iline at oracle.com> wrote: > >>> > >>>> Do you happen to have full stack trace of that? > >>>> > >>>> Also, how to I get JTReg which are you using? > >>>> > >>>> The reported missing method would be a part of JTReg, clearly. > >>>> > >>>> The other thing is you should probably be ok with just running ant ?. > >>>> test. ?test? target is coming from http://hg.openjdk.java.ne > >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. > >>>> > >>>> Shura > >>>> > >>>> > >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > > >>>> wrote: > >>>> > >>>> Hi Alexandre, > >>>> > >>>> I got a little further (This is using Java 1.8.0_162). Once I set my > >>>> swt.jar and jtreg.home I was able to run: > >>>> > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> check-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> build-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD > >>>> K_Projects/jtreg/ test-dependecies-impl > >>>> > >>>> The first two execute OK but then the test gives me the test failure > of: > >>>> > >>>> test: > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not > >>>> found: creating > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" > >>>> not found: creating > >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] Error. Unexpected error caught from test > >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: > >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su > >>>> n/javatest/regtest/agent/JDK_Version;)I > >>>> [exec] Test results: error: 1 > >>>> [exec] Report written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ > >>>> report/html/report.html > >>>> [exec] Results written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd > >>>> [exec] Error: Some tests failed or other problems occurred. > >>>> [exec] Result: 3 > >>>> > >>>> Any ideas? > >>>> > >>>> FYI - I'm still running this locally on my Mac OS X box until I get a > >>>> clean build so I know the minimum steps for the build farm job. Note > to > >>>> self that the build box will need to provide a platform specific SWT > lib > >>>> (Linux x86). > >>>> > >>>> Cheers, > >>>> Martijn > >>>> > >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < > >>>> alexandre.iline at oracle.com> wrote: > >>>> > >>>>> Now including aliases and more recipients.. > >>>>> > >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com> wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < > >>>>> martijnverburg at gmail.com> wrote: > >>>>>>> > >>>>>>> Hi Alexandre, > >>>>>>> > >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and > >>>>> that failed with: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_ > Projects/v3/SWT/JemmySWT/build.xml:33: > >>>>> Please specify swt.jar > >>>>>> > >>>>>> You do need the SWT library to build SWT. > >>>>>> > >>>>>> this is what I just did: > >>>>>> > >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/ > plugins/org.eclipse.swt_3.8.2.jar > >>>>> jar > >>>>>> > >>>>>> > >>>>>> I clearly need to provide a README. Will do. > >>>>>> > >>>>>> Shura > >>>>>> > >>>>>>> > >>>>>>> Then I actually bothered to read the build.xml file and saw the > >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl > which > >>>>> seemed to build: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyCore/build/JemmyCore.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar > >>>>>>> > >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home > set > >>>>>>> > >>>>>>> Before I shave more Yaks, is this the right direction to be going > in? > >>>>>>> > >>>>>>> > >>>>>>> Cheers, > >>>>>>> Martijn > >>>>>>> > >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com> wrote: > >>>>>>> Martijn, > >>>>>>> > >>>>>>> Jemmy v3 consists of several project which depend on each other. > >>>>>>> > >>>>>>> If, besides hosting the source, the intension is to build it, you > >>>>> need to build projects which are in use by others who would be > coming to > >>>>> AdoptOpenJDK for binaries. > >>>>>>> > >>>>>>> At this point of time, from what I know, JemmySWT is what is > needed. > >>>>> Ant build scripts are constructed in a way so that by while JemmySWT > is > >>>>> build, the dependences are also built, you should have no problem > with that. > >>>>>>> > >>>>>>> Binaries would, then, simply include all jar files create after the > >>>>> build. The jar files will be: */*/build/*.jar > >>>>>>> > >>>>>>> Shura > >>>>>>> > >>>>>>> > >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < > >>>>> martijnverburg at gmail.com> wrote: > >>>>>>>> > >>>>>>>> Hi Dalibor, > >>>>>>>> > >>>>>>>> We're shifting the code tools off Cloudbees to the new > >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a > quick > >>>>> Q: > >>>>>>>> > >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives > me: > >>>>>>>> > >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . > >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. > >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck > >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT > >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make > >>>>>>>> > >>>>>>>> but I can't see what the canonical entry point to build it is. > >>>>>>>> > >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> Martijn > >>>>>>>> > >>>>>>>> On 28 March 2018 at 17:02, dalibor topic < > dalibor.topic at oracle.com> > >>>>> wrote: > >>>>>>>> Hi Martijn, > >>>>>>>> > >>>>>>>> would you be able to add the Jemmy v3 repo at > >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to > >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? > >>>>>>>> > >>>>>>>> cheers, > >>>>>>>> dalibor topic > >>>>>>>> -- > >>>>>>>> Dalibor Topic | Principal Product Manager > >>>>>>>> Phone: +494089091214 > | Mobile: > >>>>> +491737185961 > >>>>>>>> > > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg > >>>>> Hamburg&entry=gmail&source=g> > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG > >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 > >>>>> gmail&source=g> > >>>>> M?nchen > >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 > >>>>>>>> > >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. > >>>>>>>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande > >>>>> AS+Utrecht,+Niederlande&entry=gmail&source=g> > >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 > >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher > >>>>>>>> > >>>>>>>> Oracle is committed to > >>>>> developing > >>>>>>>> practices and products that help protect the environment > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>>> > >>>> > >>>> > >>> > >>> > >> > > From martijnverburg at gmail.com Fri May 4 08:39:41 2018 From: martijnverburg at gmail.com (Martijn Verburg) Date: Fri, 4 May 2018 09:39:41 +0100 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> Message-ID: Hi all, 1.) I'm OK with the groupId being org.adoptopenjdk - but that may cause some confusion if we do not actually host the source code as well. Not too big an issue if we explain this in the POM file 2.) Thank you Patrick (what an awesome co-incidence)! 3.) I'm totally OK with it being version 3.0.0, so I'd recommend setting the version to 3.0.0-SNAPSHOT to start with. I'd still like to understand if we need a SWT JAR for each platform, is someone able to answer that? Cheers, Martijn On 3 May 2018 at 21:17, Marcus Hirt wrote: > So, we?re suggesting to use adoptopenjdk.org as groupid and change the > camel case module names to lower case and dashes. Patrick is also fixing > the javadocs, as that must be done to publish the source Jars. I think > Patrick will be back with big wonderful patch soon. :) > > > > Also, would it be okay to not have v3 in the name, but rather just set the > version to 3.0.0? > > > > Kind regards, > > Marcus > > > > *From: *Martijn Verburg > *Date: *Thursday, 3 May 2018 at 22:13 > *To: *Erik Greijus > *Cc: *"Alexandre (Shura) Iline" , " > adoption-discuss at openjdk.java.net" , < > jemmy-dev at openjdk.java.net>, dalibor topic , > Marcus Hirt , Patrick Reinhart < > patrick.reinhart at gmail.com> > *Subject: *Re: Adding Jemmy v3 to https://adopt-openjdk.ci. > cloudbees.com/view/OpenJDK%20code-tools/ > > > > Hi all, > > > > I've made a little further progress with the new Maven based Jemmy build ( > https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/). I > have a few questions / comments. > > > > 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we > need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT- > windows-1.0.jar? > > > > 2.) I still need to figure out how to bring up the Linux UI for our build > node to pass the tests, I'm skipping for now. > > > > 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release > versions. > > > > * In terms of SNAPSHOTS we could could likely push on every build > > * In terms of releases we can add a release task (or a release job if we > Jenkins pipeline pro it) that can be manaully executed when the Jemmy team > decides to cut a release > > > > My suggestion is that you: > > > > 1.) Change the version numbers to 1.0.0-SNAPSHOT > > 2.) We get a SNAPSHOT release out to Maven Central (and practice getting > past the OSSRH gatekeeper) > > 3.) We perform a formal release (1.0.0) and push that to Maven Central > > 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be > manually changed to whatever you need > > > > I notice that `org.jemmy.v3` is your groupID, that might be OK but the > OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on > this so I've cruelly dragged in Patrick Reinhart who's done Maven Central > deploys for other Adopt projects in the past, sorry Patrick! > > > > Cheers, > Martijn > > > > On 13 April 2018 at 08:40, Erik Greijus wrote: > > > > > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg : > > > > Hi all, > > > > The Jemmy build project is here: > > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ > > > > If managed to get a mostly successful run and have produced a > jemmy.tar.gz > > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, > > JemmyBrowser.jar). Now for some questions :-) > > > > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, > do > > platform specific jemmy's need to be built? > > Yes. The JemmySWT jar should have been built as well > (./SWT/JemmySWT/target/...) > > > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see > if > > I can get that Jenkins node to fire up an X11 so that those tests can > pass. > > That would be good. > > > 3.) Can folks please grab the tar.gz from the latest artifacts link > > lastSuccessfulBuild/artifact/> > > and let me know if that's how they expect it to be named and whether the > > layout of the contents is acceptable > > I miss the JemmySWT jar file mentioned above. > > > > 4.) Versioning / naming - should I be building off a known good tag? Do > we > > want the tip/commit number to be part of the artifact name? > > > > It should build on an SCM change and weekly as well > > > > > > Cheers, > > Martijn > > > > On 11 April 2018 at 09:56, Martijn Verburg > wrote: > > > >> Cool, I'll go with what I have as a working build for now and adjust to > >> use the test target when that change comes in, and then perhaps move to > the > >> Maven build later. > >> > >> Cheers, > >> Martijn > >> > >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < > >> alexandre.iline at oracle.com> wrote: > >> > >>> > >>> > >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > > >>> wrote: > >>> > >>> Hi Alexandre, > >>> > >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( > >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/) in particular > >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that > issue > >>> up (we did have broken binaries for a bit). > >>> > >>> If I now run > >>> > >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu > >>> ild-dependecies-impl > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/ > AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te > >>> st-dependecies-impl > >>> > >>> Then I get a passing build! > >>> > >>> --------- > >>> > >>> Onto the next issue! If I run just: > >>> > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/ > AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test > >>> > >>> Then I get compile errors like: > >>> > >>> compile-test: > >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work > >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot > find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem("Table")). > >>> wrap().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot > find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap > >>> ().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> > >>> > >>> > >>> This, I believe, is a bug which is going to be addressed by the review > in > >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 > >>> 018-April/000080.html > >>> > >>> Shura > >>> > >>> > >>> ------------ > >>> > > >>> A *README.txt* for building at the root of the project and a > .*hgignore* > > >>> file would also be nice to haves. > >>> > >>> ------------ > >>> > >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy > >>> building nightly on our build farm. I'm also very interested in > seeing the > >>> Maven support go in :-). > >>> > >>> Cheers, > >>> Martijn > >>> > >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < > >>> alexandre.iline at oracle.com> wrote: > >>> > >>>> Do you happen to have full stack trace of that? > >>>> > >>>> Also, how to I get JTReg which are you using? > >>>> > >>>> The reported missing method would be a part of JTReg, clearly. > >>>> > >>>> The other thing is you should probably be ok with just running ant ?. > >>>> test. ?test? target is coming from http://hg.openjdk.java.ne > >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. > >>>> > >>>> Shura > >>>> > >>>> > >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > > >>>> wrote: > >>>> > >>>> Hi Alexandre, > >>>> > >>>> I got a little further (This is using Java 1.8.0_162). Once I set my > >>>> swt.jar and jtreg.home I was able to run: > >>>> > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> check-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> build-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD > > >>>> K_Projects/jtreg/ test-dependecies-impl > > >>>> > >>>> The first two execute OK but then the test gives me the test failure > of: > >>>> > >>>> test: > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not > >>>> found: creating > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" > >>>> not found: creating > >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] Error. Unexpected error caught from test > >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: > >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su > >>>> n/javatest/regtest/agent/JDK_Version;)I > >>>> [exec] Test results: error: 1 > >>>> [exec] Report written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ > >>>> report/html/report.html > >>>> [exec] Results written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd > >>>> [exec] Error: Some tests failed or other problems occurred. > >>>> [exec] Result: 3 > >>>> > >>>> Any ideas? > >>>> > >>>> FYI - I'm still running this locally on my Mac OS X box until I get a > >>>> clean build so I know the minimum steps for the build farm job. Note > to > >>>> self that the build box will need to provide a platform specific SWT > lib > >>>> (Linux x86). > >>>> > >>>> Cheers, > >>>> Martijn > >>>> > >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < > >>>> alexandre.iline at oracle.com> wrote: > >>>> > >>>>> Now including aliases and more recipients.. > >>>>> > >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com> wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < > >>>>> martijnverburg at gmail.com> wrote: > >>>>>>> > >>>>>>> Hi Alexandre, > >>>>>>> > >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and > >>>>> that failed with: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_ > Projects/v3/SWT/JemmySWT/build.xml:33: > >>>>> Please specify swt.jar > >>>>>> > >>>>>> You do need the SWT library to build SWT. > >>>>>> > >>>>>> this is what I just did: > >>>>>> > >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/ > plugins/org.eclipse.swt_3.8.2.jar > >>>>> jar > >>>>>> > >>>>>> > >>>>>> I clearly need to provide a README. Will do. > >>>>>> > >>>>>> Shura > >>>>>> > >>>>>>> > >>>>>>> Then I actually bothered to read the build.xml file and saw the > >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl > which > >>>>> seemed to build: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyCore/build/JemmyCore.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar > >>>>>>> > >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home > set > >>>>>>> > >>>>>>> Before I shave more Yaks, is this the right direction to be going > in? > >>>>>>> > >>>>>>> > >>>>>>> Cheers, > >>>>>>> Martijn > >>>>>>> > >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com> wrote: > >>>>>>> Martijn, > >>>>>>> > >>>>>>> Jemmy v3 consists of several project which depend on each other. > >>>>>>> > >>>>>>> If, besides hosting the source, the intension is to build it, you > >>>>> need to build projects which are in use by others who would be > coming to > >>>>> AdoptOpenJDK for binaries. > >>>>>>> > >>>>>>> At this point of time, from what I know, JemmySWT is what is > needed. > >>>>> Ant build scripts are constructed in a way so that by while JemmySWT > is > >>>>> build, the dependences are also built, you should have no problem > with that. > >>>>>>> > >>>>>>> Binaries would, then, simply include all jar files create after the > >>>>> build. The jar files will be: */*/build/*.jar > >>>>>>> > >>>>>>> Shura > >>>>>>> > >>>>>>> > >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < > >>>>> martijnverburg at gmail.com> wrote: > >>>>>>>> > >>>>>>>> Hi Dalibor, > >>>>>>>> > >>>>>>>> We're shifting the code tools off Cloudbees to the new > >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a > quick > >>>>> Q: > >>>>>>>> > >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives > me: > >>>>>>>> > >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . > >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. > >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck > >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT > >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make > >>>>>>>> > >>>>>>>> but I can't see what the canonical entry point to build it is. > >>>>>>>> > >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> Martijn > >>>>>>>> > >>>>>>>> On 28 March 2018 at 17:02, dalibor topic < > dalibor.topic at oracle.com> > >>>>> wrote: > >>>>>>>> Hi Martijn, > >>>>>>>> > >>>>>>>> would you be able to add the Jemmy v3 repo at > >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to > >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? > >>>>>>>> > >>>>>>>> cheers, > >>>>>>>> dalibor topic > >>>>>>>> -- > >>>>>>>> Dalibor Topic | Principal Product Manager > > >>>>>>>> Phone: +494089091214 > | Mobile: > >>>>> +491737185961 > >>>>>>>> > > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg > > >>>>> Hamburg&entry=gmail&source=g> > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG > >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 > > >>>>> gmail&source=g> > >>>>> M?nchen > >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 > >>>>>>>> > >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. > >>>>>>>> Hertogswetering 163 > /167, > 3543 AS Utrecht, Niederlande > >>>>> AS+Utrecht,+Niederlande&entry=gmail&source=g> > > >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 > >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher > >>>>>>>> > >>>>>>>> Oracle is committed to > >>>>> developing > >>>>>>>> practices and products that help protect the environment > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>>> > >>>> > >>>> > >>> > >>> > >> > > > From erik.greijus at oracle.com Fri May 4 11:01:47 2018 From: erik.greijus at oracle.com (Erik Greijus) Date: Fri, 4 May 2018 13:01:47 +0200 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> Message-ID: <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> Hello, Sorry for the late answer. As for JemmySWT.jar it is platform independent (it relies on the platform dependent SWT library - which is needed to build the project, and later on to actually use Jemmy). You only need to build and make available the four jars as they are. Best regards /Erik > 4 maj 2018 kl. 10:39 skrev Martijn Verburg : > > Hi all, > > 1.) I'm OK with the groupId being org.adoptopenjdk - but that may cause some confusion if we do not actually host the source code as well. Not too big an issue if we explain this in the POM file > > 2.) Thank you Patrick (what an awesome co-incidence)! > > 3.) I'm totally OK with it being version 3.0.0, so I'd recommend setting the version to 3.0.0-SNAPSHOT to start with. > > I'd still like to understand if we need a SWT JAR for each platform, is someone able to answer that? > > > > Cheers, > Martijn > > On 3 May 2018 at 21:17, Marcus Hirt > wrote: > So, we?re suggesting to use adoptopenjdk.org as groupid and change the camel case module names to lower case and dashes. Patrick is also fixing the javadocs, as that must be done to publish the source Jars. I think Patrick will be back with big wonderful patch soon. :) > > > > Also, would it be okay to not have v3 in the name, but rather just set the version to 3.0.0? > > > > Kind regards, > > Marcus > > > > From: Martijn Verburg > > Date: Thursday, 3 May 2018 at 22:13 > To: Erik Greijus > > Cc: "Alexandre (Shura) Iline" >, "adoption-discuss at openjdk.java.net " >, >, dalibor topic >, Marcus Hirt >, Patrick Reinhart > > Subject: Re: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ > > > Hi all, <> > > > I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/ ). I have a few questions / comments. > > > > 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? > > > > > 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. > > > > > 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. > > > > * In terms of SNAPSHOTS we could could likely push on every build > > * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release > > > > My suggestion is that you: > > > > 1.) Change the version numbers to 1.0.0-SNAPSHOT > > 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) > > 3.) We perform a formal release (1.0.0) and push that to Maven Central > > 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need > > > > I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! > > > > Cheers, > Martijn > > > > On 13 April 2018 at 08:40, Erik Greijus > wrote: > > > > > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg >: > > > > Hi all, > > > > The Jemmy build project is here: > > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ > > > > If managed to get a mostly successful run and have produced a jemmy.tar.gz > > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, > > JemmyBrowser.jar). Now for some questions :-) > > > > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do > > platform specific jemmy's need to be built? > > Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) > > > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if > > I can get that Jenkins node to fire up an X11 so that those tests can pass. > > That would be good. > > > 3.) Can folks please grab the tar.gz from the latest artifacts link > > > > > and let me know if that's how they expect it to be named and whether the > > layout of the contents is acceptable > > I miss the JemmySWT jar file mentioned above. > > > > 4.) Versioning / naming - should I be building off a known good tag? Do we > > want the tip/commit number to be part of the artifact name? > > > > It should build on an SCM change and weekly as well > > > > > > Cheers, > > Martijn > > > > On 11 April 2018 at 09:56, Martijn Verburg > wrote: > > > >> Cool, I'll go with what I have as a working build for now and adjust to > >> use the test target when that change comes in, and then perhaps move to the > >> Maven build later. > >> > >> Cheers, > >> Martijn > >> > >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < > >> alexandre.iline at oracle.com > wrote: > >> > >>> > >>> > >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > > >>> wrote: > >>> > >>> Hi Alexandre, > >>> > >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( > >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/ ) in particular > >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue > >>> up (we did have broken binaries for a bit). > >>> > >>> If I now run > >>> > >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu > >>> ild-dependecies-impl > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te > >>> st-dependecies-impl > >>> > >>> Then I get a passing build! > >>> > >>> --------- > >>> > >>> Onto the next issue! If I run just: > >>> > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test > >>> > >>> Then I get compile errors like: > >>> > >>> compile-test: > >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work > >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem("Table")). > >>> wrap().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap > >>> ().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> > >>> > >>> > >>> This, I believe, is a bug which is going to be addressed by the review in > >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 > >>> 018-April/000080.html > >>> > >>> Shura > >>> > >>> > >>> ------------ > >>> > > >>> A *README.txt* for building at the root of the project and a .*hgignore* > > >>> file would also be nice to haves. > >>> > >>> ------------ > >>> > >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy > >>> building nightly on our build farm. I'm also very interested in seeing the > >>> Maven support go in :-). > >>> > >>> Cheers, > >>> Martijn > >>> > >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < > >>> alexandre.iline at oracle.com > wrote: > >>> > >>>> Do you happen to have full stack trace of that? > >>>> > >>>> Also, how to I get JTReg which are you using? > >>>> > >>>> The reported missing method would be a part of JTReg, clearly. > >>>> > >>>> The other thing is you should probably be ok with just running ant ?. > >>>> test. ?test? target is coming from http://hg.openjdk.java.ne > >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. > >>>> > >>>> Shura > >>>> > >>>> > >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > > >>>> wrote: > >>>> > >>>> Hi Alexandre, > >>>> > >>>> I got a little further (This is using Java 1.8.0_162). Once I set my > >>>> swt.jar and jtreg.home I was able to run: > >>>> > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> check-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> build-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD > > >>>> K_Projects/jtreg/ test-dependecies-impl > > >>>> > >>>> The first two execute OK but then the test gives me the test failure of: > >>>> > >>>> test: > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not > >>>> found: creating > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" > >>>> not found: creating > >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] Error. Unexpected error caught from test > >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: > >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su > >>>> n/javatest/regtest/agent/JDK_Version;)I > >>>> [exec] Test results: error: 1 > >>>> [exec] Report written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ > >>>> report/html/report.html > >>>> [exec] Results written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd > >>>> [exec] Error: Some tests failed or other problems occurred. > >>>> [exec] Result: 3 > >>>> > >>>> Any ideas? > >>>> > >>>> FYI - I'm still running this locally on my Mac OS X box until I get a > >>>> clean build so I know the minimum steps for the build farm job. Note to > >>>> self that the build box will need to provide a platform specific SWT lib > >>>> (Linux x86). > >>>> > >>>> Cheers, > >>>> Martijn > >>>> > >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < > >>>> alexandre.iline at oracle.com > wrote: > >>>> > >>>>> Now including aliases and more recipients.. > >>>>> > >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com > wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < > >>>>> martijnverburg at gmail.com > wrote: > >>>>>>> > >>>>>>> Hi Alexandre, > >>>>>>> > >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and > >>>>> that failed with: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: > >>>>> Please specify swt.jar > >>>>>> > >>>>>> You do need the SWT library to build SWT. > >>>>>> > >>>>>> this is what I just did: > >>>>>> > >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar > >>>>> jar > >>>>>> > >>>>>> > >>>>>> I clearly need to provide a README. Will do. > >>>>>> > >>>>>> Shura > >>>>>> > >>>>>>> > >>>>>>> Then I actually bothered to read the build.xml file and saw the > >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which > >>>>> seemed to build: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyCore/build/JemmyCore.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar > >>>>>>> > >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set > >>>>>>> > >>>>>>> Before I shave more Yaks, is this the right direction to be going in? > >>>>>>> > >>>>>>> > >>>>>>> Cheers, > >>>>>>> Martijn > >>>>>>> > >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com > wrote: > >>>>>>> Martijn, > >>>>>>> > >>>>>>> Jemmy v3 consists of several project which depend on each other. > >>>>>>> > >>>>>>> If, besides hosting the source, the intension is to build it, you > >>>>> need to build projects which are in use by others who would be coming to > >>>>> AdoptOpenJDK for binaries. > >>>>>>> > >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. > >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is > >>>>> build, the dependences are also built, you should have no problem with that. > >>>>>>> > >>>>>>> Binaries would, then, simply include all jar files create after the > >>>>> build. The jar files will be: */*/build/*.jar > >>>>>>> > >>>>>>> Shura > >>>>>>> > >>>>>>> > >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < > >>>>> martijnverburg at gmail.com > wrote: > >>>>>>>> > >>>>>>>> Hi Dalibor, > >>>>>>>> > >>>>>>>> We're shifting the code tools off Cloudbees to the new > >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick > >>>>> Q: > >>>>>>>> > >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: > >>>>>>>> > >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . > >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. > >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck > >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT > >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make > >>>>>>>> > >>>>>>>> but I can't see what the canonical entry point to build it is. > >>>>>>>> > >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> Martijn > >>>>>>>> > >>>>>>>> On 28 March 2018 at 17:02, dalibor topic > > >>>>> wrote: > >>>>>>>> Hi Martijn, > >>>>>>>> > >>>>>>>> would you be able to add the Jemmy v3 repo at > >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to > >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? > >>>>>>>> > >>>>>>>> cheers, > >>>>>>>> dalibor topic > >>>>>>>> -- > >>>>>>>> > Dalibor Topic | Principal Product Manager > > >>>>>>>> Phone: +494089091214 > | Mobile: > >>>>> +491737185961 > >>>>>>>> > > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg > >>>>> > > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG > >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 > >>>>> > > >>>>> M?nchen > >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 > >>>>>>>> > >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. > >>>>>>>> Hertogswetering 163 /167, 3543 AS Utrecht, Niederlande > >>>>> > > > >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 > >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher > >>>>>>>> > >>>>>>>> > Oracle is committed to > >>>>> developing > >>>>>>>> practices and products that help protect the environment > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>>> > >>>> > >>>> > >>> > >>> > >> > > > > From martijnverburg at gmail.com Fri May 4 11:38:08 2018 From: martijnverburg at gmail.com (Martijn Verburg) Date: Fri, 4 May 2018 12:38:08 +0100 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> Message-ID: Awesome, that makes life a lot easier - OK, now to get X11 running on the build boxes we want to pass tests. Cheers, Martijn On 4 May 2018 at 12:01, Erik Greijus wrote: > Hello, > > Sorry for the late answer. > As for JemmySWT.jar it is platform independent (it relies on the platform > dependent SWT library - which is needed to build the project, and later on > to actually use Jemmy). > You only need to build and make available the four jars as they are. > > Best regards > /Erik > > > > 4 maj 2018 kl. 10:39 skrev Martijn Verburg : > > Hi all, > > 1.) I'm OK with the groupId being org.adoptopenjdk - but that may cause > some confusion if we do not actually host the source code as well. Not too > big an issue if we explain this in the POM file > > 2.) Thank you Patrick (what an awesome co-incidence)! > > 3.) I'm totally OK with it being version 3.0.0, so I'd recommend setting > the version to 3.0.0-SNAPSHOT to start with. > > I'd still like to understand if we need a SWT JAR for each platform, is > someone able to answer that? > > > > Cheers, > Martijn > > On 3 May 2018 at 21:17, Marcus Hirt wrote: > >> So, we?re suggesting to use adoptopenjdk.org as groupid and change the >> camel case module names to lower case and dashes. Patrick is also fixing >> the javadocs, as that must be done to publish the source Jars. I think >> Patrick will be back with big wonderful patch soon. :) >> >> >> >> Also, would it be okay to not have v3 in the name, but rather just set >> the version to 3.0.0? >> >> >> >> Kind regards, >> >> Marcus >> >> >> >> *From: *Martijn Verburg >> *Date: *Thursday, 3 May 2018 at 22:13 >> *To: *Erik Greijus >> *Cc: *"Alexandre (Shura) Iline" , " >> adoption-discuss at openjdk.java.net" , < >> jemmy-dev at openjdk.java.net>, dalibor topic , >> Marcus Hirt , Patrick Reinhart < >> patrick.reinhart at gmail.com> >> *Subject: *Re: Adding Jemmy v3 to https://adopt-openjdk.ci.cloud >> bees.com/view/OpenJDK%20code-tools/ >> >> >> >> Hi all, >> >> >> >> I've made a little further progress with the new Maven based Jemmy build ( >> https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/). I >> have a few questions / comments. >> >> >> >> 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we >> need to create a JemmySWT-linux-1.0.jar, Jemm >> ySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? >> >> >> >> 2.) I still need to figure out how to bring up the Linux UI for our build >> node to pass the tests, I'm skipping for now. >> >> >> >> 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and >> release versions. >> >> >> >> * In terms of SNAPSHOTS we could could likely push on every build >> >> * In terms of releases we can add a release task (or a release job if we >> Jenkins pipeline pro it) that can be manaully executed when the Jemmy team >> decides to cut a release >> >> >> >> My suggestion is that you: >> >> >> >> 1.) Change the version numbers to 1.0.0-SNAPSHOT >> >> 2.) We get a SNAPSHOT release out to Maven Central (and practice getting >> past the OSSRH gatekeeper) >> >> 3.) We perform a formal release (1.0.0) and push that to Maven Central >> >> 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be >> manually changed to whatever you need >> >> >> >> I notice that `org.jemmy.v3` is your groupID, that might be OK but the >> OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on >> this so I've cruelly dragged in Patrick Reinhart who's done Maven Central >> deploys for other Adopt projects in the past, sorry Patrick! >> >> >> >> Cheers, >> Martijn >> >> >> >> On 13 April 2018 at 08:40, Erik Greijus wrote: >> >> >> >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg > >: >> > >> > Hi all, >> > >> > The Jemmy build project is here: >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ >> > >> > If managed to get a mostly successful run and have produced a >> jemmy.tar.gz >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, >> > JemmyBrowser.jar). Now for some questions :-) >> > >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, >> do >> > platform specific jemmy's need to be built? >> >> Yes. The JemmySWT jar should have been built as well >> (./SWT/JemmySWT/target/...) >> >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see >> if >> > I can get that Jenkins node to fire up an X11 so that those tests can >> pass. >> >> That would be good. >> >> > 3.) Can folks please grab the tar.gz from the latest artifacts link >> > > tSuccessfulBuild/artifact/> >> > and let me know if that's how they expect it to be named and whether the >> > layout of the contents is acceptable >> >> I miss the JemmySWT jar file mentioned above. >> >> >> > 4.) Versioning / naming - should I be building off a known good tag? >> Do we >> > want the tip/commit number to be part of the artifact name? >> > >> > It should build on an SCM change and weekly as well >> > >> > >> > Cheers, >> > Martijn >> > >> > On 11 April 2018 at 09:56, Martijn Verburg >> wrote: >> > >> >> Cool, I'll go with what I have as a working build for now and adjust to >> >> use the test target when that change comes in, and then perhaps move >> to the >> >> Maven build later. >> >> >> >> Cheers, >> >> Martijn >> >> >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < >> >> alexandre.iline at oracle.com> wrote: >> >> >> >>> >> >>> >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg < >> martijnverburg at gmail.com> >> >>> wrote: >> >>> >> >>> Hi Alexandre, >> >>> >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/) in particular >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that >> issue >> >>> up (we did have broken binaries for a bit). >> >>> >> >>> If I now run >> >>> >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu >> >>> ild-dependecies-impl >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >> K_Projects/jtreg/ >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te >> >>> st-dependecies-impl >> >>> >> >>> Then I get a passing build! >> >>> >> >>> --------- >> >>> >> >>> Onto the next issue! If I run just: >> >>> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >> K_Projects/jtreg/ >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test >> >>> >> >>> Then I get compile errors like: >> >>> >> >>> compile-test: >> >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot >> find >> >>> symbol >> >>> [javac] prnt.lookup(new ByTextItem("Table")). >> >>> wrap().mouse().click(); >> >>> [javac] ^ >> >>> [javac] symbol: class ByTextItem >> >>> [javac] location: class ItemsTest >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot >> find >> >>> symbol >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap >> >>> ().mouse().click(); >> >>> [javac] ^ >> >>> [javac] symbol: class ByTextItem >> >>> [javac] location: class ItemsTest >> >>> >> >>> >> >>> >> >>> This, I believe, is a bug which is going to be addressed by the >> review in >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 >> >>> 018-April/000080.html >> >>> >> >>> Shura >> >>> >> >>> >> >>> ------------ >> >>> >> >> >>> A *README.txt* for building at the root of the project and a >> .*hgignore* >> >> >>> file would also be nice to haves. >> >>> >> >>> ------------ >> >>> >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy >> >>> building nightly on our build farm. I'm also very interested in >> seeing the >> >>> Maven support go in :-). >> >>> >> >>> Cheers, >> >>> Martijn >> >>> >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < >> >>> alexandre.iline at oracle.com> wrote: >> >>> >> >>>> Do you happen to have full stack trace of that? >> >>>> >> >>>> Also, how to I get JTReg which are you using? >> >>>> >> >>>> The reported missing method would be a part of JTReg, clearly. >> >>>> >> >>>> The other thing is you should probably be ok with just running ant ?. >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. >> >>>> >> >>>> Shura >> >>>> >> >>>> >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg < >> martijnverburg at gmail.com> >> >>>> wrote: >> >>>> >> >>>> Hi Alexandre, >> >>>> >> >>>> I got a little further (This is using Java 1.8.0_162). Once I set my >> >>>> swt.jar and jtreg.home I was able to run: >> >>>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> check-dependecies-impl >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> build-dependecies-impl >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >> >> >>>> K_Projects/jtreg/ test-dependecies-impl >> >> >>>> >> >>>> The first two execute OK but then the test gives me the test failure >> of: >> >>>> >> >>>> test: >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not >> >>>> found: creating >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" >> >>>> not found: creating >> >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTes >> t.java >> >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTes >> t.java >> >>>> [exec] Error. Unexpected error caught from test >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su >> >>>> n/javatest/regtest/agent/JDK_Version;)I >> >>>> [exec] Test results: error: 1 >> >>>> [exec] Report written to /Users/karianna/Documents/work >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ >> >>>> report/html/report.html >> >>>> [exec] Results written to /Users/karianna/Documents/work >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd >> >>>> [exec] Error: Some tests failed or other problems occurred. >> >>>> [exec] Result: 3 >> >>>> >> >>>> Any ideas? >> >>>> >> >>>> FYI - I'm still running this locally on my Mac OS X box until I get a >> >>>> clean build so I know the minimum steps for the build farm job. >> Note to >> >>>> self that the build box will need to provide a platform specific SWT >> lib >> >>>> (Linux x86). >> >>>> >> >>>> Cheers, >> >>>> Martijn >> >>>> >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < >> >>>> alexandre.iline at oracle.com> wrote: >> >>>> >> >>>>> Now including aliases and more recipients.. >> >>>>> >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < >> >>>>> alexandre.iline at oracle.com> wrote: >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < >> >>>>> martijnverburg at gmail.com> wrote: >> >>>>>>> >> >>>>>>> Hi Alexandre, >> >>>>>>> >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and >> >>>>> that failed with: >> >>>>>>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> v3/SWT/JemmySWT/build.xml:33: >> >>>>> Please specify swt.jar >> >>>>>> >> >>>>>> You do need the SWT library to build SWT. >> >>>>>> >> >>>>>> this is what I just did: >> >>>>>> >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plu >> gins/org.eclipse.swt_3.8.2.jar >> >>>>> jar >> >>>>>> >> >>>>>> >> >>>>>> I clearly need to provide a README. Will do. >> >>>>>> >> >>>>>> Shura >> >>>>>> >> >>>>>>> >> >>>>>>> Then I actually bothered to read the build.xml file and saw the >> >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl >> which >> >>>>> seemed to build: >> >>>>>>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyCore/build/JemmyCore.jar >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar >> >>>>>>> >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home >> set >> >>>>>>> >> >>>>>>> Before I shave more Yaks, is this the right direction to be going >> in? >> >>>>>>> >> >>>>>>> >> >>>>>>> Cheers, >> >>>>>>> Martijn >> >>>>>>> >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < >> >>>>> alexandre.iline at oracle.com> wrote: >> >>>>>>> Martijn, >> >>>>>>> >> >>>>>>> Jemmy v3 consists of several project which depend on each other. >> >>>>>>> >> >>>>>>> If, besides hosting the source, the intension is to build it, you >> >>>>> need to build projects which are in use by others who would be >> coming to >> >>>>> AdoptOpenJDK for binaries. >> >>>>>>> >> >>>>>>> At this point of time, from what I know, JemmySWT is what is >> needed. >> >>>>> Ant build scripts are constructed in a way so that by while >> JemmySWT is >> >>>>> build, the dependences are also built, you should have no problem >> with that. >> >>>>>>> >> >>>>>>> Binaries would, then, simply include all jar files create after >> the >> >>>>> build. The jar files will be: */*/build/*.jar >> >>>>>>> >> >>>>>>> Shura >> >>>>>>> >> >>>>>>> >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < >> >>>>> martijnverburg at gmail.com> wrote: >> >>>>>>>> >> >>>>>>>> Hi Dalibor, >> >>>>>>>> >> >>>>>>>> We're shifting the code tools off Cloudbees to the new >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a >> quick >> >>>>> Q: >> >>>>>>>> >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives >> me: >> >>>>>>>> >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make >> >>>>>>>> >> >>>>>>>> but I can't see what the canonical entry point to build it is. >> >>>>>>>> >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. >> >>>>>>>> >> >>>>>>>> Cheers, >> >>>>>>>> Martijn >> >>>>>>>> >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic < >> dalibor.topic at oracle.com> >> >>>>> wrote: >> >>>>>>>> Hi Martijn, >> >>>>>>>> >> >>>>>>>> would you be able to add the Jemmy v3 repo at >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to >> >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? >> >>>>>>>> >> >>>>>>>> cheers, >> >>>>>>>> dalibor topic >> >>>>>>>> -- >> >>>>>>>> Dalibor Topic | Principal Product >> Manager >> >> >>>>>>>> Phone: +494089091214 >> <+494089091214>> | Mobile: >> >>>>> +491737185961 >> >>>>>>>> <+491737185961>> >> >>>>>>>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg >> >> >>>>> > Hamburg&entry=gmail&source=g> >> >>>>>>>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 >> >> >>>>> > &source=g> >> >>>>> M?nchen >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 >> >>>>>>>> >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. >> >>>>>>>> Hertogswetering 163 >> /167, >> 3543 AS Utrecht, Niederlande >> >>>>> > +Utrecht,+Niederlande&entry=gmail&source=g> >> >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. >> 30143697 >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val >> Maher >> >>>>>>>> >> >>>>>>>> Oracle is committed to >> >>>>> developing >> >>>>>>>> practices and products that help protect the environment >> >>>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>> >> >>>>> >> >>>>> >> >>>> >> >>>> >> >>> >> >>> >> >> >> >> >> > > > From erik.greijus at oracle.com Fri May 4 12:04:25 2018 From: erik.greijus at oracle.com (Erik Greijus) Date: Fri, 4 May 2018 14:04:25 +0200 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> Message-ID: <6C2322CD-6483-4E90-98C6-245FB8828A94@oracle.com> Not sure about the version numbering. The actual versions of the modules range from 0.9.5 to 1.0.0 (the versions in the pom files don?t match the actual versions - my bad). I think that, instead of using "v3? we probably should use ?jemmy3?. Regards /Erik > 3 maj 2018 kl. 22:17 skrev Marcus Hirt : > > So, we?re suggesting to use adoptopenjdk.org as groupid and change the camel case module names to lower case and dashes. Patrick is also fixing the javadocs, as that must be done to publish the source Jars. I think Patrick will be back with big wonderful patch soon. :) > > Also, would it be okay to not have v3 in the name, but rather just set the version to 3.0.0? > > Kind regards, > Marcus > > From: Martijn Verburg > Date: Thursday, 3 May 2018 at 22:13 > To: Erik Greijus > Cc: "Alexandre (Shura) Iline" , "adoption-discuss at openjdk.java.net" , , dalibor topic , Marcus Hirt , Patrick Reinhart > Subject: Re: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ > > Hi all, <> > > I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/ ). I have a few questions / comments. > > 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? > > > 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. > > > 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. > > * In terms of SNAPSHOTS we could could likely push on every build > * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release > > My suggestion is that you: > > 1.) Change the version numbers to 1.0.0-SNAPSHOT > 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) > 3.) We perform a formal release (1.0.0) and push that to Maven Central > 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need > > I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! > > Cheers, > Martijn > > On 13 April 2018 at 08:40, Erik Greijus > wrote: >> >> >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg >: >> > >> > Hi all, >> > >> > The Jemmy build project is here: >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ >> > >> > If managed to get a mostly successful run and have produced a jemmy.tar.gz >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, >> > JemmyBrowser.jar). Now for some questions :-) >> > >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do >> > platform specific jemmy's need to be built? >> >> Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) >> >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if >> > I can get that Jenkins node to fire up an X11 so that those tests can pass. >> >> That would be good. >> >> > 3.) Can folks please grab the tar.gz from the latest artifacts link >> > > >> > and let me know if that's how they expect it to be named and whether the >> > layout of the contents is acceptable >> >> I miss the JemmySWT jar file mentioned above. >> >> > 4.) Versioning / naming - should I be building off a known good tag? Do we >> > want the tip/commit number to be part of the artifact name? >> > >> > It should build on an SCM change and weekly as well >> > >> > >> > Cheers, >> > Martijn >> > >> > On 11 April 2018 at 09:56, Martijn Verburg > wrote: >> > >> >> Cool, I'll go with what I have as a working build for now and adjust to >> >> use the test target when that change comes in, and then perhaps move to the >> >> Maven build later. >> >> >> >> Cheers, >> >> Martijn >> >> >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < >> >> alexandre.iline at oracle.com > wrote: >> >> >> >>> >> >>> >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > >> >>> wrote: >> >>> >> >>> Hi Alexandre, >> >>> >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/ ) in particular >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue >> >>> up (we did have broken binaries for a bit). >> >>> >> >>> If I now run >> >>> >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu >> >>> ild-dependecies-impl >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te >> >>> st-dependecies-impl >> >>> >> >>> Then I get a passing build! >> >>> >> >>> --------- >> >>> >> >>> Onto the next issue! If I run just: >> >>> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test >> >>> >> >>> Then I get compile errors like: >> >>> >> >>> compile-test: >> >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find >> >>> symbol >> >>> [javac] prnt.lookup(new ByTextItem("Table")). >> >>> wrap().mouse().click(); >> >>> [javac] ^ >> >>> [javac] symbol: class ByTextItem >> >>> [javac] location: class ItemsTest >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find >> >>> symbol >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap >> >>> ().mouse().click(); >> >>> [javac] ^ >> >>> [javac] symbol: class ByTextItem >> >>> [javac] location: class ItemsTest >> >>> >> >>> >> >>> >> >>> This, I believe, is a bug which is going to be addressed by the review in >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 >> >>> 018-April/000080.html >> >>> >> >>> Shura >> >>> >> >>> >> >>> ------------ >> >>> >> >>> A *README.txt* for building at the root of the project and a .*hgignore* >> >>> file would also be nice to haves. >> >>> >> >>> ------------ >> >>> >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy >> >>> building nightly on our build farm. I'm also very interested in seeing the >> >>> Maven support go in :-). >> >>> >> >>> Cheers, >> >>> Martijn >> >>> >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < >> >>> alexandre.iline at oracle.com > wrote: >> >>> >> >>>> Do you happen to have full stack trace of that? >> >>>> >> >>>> Also, how to I get JTReg which are you using? >> >>>> >> >>>> The reported missing method would be a part of JTReg, clearly. >> >>>> >> >>>> The other thing is you should probably be ok with just running ant ?. >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. >> >>>> >> >>>> Shura >> >>>> >> >>>> >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > >> >>>> wrote: >> >>>> >> >>>> Hi Alexandre, >> >>>> >> >>>> I got a little further (This is using Java 1.8.0_162). Once I set my >> >>>> swt.jar and jtreg.home I was able to run: >> >>>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> check-dependecies-impl >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> build-dependecies-impl >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >> >>>> K_Projects/jtreg/ test-dependecies-impl >> >>>> >> >>>> The first two execute OK but then the test gives me the test failure of: >> >>>> >> >>>> test: >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not >> >>>> found: creating >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" >> >>>> not found: creating >> >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java >> >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java >> >>>> [exec] Error. Unexpected error caught from test >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su >> >>>> n/javatest/regtest/agent/JDK_Version;)I >> >>>> [exec] Test results: error: 1 >> >>>> [exec] Report written to /Users/karianna/Documents/work >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ >> >>>> report/html/report.html >> >>>> [exec] Results written to /Users/karianna/Documents/work >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd >> >>>> [exec] Error: Some tests failed or other problems occurred. >> >>>> [exec] Result: 3 >> >>>> >> >>>> Any ideas? >> >>>> >> >>>> FYI - I'm still running this locally on my Mac OS X box until I get a >> >>>> clean build so I know the minimum steps for the build farm job. Note to >> >>>> self that the build box will need to provide a platform specific SWT lib >> >>>> (Linux x86). >> >>>> >> >>>> Cheers, >> >>>> Martijn >> >>>> >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < >> >>>> alexandre.iline at oracle.com > wrote: >> >>>> >> >>>>> Now including aliases and more recipients.. >> >>>>> >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < >> >>>>> alexandre.iline at oracle.com > wrote: >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < >> >>>>> martijnverburg at gmail.com > wrote: >> >>>>>>> >> >>>>>>> Hi Alexandre, >> >>>>>>> >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and >> >>>>> that failed with: >> >>>>>>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: >> >>>>> Please specify swt.jar >> >>>>>> >> >>>>>> You do need the SWT library to build SWT. >> >>>>>> >> >>>>>> this is what I just did: >> >>>>>> >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar >> >>>>> jar >> >>>>>> >> >>>>>> >> >>>>>> I clearly need to provide a README. Will do. >> >>>>>> >> >>>>>> Shura >> >>>>>> >> >>>>>>> >> >>>>>>> Then I actually bothered to read the build.xml file and saw the >> >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which >> >>>>> seemed to build: >> >>>>>>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyCore/build/JemmyCore.jar >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar >> >>>>>>> >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set >> >>>>>>> >> >>>>>>> Before I shave more Yaks, is this the right direction to be going in? >> >>>>>>> >> >>>>>>> >> >>>>>>> Cheers, >> >>>>>>> Martijn >> >>>>>>> >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < >> >>>>> alexandre.iline at oracle.com > wrote: >> >>>>>>> Martijn, >> >>>>>>> >> >>>>>>> Jemmy v3 consists of several project which depend on each other. >> >>>>>>> >> >>>>>>> If, besides hosting the source, the intension is to build it, you >> >>>>> need to build projects which are in use by others who would be coming to >> >>>>> AdoptOpenJDK for binaries. >> >>>>>>> >> >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. >> >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is >> >>>>> build, the dependences are also built, you should have no problem with that. >> >>>>>>> >> >>>>>>> Binaries would, then, simply include all jar files create after the >> >>>>> build. The jar files will be: */*/build/*.jar >> >>>>>>> >> >>>>>>> Shura >> >>>>>>> >> >>>>>>> >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < >> >>>>> martijnverburg at gmail.com > wrote: >> >>>>>>>> >> >>>>>>>> Hi Dalibor, >> >>>>>>>> >> >>>>>>>> We're shifting the code tools off Cloudbees to the new >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick >> >>>>> Q: >> >>>>>>>> >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: >> >>>>>>>> >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make >> >>>>>>>> >> >>>>>>>> but I can't see what the canonical entry point to build it is. >> >>>>>>>> >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. >> >>>>>>>> >> >>>>>>>> Cheers, >> >>>>>>>> Martijn >> >>>>>>>> >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic > >> >>>>> wrote: >> >>>>>>>> Hi Martijn, >> >>>>>>>> >> >>>>>>>> would you be able to add the Jemmy v3 repo at >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to >> >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? >> >>>>>>>> >> >>>>>>>> cheers, >> >>>>>>>> dalibor topic >> >>>>>>>> -- >> >>>>>>>> > Dalibor Topic | Principal Product Manager >> >>>>>>>> Phone: +494089091214 > | Mobile: >> >>>>> +491737185961 >> >>>>>>>> > >> >>>>>>>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg >> >>>>> > >> >>>>>>>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 >> >>>>> > >> >>>>> M?nchen >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 >> >>>>>>>> >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. >> >>>>>>>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande >> >>>>> > >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher >> >>>>>>>> >> >>>>>>>> > Oracle is committed to >> >>>>> developing >> >>>>>>>> practices and products that help protect the environment >> >>>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>> >> >>>>> >> >>>>> >> >>>> >> >>>> >> >>> >> >>> >> >> >> From martijnverburg at gmail.com Fri May 4 13:00:39 2018 From: martijnverburg at gmail.com (Martijn Verburg) Date: Fri, 4 May 2018 14:00:39 +0100 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: <80E4F1B0-1C7C-4277-9234-DE646ED0196C@reini.net> References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> <80E4F1B0-1C7C-4277-9234-DE646ED0196C@reini.net> Message-ID: Sounds like we need to change the version numbers and artifactId according to Erik's instructions as well? So groupId org.adoptopenjdk artifactId jemmy3 version 1.0.0-SNAPSHOT How does that sound Erik? Cheers, Martijn On 4 May 2018 at 13:19, Patrick Reinhart wrote: > Hello together, > > I went over the jemmy codebase so far, that the compilation succeeds and a > push to the maven repo is possible: > > > http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/ > > The following changes include mostly the following: > > Javadoc > The changes removed all comments, that did not provide any informations. > In those cases where the comments where not complete the I added ?todo > document? as text to pass the minimal build requirements. > > groupId/artifactId > I changed the groupId to ?org.adoptopenjdk? and all artifactId values to > be lower case and dash separated: > > The current state of the changes will build an 3.0.0-SNAPSHOT version so > far. > > Before I we can publish an initial version, we must clarify the correct > license and update the according header files. For the moment I took the > latest GPL license for my local build and its initial tests. > > > -Patrick > > > > Am 04.05.2018 um 13:38 schrieb Martijn Verburg >: > > > > Awesome, that makes life a lot easier - OK, now to get X11 running on > the build boxes we want to pass tests. > > > > Cheers, > > Martijn > > > > On 4 May 2018 at 12:01, Erik Greijus wrote: > > Hello, > > > > Sorry for the late answer. > > As for JemmySWT.jar it is platform independent (it relies on the > platform dependent SWT library - which is needed to build the project, and > later on to actually use Jemmy). > > You only need to build and make available the four jars as they are. > > > > Best regards > > /Erik > > > > > > > >> 4 maj 2018 kl. 10:39 skrev Martijn Verburg : > >> > >> Hi all, > >> > >> 1.) I'm OK with the groupId being org.adoptopenjdk - but that may cause > some confusion if we do not actually host the source code as well. Not too > big an issue if we explain this in the POM file > >> > >> 2.) Thank you Patrick (what an awesome co-incidence)! > >> > >> 3.) I'm totally OK with it being version 3.0.0, so I'd recommend > setting the version to 3.0.0-SNAPSHOT to start with. > >> > >> I'd still like to understand if we need a SWT JAR for each platform, is > someone able to answer that? > >> > >> > >> > >> Cheers, > >> Martijn > >> > >> On 3 May 2018 at 21:17, Marcus Hirt wrote: > >> So, we?re suggesting to use adoptopenjdk.org as groupid and change the > camel case module names to lower case and dashes. Patrick is also fixing > the javadocs, as that must be done to publish the source Jars. I think > Patrick will be back with big wonderful patch soon. :) > >> > >> > >> > >> Also, would it be okay to not have v3 in the name, but rather just set > the version to 3.0.0? > >> > >> > >> > >> Kind regards, > >> > >> Marcus > >> > >> > >> > >> From: Martijn Verburg > >> Date: Thursday, 3 May 2018 at 22:13 > >> To: Erik Greijus > >> Cc: "Alexandre (Shura) Iline" , " > adoption-discuss at openjdk.java.net" , < > jemmy-dev at openjdk.java.net>, dalibor topic , > Marcus Hirt , Patrick Reinhart < > patrick.reinhart at gmail.com> > >> Subject: Re: Adding Jemmy v3 to https://adopt-openjdk.ci. > cloudbees.com/view/OpenJDK%20code-tools/ > >> > >> > >> > >> Hi all, > >> > >> > >> > >> I've made a little further progress with the new Maven based Jemmy > build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/). > I have a few questions / comments. > >> > >> > >> > >> 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do > we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, > JemmySWT-windows-1.0.jar? > >> > >> > >> > >> > >> 2.) I still need to figure out how to bring up the Linux UI for our > build node to pass the tests, I'm skipping for now. > >> > >> > >> > >> > >> 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and > release versions. > >> > >> > >> > >> * In terms of SNAPSHOTS we could could likely push on every build > >> > >> * In terms of releases we can add a release task (or a release job if > we Jenkins pipeline pro it) that can be manaully executed when the Jemmy > team decides to cut a release > >> > >> > >> > >> My suggestion is that you: > >> > >> > >> > >> 1.) Change the version numbers to 1.0.0-SNAPSHOT > >> > >> 2.) We get a SNAPSHOT release out to Maven Central (and practice > getting past the OSSRH gatekeeper) > >> > >> 3.) We perform a formal release (1.0.0) and push that to Maven Central > >> > >> 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be > manually changed to whatever you need > >> > >> > >> > >> I notice that `org.jemmy.v3` is your groupID, that might be OK but the > OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on > this so I've cruelly dragged in Patrick Reinhart who's done Maven Central > deploys for other Adopt projects in the past, sorry Patrick! > >> > >> > >> > >> Cheers, > >> Martijn > >> > >> > >> > >> On 13 April 2018 at 08:40, Erik Greijus > wrote: > >> > >> > >> > >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg < > martijnverburg at gmail.com>: > >> > > >> > Hi all, > >> > > >> > The Jemmy build project is here: > >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ > >> > > >> > If managed to get a mostly successful run and have produced a > jemmy.tar.gz > >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, > >> > JemmyBrowser.jar). Now for some questions :-) > >> > > >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT > lib, do > >> > platform specific jemmy's need to be built? > >> > >> Yes. The JemmySWT jar should have been built as well > (./SWT/JemmySWT/target/...) > >> > >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll > see if > >> > I can get that Jenkins node to fire up an X11 so that those tests can > pass. > >> > >> That would be good. > >> > >> > 3.) Can folks please grab the tar.gz from the latest artifacts link > >> > lastSuccessfulBuild/artifact/> > >> > and let me know if that's how they expect it to be named and whether > the > >> > layout of the contents is acceptable > >> > >> I miss the JemmySWT jar file mentioned above. > >> > >> > >> > 4.) Versioning / naming - should I be building off a known good tag? > Do we > >> > want the tip/commit number to be part of the artifact name? > >> > > >> > It should build on an SCM change and weekly as well > >> > > >> > > >> > Cheers, > >> > Martijn > >> > > >> > On 11 April 2018 at 09:56, Martijn Verburg > wrote: > >> > > >> >> Cool, I'll go with what I have as a working build for now and adjust > to > >> >> use the test target when that change comes in, and then perhaps move > to the > >> >> Maven build later. > >> >> > >> >> Cheers, > >> >> Martijn > >> >> > >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < > >> >> alexandre.iline at oracle.com> wrote: > >> >> > >> >>> > >> >>> > >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg < > martijnverburg at gmail.com> > >> >>> wrote: > >> >>> > >> >>> Hi Alexandre, > >> >>> > >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( > >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/) in particular > >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that > issue > >> >>> up (we did have broken binaries for a bit). > >> >>> > >> >>> If I now run > >> >>> > >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu > >> >>> ild-dependecies-impl > >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/ > AdoptOpenJDK_Projects/jtreg/ > >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te > >> >>> st-dependecies-impl > >> >>> > >> >>> Then I get a passing build! > >> >>> > >> >>> --------- > >> >>> > >> >>> Onto the next issue! If I run just: > >> >>> > >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/ > AdoptOpenJDK_Projects/jtreg/ > >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test > >> >>> > >> >>> Then I get compile errors like: > >> >>> > >> >>> compile-test: > >> >>> [javac] Compiling 7 source files to > /Users/karianna/Documents/work > >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test > >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_ > Projects/ > >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: > cannot find > >> >>> symbol > >> >>> [javac] prnt.lookup(new ByTextItem("Table")). > >> >>> wrap().mouse().click(); > >> >>> [javac] ^ > >> >>> [javac] symbol: class ByTextItem > >> >>> [javac] location: class ItemsTest > >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_ > Projects/ > >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: > cannot find > >> >>> symbol > >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap > >> >>> ().mouse().click(); > >> >>> [javac] ^ > >> >>> [javac] symbol: class ByTextItem > >> >>> [javac] location: class ItemsTest > >> >>> > >> >>> > >> >>> > >> >>> This, I believe, is a bug which is going to be addressed by the > review in > >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 > >> >>> 018-April/000080.html > >> >>> > >> >>> Shura > >> >>> > >> >>> > >> >>> ------------ > >> >>> > >> > >> >>> A *README.txt* for building at the root of the project and a > .*hgignore* > >> > >> >>> file would also be nice to haves. > >> >>> > >> >>> ------------ > >> >>> > >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get > Jemmy > >> >>> building nightly on our build farm. I'm also very interested in > seeing the > >> >>> Maven support go in :-). > >> >>> > >> >>> Cheers, > >> >>> Martijn > >> >>> > >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < > >> >>> alexandre.iline at oracle.com> wrote: > >> >>> > >> >>>> Do you happen to have full stack trace of that? > >> >>>> > >> >>>> Also, how to I get JTReg which are you using? > >> >>>> > >> >>>> The reported missing method would be a part of JTReg, clearly. > >> >>>> > >> >>>> The other thing is you should probably be ok with just running ant > ?. > >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne > >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. > >> >>>> > >> >>>> Shura > >> >>>> > >> >>>> > >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg < > martijnverburg at gmail.com> > >> >>>> wrote: > >> >>>> > >> >>>> Hi Alexandre, > >> >>>> > >> >>>> I got a little further (This is using Java 1.8.0_162). Once I set > my > >> >>>> swt.jar and jtreg.home I was able to run: > >> >>>> > >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >> >>>> check-dependecies-impl > >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >> >>>> build-dependecies-impl > >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD > >> > >> >>>> K_Projects/jtreg/ test-dependecies-impl > >> > >> >>>> > >> >>>> The first two execute OK but then the test gives me the test > failure of: > >> >>>> > >> >>>> test: > >> >>>> [exec] Directory "/Users/karianna/Documents/wor > >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" > not > >> >>>> found: creating > >> >>>> [exec] Directory "/Users/karianna/Documents/wor > >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/ > test_report" > >> >>>> not found: creating > >> >>>> [exec] runner starting test: org/jemmy/browser/ > PropPanelTest.java > >> >>>> [exec] runner finished test: org/jemmy/browser/ > PropPanelTest.java > >> >>>> [exec] Error. Unexpected error caught from test > >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: > >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su > >> >>>> n/javatest/regtest/agent/JDK_Version;)I > >> >>>> [exec] Test results: error: 1 > >> >>>> [exec] Report written to /Users/karianna/Documents/work > >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ > >> >>>> report/html/report.html > >> >>>> [exec] Results written to /Users/karianna/Documents/work > >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd > >> >>>> [exec] Error: Some tests failed or other problems occurred. > >> >>>> [exec] Result: 3 > >> >>>> > >> >>>> Any ideas? > >> >>>> > >> >>>> FYI - I'm still running this locally on my Mac OS X box until I > get a > >> >>>> clean build so I know the minimum steps for the build farm job. > Note to > >> >>>> self that the build box will need to provide a platform specific > SWT lib > >> >>>> (Linux x86). > >> >>>> > >> >>>> Cheers, > >> >>>> Martijn > >> >>>> > >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < > >> >>>> alexandre.iline at oracle.com> wrote: > >> >>>> > >> >>>>> Now including aliases and more recipients.. > >> >>>>> > >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < > >> >>>>> alexandre.iline at oracle.com> wrote: > >> >>>>>> > >> >>>>>> > >> >>>>>> > >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < > >> >>>>> martijnverburg at gmail.com> wrote: > >> >>>>>>> > >> >>>>>>> Hi Alexandre, > >> >>>>>>> > >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and > >> >>>>> that failed with: > >> >>>>>>> > >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_ > Projects/v3/SWT/JemmySWT/build.xml:33: > >> >>>>> Please specify swt.jar > >> >>>>>> > >> >>>>>> You do need the SWT library to build SWT. > >> >>>>>> > >> >>>>>> this is what I just did: > >> >>>>>> > >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/ > plugins/org.eclipse.swt_3.8.2.jar > >> >>>>> jar > >> >>>>>> > >> >>>>>> > >> >>>>>> I clearly need to provide a README. Will do. > >> >>>>>> > >> >>>>>> Shura > >> >>>>>> > >> >>>>>>> > >> >>>>>>> Then I actually bothered to read the build.xml file and saw the > >> >>>>> build-dependecies-impl target, so I ran ant > build-dependecies-impl which > >> >>>>> seemed to build: > >> >>>>>>> > >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >> >>>>> /core/JemmyCore/build/JemmyCore.jar > >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar > >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar > >> >>>>>>> > >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my > jtreg.home set > >> >>>>>>> > >> >>>>>>> Before I shave more Yaks, is this the right direction to be > going in? > >> >>>>>>> > >> >>>>>>> > >> >>>>>>> Cheers, > >> >>>>>>> Martijn > >> >>>>>>> > >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < > >> >>>>> alexandre.iline at oracle.com> wrote: > >> >>>>>>> Martijn, > >> >>>>>>> > >> >>>>>>> Jemmy v3 consists of several project which depend on each other. > >> >>>>>>> > >> >>>>>>> If, besides hosting the source, the intension is to build it, > you > >> >>>>> need to build projects which are in use by others who would be > coming to > >> >>>>> AdoptOpenJDK for binaries. > >> >>>>>>> > >> >>>>>>> At this point of time, from what I know, JemmySWT is what is > needed. > >> >>>>> Ant build scripts are constructed in a way so that by while > JemmySWT is > >> >>>>> build, the dependences are also built, you should have no problem > with that. > >> >>>>>>> > >> >>>>>>> Binaries would, then, simply include all jar files create after > the > >> >>>>> build. The jar files will be: */*/build/*.jar > >> >>>>>>> > >> >>>>>>> Shura > >> >>>>>>> > >> >>>>>>> > >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < > >> >>>>> martijnverburg at gmail.com> wrote: > >> >>>>>>>> > >> >>>>>>>> Hi Dalibor, > >> >>>>>>>> > >> >>>>>>>> We're shifting the code tools off Cloudbees to the new > >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a > quick > >> >>>>> Q: > >> >>>>>>>> > >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ > gives me: > >> >>>>>>>> > >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . > >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. > >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg > >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck > >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT > >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core > >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make > >> >>>>>>>> > >> >>>>>>>> but I can't see what the canonical entry point to build it is. > >> >>>>>>>> > >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. > >> >>>>>>>> > >> >>>>>>>> Cheers, > >> >>>>>>>> Martijn > >> >>>>>>>> > >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic < > dalibor.topic at oracle.com> > >> >>>>> wrote: > >> >>>>>>>> Hi Martijn, > >> >>>>>>>> > >> >>>>>>>> would you be able to add the Jemmy v3 repo at > >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to > >> >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ > ? > >> >>>>>>>> > >> >>>>>>>> cheers, > >> >>>>>>>> dalibor topic > >> >>>>>>>> -- > >> >>>>>>>> Dalibor Topic | Principal Product > Manager > >> > >> >>>>>>>> Phone: +494089091214 > | > Mobile: > >> >>>>> +491737185961 > >> >>>>>>>> > > >> >>>>>>>> > >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg > >> >>>>> Hamburg&entry=gmail&source=g> > >> >>>>>>>> > >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG > >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 > >> >>>>> gmail&source=g> > >> >>>>> M?nchen > >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 > >> >>>>>>>> > >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. > >> >>>>>>>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande > >> >>>>> AS+Utrecht,+Niederlande&entry=gmail&source=g> > >> > >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. > 30143697 > >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val > Maher > >> >>>>>>>> > >> >>>>>>>> Oracle is committed to > >> >>>>> developing > >> >>>>>>>> practices and products that help protect the environment > >> >>>>>>>> > >> >>>>>>> > >> >>>>>>> > >> >>>>>> > >> >>>>> > >> >>>>> > >> >>>> > >> >>>> > >> >>> > >> >>> > >> >> > >> > >> > >> > >> > > > > > > From erik.greijus at oracle.com Fri May 4 13:04:23 2018 From: erik.greijus at oracle.com (Erik Greijus) Date: Fri, 4 May 2018 15:04:23 +0200 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> <80E4F1B0-1C7C-4277-9234-DE646ED0196C@reini.net> Message-ID: I think that?s better. Remember that each of the modules have their own version as well (see the version.properties file for each of them). Regards /Erik > 4 maj 2018 kl. 15:00 skrev Martijn Verburg : > > Sounds like we need to change the version numbers and artifactId according to Erik's instructions as well? > > So > > groupId org.adoptopenjdk > artifactId jemmy3 > version 1.0.0-SNAPSHOT > > How does that sound Erik? > > > > > Cheers, > Martijn > > On 4 May 2018 at 13:19, Patrick Reinhart > wrote: > Hello together, > > I went over the jemmy codebase so far, that the compilation succeeds and a push to the maven repo is possible: > > > http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/ > > The following changes include mostly the following: > > Javadoc > The changes removed all comments, that did not provide any informations. In those cases where the comments where not complete the I added ?todo document? as text to pass the minimal build requirements. > > groupId/artifactId > I changed the groupId to ?org.adoptopenjdk? and all artifactId values to be lower case and dash separated: > > The current state of the changes will build an 3.0.0-SNAPSHOT version so far. > > Before I we can publish an initial version, we must clarify the correct license and update the according header files. For the moment I took the latest GPL license for my local build and its initial tests. > > > -Patrick > > > > Am 04.05.2018 um 13:38 schrieb Martijn Verburg >: > > > > Awesome, that makes life a lot easier - OK, now to get X11 running on the build boxes we want to pass tests. > > > > Cheers, > > Martijn > > > > On 4 May 2018 at 12:01, Erik Greijus > wrote: > > Hello, > > > > Sorry for the late answer. > > As for JemmySWT.jar it is platform independent (it relies on the platform dependent SWT library - which is needed to build the project, and later on to actually use Jemmy). > > You only need to build and make available the four jars as they are. > > > > Best regards > > /Erik > > > > > > > >> 4 maj 2018 kl. 10:39 skrev Martijn Verburg >: > >> > >> Hi all, > >> > >> 1.) I'm OK with the groupId being org.adoptopenjdk - but that may cause some confusion if we do not actually host the source code as well. Not too big an issue if we explain this in the POM file > >> > >> 2.) Thank you Patrick (what an awesome co-incidence)! > >> > >> 3.) I'm totally OK with it being version 3.0.0, so I'd recommend setting the version to 3.0.0-SNAPSHOT to start with. > >> > >> I'd still like to understand if we need a SWT JAR for each platform, is someone able to answer that? > >> > >> > >> > >> Cheers, > >> Martijn > >> > >> On 3 May 2018 at 21:17, Marcus Hirt > wrote: > >> So, we?re suggesting to use adoptopenjdk.org as groupid and change the camel case module names to lower case and dashes. Patrick is also fixing the javadocs, as that must be done to publish the source Jars. I think Patrick will be back with big wonderful patch soon. :) > >> > >> > >> > >> Also, would it be okay to not have v3 in the name, but rather just set the version to 3.0.0? > >> > >> > >> > >> Kind regards, > >> > >> Marcus > >> > >> > >> > >> From: Martijn Verburg > > >> Date: Thursday, 3 May 2018 at 22:13 > >> To: Erik Greijus > > >> Cc: "Alexandre (Shura) Iline" >, "adoption-discuss at openjdk.java.net " >, >, dalibor topic >, Marcus Hirt >, Patrick Reinhart > > >> Subject: Re: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ > >> > >> > >> > >> Hi all, > >> > >> > >> > >> I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/ ). I have a few questions / comments. > >> > >> > >> > >> 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? > >> > >> > >> > >> > >> 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. > >> > >> > >> > >> > >> 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. > >> > >> > >> > >> * In terms of SNAPSHOTS we could could likely push on every build > >> > >> * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release > >> > >> > >> > >> My suggestion is that you: > >> > >> > >> > >> 1.) Change the version numbers to 1.0.0-SNAPSHOT > >> > >> 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) > >> > >> 3.) We perform a formal release (1.0.0) and push that to Maven Central > >> > >> 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need > >> > >> > >> > >> I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! > >> > >> > >> > >> Cheers, > >> Martijn > >> > >> > >> > >> On 13 April 2018 at 08:40, Erik Greijus > wrote: > >> > >> > >> > >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg >: > >> > > >> > Hi all, > >> > > >> > The Jemmy build project is here: > >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ > >> > > >> > If managed to get a mostly successful run and have produced a jemmy.tar.gz > >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, > >> > JemmyBrowser.jar). Now for some questions :-) > >> > > >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do > >> > platform specific jemmy's need to be built? > >> > >> Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) > >> > >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if > >> > I can get that Jenkins node to fire up an X11 so that those tests can pass. > >> > >> That would be good. > >> > >> > 3.) Can folks please grab the tar.gz from the latest artifacts link > >> > > > >> > and let me know if that's how they expect it to be named and whether the > >> > layout of the contents is acceptable > >> > >> I miss the JemmySWT jar file mentioned above. > >> > >> > >> > 4.) Versioning / naming - should I be building off a known good tag? Do we > >> > want the tip/commit number to be part of the artifact name? > >> > > >> > It should build on an SCM change and weekly as well > >> > > >> > > >> > Cheers, > >> > Martijn > >> > > >> > On 11 April 2018 at 09:56, Martijn Verburg > wrote: > >> > > >> >> Cool, I'll go with what I have as a working build for now and adjust to > >> >> use the test target when that change comes in, and then perhaps move to the > >> >> Maven build later. > >> >> > >> >> Cheers, > >> >> Martijn > >> >> > >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < > >> >> alexandre.iline at oracle.com > wrote: > >> >> > >> >>> > >> >>> > >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > > >> >>> wrote: > >> >>> > >> >>> Hi Alexandre, > >> >>> > >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( > >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/ ) in particular > >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue > >> >>> up (we did have broken binaries for a bit). > >> >>> > >> >>> If I now run > >> >>> > >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu > >> >>> ild-dependecies-impl > >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ > >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te > >> >>> st-dependecies-impl > >> >>> > >> >>> Then I get a passing build! > >> >>> > >> >>> --------- > >> >>> > >> >>> Onto the next issue! If I run just: > >> >>> > >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ > >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test > >> >>> > >> >>> Then I get compile errors like: > >> >>> > >> >>> compile-test: > >> >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work > >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test > >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find > >> >>> symbol > >> >>> [javac] prnt.lookup(new ByTextItem("Table")). > >> >>> wrap().mouse().click(); > >> >>> [javac] ^ > >> >>> [javac] symbol: class ByTextItem > >> >>> [javac] location: class ItemsTest > >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find > >> >>> symbol > >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap > >> >>> ().mouse().click(); > >> >>> [javac] ^ > >> >>> [javac] symbol: class ByTextItem > >> >>> [javac] location: class ItemsTest > >> >>> > >> >>> > >> >>> > >> >>> This, I believe, is a bug which is going to be addressed by the review in > >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 > >> >>> 018-April/000080.html > >> >>> > >> >>> Shura > >> >>> > >> >>> > >> >>> ------------ > >> >>> > >> > >> >>> A *README.txt* for building at the root of the project and a .*hgignore* > >> > >> >>> file would also be nice to haves. > >> >>> > >> >>> ------------ > >> >>> > >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy > >> >>> building nightly on our build farm. I'm also very interested in seeing the > >> >>> Maven support go in :-). > >> >>> > >> >>> Cheers, > >> >>> Martijn > >> >>> > >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < > >> >>> alexandre.iline at oracle.com > wrote: > >> >>> > >> >>>> Do you happen to have full stack trace of that? > >> >>>> > >> >>>> Also, how to I get JTReg which are you using? > >> >>>> > >> >>>> The reported missing method would be a part of JTReg, clearly. > >> >>>> > >> >>>> The other thing is you should probably be ok with just running ant ?. > >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne > >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. > >> >>>> > >> >>>> Shura > >> >>>> > >> >>>> > >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > > >> >>>> wrote: > >> >>>> > >> >>>> Hi Alexandre, > >> >>>> > >> >>>> I got a little further (This is using Java 1.8.0_162). Once I set my > >> >>>> swt.jar and jtreg.home I was able to run: > >> >>>> > >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >> >>>> check-dependecies-impl > >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >> >>>> build-dependecies-impl > >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD > >> > >> >>>> K_Projects/jtreg/ test-dependecies-impl > >> > >> >>>> > >> >>>> The first two execute OK but then the test gives me the test failure of: > >> >>>> > >> >>>> test: > >> >>>> [exec] Directory "/Users/karianna/Documents/wor > >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not > >> >>>> found: creating > >> >>>> [exec] Directory "/Users/karianna/Documents/wor > >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" > >> >>>> not found: creating > >> >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java > >> >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java > >> >>>> [exec] Error. Unexpected error caught from test > >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: > >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su > >> >>>> n/javatest/regtest/agent/JDK_Version;)I > >> >>>> [exec] Test results: error: 1 > >> >>>> [exec] Report written to /Users/karianna/Documents/work > >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ > >> >>>> report/html/report.html > >> >>>> [exec] Results written to /Users/karianna/Documents/work > >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd > >> >>>> [exec] Error: Some tests failed or other problems occurred. > >> >>>> [exec] Result: 3 > >> >>>> > >> >>>> Any ideas? > >> >>>> > >> >>>> FYI - I'm still running this locally on my Mac OS X box until I get a > >> >>>> clean build so I know the minimum steps for the build farm job. Note to > >> >>>> self that the build box will need to provide a platform specific SWT lib > >> >>>> (Linux x86). > >> >>>> > >> >>>> Cheers, > >> >>>> Martijn > >> >>>> > >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < > >> >>>> alexandre.iline at oracle.com > wrote: > >> >>>> > >> >>>>> Now including aliases and more recipients.. > >> >>>>> > >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < > >> >>>>> alexandre.iline at oracle.com > wrote: > >> >>>>>> > >> >>>>>> > >> >>>>>> > >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < > >> >>>>> martijnverburg at gmail.com > wrote: > >> >>>>>>> > >> >>>>>>> Hi Alexandre, > >> >>>>>>> > >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and > >> >>>>> that failed with: > >> >>>>>>> > >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: > >> >>>>> Please specify swt.jar > >> >>>>>> > >> >>>>>> You do need the SWT library to build SWT. > >> >>>>>> > >> >>>>>> this is what I just did: > >> >>>>>> > >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar > >> >>>>> jar > >> >>>>>> > >> >>>>>> > >> >>>>>> I clearly need to provide a README. Will do. > >> >>>>>> > >> >>>>>> Shura > >> >>>>>> > >> >>>>>>> > >> >>>>>>> Then I actually bothered to read the build.xml file and saw the > >> >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which > >> >>>>> seemed to build: > >> >>>>>>> > >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >> >>>>> /core/JemmyCore/build/JemmyCore.jar > >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar > >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar > >> >>>>>>> > >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set > >> >>>>>>> > >> >>>>>>> Before I shave more Yaks, is this the right direction to be going in? > >> >>>>>>> > >> >>>>>>> > >> >>>>>>> Cheers, > >> >>>>>>> Martijn > >> >>>>>>> > >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < > >> >>>>> alexandre.iline at oracle.com > wrote: > >> >>>>>>> Martijn, > >> >>>>>>> > >> >>>>>>> Jemmy v3 consists of several project which depend on each other. > >> >>>>>>> > >> >>>>>>> If, besides hosting the source, the intension is to build it, you > >> >>>>> need to build projects which are in use by others who would be coming to > >> >>>>> AdoptOpenJDK for binaries. > >> >>>>>>> > >> >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. > >> >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is > >> >>>>> build, the dependences are also built, you should have no problem with that. > >> >>>>>>> > >> >>>>>>> Binaries would, then, simply include all jar files create after the > >> >>>>> build. The jar files will be: */*/build/*.jar > >> >>>>>>> > >> >>>>>>> Shura > >> >>>>>>> > >> >>>>>>> > >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < > >> >>>>> martijnverburg at gmail.com > wrote: > >> >>>>>>>> > >> >>>>>>>> Hi Dalibor, > >> >>>>>>>> > >> >>>>>>>> We're shifting the code tools off Cloudbees to the new > >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick > >> >>>>> Q: > >> >>>>>>>> > >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: > >> >>>>>>>> > >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . > >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. > >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg > >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck > >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT > >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core > >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make > >> >>>>>>>> > >> >>>>>>>> but I can't see what the canonical entry point to build it is. > >> >>>>>>>> > >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. > >> >>>>>>>> > >> >>>>>>>> Cheers, > >> >>>>>>>> Martijn > >> >>>>>>>> > >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic > > >> >>>>> wrote: > >> >>>>>>>> Hi Martijn, > >> >>>>>>>> > >> >>>>>>>> would you be able to add the Jemmy v3 repo at > >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to > >> >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? > >> >>>>>>>> > >> >>>>>>>> cheers, > >> >>>>>>>> dalibor topic > >> >>>>>>>> -- > >> >>>>>>>> > Dalibor Topic | Principal Product Manager > >> > >> >>>>>>>> Phone: +494089091214 > | Mobile: > >> >>>>> +491737185961 > >> >>>>>>>> > > >> >>>>>>>> > >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg > >> >>>>> > > >> >>>>>>>> > >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG > >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 > >> >>>>> > > >> >>>>> M?nchen > >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 > >> >>>>>>>> > >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. > >> >>>>>>>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande > >> >>>>> > > >> > >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 > >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher > >> >>>>>>>> > >> >>>>>>>> > Oracle is committed to > >> >>>>> developing > >> >>>>>>>> practices and products that help protect the environment > >> >>>>>>>> > >> >>>>>>> > >> >>>>>>> > >> >>>>>> > >> >>>>> > >> >>>>> > >> >>>> > >> >>>> > >> >>> > >> >>> > >> >> > >> > >> > >> > >> > > > > > > From martijnverburg at gmail.com Fri May 4 13:18:18 2018 From: martijnverburg at gmail.com (Martijn Verburg) Date: Fri, 04 May 2018 13:18:18 +0000 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> <80E4F1B0-1C7C-4277-9234-DE646ED0196C@reini.net> Message-ID: Hmmm - is it worth unifying the module numbers to 1.0.0 for this initial release? On Fri, 4 May 2018 at 14:04, Erik Greijus wrote: > I think that?s better. Remember that each of the modules have their own > version as well (see the version.properties file for each of them). > > Regards > /Erik > > > 4 maj 2018 kl. 15:00 skrev Martijn Verburg : > > Sounds like we need to change the version numbers and artifactId according > to Erik's instructions as well? > > So > > groupId org.adoptopenjdk > artifactId jemmy3 > version 1.0.0-SNAPSHOT > > How does that sound Erik? > > > > > Cheers, > Martijn > > On 4 May 2018 at 13:19, Patrick Reinhart wrote: > >> Hello together, >> >> I went over the jemmy codebase so far, that the compilation succeeds and >> a push to the maven repo is possible: >> >> >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/ >> >> The following changes include mostly the following: >> >> Javadoc >> The changes removed all comments, that did not provide any informations. >> In those cases where the comments where not complete the I added ?todo >> document? as text to pass the minimal build requirements. >> >> groupId/artifactId >> I changed the groupId to ?org.adoptopenjdk? and all artifactId values to >> be lower case and dash separated: >> >> The current state of the changes will build an 3.0.0-SNAPSHOT version so >> far. >> >> Before I we can publish an initial version, we must clarify the correct >> license and update the according header files. For the moment I took the >> latest GPL license for my local build and its initial tests. >> >> >> -Patrick >> >> >> > Am 04.05.2018 um 13:38 schrieb Martijn Verburg < >> martijnverburg at gmail.com>: >> > >> > Awesome, that makes life a lot easier - OK, now to get X11 running on >> the build boxes we want to pass tests. >> > >> > Cheers, >> > Martijn >> > >> > On 4 May 2018 at 12:01, Erik Greijus wrote: >> > Hello, >> > >> > Sorry for the late answer. >> > As for JemmySWT.jar it is platform independent (it relies on the >> platform dependent SWT library - which is needed to build the project, and >> later on to actually use Jemmy). >> > You only need to build and make available the four jars as they are. >> > >> > Best regards >> > /Erik >> > >> > >> > >> >> 4 maj 2018 kl. 10:39 skrev Martijn Verburg : >> >> >> >> Hi all, >> >> >> >> 1.) I'm OK with the groupId being org.adoptopenjdk - but that may >> cause some confusion if we do not actually host the source code as well. >> Not too big an issue if we explain this in the POM file >> >> >> >> 2.) Thank you Patrick (what an awesome co-incidence)! >> >> >> >> 3.) I'm totally OK with it being version 3.0.0, so I'd recommend >> setting the version to 3.0.0-SNAPSHOT to start with. >> >> >> >> I'd still like to understand if we need a SWT JAR for each platform, >> is someone able to answer that? >> >> >> >> >> >> >> >> Cheers, >> >> Martijn >> >> >> >> On 3 May 2018 at 21:17, Marcus Hirt wrote: >> >> So, we?re suggesting to use adoptopenjdk.org as groupid and change >> the camel case module names to lower case and dashes. Patrick is also >> fixing the javadocs, as that must be done to publish the source Jars. I >> think Patrick will be back with big wonderful patch soon. :) >> >> >> >> >> >> >> >> Also, would it be okay to not have v3 in the name, but rather just set >> the version to 3.0.0? >> >> >> >> >> >> >> >> Kind regards, >> >> >> >> Marcus >> >> >> >> >> >> >> >> From: Martijn Verburg >> >> Date: Thursday, 3 May 2018 at 22:13 >> >> To: Erik Greijus >> >> Cc: "Alexandre (Shura) Iline" , " >> adoption-discuss at openjdk.java.net" , < >> jemmy-dev at openjdk.java.net>, dalibor topic , >> Marcus Hirt , Patrick Reinhart < >> patrick.reinhart at gmail.com> >> >> Subject: Re: Adding Jemmy v3 to >> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ >> >> >> >> >> >> >> >> Hi all, >> >> >> >> >> >> >> >> I've made a little further progress with the new Maven based Jemmy >> build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/). >> I have a few questions / comments. >> >> >> >> >> >> >> >> 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do >> we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, >> JemmySWT-windows-1.0.jar? >> >> >> >> >> >> >> >> >> >> 2.) I still need to figure out how to bring up the Linux UI for our >> build node to pass the tests, I'm skipping for now. >> >> >> >> >> >> >> >> >> >> 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and >> release versions. >> >> >> >> >> >> >> >> * In terms of SNAPSHOTS we could could likely push on every build >> >> >> >> * In terms of releases we can add a release task (or a release job if >> we Jenkins pipeline pro it) that can be manaully executed when the Jemmy >> team decides to cut a release >> >> >> >> >> >> >> >> My suggestion is that you: >> >> >> >> >> >> >> >> 1.) Change the version numbers to 1.0.0-SNAPSHOT >> >> >> >> 2.) We get a SNAPSHOT release out to Maven Central (and practice >> getting past the OSSRH gatekeeper) >> >> >> >> 3.) We perform a formal release (1.0.0) and push that to Maven Central >> >> >> >> 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be >> manually changed to whatever you need >> >> >> >> >> >> >> >> I notice that `org.jemmy.v3` is your groupID, that might be OK but the >> OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on >> this so I've cruelly dragged in Patrick Reinhart who's done Maven Central >> deploys for other Adopt projects in the past, sorry Patrick! >> >> >> >> >> >> >> >> Cheers, >> >> Martijn >> >> >> >> >> >> >> >> On 13 April 2018 at 08:40, Erik Greijus >> wrote: >> >> >> >> >> >> >> >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg < >> martijnverburg at gmail.com>: >> >> > >> >> > Hi all, >> >> > >> >> > The Jemmy build project is here: >> >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ >> >> > >> >> > If managed to get a mostly successful run and have produced a >> jemmy.tar.gz >> >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, >> >> > JemmyBrowser.jar). Now for some questions :-) >> >> > >> >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT >> lib, do >> >> > platform specific jemmy's need to be built? >> >> >> >> Yes. The JemmySWT jar should have been built as well >> (./SWT/JemmySWT/target/...) >> >> >> >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll >> see if >> >> > I can get that Jenkins node to fire up an X11 so that those tests >> can pass. >> >> >> >> That would be good. >> >> >> >> > 3.) Can folks please grab the tar.gz from the latest artifacts link >> >> > < >> https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/lastSuccessfulBuild/artifact/ >> > >> >> > and let me know if that's how they expect it to be named and whether >> the >> >> > layout of the contents is acceptable >> >> >> >> I miss the JemmySWT jar file mentioned above. >> >> >> >> >> >> > 4.) Versioning / naming - should I be building off a known good >> tag? Do we >> >> > want the tip/commit number to be part of the artifact name? >> >> > >> >> > It should build on an SCM change and weekly as well >> >> > >> >> > >> >> > Cheers, >> >> > Martijn >> >> > >> >> > On 11 April 2018 at 09:56, Martijn Verburg >> wrote: >> >> > >> >> >> Cool, I'll go with what I have as a working build for now and >> adjust to >> >> >> use the test target when that change comes in, and then perhaps >> move to the >> >> >> Maven build later. >> >> >> >> >> >> Cheers, >> >> >> Martijn >> >> >> >> >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < >> >> >> alexandre.iline at oracle.com> wrote: >> >> >> >> >> >>> >> >> >>> >> >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg < >> martijnverburg at gmail.com> >> >> >>> wrote: >> >> >>> >> >> >>> Hi Alexandre, >> >> >>> >> >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( >> >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/) in particular >> >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared >> that issue >> >> >>> up (we did have broken binaries for a bit). >> >> >>> >> >> >>> If I now run >> >> >>> >> >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu >> >> >>> ild-dependecies-impl >> >> >>> ant >> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te >> >> >>> st-dependecies-impl >> >> >>> >> >> >>> Then I get a passing build! >> >> >>> >> >> >>> --------- >> >> >>> >> >> >>> Onto the next issue! If I run just: >> >> >>> >> >> >>> ant >> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test >> >> >>> >> >> >>> Then I get compile errors like: >> >> >>> >> >> >>> compile-test: >> >> >>> [javac] Compiling 7 source files to >> /Users/karianna/Documents/work >> >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test >> >> >>> [javac] >> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: >> cannot find >> >> >>> symbol >> >> >>> [javac] prnt.lookup(new ByTextItem("Table")). >> >> >>> wrap().mouse().click(); >> >> >>> [javac] ^ >> >> >>> [javac] symbol: class ByTextItem >> >> >>> [javac] location: class ItemsTest >> >> >>> [javac] >> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: >> cannot find >> >> >>> symbol >> >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap >> >> >>> ().mouse().click(); >> >> >>> [javac] ^ >> >> >>> [javac] symbol: class ByTextItem >> >> >>> [javac] location: class ItemsTest >> >> >>> >> >> >>> >> >> >>> >> >> >>> This, I believe, is a bug which is going to be addressed by the >> review in >> >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 >> >> >>> 018-April/000080.html >> >> >>> >> >> >>> Shura >> >> >>> >> >> >>> >> >> >>> ------------ >> >> >>> >> >> >> >> >>> A *README.txt* for building at the root of the project and a >> .*hgignore* >> >> >> >> >>> file would also be nice to haves. >> >> >>> >> >> >>> ------------ >> >> >>> >> >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get >> Jemmy >> >> >>> building nightly on our build farm. I'm also very interested in >> seeing the >> >> >>> Maven support go in :-). >> >> >>> >> >> >>> Cheers, >> >> >>> Martijn >> >> >>> >> >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < >> >> >>> alexandre.iline at oracle.com> wrote: >> >> >>> >> >> >>>> Do you happen to have full stack trace of that? >> >> >>>> >> >> >>>> Also, how to I get JTReg which are you using? >> >> >>>> >> >> >>>> The reported missing method would be a part of JTReg, clearly. >> >> >>>> >> >> >>>> The other thing is you should probably be ok with just running >> ant ?. >> >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne >> >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. >> >> >>>> >> >> >>>> Shura >> >> >>>> >> >> >>>> >> >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg < >> martijnverburg at gmail.com> >> >> >>>> wrote: >> >> >>>> >> >> >>>> Hi Alexandre, >> >> >>>> >> >> >>>> I got a little further (This is using Java 1.8.0_162). Once I >> set my >> >> >>>> swt.jar and jtreg.home I was able to run: >> >> >>>> >> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >> >>>> check-dependecies-impl >> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >> >>>> build-dependecies-impl >> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >> >> >> >> >>>> K_Projects/jtreg/ test-dependecies-impl >> >> >> >> >>>> >> >> >>>> The first two execute OK but then the test gives me the test >> failure of: >> >> >>>> >> >> >>>> test: >> >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" >> not >> >> >>>> found: creating >> >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >> >>>> >> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" >> >> >>>> not found: creating >> >> >>>> [exec] runner starting test: >> org/jemmy/browser/PropPanelTest.java >> >> >>>> [exec] runner finished test: >> org/jemmy/browser/PropPanelTest.java >> >> >>>> [exec] Error. Unexpected error caught from test >> >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: >> >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su >> >> >>>> n/javatest/regtest/agent/JDK_Version;)I >> >> >>>> [exec] Test results: error: 1 >> >> >>>> [exec] Report written to /Users/karianna/Documents/work >> >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ >> >> >>>> report/html/report.html >> >> >>>> [exec] Results written to /Users/karianna/Documents/work >> >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd >> >> >>>> [exec] Error: Some tests failed or other problems occurred. >> >> >>>> [exec] Result: 3 >> >> >>>> >> >> >>>> Any ideas? >> >> >>>> >> >> >>>> FYI - I'm still running this locally on my Mac OS X box until I >> get a >> >> >>>> clean build so I know the minimum steps for the build farm job. >> Note to >> >> >>>> self that the build box will need to provide a platform specific >> SWT lib >> >> >>>> (Linux x86). >> >> >>>> >> >> >>>> Cheers, >> >> >>>> Martijn >> >> >>>> >> >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < >> >> >>>> alexandre.iline at oracle.com> wrote: >> >> >>>> >> >> >>>>> Now including aliases and more recipients.. >> >> >>>>> >> >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < >> >> >>>>> alexandre.iline at oracle.com> wrote: >> >> >>>>>> >> >> >>>>>> >> >> >>>>>> >> >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < >> >> >>>>> martijnverburg at gmail.com> wrote: >> >> >>>>>>> >> >> >>>>>>> Hi Alexandre, >> >> >>>>>>> >> >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder >> and >> >> >>>>> that failed with: >> >> >>>>>>> >> >> >>>>>>> >> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: >> >> >>>>> Please specify swt.jar >> >> >>>>>> >> >> >>>>>> You do need the SWT library to build SWT. >> >> >>>>>> >> >> >>>>>> this is what I just did: >> >> >>>>>> >> >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant >> -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar >> >> >>>>> jar >> >> >>>>>> >> >> >>>>>> >> >> >>>>>> I clearly need to provide a README. Will do. >> >> >>>>>> >> >> >>>>>> Shura >> >> >>>>>> >> >> >>>>>>> >> >> >>>>>>> Then I actually bothered to read the build.xml file and saw the >> >> >>>>> build-dependecies-impl target, so I ran ant >> build-dependecies-impl which >> >> >>>>> seemed to build: >> >> >>>>>>> >> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >> >>>>> /core/JemmyCore/build/JemmyCore.jar >> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar >> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar >> >> >>>>>>> >> >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my >> jtreg.home set >> >> >>>>>>> >> >> >>>>>>> Before I shave more Yaks, is this the right direction to be >> going in? >> >> >>>>>>> >> >> >>>>>>> >> >> >>>>>>> Cheers, >> >> >>>>>>> Martijn >> >> >>>>>>> >> >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < >> >> >>>>> alexandre.iline at oracle.com> wrote: >> >> >>>>>>> Martijn, >> >> >>>>>>> >> >> >>>>>>> Jemmy v3 consists of several project which depend on each >> other. >> >> >>>>>>> >> >> >>>>>>> If, besides hosting the source, the intension is to build it, >> you >> >> >>>>> need to build projects which are in use by others who would be >> coming to >> >> >>>>> AdoptOpenJDK for binaries. >> >> >>>>>>> >> >> >>>>>>> At this point of time, from what I know, JemmySWT is what is >> needed. >> >> >>>>> Ant build scripts are constructed in a way so that by while >> JemmySWT is >> >> >>>>> build, the dependences are also built, you should have no >> problem with that. >> >> >>>>>>> >> >> >>>>>>> Binaries would, then, simply include all jar files create >> after the >> >> >>>>> build. The jar files will be: */*/build/*.jar >> >> >>>>>>> >> >> >>>>>>> Shura >> >> >>>>>>> >> >> >>>>>>> >> >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < >> >> >>>>> martijnverburg at gmail.com> wrote: >> >> >>>>>>>> >> >> >>>>>>>> Hi Dalibor, >> >> >>>>>>>> >> >> >>>>>>>> We're shifting the code tools off Cloudbees to the new >> >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a >> quick >> >> >>>>> Q: >> >> >>>>>>>> >> >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ >> gives me: >> >> >>>>>>>> >> >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . >> >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. >> >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg >> >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck >> >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT >> >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core >> >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make >> >> >>>>>>>> >> >> >>>>>>>> but I can't see what the canonical entry point to build it is. >> >> >>>>>>>> >> >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. >> >> >>>>>>>> >> >> >>>>>>>> Cheers, >> >> >>>>>>>> Martijn >> >> >>>>>>>> >> >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic < >> dalibor.topic at oracle.com> >> >> >>>>> wrote: >> >> >>>>>>>> Hi Martijn, >> >> >>>>>>>> >> >> >>>>>>>> would you be able to add the Jemmy v3 repo at >> >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to >> >> >>>>> >> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? >> >> >>>>>>>> >> >> >>>>>>>> cheers, >> >> >>>>>>>> dalibor topic >> >> >>>>>>>> -- >> >> >>>>>>>> Dalibor Topic | Principal Product >> Manager >> >> >> >> >>>>>>>> Phone: +494089091214 >> <+494089091214>> | Mobile: >> >> >>>>> +491737185961 >> >> >>>>>>>> <+491737185961>> >> >> >>>>>>>> >> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 >> Hamburg >> >> >> >>>>> < >> https://maps.google.com/?q=K%C3%BChneh%C3%B6fe+5+%7C+22761+Hamburg&entry=gmail&source=g >> > >> >> >>>>>>>> >> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG >> >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 >> >> >> >>>>> < >> https://maps.google.com/?q=Riesstr.+25,+D-80992&entry=gmail&source=g> >> >> >>>>> M?nchen >> >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 >> >> >>>>>>>> >> >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. >> >> >>>>>>>> Hertogswetering 163 >> /167, >> 3543 AS Utrecht, Niederlande >> >> >>>>> < >> https://maps.google.com/?q=Hertogswetering+163/167,+3543+AS+Utrecht,+Niederlande&entry=gmail&source=g >> > >> >> >> >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. >> 30143697 >> >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val >> Maher >> >> >>>>>>>> >> >> >>>>>>>> Oracle is committed to >> >> >>>>> developing >> >> >>>>>>>> practices and products that help protect the environment >> >> >>>>>>>> >> >> >>>>>>> >> >> >>>>>>> >> >> >>>>>> >> >> >>>>> >> >> >>>>> >> >> >>>> >> >> >>>> >> >> >>> >> >> >>> >> >> >> >> >> >> >> >> >> >> >> >> > >> > >> >> > > -- Cheers, Martijn (Sent from Gmail Mobile) From erik.greijus at oracle.com Fri May 4 13:30:37 2018 From: erik.greijus at oracle.com (Erik Greijus) Date: Fri, 4 May 2018 15:30:37 +0200 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> <80E4F1B0-1C7C-4277-9234-DE646ED0196C@reini.net> Message-ID: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> I actually think they were all meant to be 1.0.0 at initial commit when Jemmy3 was open sourced. Maybe Shura can enlighten us on that? /Erik > 4 maj 2018 kl. 15:18 skrev Martijn Verburg : > > Hmmm - is it worth unifying the module numbers to 1.0.0 for this initial release? > > On Fri, 4 May 2018 at 14:04, Erik Greijus > wrote: > I think that?s better. Remember that each of the modules have their own version as well (see the version.properties file for each of them). > > Regards > /Erik > > >> 4 maj 2018 kl. 15:00 skrev Martijn Verburg >: >> >> Sounds like we need to change the version numbers and artifactId according to Erik's instructions as well? >> >> So >> >> groupId org.adoptopenjdk >> artifactId jemmy3 >> version 1.0.0-SNAPSHOT >> >> How does that sound Erik? >> >> >> >> >> Cheers, >> Martijn >> >> On 4 May 2018 at 13:19, Patrick Reinhart > wrote: >> Hello together, >> >> I went over the jemmy codebase so far, that the compilation succeeds and a push to the maven repo is possible: >> >> >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/ >> >> The following changes include mostly the following: >> >> Javadoc >> The changes removed all comments, that did not provide any informations. In those cases where the comments where not complete the I added ?todo document? as text to pass the minimal build requirements. >> >> groupId/artifactId >> I changed the groupId to ?org.adoptopenjdk? and all artifactId values to be lower case and dash separated: >> >> The current state of the changes will build an 3.0.0-SNAPSHOT version so far. >> >> Before I we can publish an initial version, we must clarify the correct license and update the according header files. For the moment I took the latest GPL license for my local build and its initial tests. >> >> >> -Patrick >> >> >> > Am 04.05.2018 um 13:38 schrieb Martijn Verburg >: >> > >> > Awesome, that makes life a lot easier - OK, now to get X11 running on the build boxes we want to pass tests. >> > >> > Cheers, >> > Martijn >> > >> > On 4 May 2018 at 12:01, Erik Greijus > wrote: >> > Hello, >> > >> > Sorry for the late answer. >> > As for JemmySWT.jar it is platform independent (it relies on the platform dependent SWT library - which is needed to build the project, and later on to actually use Jemmy). >> > You only need to build and make available the four jars as they are. >> > >> > Best regards >> > /Erik >> > >> > >> > >> >> 4 maj 2018 kl. 10:39 skrev Martijn Verburg >: >> >> >> >> Hi all, >> >> >> >> 1.) I'm OK with the groupId being org.adoptopenjdk - but that may cause some confusion if we do not actually host the source code as well. Not too big an issue if we explain this in the POM file >> >> >> >> 2.) Thank you Patrick (what an awesome co-incidence)! >> >> >> >> 3.) I'm totally OK with it being version 3.0.0, so I'd recommend setting the version to 3.0.0-SNAPSHOT to start with. >> >> >> >> I'd still like to understand if we need a SWT JAR for each platform, is someone able to answer that? >> >> >> >> >> >> >> >> Cheers, >> >> Martijn >> >> >> >> On 3 May 2018 at 21:17, Marcus Hirt > wrote: >> >> So, we?re suggesting to use adoptopenjdk.org as groupid and change the camel case module names to lower case and dashes. Patrick is also fixing the javadocs, as that must be done to publish the source Jars. I think Patrick will be back with big wonderful patch soon. :) >> >> >> >> >> >> >> >> Also, would it be okay to not have v3 in the name, but rather just set the version to 3.0.0? >> >> >> >> >> >> >> >> Kind regards, >> >> >> >> Marcus >> >> >> >> >> >> >> >> From: Martijn Verburg > >> >> Date: Thursday, 3 May 2018 at 22:13 >> >> To: Erik Greijus > >> >> Cc: "Alexandre (Shura) Iline" >, "adoption-discuss at openjdk.java.net " >, >, dalibor topic >, Marcus Hirt >, Patrick Reinhart > >> >> Subject: Re: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ >> >> >> >> >> >> >> >> Hi all, >> >> >> >> >> >> >> >> I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/ ). I have a few questions / comments. >> >> >> >> >> >> >> >> 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? >> >> >> >> >> >> >> >> >> >> 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. >> >> >> >> >> >> >> >> >> >> 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. >> >> >> >> >> >> >> >> * In terms of SNAPSHOTS we could could likely push on every build >> >> >> >> * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release >> >> >> >> >> >> >> >> My suggestion is that you: >> >> >> >> >> >> >> >> 1.) Change the version numbers to 1.0.0-SNAPSHOT >> >> >> >> 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) >> >> >> >> 3.) We perform a formal release (1.0.0) and push that to Maven Central >> >> >> >> 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need >> >> >> >> >> >> >> >> I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! >> >> >> >> >> >> >> >> Cheers, >> >> Martijn >> >> >> >> >> >> >> >> On 13 April 2018 at 08:40, Erik Greijus > wrote: >> >> >> >> >> >> >> >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg >: >> >> > >> >> > Hi all, >> >> > >> >> > The Jemmy build project is here: >> >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ >> >> > >> >> > If managed to get a mostly successful run and have produced a jemmy.tar.gz >> >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, >> >> > JemmyBrowser.jar). Now for some questions :-) >> >> > >> >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do >> >> > platform specific jemmy's need to be built? >> >> >> >> Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) >> >> >> >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if >> >> > I can get that Jenkins node to fire up an X11 so that those tests can pass. >> >> >> >> That would be good. >> >> >> >> > 3.) Can folks please grab the tar.gz from the latest artifacts link >> >> > > >> >> > and let me know if that's how they expect it to be named and whether the >> >> > layout of the contents is acceptable >> >> >> >> I miss the JemmySWT jar file mentioned above. >> >> >> >> >> >> > 4.) Versioning / naming - should I be building off a known good tag? Do we >> >> > want the tip/commit number to be part of the artifact name? >> >> > >> >> > It should build on an SCM change and weekly as well >> >> > >> >> > >> >> > Cheers, >> >> > Martijn >> >> > >> >> > On 11 April 2018 at 09:56, Martijn Verburg > wrote: >> >> > >> >> >> Cool, I'll go with what I have as a working build for now and adjust to >> >> >> use the test target when that change comes in, and then perhaps move to the >> >> >> Maven build later. >> >> >> >> >> >> Cheers, >> >> >> Martijn >> >> >> >> >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < >> >> >> alexandre.iline at oracle.com > wrote: >> >> >> >> >> >>> >> >> >>> >> >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > >> >> >>> wrote: >> >> >>> >> >> >>> Hi Alexandre, >> >> >>> >> >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( >> >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/ ) in particular >> >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue >> >> >>> up (we did have broken binaries for a bit). >> >> >>> >> >> >>> If I now run >> >> >>> >> >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu >> >> >>> ild-dependecies-impl >> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te >> >> >>> st-dependecies-impl >> >> >>> >> >> >>> Then I get a passing build! >> >> >>> >> >> >>> --------- >> >> >>> >> >> >>> Onto the next issue! If I run just: >> >> >>> >> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test >> >> >>> >> >> >>> Then I get compile errors like: >> >> >>> >> >> >>> compile-test: >> >> >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work >> >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test >> >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find >> >> >>> symbol >> >> >>> [javac] prnt.lookup(new ByTextItem("Table")). >> >> >>> wrap().mouse().click(); >> >> >>> [javac] ^ >> >> >>> [javac] symbol: class ByTextItem >> >> >>> [javac] location: class ItemsTest >> >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find >> >> >>> symbol >> >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap >> >> >>> ().mouse().click(); >> >> >>> [javac] ^ >> >> >>> [javac] symbol: class ByTextItem >> >> >>> [javac] location: class ItemsTest >> >> >>> >> >> >>> >> >> >>> >> >> >>> This, I believe, is a bug which is going to be addressed by the review in >> >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 >> >> >>> 018-April/000080.html >> >> >>> >> >> >>> Shura >> >> >>> >> >> >>> >> >> >>> ------------ >> >> >>> >> >> >> >> >>> A *README.txt* for building at the root of the project and a .*hgignore* >> >> >> >> >>> file would also be nice to haves. >> >> >>> >> >> >>> ------------ >> >> >>> >> >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy >> >> >>> building nightly on our build farm. I'm also very interested in seeing the >> >> >>> Maven support go in :-). >> >> >>> >> >> >>> Cheers, >> >> >>> Martijn >> >> >>> >> >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < >> >> >>> alexandre.iline at oracle.com > wrote: >> >> >>> >> >> >>>> Do you happen to have full stack trace of that? >> >> >>>> >> >> >>>> Also, how to I get JTReg which are you using? >> >> >>>> >> >> >>>> The reported missing method would be a part of JTReg, clearly. >> >> >>>> >> >> >>>> The other thing is you should probably be ok with just running ant ?. >> >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne >> >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. >> >> >>>> >> >> >>>> Shura >> >> >>>> >> >> >>>> >> >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > >> >> >>>> wrote: >> >> >>>> >> >> >>>> Hi Alexandre, >> >> >>>> >> >> >>>> I got a little further (This is using Java 1.8.0_162). Once I set my >> >> >>>> swt.jar and jtreg.home I was able to run: >> >> >>>> >> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >> >>>> check-dependecies-impl >> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >> >>>> build-dependecies-impl >> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >> >> >> >> >>>> K_Projects/jtreg/ test-dependecies-impl >> >> >> >> >>>> >> >> >>>> The first two execute OK but then the test gives me the test failure of: >> >> >>>> >> >> >>>> test: >> >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not >> >> >>>> found: creating >> >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" >> >> >>>> not found: creating >> >> >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java >> >> >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java >> >> >>>> [exec] Error. Unexpected error caught from test >> >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: >> >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su >> >> >>>> n/javatest/regtest/agent/JDK_Version;)I >> >> >>>> [exec] Test results: error: 1 >> >> >>>> [exec] Report written to /Users/karianna/Documents/work >> >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ >> >> >>>> report/html/report.html >> >> >>>> [exec] Results written to /Users/karianna/Documents/work >> >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd >> >> >>>> [exec] Error: Some tests failed or other problems occurred. >> >> >>>> [exec] Result: 3 >> >> >>>> >> >> >>>> Any ideas? >> >> >>>> >> >> >>>> FYI - I'm still running this locally on my Mac OS X box until I get a >> >> >>>> clean build so I know the minimum steps for the build farm job. Note to >> >> >>>> self that the build box will need to provide a platform specific SWT lib >> >> >>>> (Linux x86). >> >> >>>> >> >> >>>> Cheers, >> >> >>>> Martijn >> >> >>>> >> >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < >> >> >>>> alexandre.iline at oracle.com > wrote: >> >> >>>> >> >> >>>>> Now including aliases and more recipients.. >> >> >>>>> >> >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < >> >> >>>>> alexandre.iline at oracle.com > wrote: >> >> >>>>>> >> >> >>>>>> >> >> >>>>>> >> >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < >> >> >>>>> martijnverburg at gmail.com > wrote: >> >> >>>>>>> >> >> >>>>>>> Hi Alexandre, >> >> >>>>>>> >> >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and >> >> >>>>> that failed with: >> >> >>>>>>> >> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: >> >> >>>>> Please specify swt.jar >> >> >>>>>> >> >> >>>>>> You do need the SWT library to build SWT. >> >> >>>>>> >> >> >>>>>> this is what I just did: >> >> >>>>>> >> >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar >> >> >>>>> jar >> >> >>>>>> >> >> >>>>>> >> >> >>>>>> I clearly need to provide a README. Will do. >> >> >>>>>> >> >> >>>>>> Shura >> >> >>>>>> >> >> >>>>>>> >> >> >>>>>>> Then I actually bothered to read the build.xml file and saw the >> >> >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which >> >> >>>>> seemed to build: >> >> >>>>>>> >> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >> >>>>> /core/JemmyCore/build/JemmyCore.jar >> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar >> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar >> >> >>>>>>> >> >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set >> >> >>>>>>> >> >> >>>>>>> Before I shave more Yaks, is this the right direction to be going in? >> >> >>>>>>> >> >> >>>>>>> >> >> >>>>>>> Cheers, >> >> >>>>>>> Martijn >> >> >>>>>>> >> >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < >> >> >>>>> alexandre.iline at oracle.com > wrote: >> >> >>>>>>> Martijn, >> >> >>>>>>> >> >> >>>>>>> Jemmy v3 consists of several project which depend on each other. >> >> >>>>>>> >> >> >>>>>>> If, besides hosting the source, the intension is to build it, you >> >> >>>>> need to build projects which are in use by others who would be coming to >> >> >>>>> AdoptOpenJDK for binaries. >> >> >>>>>>> >> >> >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. >> >> >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is >> >> >>>>> build, the dependences are also built, you should have no problem with that. >> >> >>>>>>> >> >> >>>>>>> Binaries would, then, simply include all jar files create after the >> >> >>>>> build. The jar files will be: */*/build/*.jar >> >> >>>>>>> >> >> >>>>>>> Shura >> >> >>>>>>> >> >> >>>>>>> >> >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < >> >> >>>>> martijnverburg at gmail.com > wrote: >> >> >>>>>>>> >> >> >>>>>>>> Hi Dalibor, >> >> >>>>>>>> >> >> >>>>>>>> We're shifting the code tools off Cloudbees to the new >> >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick >> >> >>>>> Q: >> >> >>>>>>>> >> >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: >> >> >>>>>>>> >> >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . >> >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. >> >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg >> >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck >> >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT >> >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core >> >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make >> >> >>>>>>>> >> >> >>>>>>>> but I can't see what the canonical entry point to build it is. >> >> >>>>>>>> >> >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. >> >> >>>>>>>> >> >> >>>>>>>> Cheers, >> >> >>>>>>>> Martijn >> >> >>>>>>>> >> >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic > >> >> >>>>> wrote: >> >> >>>>>>>> Hi Martijn, >> >> >>>>>>>> >> >> >>>>>>>> would you be able to add the Jemmy v3 repo at >> >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to >> >> >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? >> >> >>>>>>>> >> >> >>>>>>>> cheers, >> >> >>>>>>>> dalibor topic >> >> >>>>>>>> -- >> >> >>>>>>>> > Dalibor Topic | Principal Product Manager >> >> >> >> >>>>>>>> Phone: +494089091214 <+494089091214>> | Mobile: >> >> >>>>> +491737185961 >> >> >>>>>>>> <+491737185961>> >> >> >>>>>>>> >> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg >> >> >>>>> > >> >> >>>>>>>> >> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG >> >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 >> >> >>>>> > >> >> >>>>> M?nchen >> >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 >> >> >>>>>>>> >> >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. >> >> >>>>>>>> Hertogswetering 163 /167, 3543 AS Utrecht, Niederlande >> >> >>>>> > >> >> >> >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 >> >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher >> >> >>>>>>>> >> >> >>>>>>>> > Oracle is committed to >> >> >>>>> developing >> >> >>>>>>>> practices and products that help protect the environment >> >> >>>>>>>> >> >> >>>>>>> >> >> >>>>>>> >> >> >>>>>> >> >> >>>>> >> >> >>>>> >> >> >>>> >> >> >>>> >> >> >>> >> >> >>> >> >> >> >> >> >> >> >> >> >> >> >> > >> > >> >> > > -- > Cheers, Martijn (Sent from Gmail Mobile) From alexandre.iline at oracle.com Fri May 4 16:05:17 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Fri, 4 May 2018 09:05:17 -0700 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> Message-ID: <5C1EFC33-D595-4475-8C2F-2668A4704100@oracle.com> > On May 3, 2018, at 1:12 PM, Martijn Verburg wrote: > > Hi all, > > I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/ ). I have a few questions / comments. > > 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? What does the JemmySWT-1.0.jar contain? Is it only JemmySWT and JemmyCore, etc should be in separate artifacts? > > 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. > > 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. > > * In terms of SNAPSHOTS we could could likely push on every build > * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release > > My suggestion is that you: > > 1.) Change the version numbers to 1.0.0-SNAPSHOT Is the version number then consistent with appropriate Jemmy ?module? version number? JemmySWT may and does have a different version number than JemmyCore. That is because these are two _differed_ projects, out of which one happen to depend on the other. Maven is expected to be very good with managing modules and versions, etc, so should not be a problem to handle the case. On the same hand ? Jemmy existed and was used long before there came a need to put it in maven. It has its own history and versioning. Putting the artifacts in maven is a noticeable event in history and can be reflected in the version number, I agree, even if no source changes are associated with that event. That said, re-setting the version to something sounds incorrect. > 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) > 3.) We perform a formal release (1.0.0) and push that to Maven Central > 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need Oh! Setting 1.0.0 initially is just a workaround of a sort? That?s fine then, of course. > > I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! Drop the ?.v3". If there would be artifacts from v2 they would be different. I have no opinion on jemmy.org, other than changing existing package name is not the way to go. Shura > > Cheers, > Martijn > > On 13 April 2018 at 08:40, Erik Greijus > wrote: > > > > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg >: > > > > Hi all, > > > > The Jemmy build project is here: > > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ > > > > If managed to get a mostly successful run and have produced a jemmy.tar.gz > > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, > > JemmyBrowser.jar). Now for some questions :-) > > > > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do > > platform specific jemmy's need to be built? > > Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) > > > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if > > I can get that Jenkins node to fire up an X11 so that those tests can pass. > > That would be good. > > > 3.) Can folks please grab the tar.gz from the latest artifacts link > > > > > and let me know if that's how they expect it to be named and whether the > > layout of the contents is acceptable > > I miss the JemmySWT jar file mentioned above. > > > 4.) Versioning / naming - should I be building off a known good tag? Do we > > want the tip/commit number to be part of the artifact name? > > > > It should build on an SCM change and weekly as well > > > > > > Cheers, > > Martijn > > > > On 11 April 2018 at 09:56, Martijn Verburg > wrote: > > > >> Cool, I'll go with what I have as a working build for now and adjust to > >> use the test target when that change comes in, and then perhaps move to the > >> Maven build later. > >> > >> Cheers, > >> Martijn > >> > >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < > >> alexandre.iline at oracle.com > wrote: > >> > >>> > >>> > >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > > >>> wrote: > >>> > >>> Hi Alexandre, > >>> > >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( > >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/ ) in particular > >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue > >>> up (we did have broken binaries for a bit). > >>> > >>> If I now run > >>> > >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu > >>> ild-dependecies-impl > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te > >>> st-dependecies-impl > >>> > >>> Then I get a passing build! > >>> > >>> --------- > >>> > >>> Onto the next issue! If I run just: > >>> > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test > >>> > >>> Then I get compile errors like: > >>> > >>> compile-test: > >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work > >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem("Table")). > >>> wrap().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap > >>> ().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> > >>> > >>> > >>> This, I believe, is a bug which is going to be addressed by the review in > >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 > >>> 018-April/000080.html > >>> > >>> Shura > >>> > >>> > >>> ------------ > >>> > >>> A *README.txt* for building at the root of the project and a .*hgignore* > >>> file would also be nice to haves. > >>> > >>> ------------ > >>> > >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy > >>> building nightly on our build farm. I'm also very interested in seeing the > >>> Maven support go in :-). > >>> > >>> Cheers, > >>> Martijn > >>> > >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < > >>> alexandre.iline at oracle.com > wrote: > >>> > >>>> Do you happen to have full stack trace of that? > >>>> > >>>> Also, how to I get JTReg which are you using? > >>>> > >>>> The reported missing method would be a part of JTReg, clearly. > >>>> > >>>> The other thing is you should probably be ok with just running ant ?. > >>>> test. ?test? target is coming from http://hg.openjdk.java.ne > >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. > >>>> > >>>> Shura > >>>> > >>>> > >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > > >>>> wrote: > >>>> > >>>> Hi Alexandre, > >>>> > >>>> I got a little further (This is using Java 1.8.0_162). Once I set my > >>>> swt.jar and jtreg.home I was able to run: > >>>> > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> check-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> build-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD > >>>> K_Projects/jtreg/ test-dependecies-impl > >>>> > >>>> The first two execute OK but then the test gives me the test failure of: > >>>> > >>>> test: > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not > >>>> found: creating > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" > >>>> not found: creating > >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] Error. Unexpected error caught from test > >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: > >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su > >>>> n/javatest/regtest/agent/JDK_Version;)I > >>>> [exec] Test results: error: 1 > >>>> [exec] Report written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ > >>>> report/html/report.html > >>>> [exec] Results written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd > >>>> [exec] Error: Some tests failed or other problems occurred. > >>>> [exec] Result: 3 > >>>> > >>>> Any ideas? > >>>> > >>>> FYI - I'm still running this locally on my Mac OS X box until I get a > >>>> clean build so I know the minimum steps for the build farm job. Note to > >>>> self that the build box will need to provide a platform specific SWT lib > >>>> (Linux x86). > >>>> > >>>> Cheers, > >>>> Martijn > >>>> > >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < > >>>> alexandre.iline at oracle.com > wrote: > >>>> > >>>>> Now including aliases and more recipients.. > >>>>> > >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com > wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < > >>>>> martijnverburg at gmail.com > wrote: > >>>>>>> > >>>>>>> Hi Alexandre, > >>>>>>> > >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and > >>>>> that failed with: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: > >>>>> Please specify swt.jar > >>>>>> > >>>>>> You do need the SWT library to build SWT. > >>>>>> > >>>>>> this is what I just did: > >>>>>> > >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar > >>>>> jar > >>>>>> > >>>>>> > >>>>>> I clearly need to provide a README. Will do. > >>>>>> > >>>>>> Shura > >>>>>> > >>>>>>> > >>>>>>> Then I actually bothered to read the build.xml file and saw the > >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which > >>>>> seemed to build: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyCore/build/JemmyCore.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar > >>>>>>> > >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set > >>>>>>> > >>>>>>> Before I shave more Yaks, is this the right direction to be going in? > >>>>>>> > >>>>>>> > >>>>>>> Cheers, > >>>>>>> Martijn > >>>>>>> > >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com > wrote: > >>>>>>> Martijn, > >>>>>>> > >>>>>>> Jemmy v3 consists of several project which depend on each other. > >>>>>>> > >>>>>>> If, besides hosting the source, the intension is to build it, you > >>>>> need to build projects which are in use by others who would be coming to > >>>>> AdoptOpenJDK for binaries. > >>>>>>> > >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. > >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is > >>>>> build, the dependences are also built, you should have no problem with that. > >>>>>>> > >>>>>>> Binaries would, then, simply include all jar files create after the > >>>>> build. The jar files will be: */*/build/*.jar > >>>>>>> > >>>>>>> Shura > >>>>>>> > >>>>>>> > >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < > >>>>> martijnverburg at gmail.com > wrote: > >>>>>>>> > >>>>>>>> Hi Dalibor, > >>>>>>>> > >>>>>>>> We're shifting the code tools off Cloudbees to the new > >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick > >>>>> Q: > >>>>>>>> > >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: > >>>>>>>> > >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . > >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. > >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck > >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT > >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make > >>>>>>>> > >>>>>>>> but I can't see what the canonical entry point to build it is. > >>>>>>>> > >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> Martijn > >>>>>>>> > >>>>>>>> On 28 March 2018 at 17:02, dalibor topic > > >>>>> wrote: > >>>>>>>> Hi Martijn, > >>>>>>>> > >>>>>>>> would you be able to add the Jemmy v3 repo at > >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to > >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? > >>>>>>>> > >>>>>>>> cheers, > >>>>>>>> dalibor topic > >>>>>>>> -- > >>>>>>>> > Dalibor Topic | Principal Product Manager > >>>>>>>> Phone: +494089091214 > | Mobile: > >>>>> +491737185961 > >>>>>>>> > > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg > >>>>> > > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG > >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 > >>>>> > > >>>>> M?nchen > >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 > >>>>>>>> > >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. > >>>>>>>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande > >>>>> > > >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 > >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher > >>>>>>>> > >>>>>>>> > Oracle is committed to > >>>>> developing > >>>>>>>> practices and products that help protect the environment > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>>> > >>>> > >>>> > >>> > >>> > >> > > From alexandre.iline at oracle.com Fri May 4 16:11:42 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Fri, 4 May 2018 09:11:42 -0700 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> Message-ID: <8D54D1AD-5A6D-4673-96EB-63CED00F630A@oracle.com> > On May 3, 2018, at 1:17 PM, Marcus Hirt wrote: > > So, we?re suggesting to use adoptopenjdk.org as groupid and change the camel case module names to lower case and dashes. Patrick is also fixing the javadocs, as that must be done to publish the source Jars. I think Patrick will be back with big wonderful patch soon. :) > > Also, would it be okay to not have v3 in the name, but rather just set the version to 3.0.0? The matter of fact is that Jemmy v3 is a completely different system, which does not share any code with Jemmy v2. It is a complete redesign on the same ver-basic principles. So it was started with version 0.1.0. Functionality of Jemmy v3 does not overlap with Jemmy v2, so I think it is better to drop v3 than to increase the version to 3.0.0. Shura > > Kind regards, > Marcus > > From: Martijn Verburg > > Date: Thursday, 3 May 2018 at 22:13 > To: Erik Greijus > > Cc: "Alexandre (Shura) Iline" >, "adoption-discuss at openjdk.java.net " >, >, dalibor topic >, Marcus Hirt >, Patrick Reinhart > > Subject: Re: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ > > Hi all, <> > > I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/ ). I have a few questions / comments. > > 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? > > > 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. > > > 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. > > * In terms of SNAPSHOTS we could could likely push on every build > * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release > > My suggestion is that you: > > 1.) Change the version numbers to 1.0.0-SNAPSHOT > 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) > 3.) We perform a formal release (1.0.0) and push that to Maven Central > 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need > > I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! > > Cheers, > Martijn > > On 13 April 2018 at 08:40, Erik Greijus > wrote: >> >> >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg >: >> > >> > Hi all, >> > >> > The Jemmy build project is here: >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ >> > >> > If managed to get a mostly successful run and have produced a jemmy.tar.gz >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, >> > JemmyBrowser.jar). Now for some questions :-) >> > >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do >> > platform specific jemmy's need to be built? >> >> Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) >> >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if >> > I can get that Jenkins node to fire up an X11 so that those tests can pass. >> >> That would be good. >> >> > 3.) Can folks please grab the tar.gz from the latest artifacts link >> > > >> > and let me know if that's how they expect it to be named and whether the >> > layout of the contents is acceptable >> >> I miss the JemmySWT jar file mentioned above. >> >> > 4.) Versioning / naming - should I be building off a known good tag? Do we >> > want the tip/commit number to be part of the artifact name? >> > >> > It should build on an SCM change and weekly as well >> > >> > >> > Cheers, >> > Martijn >> > >> > On 11 April 2018 at 09:56, Martijn Verburg > wrote: >> > >> >> Cool, I'll go with what I have as a working build for now and adjust to >> >> use the test target when that change comes in, and then perhaps move to the >> >> Maven build later. >> >> >> >> Cheers, >> >> Martijn >> >> >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < >> >> alexandre.iline at oracle.com > wrote: >> >> >> >>> >> >>> >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > >> >>> wrote: >> >>> >> >>> Hi Alexandre, >> >>> >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/ ) in particular >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue >> >>> up (we did have broken binaries for a bit). >> >>> >> >>> If I now run >> >>> >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu >> >>> ild-dependecies-impl >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te >> >>> st-dependecies-impl >> >>> >> >>> Then I get a passing build! >> >>> >> >>> --------- >> >>> >> >>> Onto the next issue! If I run just: >> >>> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test >> >>> >> >>> Then I get compile errors like: >> >>> >> >>> compile-test: >> >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find >> >>> symbol >> >>> [javac] prnt.lookup(new ByTextItem("Table")). >> >>> wrap().mouse().click(); >> >>> [javac] ^ >> >>> [javac] symbol: class ByTextItem >> >>> [javac] location: class ItemsTest >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find >> >>> symbol >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap >> >>> ().mouse().click(); >> >>> [javac] ^ >> >>> [javac] symbol: class ByTextItem >> >>> [javac] location: class ItemsTest >> >>> >> >>> >> >>> >> >>> This, I believe, is a bug which is going to be addressed by the review in >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 >> >>> 018-April/000080.html >> >>> >> >>> Shura >> >>> >> >>> >> >>> ------------ >> >>> >> >>> A *README.txt* for building at the root of the project and a .*hgignore* >> >>> file would also be nice to haves. >> >>> >> >>> ------------ >> >>> >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy >> >>> building nightly on our build farm. I'm also very interested in seeing the >> >>> Maven support go in :-). >> >>> >> >>> Cheers, >> >>> Martijn >> >>> >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < >> >>> alexandre.iline at oracle.com > wrote: >> >>> >> >>>> Do you happen to have full stack trace of that? >> >>>> >> >>>> Also, how to I get JTReg which are you using? >> >>>> >> >>>> The reported missing method would be a part of JTReg, clearly. >> >>>> >> >>>> The other thing is you should probably be ok with just running ant ?. >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. >> >>>> >> >>>> Shura >> >>>> >> >>>> >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > >> >>>> wrote: >> >>>> >> >>>> Hi Alexandre, >> >>>> >> >>>> I got a little further (This is using Java 1.8.0_162). Once I set my >> >>>> swt.jar and jtreg.home I was able to run: >> >>>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> check-dependecies-impl >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> build-dependecies-impl >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >> >>>> K_Projects/jtreg/ test-dependecies-impl >> >>>> >> >>>> The first two execute OK but then the test gives me the test failure of: >> >>>> >> >>>> test: >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not >> >>>> found: creating >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" >> >>>> not found: creating >> >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java >> >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java >> >>>> [exec] Error. Unexpected error caught from test >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su >> >>>> n/javatest/regtest/agent/JDK_Version;)I >> >>>> [exec] Test results: error: 1 >> >>>> [exec] Report written to /Users/karianna/Documents/work >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ >> >>>> report/html/report.html >> >>>> [exec] Results written to /Users/karianna/Documents/work >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd >> >>>> [exec] Error: Some tests failed or other problems occurred. >> >>>> [exec] Result: 3 >> >>>> >> >>>> Any ideas? >> >>>> >> >>>> FYI - I'm still running this locally on my Mac OS X box until I get a >> >>>> clean build so I know the minimum steps for the build farm job. Note to >> >>>> self that the build box will need to provide a platform specific SWT lib >> >>>> (Linux x86). >> >>>> >> >>>> Cheers, >> >>>> Martijn >> >>>> >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < >> >>>> alexandre.iline at oracle.com > wrote: >> >>>> >> >>>>> Now including aliases and more recipients.. >> >>>>> >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < >> >>>>> alexandre.iline at oracle.com > wrote: >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < >> >>>>> martijnverburg at gmail.com > wrote: >> >>>>>>> >> >>>>>>> Hi Alexandre, >> >>>>>>> >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and >> >>>>> that failed with: >> >>>>>>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: >> >>>>> Please specify swt.jar >> >>>>>> >> >>>>>> You do need the SWT library to build SWT. >> >>>>>> >> >>>>>> this is what I just did: >> >>>>>> >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar >> >>>>> jar >> >>>>>> >> >>>>>> >> >>>>>> I clearly need to provide a README. Will do. >> >>>>>> >> >>>>>> Shura >> >>>>>> >> >>>>>>> >> >>>>>>> Then I actually bothered to read the build.xml file and saw the >> >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which >> >>>>> seemed to build: >> >>>>>>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyCore/build/JemmyCore.jar >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar >> >>>>>>> >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set >> >>>>>>> >> >>>>>>> Before I shave more Yaks, is this the right direction to be going in? >> >>>>>>> >> >>>>>>> >> >>>>>>> Cheers, >> >>>>>>> Martijn >> >>>>>>> >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < >> >>>>> alexandre.iline at oracle.com > wrote: >> >>>>>>> Martijn, >> >>>>>>> >> >>>>>>> Jemmy v3 consists of several project which depend on each other. >> >>>>>>> >> >>>>>>> If, besides hosting the source, the intension is to build it, you >> >>>>> need to build projects which are in use by others who would be coming to >> >>>>> AdoptOpenJDK for binaries. >> >>>>>>> >> >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. >> >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is >> >>>>> build, the dependences are also built, you should have no problem with that. >> >>>>>>> >> >>>>>>> Binaries would, then, simply include all jar files create after the >> >>>>> build. The jar files will be: */*/build/*.jar >> >>>>>>> >> >>>>>>> Shura >> >>>>>>> >> >>>>>>> >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < >> >>>>> martijnverburg at gmail.com > wrote: >> >>>>>>>> >> >>>>>>>> Hi Dalibor, >> >>>>>>>> >> >>>>>>>> We're shifting the code tools off Cloudbees to the new >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick >> >>>>> Q: >> >>>>>>>> >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: >> >>>>>>>> >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make >> >>>>>>>> >> >>>>>>>> but I can't see what the canonical entry point to build it is. >> >>>>>>>> >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. >> >>>>>>>> >> >>>>>>>> Cheers, >> >>>>>>>> Martijn >> >>>>>>>> >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic > >> >>>>> wrote: >> >>>>>>>> Hi Martijn, >> >>>>>>>> >> >>>>>>>> would you be able to add the Jemmy v3 repo at >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to >> >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? >> >>>>>>>> >> >>>>>>>> cheers, >> >>>>>>>> dalibor topic >> >>>>>>>> -- >> >>>>>>>> > Dalibor Topic | Principal Product Manager >> >>>>>>>> Phone: +494089091214 <+494089091214>> | Mobile: >> >>>>> +491737185961 >> >>>>>>>> <+491737185961>> >> >>>>>>>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg >> >>>>> > >> >>>>>>>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 >> >>>>> > >> >>>>> M?nchen >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 >> >>>>>>>> >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. >> >>>>>>>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande >> >>>>> > >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher >> >>>>>>>> >> >>>>>>>> > Oracle is committed to >> >>>>> developing >> >>>>>>>> practices and products that help protect the environment >> >>>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>> >> >>>>> >> >>>>> >> >>>> >> >>>> >> >>> >> >>> >> >> >> From alexandre.iline at oracle.com Fri May 4 16:23:28 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Fri, 4 May 2018 09:23:28 -0700 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> <80E4F1B0-1C7C-4277-9234-DE646ED0196C@reini.net> <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> Message-ID: <9FACE9B4-B75E-40C8-BFEF-E19686D4D6DB@oracle.com> > On May 4, 2018, at 6:30 AM, Erik Greijus wrote: > > I actually think they were all meant to be 1.0.0 at initial commit when Jemmy3 was open sourced. Jemmy was open-sourced long before it came to code-tools. I do not presently recall what version was it back then. Shura > > Maybe Shura can enlighten us on that? > > /Erik > >> 4 maj 2018 kl. 15:18 skrev Martijn Verburg >: >> >> Hmmm - is it worth unifying the module numbers to 1.0.0 for this initial release? >> >> On Fri, 4 May 2018 at 14:04, Erik Greijus > wrote: >> I think that?s better. Remember that each of the modules have their own version as well (see the version.properties file for each of them). >> >> Regards >> /Erik >> >> >>> 4 maj 2018 kl. 15:00 skrev Martijn Verburg >: >>> >>> Sounds like we need to change the version numbers and artifactId according to Erik's instructions as well? >>> >>> So >>> >>> groupId org.adoptopenjdk >>> artifactId jemmy3 >>> version 1.0.0-SNAPSHOT >>> >>> How does that sound Erik? >>> >>> >>> >>> >>> Cheers, >>> Martijn >>> >>> On 4 May 2018 at 13:19, Patrick Reinhart > wrote: >>> Hello together, >>> >>> I went over the jemmy codebase so far, that the compilation succeeds and a push to the maven repo is possible: >>> >>> >>> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/ >>> >>> The following changes include mostly the following: >>> >>> Javadoc >>> The changes removed all comments, that did not provide any informations. In those cases where the comments where not complete the I added ?todo document? as text to pass the minimal build requirements. >>> >>> groupId/artifactId >>> I changed the groupId to ?org.adoptopenjdk? and all artifactId values to be lower case and dash separated: >>> >>> The current state of the changes will build an 3.0.0-SNAPSHOT version so far. >>> >>> Before I we can publish an initial version, we must clarify the correct license and update the according header files. For the moment I took the latest GPL license for my local build and its initial tests. >>> >>> >>> -Patrick >>> >>> >>> > Am 04.05.2018 um 13:38 schrieb Martijn Verburg >: >>> > >>> > Awesome, that makes life a lot easier - OK, now to get X11 running on the build boxes we want to pass tests. >>> > >>> > Cheers, >>> > Martijn >>> > >>> > On 4 May 2018 at 12:01, Erik Greijus > wrote: >>> > Hello, >>> > >>> > Sorry for the late answer. >>> > As for JemmySWT.jar it is platform independent (it relies on the platform dependent SWT library - which is needed to build the project, and later on to actually use Jemmy). >>> > You only need to build and make available the four jars as they are. >>> > >>> > Best regards >>> > /Erik >>> > >>> > >>> > >>> >> 4 maj 2018 kl. 10:39 skrev Martijn Verburg >: >>> >> >>> >> Hi all, >>> >> >>> >> 1.) I'm OK with the groupId being org.adoptopenjdk - but that may cause some confusion if we do not actually host the source code as well. Not too big an issue if we explain this in the POM file >>> >> >>> >> 2.) Thank you Patrick (what an awesome co-incidence)! >>> >> >>> >> 3.) I'm totally OK with it being version 3.0.0, so I'd recommend setting the version to 3.0.0-SNAPSHOT to start with. >>> >> >>> >> I'd still like to understand if we need a SWT JAR for each platform, is someone able to answer that? >>> >> >>> >> >>> >> >>> >> Cheers, >>> >> Martijn >>> >> >>> >> On 3 May 2018 at 21:17, Marcus Hirt > wrote: >>> >> So, we?re suggesting to use adoptopenjdk.org as groupid and change the camel case module names to lower case and dashes. Patrick is also fixing the javadocs, as that must be done to publish the source Jars. I think Patrick will be back with big wonderful patch soon. :) >>> >> >>> >> >>> >> >>> >> Also, would it be okay to not have v3 in the name, but rather just set the version to 3.0.0? >>> >> >>> >> >>> >> >>> >> Kind regards, >>> >> >>> >> Marcus >>> >> >>> >> >>> >> >>> >> From: Martijn Verburg > >>> >> Date: Thursday, 3 May 2018 at 22:13 >>> >> To: Erik Greijus > >>> >> Cc: "Alexandre (Shura) Iline" >, "adoption-discuss at openjdk.java.net " >, >, dalibor topic >, Marcus Hirt >, Patrick Reinhart > >>> >> Subject: Re: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ >>> >> >>> >> >>> >> >>> >> Hi all, >>> >> >>> >> >>> >> >>> >> I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/ ). I have a few questions / comments. >>> >> >>> >> >>> >> >>> >> 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? >>> >> >>> >> >>> >> >>> >> >>> >> 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. >>> >> >>> >> >>> >> >>> >> >>> >> 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. >>> >> >>> >> >>> >> >>> >> * In terms of SNAPSHOTS we could could likely push on every build >>> >> >>> >> * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release >>> >> >>> >> >>> >> >>> >> My suggestion is that you: >>> >> >>> >> >>> >> >>> >> 1.) Change the version numbers to 1.0.0-SNAPSHOT >>> >> >>> >> 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) >>> >> >>> >> 3.) We perform a formal release (1.0.0) and push that to Maven Central >>> >> >>> >> 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need >>> >> >>> >> >>> >> >>> >> I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! >>> >> >>> >> >>> >> >>> >> Cheers, >>> >> Martijn >>> >> >>> >> >>> >> >>> >> On 13 April 2018 at 08:40, Erik Greijus > wrote: >>> >> >>> >> >>> >> >>> >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg >: >>> >> > >>> >> > Hi all, >>> >> > >>> >> > The Jemmy build project is here: >>> >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ >>> >> > >>> >> > If managed to get a mostly successful run and have produced a jemmy.tar.gz >>> >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, >>> >> > JemmyBrowser.jar). Now for some questions :-) >>> >> > >>> >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do >>> >> > platform specific jemmy's need to be built? >>> >> >>> >> Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) >>> >> >>> >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if >>> >> > I can get that Jenkins node to fire up an X11 so that those tests can pass. >>> >> >>> >> That would be good. >>> >> >>> >> > 3.) Can folks please grab the tar.gz from the latest artifacts link >>> >> > > >>> >> > and let me know if that's how they expect it to be named and whether the >>> >> > layout of the contents is acceptable >>> >> >>> >> I miss the JemmySWT jar file mentioned above. >>> >> >>> >> >>> >> > 4.) Versioning / naming - should I be building off a known good tag? Do we >>> >> > want the tip/commit number to be part of the artifact name? >>> >> > >>> >> > It should build on an SCM change and weekly as well >>> >> > >>> >> > >>> >> > Cheers, >>> >> > Martijn >>> >> > >>> >> > On 11 April 2018 at 09:56, Martijn Verburg > wrote: >>> >> > >>> >> >> Cool, I'll go with what I have as a working build for now and adjust to >>> >> >> use the test target when that change comes in, and then perhaps move to the >>> >> >> Maven build later. >>> >> >> >>> >> >> Cheers, >>> >> >> Martijn >>> >> >> >>> >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < >>> >> >> alexandre.iline at oracle.com > wrote: >>> >> >> >>> >> >>> >>> >> >>> >>> >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > >>> >> >>> wrote: >>> >> >>> >>> >> >>> Hi Alexandre, >>> >> >>> >>> >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( >>> >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/ ) in particular >>> >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue >>> >> >>> up (we did have broken binaries for a bit). >>> >> >>> >>> >> >>> If I now run >>> >> >>> >>> >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu >>> >> >>> ild-dependecies-impl >>> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >>> >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te >>> >> >>> st-dependecies-impl >>> >> >>> >>> >> >>> Then I get a passing build! >>> >> >>> >>> >> >>> --------- >>> >> >>> >>> >> >>> Onto the next issue! If I run just: >>> >> >>> >>> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >>> >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test >>> >> >>> >>> >> >>> Then I get compile errors like: >>> >> >>> >>> >> >>> compile-test: >>> >> >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work >>> >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test >>> >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >>> >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find >>> >> >>> symbol >>> >> >>> [javac] prnt.lookup(new ByTextItem("Table")). >>> >> >>> wrap().mouse().click(); >>> >> >>> [javac] ^ >>> >> >>> [javac] symbol: class ByTextItem >>> >> >>> [javac] location: class ItemsTest >>> >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >>> >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find >>> >> >>> symbol >>> >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap >>> >> >>> ().mouse().click(); >>> >> >>> [javac] ^ >>> >> >>> [javac] symbol: class ByTextItem >>> >> >>> [javac] location: class ItemsTest >>> >> >>> >>> >> >>> >>> >> >>> >>> >> >>> This, I believe, is a bug which is going to be addressed by the review in >>> >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 >>> >> >>> 018-April/000080.html >>> >> >>> >>> >> >>> Shura >>> >> >>> >>> >> >>> >>> >> >>> ------------ >>> >> >>> >>> >> >>> >> >>> A *README.txt* for building at the root of the project and a .*hgignore* >>> >> >>> >> >>> file would also be nice to haves. >>> >> >>> >>> >> >>> ------------ >>> >> >>> >>> >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy >>> >> >>> building nightly on our build farm. I'm also very interested in seeing the >>> >> >>> Maven support go in :-). >>> >> >>> >>> >> >>> Cheers, >>> >> >>> Martijn >>> >> >>> >>> >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < >>> >> >>> alexandre.iline at oracle.com > wrote: >>> >> >>> >>> >> >>>> Do you happen to have full stack trace of that? >>> >> >>>> >>> >> >>>> Also, how to I get JTReg which are you using? >>> >> >>>> >>> >> >>>> The reported missing method would be a part of JTReg, clearly. >>> >> >>>> >>> >> >>>> The other thing is you should probably be ok with just running ant ?. >>> >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne >>> >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. >>> >> >>>> >>> >> >>>> Shura >>> >> >>>> >>> >> >>>> >>> >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > >>> >> >>>> wrote: >>> >> >>>> >>> >> >>>> Hi Alexandre, >>> >> >>>> >>> >> >>>> I got a little further (This is using Java 1.8.0_162). Once I set my >>> >> >>>> swt.jar and jtreg.home I was able to run: >>> >> >>>> >>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >>> >> >>>> check-dependecies-impl >>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >>> >> >>>> build-dependecies-impl >>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >>> >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >>> >> >>> >> >>>> K_Projects/jtreg/ test-dependecies-impl >>> >> >>> >> >>>> >>> >> >>>> The first two execute OK but then the test gives me the test failure of: >>> >> >>>> >>> >> >>>> test: >>> >> >>>> [exec] Directory "/Users/karianna/Documents/wor >>> >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not >>> >> >>>> found: creating >>> >> >>>> [exec] Directory "/Users/karianna/Documents/wor >>> >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" >>> >> >>>> not found: creating >>> >> >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java >>> >> >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java >>> >> >>>> [exec] Error. Unexpected error caught from test >>> >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: >>> >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su >>> >> >>>> n/javatest/regtest/agent/JDK_Version;)I >>> >> >>>> [exec] Test results: error: 1 >>> >> >>>> [exec] Report written to /Users/karianna/Documents/work >>> >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ >>> >> >>>> report/html/report.html >>> >> >>>> [exec] Results written to /Users/karianna/Documents/work >>> >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd >>> >> >>>> [exec] Error: Some tests failed or other problems occurred. >>> >> >>>> [exec] Result: 3 >>> >> >>>> >>> >> >>>> Any ideas? >>> >> >>>> >>> >> >>>> FYI - I'm still running this locally on my Mac OS X box until I get a >>> >> >>>> clean build so I know the minimum steps for the build farm job. Note to >>> >> >>>> self that the build box will need to provide a platform specific SWT lib >>> >> >>>> (Linux x86). >>> >> >>>> >>> >> >>>> Cheers, >>> >> >>>> Martijn >>> >> >>>> >>> >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < >>> >> >>>> alexandre.iline at oracle.com > wrote: >>> >> >>>> >>> >> >>>>> Now including aliases and more recipients.. >>> >> >>>>> >>> >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < >>> >> >>>>> alexandre.iline at oracle.com > wrote: >>> >> >>>>>> >>> >> >>>>>> >>> >> >>>>>> >>> >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < >>> >> >>>>> martijnverburg at gmail.com > wrote: >>> >> >>>>>>> >>> >> >>>>>>> Hi Alexandre, >>> >> >>>>>>> >>> >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and >>> >> >>>>> that failed with: >>> >> >>>>>>> >>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: >>> >> >>>>> Please specify swt.jar >>> >> >>>>>> >>> >> >>>>>> You do need the SWT library to build SWT. >>> >> >>>>>> >>> >> >>>>>> this is what I just did: >>> >> >>>>>> >>> >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar >>> >> >>>>> jar >>> >> >>>>>> >>> >> >>>>>> >>> >> >>>>>> I clearly need to provide a README. Will do. >>> >> >>>>>> >>> >> >>>>>> Shura >>> >> >>>>>> >>> >> >>>>>>> >>> >> >>>>>>> Then I actually bothered to read the build.xml file and saw the >>> >> >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which >>> >> >>>>> seemed to build: >>> >> >>>>>>> >>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >>> >> >>>>> /core/JemmyCore/build/JemmyCore.jar >>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >>> >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar >>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >>> >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar >>> >> >>>>>>> >>> >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set >>> >> >>>>>>> >>> >> >>>>>>> Before I shave more Yaks, is this the right direction to be going in? >>> >> >>>>>>> >>> >> >>>>>>> >>> >> >>>>>>> Cheers, >>> >> >>>>>>> Martijn >>> >> >>>>>>> >>> >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < >>> >> >>>>> alexandre.iline at oracle.com > wrote: >>> >> >>>>>>> Martijn, >>> >> >>>>>>> >>> >> >>>>>>> Jemmy v3 consists of several project which depend on each other. >>> >> >>>>>>> >>> >> >>>>>>> If, besides hosting the source, the intension is to build it, you >>> >> >>>>> need to build projects which are in use by others who would be coming to >>> >> >>>>> AdoptOpenJDK for binaries. >>> >> >>>>>>> >>> >> >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. >>> >> >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is >>> >> >>>>> build, the dependences are also built, you should have no problem with that. >>> >> >>>>>>> >>> >> >>>>>>> Binaries would, then, simply include all jar files create after the >>> >> >>>>> build. The jar files will be: */*/build/*.jar >>> >> >>>>>>> >>> >> >>>>>>> Shura >>> >> >>>>>>> >>> >> >>>>>>> >>> >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < >>> >> >>>>> martijnverburg at gmail.com > wrote: >>> >> >>>>>>>> >>> >> >>>>>>>> Hi Dalibor, >>> >> >>>>>>>> >>> >> >>>>>>>> We're shifting the code tools off Cloudbees to the new >>> >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick >>> >> >>>>> Q: >>> >> >>>>>>>> >>> >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: >>> >> >>>>>>>> >>> >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . >>> >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. >>> >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg >>> >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck >>> >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT >>> >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core >>> >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make >>> >> >>>>>>>> >>> >> >>>>>>>> but I can't see what the canonical entry point to build it is. >>> >> >>>>>>>> >>> >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. >>> >> >>>>>>>> >>> >> >>>>>>>> Cheers, >>> >> >>>>>>>> Martijn >>> >> >>>>>>>> >>> >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic > >>> >> >>>>> wrote: >>> >> >>>>>>>> Hi Martijn, >>> >> >>>>>>>> >>> >> >>>>>>>> would you be able to add the Jemmy v3 repo at >>> >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to >>> >> >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? >>> >> >>>>>>>> >>> >> >>>>>>>> cheers, >>> >> >>>>>>>> dalibor topic >>> >> >>>>>>>> -- >>> >> >>>>>>>> > Dalibor Topic | Principal Product Manager >>> >> >>> >> >>>>>>>> Phone: +494089091214 <+494089091214>> | Mobile: >>> >> >>>>> +491737185961 >>> >> >>>>>>>> <+491737185961>> >>> >> >>>>>>>> >>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg >>> >> >>>>> > >>> >> >>>>>>>> >>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG >>> >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 >>> >> >>>>> > >>> >> >>>>> M?nchen >>> >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 >>> >> >>>>>>>> >>> >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. >>> >> >>>>>>>> Hertogswetering 163 /167, 3543 AS Utrecht, Niederlande >>> >> >>>>> > >>> >> >>> >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 >>> >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher >>> >> >>>>>>>> >>> >> >>>>>>>> > Oracle is committed to >>> >> >>>>> developing >>> >> >>>>>>>> practices and products that help protect the environment >>> >> >>>>>>>> >>> >> >>>>>>> >>> >> >>>>>>> >>> >> >>>>>> >>> >> >>>>> >>> >> >>>>> >>> >> >>>> >>> >> >>>> >>> >> >>> >>> >> >>> >>> >> >> >>> >> >>> >> >>> >> >>> >> >>> > >>> > >>> >>> >> >> -- >> Cheers, Martijn (Sent from Gmail Mobile) > From alexandre.iline at oracle.com Fri May 4 16:29:38 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Fri, 4 May 2018 09:29:38 -0700 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> Message-ID: Looks like my reply has disappeared. Not sure what happened. Let me restate. I think that 1. JemmtSWT artifact should contain JemmySWT ?module? and there should be separate artifact for JemmyCore, etc. 2. Artifact version should be coming from the appropriate artifact version. 3. Updating Jemmy version to reflect that fact that Jemmy code is maven-ized is fine, re-ressing the version to 1.0.0 or any other version 4. It is better for everybody to drop v3 in artifact naming. If there would be artifacts from v2, they would be named differently. Shura > On May 3, 2018, at 1:12 PM, Martijn Verburg wrote: > > Hi all, > > I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/ ). I have a few questions / comments. > > 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? > > 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. > > 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. > > * In terms of SNAPSHOTS we could could likely push on every build > * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release > > My suggestion is that you: > > 1.) Change the version numbers to 1.0.0-SNAPSHOT > 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) > 3.) We perform a formal release (1.0.0) and push that to Maven Central > 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need > > I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! > > Cheers, > Martijn > > On 13 April 2018 at 08:40, Erik Greijus > wrote: > > > > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg >: > > > > Hi all, > > > > The Jemmy build project is here: > > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ > > > > If managed to get a mostly successful run and have produced a jemmy.tar.gz > > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, > > JemmyBrowser.jar). Now for some questions :-) > > > > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do > > platform specific jemmy's need to be built? > > Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) > > > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if > > I can get that Jenkins node to fire up an X11 so that those tests can pass. > > That would be good. > > > 3.) Can folks please grab the tar.gz from the latest artifacts link > > > > > and let me know if that's how they expect it to be named and whether the > > layout of the contents is acceptable > > I miss the JemmySWT jar file mentioned above. > > > 4.) Versioning / naming - should I be building off a known good tag? Do we > > want the tip/commit number to be part of the artifact name? > > > > It should build on an SCM change and weekly as well > > > > > > Cheers, > > Martijn > > > > On 11 April 2018 at 09:56, Martijn Verburg > wrote: > > > >> Cool, I'll go with what I have as a working build for now and adjust to > >> use the test target when that change comes in, and then perhaps move to the > >> Maven build later. > >> > >> Cheers, > >> Martijn > >> > >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < > >> alexandre.iline at oracle.com > wrote: > >> > >>> > >>> > >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > > >>> wrote: > >>> > >>> Hi Alexandre, > >>> > >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( > >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/ ) in particular > >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue > >>> up (we did have broken binaries for a bit). > >>> > >>> If I now run > >>> > >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu > >>> ild-dependecies-impl > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te > >>> st-dependecies-impl > >>> > >>> Then I get a passing build! > >>> > >>> --------- > >>> > >>> Onto the next issue! If I run just: > >>> > >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ > >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test > >>> > >>> Then I get compile errors like: > >>> > >>> compile-test: > >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work > >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem("Table")). > >>> wrap().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ > >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find > >>> symbol > >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap > >>> ().mouse().click(); > >>> [javac] ^ > >>> [javac] symbol: class ByTextItem > >>> [javac] location: class ItemsTest > >>> > >>> > >>> > >>> This, I believe, is a bug which is going to be addressed by the review in > >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 > >>> 018-April/000080.html > >>> > >>> Shura > >>> > >>> > >>> ------------ > >>> > >>> A *README.txt* for building at the root of the project and a .*hgignore* > >>> file would also be nice to haves. > >>> > >>> ------------ > >>> > >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy > >>> building nightly on our build farm. I'm also very interested in seeing the > >>> Maven support go in :-). > >>> > >>> Cheers, > >>> Martijn > >>> > >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < > >>> alexandre.iline at oracle.com > wrote: > >>> > >>>> Do you happen to have full stack trace of that? > >>>> > >>>> Also, how to I get JTReg which are you using? > >>>> > >>>> The reported missing method would be a part of JTReg, clearly. > >>>> > >>>> The other thing is you should probably be ok with just running ant ?. > >>>> test. ?test? target is coming from http://hg.openjdk.java.ne > >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. > >>>> > >>>> Shura > >>>> > >>>> > >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > > >>>> wrote: > >>>> > >>>> Hi Alexandre, > >>>> > >>>> I got a little further (This is using Java 1.8.0_162). Once I set my > >>>> swt.jar and jtreg.home I was able to run: > >>>> > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> check-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> build-dependecies-impl > >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 > >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD > >>>> K_Projects/jtreg/ test-dependecies-impl > >>>> > >>>> The first two execute OK but then the test gives me the test failure of: > >>>> > >>>> test: > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not > >>>> found: creating > >>>> [exec] Directory "/Users/karianna/Documents/wor > >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" > >>>> not found: creating > >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java > >>>> [exec] Error. Unexpected error caught from test > >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: > >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su > >>>> n/javatest/regtest/agent/JDK_Version;)I > >>>> [exec] Test results: error: 1 > >>>> [exec] Report written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ > >>>> report/html/report.html > >>>> [exec] Results written to /Users/karianna/Documents/work > >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd > >>>> [exec] Error: Some tests failed or other problems occurred. > >>>> [exec] Result: 3 > >>>> > >>>> Any ideas? > >>>> > >>>> FYI - I'm still running this locally on my Mac OS X box until I get a > >>>> clean build so I know the minimum steps for the build farm job. Note to > >>>> self that the build box will need to provide a platform specific SWT lib > >>>> (Linux x86). > >>>> > >>>> Cheers, > >>>> Martijn > >>>> > >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < > >>>> alexandre.iline at oracle.com > wrote: > >>>> > >>>>> Now including aliases and more recipients.. > >>>>> > >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com > wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < > >>>>> martijnverburg at gmail.com > wrote: > >>>>>>> > >>>>>>> Hi Alexandre, > >>>>>>> > >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and > >>>>> that failed with: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: > >>>>> Please specify swt.jar > >>>>>> > >>>>>> You do need the SWT library to build SWT. > >>>>>> > >>>>>> this is what I just did: > >>>>>> > >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar > >>>>> jar > >>>>>> > >>>>>> > >>>>>> I clearly need to provide a README. Will do. > >>>>>> > >>>>>> Shura > >>>>>> > >>>>>>> > >>>>>>> Then I actually bothered to read the build.xml file and saw the > >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which > >>>>> seemed to build: > >>>>>>> > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyCore/build/JemmyCore.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar > >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 > >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar > >>>>>>> > >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set > >>>>>>> > >>>>>>> Before I shave more Yaks, is this the right direction to be going in? > >>>>>>> > >>>>>>> > >>>>>>> Cheers, > >>>>>>> Martijn > >>>>>>> > >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < > >>>>> alexandre.iline at oracle.com > wrote: > >>>>>>> Martijn, > >>>>>>> > >>>>>>> Jemmy v3 consists of several project which depend on each other. > >>>>>>> > >>>>>>> If, besides hosting the source, the intension is to build it, you > >>>>> need to build projects which are in use by others who would be coming to > >>>>> AdoptOpenJDK for binaries. > >>>>>>> > >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. > >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is > >>>>> build, the dependences are also built, you should have no problem with that. > >>>>>>> > >>>>>>> Binaries would, then, simply include all jar files create after the > >>>>> build. The jar files will be: */*/build/*.jar > >>>>>>> > >>>>>>> Shura > >>>>>>> > >>>>>>> > >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < > >>>>> martijnverburg at gmail.com > wrote: > >>>>>>>> > >>>>>>>> Hi Dalibor, > >>>>>>>> > >>>>>>>> We're shifting the code tools off Cloudbees to the new > >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick > >>>>> Q: > >>>>>>>> > >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: > >>>>>>>> > >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . > >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. > >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck > >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT > >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core > >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make > >>>>>>>> > >>>>>>>> but I can't see what the canonical entry point to build it is. > >>>>>>>> > >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> Martijn > >>>>>>>> > >>>>>>>> On 28 March 2018 at 17:02, dalibor topic > > >>>>> wrote: > >>>>>>>> Hi Martijn, > >>>>>>>> > >>>>>>>> would you be able to add the Jemmy v3 repo at > >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to > >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? > >>>>>>>> > >>>>>>>> cheers, > >>>>>>>> dalibor topic > >>>>>>>> -- > >>>>>>>> > Dalibor Topic | Principal Product Manager > >>>>>>>> Phone: +494089091214 > | Mobile: > >>>>> +491737185961 > >>>>>>>> > > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg > >>>>> > > >>>>>>>> > >>>>>>>> ORACLE Deutschland B.V. & Co. KG > >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 > >>>>> > > >>>>> M?nchen > >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 > >>>>>>>> > >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. > >>>>>>>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande > >>>>> > > >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 > >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher > >>>>>>>> > >>>>>>>> > Oracle is committed to > >>>>> developing > >>>>>>>> practices and products that help protect the environment > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>>> > >>>> > >>>> > >>> > >>> > >> > > From patrick at reini.net Tue May 8 19:56:13 2018 From: patrick at reini.net (Patrick Reinhart) Date: Tue, 8 May 2018 21:56:13 +0200 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> Message-ID: <75039d18-9512-73fd-5e4e-a0865e81daf3@reini.net> Hi everybody, I updated the webrev using the suggested names and version. Also the code compiles without any Javadoc errors now and there is only one remaining Test failing here using Xvfb. Any ideas or hints? org.jemmy.TimeoutExpiredException: State 'text() equals 'Now press the field', text() = 'ow press the idlef'' has not been reached in 1000 milliseconds ??? at org.jemmy.timing.Waiter.ensureState(Waiter.java:83) ??? at org.jemmy.input.TextImpl$1.run(TextImpl.java:76) ??? at org.jemmy.action.Action.execute(Action.java:48) ??? at org.jemmy.action.ActionQueue$ActionRecord.execute(ActionQueue.java:165) ??? at org.jemmy.action.ActionQueue$1.run(ActionQueue.java:63) ??? at java.lang.Thread.run(Thread.java:748) [ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 10.394 s <<< FAILURE! - in org.jemmy.swt.PushButtonTest [ERROR] type(org.jemmy.swt.PushButtonTest)? Time elapsed: 6.967 s? <<< FAILURE! org.jemmy.JemmyException: Action 'typing text "Now press the field"' invoked through ActionQueue failed ??? at org.jemmy.swt.PushButtonTest.type(PushButtonTest.java:106) Caused by: org.jemmy.TimeoutExpiredException: State 'text() equals 'Now press the field', text() = 'ow press the idlef'' has not been reached in 1000 milliseconds -Patrick Am 04.05.2018 um 18:29 schrieb Alexandre (Shura) Iline: > Looks like my reply has disappeared. Not sure what happened. Let me restate. > > I think that > 1. JemmtSWT artifact should contain JemmySWT ?module? and there should be separate artifact for JemmyCore, etc. > 2. Artifact version should be coming from the appropriate artifact version. > 3. Updating Jemmy version to reflect that fact that Jemmy code is maven-ized is fine, re-ressing the version to 1.0.0 or any other version > 4. It is better for everybody to drop v3 in artifact naming. If there would be artifacts from v2, they would be named differently. > From alexandre.iline at oracle.com Tue May 8 20:49:40 2018 From: alexandre.iline at oracle.com (alexandre.iline at oracle.com) Date: Tue, 08 May 2018 20:49:40 +0000 Subject: hg: code-tools/jemmy/v3: 7902173: Incorrect copyright files in Jemmy v3 Message-ID: <201805082049.w48KnfDu005103@aojmv0008.oracle.com> Changeset: 2b6fc4f103a4 Author: shurailine Date: 2018-05-08 13:49 -0700 URL: http://hg.openjdk.java.net/code-tools/jemmy/v3/rev/2b6fc4f103a4 7902173: Incorrect copyright files in Jemmy v3 + COPYRIGHT + LICENSE ! SWT/JemmySWT/build.xml ! SWT/JemmySWT/pom.xml ! SWT/JemmySWT/src/org/jemmy/input/KeyboardSelectable.java ! SWT/JemmySWT/src/org/jemmy/input/KeyboardSelector.java ! SWT/JemmySWT/src/org/jemmy/swt/Browser.java ! SWT/JemmySWT/src/org/jemmy/swt/CComboWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/CTabFolderWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ComboWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/CompositeWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ControlWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/IndexItemSelector.java ! SWT/JemmySWT/src/org/jemmy/swt/ItemParent.java ! SWT/JemmySWT/src/org/jemmy/swt/ItemWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ListWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/MenuItemParent.java ! SWT/JemmySWT/src/org/jemmy/swt/SWTExecutor.java ! SWT/JemmySWT/src/org/jemmy/swt/SWTMenu.java ! SWT/JemmySWT/src/org/jemmy/swt/SWTMenuOwner.java ! SWT/JemmySWT/src/org/jemmy/swt/SWTPopupOwner.java ! SWT/JemmySWT/src/org/jemmy/swt/SWTTree.java ! SWT/JemmySWT/src/org/jemmy/swt/ScrollableWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ShellWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/Shells.java ! SWT/JemmySWT/src/org/jemmy/swt/TabFolderWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/TableWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/TextItemSelector.java ! SWT/JemmySWT/src/org/jemmy/swt/TextWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ToolBarWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ToolTipItemSelector.java ! SWT/JemmySWT/src/org/jemmy/swt/TreeWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/Version.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemStringsLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemToolTipLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByName.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByStringQueueLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByTextButtonLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByTextControlLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByTextItem.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByTextLabelLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByTextShell.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByTextTextLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByToolTipControl.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByToolTipItem.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByTooltipButtonLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/CoordinateLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/QueueLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/WrapperLookup.java ! SWT/JemmySWT/test/org/jemmy/swt/Items.java ! SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java ! SWT/JemmySWT/test/org/jemmy/swt/MenuTest.java ! SWT/JemmySWT/test/org/jemmy/swt/PushButtonTest.java ! SWT/JemmySWT/test/org/jemmy/swt/Sample.java ! SWT/JemmySWT/test/org/jemmy/swt/SelectableTest.java ! SWT/JemmySWT/test/org/jemmy/swt/TestBrowser.java ! SWT/JemmySWT/test/org/jemmy/swt/TreeTest.java ! SWT/make/jemmy-v3-swt-ii/.idea/compiler.xml ! SWT/make/jemmy-v3-swt-ii/.idea/copyright/Oracle.xml ! SWT/make/jemmy-v3-swt-ii/.idea/encodings.xml ! SWT/make/jemmy-v3-swt-ii/.idea/misc.xml ! core/JemmyAWTInput/build.xml ! core/JemmyAWTInput/pom.xml ! core/JemmyAWTInput/src/org/jemmy/image/AWTImage.java ! core/JemmyAWTInput/src/org/jemmy/image/AWTRobotCapturer.java ! core/JemmyAWTInput/src/org/jemmy/image/AbstractImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/AverageDistanceImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/BufferedImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/ClasspathImageLoader.java ! core/JemmyAWTInput/src/org/jemmy/image/ColorImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/DiffDialog.form ! core/JemmyAWTInput/src/org/jemmy/image/DiffDialog.java ! core/JemmyAWTInput/src/org/jemmy/image/FilesystemImageLoader.java ! core/JemmyAWTInput/src/org/jemmy/image/ImageFinder.java ! core/JemmyAWTInput/src/org/jemmy/image/ImageTool.java ! core/JemmyAWTInput/src/org/jemmy/image/NaturalImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/PNGDecoder.java ! core/JemmyAWTInput/src/org/jemmy/image/PNGEncoder.java ! core/JemmyAWTInput/src/org/jemmy/image/PNGImageLoader.java ! core/JemmyAWTInput/src/org/jemmy/image/PNGImageSaver.java ! core/JemmyAWTInput/src/org/jemmy/image/ResizeImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/RoughImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/RoughImageFinder.java ! core/JemmyAWTInput/src/org/jemmy/image/StrictImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/StrictImageFinder.java ! core/JemmyAWTInput/src/org/jemmy/image/Utils.java ! core/JemmyAWTInput/src/org/jemmy/input/AWTMap.java ! core/JemmyAWTInput/src/org/jemmy/input/AWTRobotInputFactory.java ! core/JemmyAWTInput/src/org/jemmy/input/ClassReference.java ! core/JemmyAWTInput/src/org/jemmy/input/DragImpl.java ! core/JemmyAWTInput/src/org/jemmy/input/KeyboardImpl.java ! core/JemmyAWTInput/src/org/jemmy/input/MouseImpl.java ! core/JemmyAWTInput/src/org/jemmy/input/RobotDriver.java ! core/JemmyAWTInput/src/org/jemmy/input/RobotExecutor.java ! core/JemmyAWTInput/src/org/jemmy/input/Version.java ! core/JemmyAWTInput/src/org/jemmy/operators/AWTScreen.java ! core/JemmyAWTInput/test/org/jemmy/image/AverageDistanceImageComparatorTest.java ! core/JemmyAWTInput/test/org/jemmy/image/EnvTest.java ! core/JemmyAWTInput/test/org/jemmy/image/ImageResizerTest.java ! core/JemmyAWTInput/test/org/jemmy/image/InitTest.java ! core/JemmyAWTInput/test/org/jemmy/image/NaturalImageComparatorTest.java ! core/JemmyAWTInput/test/org/jemmy/image/SaveLoadTest.java ! core/JemmyAWTInput/test/org/jemmy/image/ScreenAreaImageTest.java ! core/JemmyAWTInput/test/org/jemmy/image/ScreenImageTest.java ! core/JemmyAWTInput/test/org/jemmy/image/comparator/ComparatorTest.java ! core/JemmyAWTInput/test/org/jemmy/input/AWTMapTest.java ! core/JemmyAWTInput/test/org/jemmy/input/RobotDriver2Test.java ! core/JemmyAWTInput/test/org/jemmy/input/RobotDriverTest.java ! core/JemmyAWTInput/test/org/jemmy/input/RobotExecutorTest.java ! core/JemmyAWTInput/test/org/jemmy/input/SmoothMoveTest.java ! core/JemmyAWTInput/test/org/jemmy/operators/ScreenTest.java ! core/JemmyBrowser/build.xml ! core/JemmyBrowser/pom.xml ! core/JemmyBrowser/src/org/jemmy/browser/BrowserDescriptor.java ! core/JemmyBrowser/src/org/jemmy/browser/ElementRetriever.java ! core/JemmyBrowser/src/org/jemmy/browser/HierarchyDescriptor.java ! core/JemmyBrowser/src/org/jemmy/browser/HierarchyView.java ! core/JemmyBrowser/src/org/jemmy/browser/ImageLabel.java ! core/JemmyBrowser/src/org/jemmy/browser/InterfacesPanel.java ! core/JemmyBrowser/src/org/jemmy/browser/NodeDescriptor.java ! core/JemmyBrowser/src/org/jemmy/browser/PropertiesPanel.java ! core/JemmyBrowser/src/org/jemmy/browser/ReflectionPanel.java ! core/JemmyBrowser/src/org/jemmy/browser/SearchDialog.java ! core/JemmyBrowser/test/org/jemmy/browser/PropPanelTest.java ! core/JemmyCore/build.xml ! core/JemmyCore/doc/Jemmy3Lookup.html ! core/JemmyCore/doc/Jemmy3UserTutorial.html ! core/JemmyCore/pom.xml ! core/JemmyCore/src/org/jemmy/Dimension.java ! core/JemmyCore/src/org/jemmy/JemmyException.java ! core/JemmyCore/src/org/jemmy/Point.java ! core/JemmyCore/src/org/jemmy/Rectangle.java ! core/JemmyCore/src/org/jemmy/TimeoutExpiredException.java ! core/JemmyCore/src/org/jemmy/Vector.java ! core/JemmyCore/src/org/jemmy/Version.java ! core/JemmyCore/src/org/jemmy/action/AbstractExecutor.java ! core/JemmyCore/src/org/jemmy/action/Action.java ! core/JemmyCore/src/org/jemmy/action/ActionExecutor.java ! core/JemmyCore/src/org/jemmy/action/ActionQueue.java ! core/JemmyCore/src/org/jemmy/action/DefaultExecutor.java ! core/JemmyCore/src/org/jemmy/action/FutureAction.java ! core/JemmyCore/src/org/jemmy/action/GetAction.java ! core/JemmyCore/src/org/jemmy/control/AbstractWrapper.java ! core/JemmyCore/src/org/jemmy/control/As.java ! core/JemmyCore/src/org/jemmy/control/ControlInterfaces.java ! core/JemmyCore/src/org/jemmy/control/ControlType.java ! core/JemmyCore/src/org/jemmy/control/DefaultWrapper.java ! core/JemmyCore/src/org/jemmy/control/FieldProperties.java ! core/JemmyCore/src/org/jemmy/control/JemmySupportWrapper.java ! core/JemmyCore/src/org/jemmy/control/LazyWrapper.java ! core/JemmyCore/src/org/jemmy/control/MethodProperties.java ! core/JemmyCore/src/org/jemmy/control/Property.java ! core/JemmyCore/src/org/jemmy/control/ScreenArea.java ! core/JemmyCore/src/org/jemmy/control/SelectorImpl.java ! core/JemmyCore/src/org/jemmy/control/Wrap.java ! core/JemmyCore/src/org/jemmy/control/Wrapper.java ! core/JemmyCore/src/org/jemmy/control/WrapperDelegate.java ! core/JemmyCore/src/org/jemmy/control/WrapperException.java ! core/JemmyCore/src/org/jemmy/control/WrapperImpl.java ! core/JemmyCore/src/org/jemmy/dock/DefaultParent.java ! core/JemmyCore/src/org/jemmy/dock/DefaultWrapper.java ! core/JemmyCore/src/org/jemmy/dock/Dock.java ! core/JemmyCore/src/org/jemmy/dock/DockInfo.java ! core/JemmyCore/src/org/jemmy/dock/ObjectLookup.java ! core/JemmyCore/src/org/jemmy/dock/PreferredParent.java ! core/JemmyCore/src/org/jemmy/dock/Shortcut.java ! core/JemmyCore/src/org/jemmy/env/Environment.java ! core/JemmyCore/src/org/jemmy/env/TestOut.java ! core/JemmyCore/src/org/jemmy/env/Timeout.java ! core/JemmyCore/src/org/jemmy/image/Image.java ! core/JemmyCore/src/org/jemmy/image/ImageCapturer.java ! core/JemmyCore/src/org/jemmy/image/ImageComparator.java ! core/JemmyCore/src/org/jemmy/image/ImageLoader.java ! core/JemmyCore/src/org/jemmy/image/ImageStore.java ! core/JemmyCore/src/org/jemmy/image/pixel/AverageDistanceComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/BaseCountingRasterComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/ColorMappingComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/MaxDistanceComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/PNGFileImageStore.java ! core/JemmyCore/src/org/jemmy/image/pixel/PNGLoader.java ! core/JemmyCore/src/org/jemmy/image/pixel/PNGSaver.java ! core/JemmyCore/src/org/jemmy/image/pixel/PeakSignalNoiseRatioComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/PixelEqualityRasterComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/PixelImageComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/Raster.java ! core/JemmyCore/src/org/jemmy/image/pixel/RasterComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/ResizeComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/ThresholdComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/WriteableRaster.java ! core/JemmyCore/src/org/jemmy/input/AbstractCaretOwner.java ! core/JemmyCore/src/org/jemmy/input/AbstractScroll.java ! core/JemmyCore/src/org/jemmy/input/CaretImpl.java ! core/JemmyCore/src/org/jemmy/input/CaretText.java ! core/JemmyCore/src/org/jemmy/input/CharBindingMap.java ! core/JemmyCore/src/org/jemmy/input/ClickFocus.java ! core/JemmyCore/src/org/jemmy/input/DefaultCharBindingMap.java ! core/JemmyCore/src/org/jemmy/input/KnobDragScrollerImpl.java ! core/JemmyCore/src/org/jemmy/input/RegexCaretDirection.java ! core/JemmyCore/src/org/jemmy/input/ScrollerImpl.java ! core/JemmyCore/src/org/jemmy/input/SelectionText.java ! core/JemmyCore/src/org/jemmy/input/StringCriteriaList.java ! core/JemmyCore/src/org/jemmy/input/StringMenuOwner.java ! core/JemmyCore/src/org/jemmy/input/StringMenuSelectableOwner.java ! core/JemmyCore/src/org/jemmy/input/StringPopupOwner.java ! core/JemmyCore/src/org/jemmy/input/StringPopupSelectableOwner.java ! core/JemmyCore/src/org/jemmy/input/StringTree.java ! core/JemmyCore/src/org/jemmy/input/TextCaret.java ! core/JemmyCore/src/org/jemmy/input/TextImpl.java ! core/JemmyCore/src/org/jemmy/input/WindowImpl.java ! core/JemmyCore/src/org/jemmy/interfaces/Button.java ! core/JemmyCore/src/org/jemmy/interfaces/Caret.java ! core/JemmyCore/src/org/jemmy/interfaces/CaretOwner.java ! core/JemmyCore/src/org/jemmy/interfaces/Collapsible.java ! core/JemmyCore/src/org/jemmy/interfaces/ControlInterface.java ! core/JemmyCore/src/org/jemmy/interfaces/ControlInterfaceFactory.java ! core/JemmyCore/src/org/jemmy/interfaces/Drag.java ! core/JemmyCore/src/org/jemmy/interfaces/Expandable.java ! core/JemmyCore/src/org/jemmy/interfaces/Focus.java ! core/JemmyCore/src/org/jemmy/interfaces/Focusable.java ! core/JemmyCore/src/org/jemmy/interfaces/InterfaceException.java ! core/JemmyCore/src/org/jemmy/interfaces/IntervalSelectable.java ! core/JemmyCore/src/org/jemmy/interfaces/IntervalSelector.java ! core/JemmyCore/src/org/jemmy/interfaces/Keyboard.java ! core/JemmyCore/src/org/jemmy/interfaces/Label.java ! core/JemmyCore/src/org/jemmy/interfaces/Menu.java ! core/JemmyCore/src/org/jemmy/interfaces/MenuOwner.java ! core/JemmyCore/src/org/jemmy/interfaces/MenuSelectable.java ! core/JemmyCore/src/org/jemmy/interfaces/MenuSelectableOwner.java ! core/JemmyCore/src/org/jemmy/interfaces/Modifier.java ! core/JemmyCore/src/org/jemmy/interfaces/Mouse.java ! core/JemmyCore/src/org/jemmy/interfaces/Parent.java ! core/JemmyCore/src/org/jemmy/interfaces/PopupOwner.java ! core/JemmyCore/src/org/jemmy/interfaces/PopupSelectableOwner.java ! core/JemmyCore/src/org/jemmy/interfaces/Scroll.java ! core/JemmyCore/src/org/jemmy/interfaces/Selectable.java ! core/JemmyCore/src/org/jemmy/interfaces/Selector.java ! core/JemmyCore/src/org/jemmy/interfaces/Show.java ! core/JemmyCore/src/org/jemmy/interfaces/Showable.java ! core/JemmyCore/src/org/jemmy/interfaces/Text.java ! core/JemmyCore/src/org/jemmy/interfaces/TextInput.java ! core/JemmyCore/src/org/jemmy/interfaces/Tree.java ! core/JemmyCore/src/org/jemmy/interfaces/TreeItem.java ! core/JemmyCore/src/org/jemmy/interfaces/TreeSelector.java ! core/JemmyCore/src/org/jemmy/interfaces/TypeControlInterface.java ! core/JemmyCore/src/org/jemmy/interfaces/Window.java ! core/JemmyCore/src/org/jemmy/lookup/AbstractLookup.java ! core/JemmyCore/src/org/jemmy/lookup/AbstractParent.java ! core/JemmyCore/src/org/jemmy/lookup/Any.java ! core/JemmyCore/src/org/jemmy/lookup/ByStringLookup.java ! core/JemmyCore/src/org/jemmy/lookup/ByToStringLookup.java ! core/JemmyCore/src/org/jemmy/lookup/CompoundLookup.java ! core/JemmyCore/src/org/jemmy/lookup/ControlHierarchy.java ! core/JemmyCore/src/org/jemmy/lookup/ControlList.java ! core/JemmyCore/src/org/jemmy/lookup/CoordinateLookup.java ! core/JemmyCore/src/org/jemmy/lookup/EqualsLookup.java ! core/JemmyCore/src/org/jemmy/lookup/HierarchyLookup.java ! core/JemmyCore/src/org/jemmy/lookup/ImageLookup.java ! core/JemmyCore/src/org/jemmy/lookup/Lookup.java ! core/JemmyCore/src/org/jemmy/lookup/LookupCriteria.java ! core/JemmyCore/src/org/jemmy/lookup/ParentImpl.java ! core/JemmyCore/src/org/jemmy/lookup/PlainLookup.java ! core/JemmyCore/src/org/jemmy/lookup/PropLookup.java ! core/JemmyCore/src/org/jemmy/lookup/RelativeCoordinateLookup.java ! core/JemmyCore/src/org/jemmy/operators/Screen.java ! core/JemmyCore/src/org/jemmy/operators/ScreenRectangle.java ! core/JemmyCore/src/org/jemmy/resources/StringComparePolicy.java ! core/JemmyCore/src/org/jemmy/timing/State.java ! core/JemmyCore/src/org/jemmy/timing/TimedCriteria.java ! core/JemmyCore/src/org/jemmy/timing/Timeline.java ! core/JemmyCore/src/org/jemmy/timing/Waiter.java ! core/JemmyCore/test/org/jemmy/RectangleTest.java ! core/JemmyCore/test/org/jemmy/animation/TimelineTest.java ! core/JemmyCore/test/org/jemmy/control/PropertiesTest.java ! core/JemmyCore/test/org/jemmy/env/EnvironmentTest.java ! core/JemmyCore/test/org/jemmy/env/LoadRelativeTimeoutsTest.java ! core/JemmyCore/test/org/jemmy/env/LoadTimeoutsTest.java ! core/JemmyCore/test/org/jemmy/env/SetTimeoutsTest.java ! core/JemmyCore/test/org/jemmy/image/SaveLoadImageTest.java ! core/JemmyCore/test/org/jemmy/image/pixel/PixelImageComparatorTest.java ! core/JemmyCore/test/org/jemmy/properties/PropTest.java ! core/JemmyCore/test/org/jemmy/properties/TestObject.java ! core/JemmyCore/test/org/jemmy/properties/TestWrap.java ! core/make/jemmy-v3-ii/.idea/compiler.xml ! core/make/jemmy-v3-ii/.idea/copyright/Oracle.xml ! core/make/jemmy-v3-ii/.idea/encodings.xml ! core/make/jemmy-v3-ii/.idea/misc.xml ! core/make/jemmy-v3-ii/.idea/modules.xml ! make/build_template.xml ! pom.xml From alexandre.iline at oracle.com Tue May 8 20:50:44 2018 From: alexandre.iline at oracle.com (alexandre.iline at oracle.com) Date: Tue, 08 May 2018 20:50:44 +0000 Subject: hg: code-tools/jemmy/v2: 7902172: No class path exception in copyright headers in Jemmy v2. code Message-ID: <201805082050.w48KoicV005585@aojmv0008.oracle.com> Changeset: 919c96a548b7 Author: shurailine Date: 2018-05-08 13:50 -0700 URL: http://hg.openjdk.java.net/code-tools/jemmy/v2/rev/919c96a548b7 7902172: No class path exception in copyright headers in Jemmy v2. code ! build.xml + make/jemmy-v2-ii/.idea/copyright/GNU_CPE.xml + make/jemmy-v2-ii/.idea/copyright/profiles_settings.xml ! make/jemmy-v2-ii/.idea/misc.xml ! make/jemmy-v2-ii/JemmyV2.iml ! src/org/netbeans/jemmy/Action.java ! src/org/netbeans/jemmy/ActionProducer.java ! src/org/netbeans/jemmy/Bundle.java ! src/org/netbeans/jemmy/BundleManager.java ! src/org/netbeans/jemmy/CharBindingMap.java ! src/org/netbeans/jemmy/ClassReference.java ! src/org/netbeans/jemmy/ComponentChooser.java ! src/org/netbeans/jemmy/ComponentIsNotFocusedException.java ! src/org/netbeans/jemmy/ComponentIsNotVisibleException.java ! src/org/netbeans/jemmy/ComponentSearcher.java ! src/org/netbeans/jemmy/DefaultCharBindingMap.java ! src/org/netbeans/jemmy/DialogWaiter.java ! src/org/netbeans/jemmy/EventDispatcher.java ! src/org/netbeans/jemmy/EventTool.java ! src/org/netbeans/jemmy/FrameWaiter.java ! src/org/netbeans/jemmy/JemmyException.java ! src/org/netbeans/jemmy/JemmyInputException.java ! src/org/netbeans/jemmy/JemmyProperties.java ! src/org/netbeans/jemmy/NoComponentUnderMouseException.java ! src/org/netbeans/jemmy/ObjectBrowser.java ! src/org/netbeans/jemmy/Outputable.java ! src/org/netbeans/jemmy/QueueTool.java ! src/org/netbeans/jemmy/Scenario.java ! src/org/netbeans/jemmy/Test.java ! src/org/netbeans/jemmy/TestCompletedException.java ! src/org/netbeans/jemmy/TestOut.java ! src/org/netbeans/jemmy/Timeout.java ! src/org/netbeans/jemmy/TimeoutExpiredException.java ! src/org/netbeans/jemmy/Timeoutable.java ! src/org/netbeans/jemmy/Timeouts.java ! src/org/netbeans/jemmy/Waitable.java ! src/org/netbeans/jemmy/Waiter.java ! src/org/netbeans/jemmy/WindowWaiter.java ! src/org/netbeans/jemmy/accessibility/AccessibilityChooser.java ! src/org/netbeans/jemmy/accessibility/AccessibleDescriptionChooser.java ! src/org/netbeans/jemmy/accessibility/AccessibleNameChooser.java ! src/org/netbeans/jemmy/demo/CommentWindow.java ! src/org/netbeans/jemmy/demo/DefaultCommentWindow.java ! src/org/netbeans/jemmy/demo/DemoInterruptedException.java ! src/org/netbeans/jemmy/demo/Demonstrator.java ! src/org/netbeans/jemmy/demo/package-info.java ! src/org/netbeans/jemmy/drivers/APIDriverInstaller.java ! src/org/netbeans/jemmy/drivers/ArrayDriverInstaller.java ! src/org/netbeans/jemmy/drivers/ButtonDriver.java ! src/org/netbeans/jemmy/drivers/DefaultDriverInstaller.java ! src/org/netbeans/jemmy/drivers/DescriptablePathChooser.java ! src/org/netbeans/jemmy/drivers/Driver.java ! src/org/netbeans/jemmy/drivers/DriverInstaller.java ! src/org/netbeans/jemmy/drivers/DriverManager.java ! src/org/netbeans/jemmy/drivers/EditorDriver.java ! src/org/netbeans/jemmy/drivers/FocusDriver.java ! src/org/netbeans/jemmy/drivers/FrameDriver.java ! src/org/netbeans/jemmy/drivers/InputDriverInstaller.java ! src/org/netbeans/jemmy/drivers/InternalFrameDriver.java ! src/org/netbeans/jemmy/drivers/KeyDriver.java ! src/org/netbeans/jemmy/drivers/LightDriver.java ! src/org/netbeans/jemmy/drivers/LightSupportiveDriver.java ! src/org/netbeans/jemmy/drivers/ListDriver.java ! src/org/netbeans/jemmy/drivers/MenuDriver.java ! src/org/netbeans/jemmy/drivers/MouseDriver.java ! src/org/netbeans/jemmy/drivers/MultiSelListDriver.java ! src/org/netbeans/jemmy/drivers/OrderedListDriver.java ! src/org/netbeans/jemmy/drivers/PathChooser.java ! src/org/netbeans/jemmy/drivers/ScrollDriver.java ! src/org/netbeans/jemmy/drivers/SupportiveDriver.java ! src/org/netbeans/jemmy/drivers/TableDriver.java ! src/org/netbeans/jemmy/drivers/TextDriver.java ! src/org/netbeans/jemmy/drivers/TreeDriver.java ! src/org/netbeans/jemmy/drivers/UnsupportedOperatorException.java ! src/org/netbeans/jemmy/drivers/WindowDriver.java ! src/org/netbeans/jemmy/drivers/buttons/ButtonMouseDriver.java ! src/org/netbeans/jemmy/drivers/buttons/package-info.java ! src/org/netbeans/jemmy/drivers/focus/APIFocusDriver.java ! src/org/netbeans/jemmy/drivers/focus/MouseFocusDriver.java ! src/org/netbeans/jemmy/drivers/focus/package-info.java ! src/org/netbeans/jemmy/drivers/input/EventDriver.java ! src/org/netbeans/jemmy/drivers/input/KeyEventDriver.java ! src/org/netbeans/jemmy/drivers/input/KeyRobotDriver.java ! src/org/netbeans/jemmy/drivers/input/MouseEventDriver.java ! src/org/netbeans/jemmy/drivers/input/MouseRobotDriver.java ! src/org/netbeans/jemmy/drivers/input/RobotDriver.java ! src/org/netbeans/jemmy/drivers/input/package-info.java ! src/org/netbeans/jemmy/drivers/lists/ChoiceDriver.java ! src/org/netbeans/jemmy/drivers/lists/JComboMouseDriver.java ! src/org/netbeans/jemmy/drivers/lists/JListMouseDriver.java ! src/org/netbeans/jemmy/drivers/lists/JTabAPIDriver.java ! src/org/netbeans/jemmy/drivers/lists/JTabMouseDriver.java ! src/org/netbeans/jemmy/drivers/lists/JTableHeaderDriver.java ! src/org/netbeans/jemmy/drivers/lists/ListAPIDriver.java ! src/org/netbeans/jemmy/drivers/lists/ListKeyboardDriver.java ! src/org/netbeans/jemmy/drivers/lists/package-info.java ! src/org/netbeans/jemmy/drivers/menus/APIJMenuDriver.java ! src/org/netbeans/jemmy/drivers/menus/AppleMenuDriver.java ! src/org/netbeans/jemmy/drivers/menus/DefaultJMenuDriver.java ! src/org/netbeans/jemmy/drivers/menus/QueueJMenuDriver.java ! src/org/netbeans/jemmy/drivers/menus/package-info.java ! src/org/netbeans/jemmy/drivers/package-info.java ! src/org/netbeans/jemmy/drivers/scrolling/AWTScrollDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/AbstractScrollDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/JScrollBarAPIDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/JScrollBarDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/JSliderAPIDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/JSliderDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/JSpinnerDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/JSplitPaneDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/KeyboardJSliderScrollDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/ScrollAdjuster.java ! src/org/netbeans/jemmy/drivers/scrolling/ScrollPaneDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/ScrollbarDriver.java ! src/org/netbeans/jemmy/drivers/scrolling/package-info.java ! src/org/netbeans/jemmy/drivers/tables/JTableMouseDriver.java ! src/org/netbeans/jemmy/drivers/tables/package-info.java ! src/org/netbeans/jemmy/drivers/text/AWTTextAPIDriver.java ! src/org/netbeans/jemmy/drivers/text/AWTTextKeyboardDriver.java ! src/org/netbeans/jemmy/drivers/text/DownKey.java ! src/org/netbeans/jemmy/drivers/text/EndKey.java ! src/org/netbeans/jemmy/drivers/text/GoAndBackKey.java ! src/org/netbeans/jemmy/drivers/text/HomeKey.java ! src/org/netbeans/jemmy/drivers/text/NavigationKey.java ! src/org/netbeans/jemmy/drivers/text/OffsetKey.java ! src/org/netbeans/jemmy/drivers/text/SwingTextAPIDriver.java ! src/org/netbeans/jemmy/drivers/text/SwingTextKeyboardDriver.java ! src/org/netbeans/jemmy/drivers/text/TextAPIDriver.java ! src/org/netbeans/jemmy/drivers/text/TextKeyboardDriver.java ! src/org/netbeans/jemmy/drivers/text/UpKey.java ! src/org/netbeans/jemmy/drivers/text/package-info.java ! src/org/netbeans/jemmy/drivers/trees/JTreeAPIDriver.java ! src/org/netbeans/jemmy/drivers/trees/JTreeMouseDriver.java ! src/org/netbeans/jemmy/drivers/trees/package-info.java ! src/org/netbeans/jemmy/drivers/windows/DefaultFrameDriver.java ! src/org/netbeans/jemmy/drivers/windows/DefaultInternalFrameDriver.java ! src/org/netbeans/jemmy/drivers/windows/DefaultWindowDriver.java ! src/org/netbeans/jemmy/drivers/windows/package-info.java ! src/org/netbeans/jemmy/explorer/GUIBrowser.java ! src/org/netbeans/jemmy/explorer/TrialListenerManager.java ! src/org/netbeans/jemmy/explorer/package-info.java ! src/org/netbeans/jemmy/image/ColorImageComparator.java ! src/org/netbeans/jemmy/image/FileImageComparator.java ! src/org/netbeans/jemmy/image/ImageComparator.java ! src/org/netbeans/jemmy/image/ImageFinder.java ! src/org/netbeans/jemmy/image/ImageLoader.java ! src/org/netbeans/jemmy/image/ImageSaver.java ! src/org/netbeans/jemmy/image/ImageTool.java ! src/org/netbeans/jemmy/image/PNGImageLoader.java ! src/org/netbeans/jemmy/image/PNGImageSaver.java ! src/org/netbeans/jemmy/image/RoughImageComparator.java ! src/org/netbeans/jemmy/image/RoughImageFinder.java ! src/org/netbeans/jemmy/image/StrictImageComparator.java ! src/org/netbeans/jemmy/image/StrictImageFinder.java ! src/org/netbeans/jemmy/image/package-info.java ! src/org/netbeans/jemmy/operators/AbstractButtonOperator.java ! src/org/netbeans/jemmy/operators/ButtonOperator.java ! src/org/netbeans/jemmy/operators/CheckboxOperator.java ! src/org/netbeans/jemmy/operators/ChoiceOperator.java ! src/org/netbeans/jemmy/operators/ComponentOperator.java ! src/org/netbeans/jemmy/operators/ContainerOperator.java ! src/org/netbeans/jemmy/operators/DialogOperator.java ! src/org/netbeans/jemmy/operators/FrameOperator.java ! src/org/netbeans/jemmy/operators/JButtonOperator.java ! src/org/netbeans/jemmy/operators/JCheckBoxMenuItemOperator.java ! src/org/netbeans/jemmy/operators/JCheckBoxOperator.java ! src/org/netbeans/jemmy/operators/JColorChooserOperator.java ! src/org/netbeans/jemmy/operators/JComboBoxOperator.java ! src/org/netbeans/jemmy/operators/JComponentOperator.java ! src/org/netbeans/jemmy/operators/JDialogOperator.java ! src/org/netbeans/jemmy/operators/JEditorPaneOperator.java ! src/org/netbeans/jemmy/operators/JFileChooserOperator.java ! src/org/netbeans/jemmy/operators/JFrameOperator.java ! src/org/netbeans/jemmy/operators/JInternalFrameOperator.java ! src/org/netbeans/jemmy/operators/JLabelOperator.java ! src/org/netbeans/jemmy/operators/JListOperator.java ! src/org/netbeans/jemmy/operators/JMenuBarOperator.java ! src/org/netbeans/jemmy/operators/JMenuItemOperator.java ! src/org/netbeans/jemmy/operators/JMenuOperator.java ! src/org/netbeans/jemmy/operators/JPasswordFieldOperator.java ! src/org/netbeans/jemmy/operators/JPopupMenuOperator.java ! src/org/netbeans/jemmy/operators/JProgressBarOperator.java ! src/org/netbeans/jemmy/operators/JRadioButtonMenuItemOperator.java ! src/org/netbeans/jemmy/operators/JRadioButtonOperator.java ! src/org/netbeans/jemmy/operators/JScrollBarOperator.java ! src/org/netbeans/jemmy/operators/JScrollPaneOperator.java ! src/org/netbeans/jemmy/operators/JSliderOperator.java ! src/org/netbeans/jemmy/operators/JSpinnerOperator.java ! src/org/netbeans/jemmy/operators/JSplitPaneOperator.java ! src/org/netbeans/jemmy/operators/JTabbedPaneOperator.java ! src/org/netbeans/jemmy/operators/JTableHeaderOperator.java ! src/org/netbeans/jemmy/operators/JTableOperator.java ! src/org/netbeans/jemmy/operators/JTextAreaOperator.java ! src/org/netbeans/jemmy/operators/JTextComponentOperator.java ! src/org/netbeans/jemmy/operators/JTextFieldOperator.java ! src/org/netbeans/jemmy/operators/JTextPaneOperator.java ! src/org/netbeans/jemmy/operators/JToggleButtonOperator.java ! src/org/netbeans/jemmy/operators/JTreeOperator.java ! src/org/netbeans/jemmy/operators/LabelOperator.java ! src/org/netbeans/jemmy/operators/ListOperator.java ! src/org/netbeans/jemmy/operators/Operator.java ! src/org/netbeans/jemmy/operators/ScrollPaneOperator.java ! src/org/netbeans/jemmy/operators/ScrollbarOperator.java ! src/org/netbeans/jemmy/operators/TextAreaOperator.java ! src/org/netbeans/jemmy/operators/TextComponentOperator.java ! src/org/netbeans/jemmy/operators/TextFieldOperator.java ! src/org/netbeans/jemmy/operators/WindowOperator.java ! src/org/netbeans/jemmy/operators/package-info.java ! src/org/netbeans/jemmy/package-info.java ! src/org/netbeans/jemmy/util/AbstractTextStyleChooser.java ! src/org/netbeans/jemmy/util/DefaultVisualizer.java ! src/org/netbeans/jemmy/util/DumpController.java ! src/org/netbeans/jemmy/util/Dumper.java ! src/org/netbeans/jemmy/util/EmptyVisualizer.java ! src/org/netbeans/jemmy/util/MouseVisualizer.java ! src/org/netbeans/jemmy/util/NameComponentChooser.java ! src/org/netbeans/jemmy/util/PNGDecoder.java ! src/org/netbeans/jemmy/util/PNGEncoder.java ! src/org/netbeans/jemmy/util/PropChooser.java ! src/org/netbeans/jemmy/util/RegExComparator.java ! src/org/netbeans/jemmy/util/StringPropChooser.java ! src/org/netbeans/jemmy/util/TextStyleChooser.java ! src/org/netbeans/jemmy/util/WindowJob.java ! src/org/netbeans/jemmy/util/WindowManager.java ! src/org/netbeans/jemmy/util/package-info.java ! test/org/netbeans/jemmy/operators/ComponentChooserTest.java ! test/org/netbeans/jemmy/operators/FileChooserApp.java ! test/org/netbeans/jemmy/operators/FileChooserTest.java ! test/org/netbeans/jemmy/operators/JInternalFrameOperatorCloseTest.java ! test/org/netbeans/jemmy/operators/JInternalFrameOperatorTest.java ! test/org/netbeans/jemmy/operators/OperatorTest.java ! test/org/netbeans/jemmy/scenario/ButtonsAndTooltipsApp.java ! test/org/netbeans/jemmy/scenario/ButtonsAndTooltipsTest.java ! test/org/netbeans/jemmy/scenario/ComboBoxesAndListApp.java ! test/org/netbeans/jemmy/scenario/ComboBoxesAndListTest.java ! test/org/netbeans/jemmy/scenario/MenuButtonTextApp.java ! test/org/netbeans/jemmy/scenario/MenuButtonTextTest.java ! test/org/netbeans/jemmy/scenario/TestDialog.java ! test/org/netbeans/jemmy/scenario/TestFrame.java ! test/org/netbeans/jemmy/scenario/Util.java ! test/org/netbeans/jemmy/stress/TimeoutsGetSetTest.java From patrick at reini.net Thu May 10 06:39:56 2018 From: patrick at reini.net (Patrick Reinhart) Date: Thu, 10 May 2018 08:39:56 +0200 Subject: RFR: Prepare jemmy for adoptopenjdk build and deploy In-Reply-To: <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com> References: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> <9F400238-53A8-4070-AB03-F23C53DD5B39@oracle.com> <10C95F52-F210-460C-A5C6-CA7A75700BBE@oracle.com> <1F871D5A-423D-4596-B7DF-EC2C93CB8FF3@oracle.com> <66190ed4-51b0-7d20-dee2-d48134a37345@reini.net> <08CE244D-0BE4-445B-96BC-4DD8E6C83E46@oracle.com> <83920EA5-875E-4030-801B-A5B809756B33@oracle.com> <3A4EA1E2-C398-47D6-A66F-06FE11FE7D1E@reini.net> <53283939-9809-4F77-AAC4-B1511615C8E8@oracle.com> <946107b29bce83841b192be0efa0a7df@reini.net> <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com> Message-ID: Hi everybody, I updated all remaining jemmy.properties files to the version 1.0.0 in order to be in sync with the pom.xml files. I therefore propose to review the made changes and push those to a to be created JBS issue http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev -Patrick Am 09.05.2018 um 15:13 schrieb Erik Greijus: > Sorry, > I misremebered the file name. > > The file I was referring to is jemmy.properties (which is present in each of the projects - SWT/JemmySWT/src/org/jemmy/swt/jemmy.properties for the SWT project). > Apart from the Core project (which is already at 1.0.0) these should be updated in the the other three projects. > > Regards > /Erik > >> 9 maj 2018 kl. 14:51 skrev Patrick Reinhart : >> >> Hi Erik, >> >> I did not understand what you mean. Do by the "version.properties" in each project. I did not see any such file in the project directory. Did I get something wrong here? >> >> The versions within the pom.xml files I already changed from their original value "1.0" to "1.0.0" to more align with the maven central version schema. >> >> For the complete list of current changes see the updated webrev: >> >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev >> >> -Patrick >> >> >> On 2018-05-09 09:45, Erik Greijus wrote: >>> Patrick, >>> There's currently a discrepancy between the "version.properties" in >>> each project and the corresponding pom.xml. I missed that in the >>> initial Maven commit but now would be a good time to update the >>> property files to all be at 1.0.0. >>> Regards >>> /Erik From alexandre.iline at oracle.com Thu May 10 15:23:11 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Thu, 10 May 2018 08:23:11 -0700 Subject: RFR: Prepare jemmy for adoptopenjdk build and deploy In-Reply-To: References: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> <9F400238-53A8-4070-AB03-F23C53DD5B39@oracle.com> <10C95F52-F210-460C-A5C6-CA7A75700BBE@oracle.com> <1F871D5A-423D-4596-B7DF-EC2C93CB8FF3@oracle.com> <66190ed4-51b0-7d20-dee2-d48134a37345@reini.net> <08CE244D-0BE4-445B-96BC-4DD8E6C83E46@oracle.com> <83920EA5-875E-4030-801B-A5B809756B33@oracle.com> <3A4EA1E2-C398-47D6-A66F-06FE11FE7D1E@reini.net> <53283939-9809-4F77-AAC4-B1511615C8E8@oracle.com> <946107b29bce83841b192be0efa0a7df@reini.net> <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com> Message-ID: <31EFDD24-328C-4C9E-AE82-E0BDE0753E28@oracle.com> Patrick, It is definitely not common to use @author tag in openjdk. Is that required for Maven? The patch also seem to be updating some javadoc (core/JemmyCore/src/org/jemmy/input/CharBindingMap.java), which is a very useful thing to do, only I am now wondering what else this patch is changing. Could you quickly summarize? I am sorry if you did this before and I missed it. Shura ) > On May 9, 2018, at 11:39 PM, Patrick Reinhart wrote: > > Hi everybody, > > I updated all remaining jemmy.properties files to the version 1.0.0 in > order to be in sync with the pom.xml files. I therefore propose to > review the made changes and push those to a to be created JBS issue > > http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev > > > -Patrick > > > > Am 09.05.2018 um 15:13 schrieb Erik Greijus: >> Sorry, >> I misremebered the file name. >> >> The file I was referring to is jemmy.properties (which is present in each of the projects - SWT/JemmySWT/src/org/jemmy/swt/jemmy.properties for the SWT project). >> Apart from the Core project (which is already at 1.0.0) these should be updated in the the other three projects. >> >> Regards >> /Erik >> >>> 9 maj 2018 kl. 14:51 skrev Patrick Reinhart : >>> >>> Hi Erik, >>> >>> I did not understand what you mean. Do by the "version.properties" in each project. I did not see any such file in the project directory. Did I get something wrong here? >>> >>> The versions within the pom.xml files I already changed from their original value "1.0" to "1.0.0" to more align with the maven central version schema. >>> >>> For the complete list of current changes see the updated webrev: >>> >>> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev >>> >>> -Patrick >>> >>> >>> On 2018-05-09 09:45, Erik Greijus wrote: >>>> Patrick, >>>> There's currently a discrepancy between the "version.properties" in >>>> each project and the corresponding pom.xml. I missed that in the >>>> initial Maven commit but now would be a good time to update the >>>> property files to all be at 1.0.0. >>>> Regards >>>> /Erik > > > From patrick at reini.net Thu May 10 16:38:24 2018 From: patrick at reini.net (Patrick Reinhart) Date: Thu, 10 May 2018 18:38:24 +0200 Subject: RFR: Prepare jemmy for adoptopenjdk build and deploy In-Reply-To: <31EFDD24-328C-4C9E-AE82-E0BDE0753E28@oracle.com> References: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> <9F400238-53A8-4070-AB03-F23C53DD5B39@oracle.com> <10C95F52-F210-460C-A5C6-CA7A75700BBE@oracle.com> <1F871D5A-423D-4596-B7DF-EC2C93CB8FF3@oracle.com> <66190ed4-51b0-7d20-dee2-d48134a37345@reini.net> <08CE244D-0BE4-445B-96BC-4DD8E6C83E46@oracle.com> <83920EA5-875E-4030-801B-A5B809756B33@oracle.com> <3A4EA1E2-C398-47D6-A66F-06FE11FE7D1E@reini.net> <53283939-9809-4F77-AAC4-B1511615C8E8@oracle.com> <946107b29bce83841b192be0efa0a7df@reini.net> <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com> <31EFDD24-328C-4C9E-AE82-E0BDE0753E28@oracle.com> Message-ID: <34B1F7C6-E958-4DC7-9489-BDC82231EFF8@reini.net> Hi Shura, There is no requirement to have @author tags in the source code. I only removed the email addresss and those characters failing to pass the Javadoc generation. For the rest of the code the main changes contain removal of Javadoc parts, that did only contained @param/@return tags with no futher content. When I started together with Marcus, we tried to complete the incomplete @param values. If there where Jacadoc comments with partial content, I added ?todo javadoc? to those @param/@return tags that where missing or where only partiallly available. The intention was to may going over it later and fill those missing parts in. Apart from this there where no code changes done exept using some diamond operators instead of the extended generics definition. Also the main changes where done within the root pom.xml file adding the licence/scm and authors section in order to pass the maven central requirements. Hope the answered your questions so far. -Patrick > Am 10.05.2018 um 17:23 schrieb Alexandre (Shura) Iline : > > Patrick, > > It is definitely not common to use @author tag in openjdk. Is that required for Maven? > > The patch also seem to be updating some javadoc (core/JemmyCore/src/org/jemmy/input/CharBindingMap.java), which is a very useful thing to do, only I am now wondering what else this patch is changing. > > Could you quickly summarize? > > I am sorry if you did this before and I missed it. > > Shura > > ) >> On May 9, 2018, at 11:39 PM, Patrick Reinhart wrote: >> >> Hi everybody, >> >> I updated all remaining jemmy.properties files to the version 1.0.0 in >> order to be in sync with the pom.xml files. I therefore propose to >> review the made changes and push those to a to be created JBS issue >> >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev >> >> >> -Patrick >> >> >> >>> Am 09.05.2018 um 15:13 schrieb Erik Greijus: >>> Sorry, >>> I misremebered the file name. >>> >>> The file I was referring to is jemmy.properties (which is present in each of the projects - SWT/JemmySWT/src/org/jemmy/swt/jemmy.properties for the SWT project). >>> Apart from the Core project (which is already at 1.0.0) these should be updated in the the other three projects. >>> >>> Regards >>> /Erik >>> >>>> 9 maj 2018 kl. 14:51 skrev Patrick Reinhart : >>>> >>>> Hi Erik, >>>> >>>> I did not understand what you mean. Do by the "version.properties" in each project. I did not see any such file in the project directory. Did I get something wrong here? >>>> >>>> The versions within the pom.xml files I already changed from their original value "1.0" to "1.0.0" to more align with the maven central version schema. >>>> >>>> For the complete list of current changes see the updated webrev: >>>> >>>> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev >>>> >>>> -Patrick >>>> >>>> >>>>> On 2018-05-09 09:45, Erik Greijus wrote: >>>>> Patrick, >>>>> There's currently a discrepancy between the "version.properties" in >>>>> each project and the corresponding pom.xml. I missed that in the >>>>> initial Maven commit but now would be a good time to update the >>>>> property files to all be at 1.0.0. >>>>> Regards >>>>> /Erik >> >> >> > From patrick at reini.net Wed May 16 19:14:54 2018 From: patrick at reini.net (Patrick Reinhart) Date: Wed, 16 May 2018 21:14:54 +0200 Subject: RFR: Prepare jemmy for adoptopenjdk build and deploy In-Reply-To: <34B1F7C6-E958-4DC7-9489-BDC82231EFF8@reini.net> References: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> <9F400238-53A8-4070-AB03-F23C53DD5B39@oracle.com> <10C95F52-F210-460C-A5C6-CA7A75700BBE@oracle.com> <1F871D5A-423D-4596-B7DF-EC2C93CB8FF3@oracle.com> <66190ed4-51b0-7d20-dee2-d48134a37345@reini.net> <08CE244D-0BE4-445B-96BC-4DD8E6C83E46@oracle.com> <83920EA5-875E-4030-801B-A5B809756B33@oracle.com> <3A4EA1E2-C398-47D6-A66F-06FE11FE7D1E@reini.net> <53283939-9809-4F77-AAC4-B1511615C8E8@oracle.com> <946107b29bce83841b192be0efa0a7df@reini.net> <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com> <31EFDD24-328C-4C9E-AE82-E0BDE0753E28@oracle.com> <34B1F7C6-E958-4DC7-9489-BDC82231EFF8@reini.net> Message-ID: <7a0bb3d6-76c4-c5b4-3044-1b3e1e3a42ef@reini.net> Just wanted to know if there is anything I can do further before that change could be commited? -Patrick Am 10.05.2018 um 18:38 schrieb Patrick Reinhart: > Hi Shura, > > There is no requirement to have @author tags in the source code. I only removed the email addresss and those characters failing to pass the Javadoc generation. > > For the rest of the code the main changes contain removal of Javadoc parts, that did only contained @param/@return tags with no futher content. > > When I started together with Marcus, we tried to complete the incomplete @param values. If there where Jacadoc comments with partial content, I added ?todo javadoc? to those @param/@return tags that where missing or where only partiallly available. The intention was to may going over it later and fill those missing parts in. Apart from this there where no code changes done exept using some diamond operators instead of the extended generics definition. Also the main changes where done within the root pom.xml file adding the licence/scm and authors section in order to pass the maven central requirements. > > Hope the answered your questions so far. > > -Patrick > > >> Am 10.05.2018 um 17:23 schrieb Alexandre (Shura) Iline : >> >> Patrick, >> >> It is definitely not common to use @author tag in openjdk. Is that required for Maven? >> >> The patch also seem to be updating some javadoc (core/JemmyCore/src/org/jemmy/input/CharBindingMap.java), which is a very useful thing to do, only I am now wondering what else this patch is changing. >> >> Could you quickly summarize? >> >> I am sorry if you did this before and I missed it. >> >> Shura >> From alexandre.iline at oracle.com Thu May 17 02:08:15 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Wed, 16 May 2018 19:08:15 -0700 Subject: RFR: Prepare jemmy for adoptopenjdk build and deploy In-Reply-To: <34B1F7C6-E958-4DC7-9489-BDC82231EFF8@reini.net> References: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> <9F400238-53A8-4070-AB03-F23C53DD5B39@oracle.com> <10C95F52-F210-460C-A5C6-CA7A75700BBE@oracle.com> <1F871D5A-423D-4596-B7DF-EC2C93CB8FF3@oracle.com> <66190ed4-51b0-7d20-dee2-d48134a37345@reini.net> <08CE244D-0BE4-445B-96BC-4DD8E6C83E46@oracle.com> <83920EA5-875E-4030-801B-A5B809756B33@oracle.com> <3A4EA1E2-C398-47D6-A66F-06FE11FE7D1E@reini.net> <53283939-9809-4F77-AAC4-B1511615C8E8@oracle.com> <946107b29bce83841b192be0efa0a7df@reini.net> <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com! > <31EFDD24-328C-4C9E-AE82-E0BDE0753E28@oracle.com> <34B1F7C6-E958-4DC7-9489-BDC82231EFF8@reini.net> Message-ID: <38D97DDE-08C8-4592-A681-79B555745909@oracle.com> > On May 10, 2018, at 9:38 AM, Patrick Reinhart wrote: > > Hi Shura, > > There is no requirement to have @author tags in the source code. I only removed the email addresss and those characters failing to pass the Javadoc generation. On the @author tag, I find some of the changes inconsistent: http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemLookup.java.sdiff.html http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/RoughImageComparator.java.sdiff.html http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/StrictImageComparator.java.sdiff.html Alexandre Iline is also me: shura > For the rest of the code the main changes contain removal of Javadoc parts, that did only contained @param/@return tags with no futher content. > A Javadoc cleanup, been very useful, should probably come with a separate bug, unless the changes are required for the maven work. Shura > When I started together with Marcus, we tried to complete the incomplete @param values. If there where Jacadoc comments with partial content, I added ?todo javadoc? to those @param/@return tags that where missing or where only partiallly available. The intention was to may going over it later and fill those missing parts in. Apart from this there where no code changes done exept using some diamond operators instead of the extended generics definition. Also the main changes where done within the root pom.xml file adding the licence/scm and authors section in order to pass the maven central requirements. > > Hope the answered your questions so far. > > -Patrick > > >> Am 10.05.2018 um 17:23 schrieb Alexandre (Shura) Iline : >> >> Patrick, >> >> It is definitely not common to use @author tag in openjdk. Is that required for Maven? >> >> The patch also seem to be updating some javadoc (core/JemmyCore/src/org/jemmy/input/CharBindingMap.java), which is a very useful thing to do, only I am now wondering what else this patch is changing. >> >> Could you quickly summarize? >> >> I am sorry if you did this before and I missed it. >> >> Shura >> >> ) >>> On May 9, 2018, at 11:39 PM, Patrick Reinhart wrote: >>> >>> Hi everybody, >>> >>> I updated all remaining jemmy.properties files to the version 1.0.0 in >>> order to be in sync with the pom.xml files. I therefore propose to >>> review the made changes and push those to a to be created JBS issue >>> >>> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev >>> >>> >>> -Patrick >>> >>> >>> >>>> Am 09.05.2018 um 15:13 schrieb Erik Greijus: >>>> Sorry, >>>> I misremebered the file name. >>>> >>>> The file I was referring to is jemmy.properties (which is present in each of the projects - SWT/JemmySWT/src/org/jemmy/swt/jemmy.properties for the SWT project). >>>> Apart from the Core project (which is already at 1.0.0) these should be updated in the the other three projects. >>>> >>>> Regards >>>> /Erik >>>> >>>>> 9 maj 2018 kl. 14:51 skrev Patrick Reinhart : >>>>> >>>>> Hi Erik, >>>>> >>>>> I did not understand what you mean. Do by the "version.properties" in each project. I did not see any such file in the project directory. Did I get something wrong here? >>>>> >>>>> The versions within the pom.xml files I already changed from their original value "1.0" to "1.0.0" to more align with the maven central version schema. >>>>> >>>>> For the complete list of current changes see the updated webrev: >>>>> >>>>> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev >>>>> >>>>> -Patrick >>>>> >>>>> >>>>>> On 2018-05-09 09:45, Erik Greijus wrote: >>>>>> Patrick, >>>>>> There's currently a discrepancy between the "version.properties" in >>>>>> each project and the corresponding pom.xml. I missed that in the >>>>>> initial Maven commit but now would be a good time to update the >>>>>> property files to all be at 1.0.0. >>>>>> Regards >>>>>> /Erik >>> >>> >>> >> > From patrick at reini.net Thu May 17 20:15:06 2018 From: patrick at reini.net (Patrick Reinhart) Date: Thu, 17 May 2018 22:15:06 +0200 Subject: RFR: Prepare jemmy for adoptopenjdk build and deploy In-Reply-To: <38D97DDE-08C8-4592-A681-79B555745909@oracle.com> References: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> <9F400238-53A8-4070-AB03-F23C53DD5B39@oracle.com> <10C95F52-F210-460C-A5C6-CA7A75700BBE@oracle.com> <1F871D5A-423D-4596-B7DF-EC2C93CB8FF3@oracle.com> <66190ed4-51b0-7d20-dee2-d48134a37345@reini.net> <08CE244D-0BE4-445B-96BC-4DD8E6C83E46@oracle.com> <83920EA5-875E-4030-801B-A5B809756B33@oracle.com> <3A4EA1E2-C398-47D6-A66F-06FE11FE7D1E@reini.net> <53283939-9809-4F77-AAC4-B1511615C8E8@oracle.com> <946107b29bce83841b192be0efa0a7df@reini.net> <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com! > <31EFDD24-328C-4C9E-AE82-E0BDE0753E28@oracle.com> <34B1F7C6-E958-4DC7-9489-BDC82231EFF8@reini.net> <38D97DDE-08C8-4592-A681-79B555745909@oracle.com> Message-ID: <11196558-FE0E-4DDB-B101-18CCAC7236F2@reini.net> Hi Shura, > Am 17.05.2018 um 04:08 schrieb Alexandre (Shura) Iline : > > > >> On May 10, 2018, at 9:38 AM, Patrick Reinhart wrote: >> >> Hi Shura, >> >> There is no requirement to have @author tags in the source code. I only removed the email addresss and those characters failing to pass the Javadoc generation. > > > On the @author tag, I find some of the changes inconsistent: > http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemLookup.java.sdiff.html > http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/RoughImageComparator.java.sdiff.html > http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/StrictImageComparator.java.sdiff.html > > Alexandre Iline is also me: shura Changed those accordingly? > > >> For the rest of the code the main changes contain removal of Javadoc parts, that did only contained @param/@return tags with no futher content. >> > > A Javadoc cleanup, been very useful, should probably come with a separate bug, unless the changes are required for the maven work. I know, that it would be do those in a separate bug, but exactly those changes where needed in order to meet the requirements in order to push a artifact to maven central? The updated webrev contains the latest changes: http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev -Patrick > > Shura > >> When I started together with Marcus, we tried to complete the incomplete @param values. If there where Jacadoc comments with partial content, I added ?todo javadoc? to those @param/@return tags that where missing or where only partiallly available. The intention was to may going over it later and fill those missing parts in. Apart from this there where no code changes done exept using some diamond operators instead of the extended generics definition. Also the main changes where done within the root pom.xml file adding the licence/scm and authors section in order to pass the maven central requirements. >> >> Hope the answered your questions so far. >> >> -Patrick >> From alexandre.iline at oracle.com Sun May 20 08:38:44 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Sun, 20 May 2018 01:38:44 -0700 Subject: RFR: Prepare jemmy for adoptopenjdk build and deploy In-Reply-To: <11196558-FE0E-4DDB-B101-18CCAC7236F2@reini.net> References: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> <9F400238-53A8-4070-AB03-F23C53DD5B39@oracle.com> <10C95F52-F210-460C-A5C6-CA7A75700BBE@oracle.com> <1F871D5A-423D-4596-B7DF-EC2C93CB8FF3@oracle.com> <66190ed4-51b0-7d20-dee2-d48134a37345@reini.net> <08CE244D-0BE4-445B-96BC-4DD8E6C83E46@oracle.com> <83920EA5-875E-4030-801B-A5B809756B33@oracle.com> <3A4EA1E2-C398-47D6-A66F-06FE11FE7D1E@reini.net> <53283939-9809-4F77-AAC4-B1511615C8E8@oracle.com> <946107b29bce83841b192be0efa0a7df@reini.net> <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com! > <31EFDD24-328C-4C9E-AE82-E0BDE0753E28@oracle.com> <34B1F7C6-E958-4DC7-9489-BDC82231EFF8@reini.net> <38D97DDE-08C8-4592-A681-79B555745909@oracle.com> <11196558-FE0E-4DDB-B101-18CCAC7236F2@reini.net> Message-ID: <2C9D9383-8D27-4E8A-AB30-DEB31B7AB06A@oracle.com> Ok, makes sense. Thank you > On May 17, 2018, at 1:15 PM, Patrick Reinhart wrote: > > Hi Shura, > > >> Am 17.05.2018 um 04:08 schrieb Alexandre (Shura) Iline : >> >> >> >>> On May 10, 2018, at 9:38 AM, Patrick Reinhart wrote: >>> >>> Hi Shura, >>> >>> There is no requirement to have @author tags in the source code. I only removed the email addresss and those characters failing to pass the Javadoc generation. >> >> >> On the @author tag, I find some of the changes inconsistent: >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemLookup.java.sdiff.html >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/RoughImageComparator.java.sdiff.html >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/StrictImageComparator.java.sdiff.html >> >> Alexandre Iline is also me: shura > > Changed those accordingly? > >> >> >>> For the rest of the code the main changes contain removal of Javadoc parts, that did only contained @param/@return tags with no futher content. >>> >> >> A Javadoc cleanup, been very useful, should probably come with a separate bug, unless the changes are required for the maven work. > > I know, that it would be do those in a separate bug, but exactly those changes where needed in order to meet the requirements in order to push a artifact to maven central? > > The updated webrev contains the latest changes: > > http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev > > -Patrick > > >> >> Shura >> >>> When I started together with Marcus, we tried to complete the incomplete @param values. If there where Jacadoc comments with partial content, I added ?todo javadoc? to those @param/@return tags that where missing or where only partiallly available. The intention was to may going over it later and fill those missing parts in. Apart from this there where no code changes done exept using some diamond operators instead of the extended generics definition. Also the main changes where done within the root pom.xml file adding the licence/scm and authors section in order to pass the maven central requirements. >>> >>> Hope the answered your questions so far. >>> >>> -Patrick >>> > From erik.greijus at oracle.com Mon May 21 12:38:19 2018 From: erik.greijus at oracle.com (Erik Greijus) Date: Mon, 21 May 2018 14:38:19 +0200 Subject: RFR: Prepare jemmy for adoptopenjdk build and deploy In-Reply-To: <11196558-FE0E-4DDB-B101-18CCAC7236F2@reini.net> References: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> <9F400238-53A8-4070-AB03-F23C53DD5B39@oracle.com> <10C95F52-F210-460C-A5C6-CA7A75700BBE@oracle.com> <1F871D5A-423D-4596-B7DF-EC2C93CB8FF3@oracle.com> <66190ed4-51b0-7d20-dee2-d48134a37345@reini.net> <08CE244D-0BE4-445B-96BC-4DD8E6C83E46@oracle.com> <83920EA5-875E-4030-801B-A5B809756B33@oracle.com> <3A4EA1E2-C398-47D6-A66F-06FE11FE7D1E@reini.net> <53283939-9809-4F77-AAC4-B1511615C8E8@oracle.com> <946107b29bce83841b192be0efa0a7df@reini.net> <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com! > <31EFDD24-328C-4C9E-AE82-E0BDE0753E28@oracle.com> <34B1F7C6-E958-4DC7-9489-BDC82231EFF8@reini.net> <38D97DDE-08C8-4592-A681-79B555745909@oracle.com> <11196558-FE0E-4DDB-B101-18CCAC7236F2@reini.net> Message-ID: Looks good to me. Regards /Erik > 17 maj 2018 kl. 22:15 skrev Patrick Reinhart : > > Hi Shura, > > >> Am 17.05.2018 um 04:08 schrieb Alexandre (Shura) Iline : >> >> >> >>> On May 10, 2018, at 9:38 AM, Patrick Reinhart wrote: >>> >>> Hi Shura, >>> >>> There is no requirement to have @author tags in the source code. I only removed the email addresss and those characters failing to pass the Javadoc generation. >> >> >> On the @author tag, I find some of the changes inconsistent: >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemLookup.java.sdiff.html >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/RoughImageComparator.java.sdiff.html >> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/StrictImageComparator.java.sdiff.html >> >> Alexandre Iline is also me: shura > > Changed those accordingly? > >> >> >>> For the rest of the code the main changes contain removal of Javadoc parts, that did only contained @param/@return tags with no futher content. >>> >> >> A Javadoc cleanup, been very useful, should probably come with a separate bug, unless the changes are required for the maven work. > > I know, that it would be do those in a separate bug, but exactly those changes where needed in order to meet the requirements in order to push a artifact to maven central? > > The updated webrev contains the latest changes: > > http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev > > -Patrick > > >> >> Shura >> >>> When I started together with Marcus, we tried to complete the incomplete @param values. If there where Jacadoc comments with partial content, I added ?todo javadoc? to those @param/@return tags that where missing or where only partiallly available. The intention was to may going over it later and fill those missing parts in. Apart from this there where no code changes done exept using some diamond operators instead of the extended generics definition. Also the main changes where done within the root pom.xml file adding the licence/scm and authors section in order to pass the maven central requirements. >>> >>> Hope the answered your questions so far. >>> >>> -Patrick From patrick at reini.net Wed May 23 16:54:04 2018 From: patrick at reini.net (Patrick Reinhart) Date: Wed, 23 May 2018 18:54:04 +0200 Subject: RFR: Prepare jemmy for adoptopenjdk build and deploy In-Reply-To: References: <10C95F52-F210-460C-A5C6-CA7A75700BBE@oracle.com> <1F871D5A-423D-4596-B7DF-EC2C93CB8FF3@oracle.com> <66190ed4-51b0-7d20-dee2-d48134a37345@reini.net> <08CE244D-0BE4-445B-96BC-4DD8E6C83E46@oracle.com> <83920EA5-875E-4030-801B-A5B809756B33@oracle.com> <3A4EA1E2-C398-47D6-A66F-06FE11FE7D1E@reini.net> <53283939-9809-4F77-AAC4-B1511615C8E8@oracle.com> <946107b29bce83841b192be0efa0a7df@reini.net> <9656D4A4-1028-4532-B0C3-50EE0D938F6C@oracle.com! > <31EFDD24-328C-4C9E-AE82-E0BDE0753E28@oracle.com> <34B1F7C6-E958-4DC7-9489-BDC82231EFF8@reini.net> <38D97DDE-08C8-4592-A681-79B555745909@oracle.com> <11196558-FE0E-4DDB-B101-18CCAC7236F2@reini.net> Message-ID: <89396f93-9ea1-f517-5835-6290514ed234@reini.net> Now I just need a commit sponsor :-) -Patrick http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/ Am 21.05.2018 um 14:38 schrieb Erik Greijus: > Looks good to me. > > Regards > /Erik > >> 17 maj 2018 kl. 22:15 skrev Patrick Reinhart > >: >> >> Hi Shura, >> >> >>> Am 17.05.2018 um 04:08 schrieb Alexandre (Shura) Iline >>> >: >>> >>> >>> >>>> On May 10, 2018, at 9:38 AM, Patrick Reinhart >>> > wrote: >>>> >>>> Hi Shura, >>>> >>>> There is no requirement to have @author tags in the source code. I >>>> only removed the email addresss and those characters failing to >>>> pass the Javadoc generation. From alexandre.iline at oracle.com Wed May 30 18:13:45 2018 From: alexandre.iline at oracle.com (alexandre.iline at oracle.com) Date: Wed, 30 May 2018 18:13:45 +0000 Subject: hg: code-tools/jemmy/v3: Prepare jemmy for adoptopenjdk build and deploy Message-ID: <201805301813.w4UIDja6004533@aojmv0008.oracle.com> Changeset: 9a0e4fa35c48 Author: shurailine Date: 2018-05-30 11:13 -0700 URL: http://hg.openjdk.java.net/code-tools/jemmy/v3/rev/9a0e4fa35c48 Prepare jemmy for adoptopenjdk build and deploy Contributed-by: patrick at reini.net Reviewed-by: shurailine + .hgignore ! SWT/JemmySWT/pom.xml ! SWT/JemmySWT/src/org/jemmy/swt/CTabFolderWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ComboWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/CompositeWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ControlWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ItemWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ScrollableWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/TabFolderWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/TextWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/ToolBarWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/TreeWrap.java ! SWT/JemmySWT/src/org/jemmy/swt/Version.java ! SWT/JemmySWT/src/org/jemmy/swt/jemmy.properties ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemStringsLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemToolTipLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByStringQueueLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByTextControlLookup.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/ByToolTipItem.java ! SWT/JemmySWT/src/org/jemmy/swt/lookup/CoordinateLookup.java ! core/JemmyAWTInput/pom.xml ! core/JemmyAWTInput/src/org/jemmy/image/AWTImage.java ! core/JemmyAWTInput/src/org/jemmy/image/AverageDistanceImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/ClasspathImageLoader.java ! core/JemmyAWTInput/src/org/jemmy/image/NaturalImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/PNGDecoder.java ! core/JemmyAWTInput/src/org/jemmy/image/PNGEncoder.java ! core/JemmyAWTInput/src/org/jemmy/image/ResizeImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/RoughImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/RoughImageFinder.java ! core/JemmyAWTInput/src/org/jemmy/image/StrictImageComparator.java ! core/JemmyAWTInput/src/org/jemmy/image/Utils.java ! core/JemmyAWTInput/src/org/jemmy/input/AWTMap.java ! core/JemmyAWTInput/src/org/jemmy/input/ClassReference.java ! core/JemmyAWTInput/src/org/jemmy/input/DragImpl.java ! core/JemmyAWTInput/src/org/jemmy/input/KeyboardImpl.java ! core/JemmyAWTInput/src/org/jemmy/input/MouseImpl.java ! core/JemmyAWTInput/src/org/jemmy/input/RobotDriver.java ! core/JemmyAWTInput/src/org/jemmy/input/Version.java ! core/JemmyAWTInput/src/org/jemmy/input/jemmy.properties ! core/JemmyAWTInput/src/org/jemmy/operators/AWTScreen.java ! core/JemmyBrowser/pom.xml ! core/JemmyBrowser/src/org/jemmy/browser/SearchDialog.java ! core/JemmyBrowser/src/org/jemmy/browser/jemmy.properties ! core/JemmyCore/pom.xml ! core/JemmyCore/src/org/jemmy/Dimension.java ! core/JemmyCore/src/org/jemmy/Point.java ! core/JemmyCore/src/org/jemmy/Rectangle.java ! core/JemmyCore/src/org/jemmy/Vector.java ! core/JemmyCore/src/org/jemmy/Version.java ! core/JemmyCore/src/org/jemmy/action/AbstractExecutor.java ! core/JemmyCore/src/org/jemmy/action/Action.java ! core/JemmyCore/src/org/jemmy/action/ActionExecutor.java ! core/JemmyCore/src/org/jemmy/action/GetAction.java ! core/JemmyCore/src/org/jemmy/control/AbstractWrapper.java ! core/JemmyCore/src/org/jemmy/control/As.java ! core/JemmyCore/src/org/jemmy/control/ControlInterfaces.java ! core/JemmyCore/src/org/jemmy/control/ControlType.java ! core/JemmyCore/src/org/jemmy/control/DefaultWrapper.java ! core/JemmyCore/src/org/jemmy/control/FieldProperties.java ! core/JemmyCore/src/org/jemmy/control/LazyWrapper.java ! core/JemmyCore/src/org/jemmy/control/MethodProperties.java ! core/JemmyCore/src/org/jemmy/control/Property.java ! core/JemmyCore/src/org/jemmy/control/ScreenArea.java ! core/JemmyCore/src/org/jemmy/control/SelectorImpl.java ! core/JemmyCore/src/org/jemmy/control/Wrap.java ! core/JemmyCore/src/org/jemmy/control/Wrapper.java ! core/JemmyCore/src/org/jemmy/control/WrapperException.java ! core/JemmyCore/src/org/jemmy/control/WrapperImpl.java ! core/JemmyCore/src/org/jemmy/dock/DefaultParent.java ! core/JemmyCore/src/org/jemmy/dock/DefaultWrapper.java ! core/JemmyCore/src/org/jemmy/dock/Dock.java ! core/JemmyCore/src/org/jemmy/dock/DockInfo.java ! core/JemmyCore/src/org/jemmy/dock/ObjectLookup.java ! core/JemmyCore/src/org/jemmy/dock/Shortcut.java ! core/JemmyCore/src/org/jemmy/env/Environment.java ! core/JemmyCore/src/org/jemmy/env/TestOut.java ! core/JemmyCore/src/org/jemmy/env/Timeout.java ! core/JemmyCore/src/org/jemmy/image/Image.java ! core/JemmyCore/src/org/jemmy/image/ImageCapturer.java ! core/JemmyCore/src/org/jemmy/image/ImageComparator.java ! core/JemmyCore/src/org/jemmy/image/ImageLoader.java ! core/JemmyCore/src/org/jemmy/image/pixel/AverageDistanceComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/BaseCountingRasterComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/ColorMappingComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/MaxDistanceComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/PNGLoader.java ! core/JemmyCore/src/org/jemmy/image/pixel/PNGSaver.java ! core/JemmyCore/src/org/jemmy/image/pixel/PixelEqualityRasterComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/PixelImageComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/Raster.java ! core/JemmyCore/src/org/jemmy/image/pixel/RasterComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/ResizeComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/ThresholdComparator.java ! core/JemmyCore/src/org/jemmy/image/pixel/WriteableRaster.java ! core/JemmyCore/src/org/jemmy/input/AbstractCaretOwner.java ! core/JemmyCore/src/org/jemmy/input/CaretImpl.java ! core/JemmyCore/src/org/jemmy/input/CaretText.java ! core/JemmyCore/src/org/jemmy/input/CharBindingMap.java ! core/JemmyCore/src/org/jemmy/input/ClickFocus.java ! core/JemmyCore/src/org/jemmy/input/DefaultCharBindingMap.java ! core/JemmyCore/src/org/jemmy/input/KnobDragScrollerImpl.java ! core/JemmyCore/src/org/jemmy/input/RegexCaretDirection.java ! core/JemmyCore/src/org/jemmy/input/ScrollerImpl.java ! core/JemmyCore/src/org/jemmy/input/SelectionText.java ! core/JemmyCore/src/org/jemmy/input/StringMenuOwner.java ! core/JemmyCore/src/org/jemmy/input/StringMenuSelectableOwner.java ! core/JemmyCore/src/org/jemmy/input/StringPopupSelectableOwner.java ! core/JemmyCore/src/org/jemmy/input/TextCaret.java ! core/JemmyCore/src/org/jemmy/input/TextImpl.java ! core/JemmyCore/src/org/jemmy/input/WindowImpl.java ! core/JemmyCore/src/org/jemmy/interfaces/Caret.java ! core/JemmyCore/src/org/jemmy/interfaces/CaretOwner.java ! core/JemmyCore/src/org/jemmy/interfaces/ControlInterfaceFactory.java ! core/JemmyCore/src/org/jemmy/interfaces/Drag.java ! core/JemmyCore/src/org/jemmy/interfaces/Focusable.java ! core/JemmyCore/src/org/jemmy/interfaces/InterfaceException.java ! core/JemmyCore/src/org/jemmy/interfaces/IntervalSelectable.java ! core/JemmyCore/src/org/jemmy/interfaces/IntervalSelector.java ! core/JemmyCore/src/org/jemmy/interfaces/Keyboard.java ! core/JemmyCore/src/org/jemmy/interfaces/Label.java ! core/JemmyCore/src/org/jemmy/interfaces/Menu.java ! core/JemmyCore/src/org/jemmy/interfaces/MenuOwner.java ! core/JemmyCore/src/org/jemmy/interfaces/MenuSelectable.java ! core/JemmyCore/src/org/jemmy/interfaces/MenuSelectableOwner.java ! core/JemmyCore/src/org/jemmy/interfaces/Modifier.java ! core/JemmyCore/src/org/jemmy/interfaces/Mouse.java ! core/JemmyCore/src/org/jemmy/interfaces/Parent.java ! core/JemmyCore/src/org/jemmy/interfaces/PopupSelectableOwner.java ! core/JemmyCore/src/org/jemmy/interfaces/Scroll.java ! core/JemmyCore/src/org/jemmy/interfaces/Selectable.java ! core/JemmyCore/src/org/jemmy/interfaces/Selector.java ! core/JemmyCore/src/org/jemmy/interfaces/Showable.java ! core/JemmyCore/src/org/jemmy/interfaces/Text.java ! core/JemmyCore/src/org/jemmy/interfaces/TextInput.java ! core/JemmyCore/src/org/jemmy/interfaces/TypeControlInterface.java ! core/JemmyCore/src/org/jemmy/interfaces/Window.java ! core/JemmyCore/src/org/jemmy/lookup/AbstractLookup.java ! core/JemmyCore/src/org/jemmy/lookup/AbstractParent.java ! core/JemmyCore/src/org/jemmy/lookup/Any.java ! core/JemmyCore/src/org/jemmy/lookup/ByStringLookup.java ! core/JemmyCore/src/org/jemmy/lookup/CompoundLookup.java ! core/JemmyCore/src/org/jemmy/lookup/ControlHierarchy.java ! core/JemmyCore/src/org/jemmy/lookup/ControlList.java ! core/JemmyCore/src/org/jemmy/lookup/CoordinateLookup.java ! core/JemmyCore/src/org/jemmy/lookup/HierarchyLookup.java ! core/JemmyCore/src/org/jemmy/lookup/Lookup.java ! core/JemmyCore/src/org/jemmy/lookup/LookupCriteria.java ! core/JemmyCore/src/org/jemmy/lookup/ParentImpl.java ! core/JemmyCore/src/org/jemmy/lookup/PlainLookup.java ! core/JemmyCore/src/org/jemmy/lookup/PropLookup.java ! core/JemmyCore/src/org/jemmy/lookup/RelativeCoordinateLookup.java ! core/JemmyCore/src/org/jemmy/operators/Screen.java ! core/JemmyCore/src/org/jemmy/operators/ScreenRectangle.java ! core/JemmyCore/src/org/jemmy/resources/StringComparePolicy.java ! core/JemmyCore/src/org/jemmy/timing/State.java ! core/JemmyCore/src/org/jemmy/timing/Waiter.java ! pom.xml From patrick at reini.net Fri May 4 12:21:14 2018 From: patrick at reini.net (Patrick Reinhart) Date: Fri, 04 May 2018 12:21:14 -0000 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> Message-ID: <80E4F1B0-1C7C-4277-9234-DE646ED0196C@reini.net> Hello together, I went over the jemmy codebase so far, that the compilation succeeds and a push to the maven repo is possible: http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/ The following changes include mostly the following: Javadoc The changes removed all comments, that did not provide any informations. In those cases where the comments where not complete the I added ?todo document? as text to pass the minimal build requirements. groupId/artifactId I changed the groupId to ?org.adoptopenjdk? and all artifactId values to be lower case and dash separated: The current state of the changes will build an 3.0.0-SNAPSHOT version so far. Before I we can publish an initial version, we must clarify the correct license and update the according header files. For the moment I took the latest GPL license for my local build and its initial tests. -Patrick > Am 04.05.2018 um 13:38 schrieb Martijn Verburg : > > Awesome, that makes life a lot easier - OK, now to get X11 running on the build boxes we want to pass tests. > > Cheers, > Martijn > > On 4 May 2018 at 12:01, Erik Greijus wrote: > Hello, > > Sorry for the late answer. > As for JemmySWT.jar it is platform independent (it relies on the platform dependent SWT library - which is needed to build the project, and later on to actually use Jemmy). > You only need to build and make available the four jars as they are. > > Best regards > /Erik > > > >> 4 maj 2018 kl. 10:39 skrev Martijn Verburg : >> >> Hi all, >> >> 1.) I'm OK with the groupId being org.adoptopenjdk - but that may cause some confusion if we do not actually host the source code as well. Not too big an issue if we explain this in the POM file >> >> 2.) Thank you Patrick (what an awesome co-incidence)! >> >> 3.) I'm totally OK with it being version 3.0.0, so I'd recommend setting the version to 3.0.0-SNAPSHOT to start with. >> >> I'd still like to understand if we need a SWT JAR for each platform, is someone able to answer that? >> >> >> >> Cheers, >> Martijn >> >> On 3 May 2018 at 21:17, Marcus Hirt wrote: >> So, we?re suggesting to use adoptopenjdk.org as groupid and change the camel case module names to lower case and dashes. Patrick is also fixing the javadocs, as that must be done to publish the source Jars. I think Patrick will be back with big wonderful patch soon. :) >> >> >> >> Also, would it be okay to not have v3 in the name, but rather just set the version to 3.0.0? >> >> >> >> Kind regards, >> >> Marcus >> >> >> >> From: Martijn Verburg >> Date: Thursday, 3 May 2018 at 22:13 >> To: Erik Greijus >> Cc: "Alexandre (Shura) Iline" , "adoption-discuss at openjdk.java.net" , , dalibor topic , Marcus Hirt , Patrick Reinhart >> Subject: Re: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ >> >> >> >> Hi all, >> >> >> >> I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/). I have a few questions / comments. >> >> >> >> 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? >> >> >> >> >> 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. >> >> >> >> >> 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. >> >> >> >> * In terms of SNAPSHOTS we could could likely push on every build >> >> * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release >> >> >> >> My suggestion is that you: >> >> >> >> 1.) Change the version numbers to 1.0.0-SNAPSHOT >> >> 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) >> >> 3.) We perform a formal release (1.0.0) and push that to Maven Central >> >> 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need >> >> >> >> I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! >> >> >> >> Cheers, >> Martijn >> >> >> >> On 13 April 2018 at 08:40, Erik Greijus wrote: >> >> >> >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg : >> > >> > Hi all, >> > >> > The Jemmy build project is here: >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ >> > >> > If managed to get a mostly successful run and have produced a jemmy.tar.gz >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, >> > JemmyBrowser.jar). Now for some questions :-) >> > >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do >> > platform specific jemmy's need to be built? >> >> Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) >> >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if >> > I can get that Jenkins node to fire up an X11 so that those tests can pass. >> >> That would be good. >> >> > 3.) Can folks please grab the tar.gz from the latest artifacts link >> > >> > and let me know if that's how they expect it to be named and whether the >> > layout of the contents is acceptable >> >> I miss the JemmySWT jar file mentioned above. >> >> >> > 4.) Versioning / naming - should I be building off a known good tag? Do we >> > want the tip/commit number to be part of the artifact name? >> > >> > It should build on an SCM change and weekly as well >> > >> > >> > Cheers, >> > Martijn >> > >> > On 11 April 2018 at 09:56, Martijn Verburg wrote: >> > >> >> Cool, I'll go with what I have as a working build for now and adjust to >> >> use the test target when that change comes in, and then perhaps move to the >> >> Maven build later. >> >> >> >> Cheers, >> >> Martijn >> >> >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < >> >> alexandre.iline at oracle.com> wrote: >> >> >> >>> >> >>> >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg >> >>> wrote: >> >>> >> >>> Hi Alexandre, >> >>> >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/) in particular >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue >> >>> up (we did have broken binaries for a bit). >> >>> >> >>> If I now run >> >>> >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu >> >>> ild-dependecies-impl >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te >> >>> st-dependecies-impl >> >>> >> >>> Then I get a passing build! >> >>> >> >>> --------- >> >>> >> >>> Onto the next issue! If I run just: >> >>> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test >> >>> >> >>> Then I get compile errors like: >> >>> >> >>> compile-test: >> >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find >> >>> symbol >> >>> [javac] prnt.lookup(new ByTextItem("Table")). >> >>> wrap().mouse().click(); >> >>> [javac] ^ >> >>> [javac] symbol: class ByTextItem >> >>> [javac] location: class ItemsTest >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find >> >>> symbol >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap >> >>> ().mouse().click(); >> >>> [javac] ^ >> >>> [javac] symbol: class ByTextItem >> >>> [javac] location: class ItemsTest >> >>> >> >>> >> >>> >> >>> This, I believe, is a bug which is going to be addressed by the review in >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 >> >>> 018-April/000080.html >> >>> >> >>> Shura >> >>> >> >>> >> >>> ------------ >> >>> >> >> >>> A *README.txt* for building at the root of the project and a .*hgignore* >> >> >>> file would also be nice to haves. >> >>> >> >>> ------------ >> >>> >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy >> >>> building nightly on our build farm. I'm also very interested in seeing the >> >>> Maven support go in :-). >> >>> >> >>> Cheers, >> >>> Martijn >> >>> >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < >> >>> alexandre.iline at oracle.com> wrote: >> >>> >> >>>> Do you happen to have full stack trace of that? >> >>>> >> >>>> Also, how to I get JTReg which are you using? >> >>>> >> >>>> The reported missing method would be a part of JTReg, clearly. >> >>>> >> >>>> The other thing is you should probably be ok with just running ant ?. >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. >> >>>> >> >>>> Shura >> >>>> >> >>>> >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg >> >>>> wrote: >> >>>> >> >>>> Hi Alexandre, >> >>>> >> >>>> I got a little further (This is using Java 1.8.0_162). Once I set my >> >>>> swt.jar and jtreg.home I was able to run: >> >>>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> check-dependecies-impl >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> build-dependecies-impl >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >> >> >>>> K_Projects/jtreg/ test-dependecies-impl >> >> >>>> >> >>>> The first two execute OK but then the test gives me the test failure of: >> >>>> >> >>>> test: >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not >> >>>> found: creating >> >>>> [exec] Directory "/Users/karianna/Documents/wor >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" >> >>>> not found: creating >> >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java >> >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java >> >>>> [exec] Error. Unexpected error caught from test >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su >> >>>> n/javatest/regtest/agent/JDK_Version;)I >> >>>> [exec] Test results: error: 1 >> >>>> [exec] Report written to /Users/karianna/Documents/work >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ >> >>>> report/html/report.html >> >>>> [exec] Results written to /Users/karianna/Documents/work >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd >> >>>> [exec] Error: Some tests failed or other problems occurred. >> >>>> [exec] Result: 3 >> >>>> >> >>>> Any ideas? >> >>>> >> >>>> FYI - I'm still running this locally on my Mac OS X box until I get a >> >>>> clean build so I know the minimum steps for the build farm job. Note to >> >>>> self that the build box will need to provide a platform specific SWT lib >> >>>> (Linux x86). >> >>>> >> >>>> Cheers, >> >>>> Martijn >> >>>> >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < >> >>>> alexandre.iline at oracle.com> wrote: >> >>>> >> >>>>> Now including aliases and more recipients.. >> >>>>> >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < >> >>>>> alexandre.iline at oracle.com> wrote: >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < >> >>>>> martijnverburg at gmail.com> wrote: >> >>>>>>> >> >>>>>>> Hi Alexandre, >> >>>>>>> >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and >> >>>>> that failed with: >> >>>>>>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: >> >>>>> Please specify swt.jar >> >>>>>> >> >>>>>> You do need the SWT library to build SWT. >> >>>>>> >> >>>>>> this is what I just did: >> >>>>>> >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar >> >>>>> jar >> >>>>>> >> >>>>>> >> >>>>>> I clearly need to provide a README. Will do. >> >>>>>> >> >>>>>> Shura >> >>>>>> >> >>>>>>> >> >>>>>>> Then I actually bothered to read the build.xml file and saw the >> >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which >> >>>>> seemed to build: >> >>>>>>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyCore/build/JemmyCore.jar >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar >> >>>>>>> >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set >> >>>>>>> >> >>>>>>> Before I shave more Yaks, is this the right direction to be going in? >> >>>>>>> >> >>>>>>> >> >>>>>>> Cheers, >> >>>>>>> Martijn >> >>>>>>> >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < >> >>>>> alexandre.iline at oracle.com> wrote: >> >>>>>>> Martijn, >> >>>>>>> >> >>>>>>> Jemmy v3 consists of several project which depend on each other. >> >>>>>>> >> >>>>>>> If, besides hosting the source, the intension is to build it, you >> >>>>> need to build projects which are in use by others who would be coming to >> >>>>> AdoptOpenJDK for binaries. >> >>>>>>> >> >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. >> >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is >> >>>>> build, the dependences are also built, you should have no problem with that. >> >>>>>>> >> >>>>>>> Binaries would, then, simply include all jar files create after the >> >>>>> build. The jar files will be: */*/build/*.jar >> >>>>>>> >> >>>>>>> Shura >> >>>>>>> >> >>>>>>> >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < >> >>>>> martijnverburg at gmail.com> wrote: >> >>>>>>>> >> >>>>>>>> Hi Dalibor, >> >>>>>>>> >> >>>>>>>> We're shifting the code tools off Cloudbees to the new >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick >> >>>>> Q: >> >>>>>>>> >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: >> >>>>>>>> >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make >> >>>>>>>> >> >>>>>>>> but I can't see what the canonical entry point to build it is. >> >>>>>>>> >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. >> >>>>>>>> >> >>>>>>>> Cheers, >> >>>>>>>> Martijn >> >>>>>>>> >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic >> >>>>> wrote: >> >>>>>>>> Hi Martijn, >> >>>>>>>> >> >>>>>>>> would you be able to add the Jemmy v3 repo at >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to >> >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? >> >>>>>>>> >> >>>>>>>> cheers, >> >>>>>>>> dalibor topic >> >>>>>>>> -- >> >>>>>>>> Dalibor Topic | Principal Product Manager >> >> >>>>>>>> Phone: +494089091214 > | Mobile: >> >>>>> +491737185961 >> >>>>>>>> > >> >>>>>>>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg >> >>>>> >> >>>>>>>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 >> >>>>> >> >>>>> M?nchen >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 >> >>>>>>>> >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. >> >>>>>>>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande >> >>>>> >> >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher >> >>>>>>>> >> >>>>>>>> Oracle is committed to >> >>>>> developing >> >>>>>>>> practices and products that help protect the environment >> >>>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>> >> >>>>> >> >>>>> >> >>>> >> >>>> >> >>> >> >>> >> >> >> >> >> >> > > From patrick at reini.net Fri May 4 14:15:52 2018 From: patrick at reini.net (Patrick Reinhart) Date: Fri, 04 May 2018 14:15:52 -0000 Subject: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ In-Reply-To: <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> References: <8EEAEA50-2843-4534-8A77-D8DD9058D758@oracle.com> <393DE88C-5998-4DF0-A820-F20CBFBF57DD@oracle.com> <36F950F3-220C-4E87-B48B-EC47CBA76A88@oracle.com> <6C42B916-3F79-4889-AFB8-56AD71E2EF74@oracle.com> <80E4F1B0-1C7C-4277-9234-DE646ED0196C@reini.net> <370D7FBD-81BC-485D-8549-3648E1243980@oracle.com> Message-ID: I will apply the corresponding updates as soon we have a final decision on the version numbers and license though? -Patrick > Am 04.05.2018 um 15:30 schrieb Erik Greijus : > > I actually think they were all meant to be 1.0.0 at initial commit when Jemmy3 was open sourced. > > Maybe Shura can enlighten us on that? > > /Erik > >> 4 maj 2018 kl. 15:18 skrev Martijn Verburg >: >> >> Hmmm - is it worth unifying the module numbers to 1.0.0 for this initial release? >> >> On Fri, 4 May 2018 at 14:04, Erik Greijus > wrote: >> I think that?s better. Remember that each of the modules have their own version as well (see the version.properties file for each of them). >> >> Regards >> /Erik >> >> >>> 4 maj 2018 kl. 15:00 skrev Martijn Verburg >: >>> >>> Sounds like we need to change the version numbers and artifactId according to Erik's instructions as well? >>> >>> So >>> >>> groupId org.adoptopenjdk >>> artifactId jemmy3 >>> version 1.0.0-SNAPSHOT >>> >>> How does that sound Erik? >>> >>> >>> >>> >>> Cheers, >>> Martijn >>> >>> On 4 May 2018 at 13:19, Patrick Reinhart > wrote: >>> Hello together, >>> >>> I went over the jemmy codebase so far, that the compilation succeeds and a push to the maven repo is possible: >>> >>> >>> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/ >>> >>> The following changes include mostly the following: >>> >>> Javadoc >>> The changes removed all comments, that did not provide any informations. In those cases where the comments where not complete the I added ?todo document? as text to pass the minimal build requirements. >>> >>> groupId/artifactId >>> I changed the groupId to ?org.adoptopenjdk? and all artifactId values to be lower case and dash separated: >>> >>> The current state of the changes will build an 3.0.0-SNAPSHOT version so far. >>> >>> Before I we can publish an initial version, we must clarify the correct license and update the according header files. For the moment I took the latest GPL license for my local build and its initial tests. >>> >>> >>> -Patrick >>> >>> >>> > Am 04.05.2018 um 13:38 schrieb Martijn Verburg >: >>> > >>> > Awesome, that makes life a lot easier - OK, now to get X11 running on the build boxes we want to pass tests. >>> > >>> > Cheers, >>> > Martijn >>> > >>> > On 4 May 2018 at 12:01, Erik Greijus > wrote: >>> > Hello, >>> > >>> > Sorry for the late answer. >>> > As for JemmySWT.jar it is platform independent (it relies on the platform dependent SWT library - which is needed to build the project, and later on to actually use Jemmy). >>> > You only need to build and make available the four jars as they are. >>> > >>> > Best regards >>> > /Erik >>> > >>> > >>> > >>> >> 4 maj 2018 kl. 10:39 skrev Martijn Verburg >: >>> >> >>> >> Hi all, >>> >> >>> >> 1.) I'm OK with the groupId being org.adoptopenjdk - but that may cause some confusion if we do not actually host the source code as well. Not too big an issue if we explain this in the POM file >>> >> >>> >> 2.) Thank you Patrick (what an awesome co-incidence)! >>> >> >>> >> 3.) I'm totally OK with it being version 3.0.0, so I'd recommend setting the version to 3.0.0-SNAPSHOT to start with. >>> >> >>> >> I'd still like to understand if we need a SWT JAR for each platform, is someone able to answer that? >>> >> >>> >> >>> >> >>> >> Cheers, >>> >> Martijn >>> >> >>> >> On 3 May 2018 at 21:17, Marcus Hirt > wrote: >>> >> So, we?re suggesting to use adoptopenjdk.org as groupid and change the camel case module names to lower case and dashes. Patrick is also fixing the javadocs, as that must be done to publish the source Jars. I think Patrick will be back with big wonderful patch soon. :) >>> >> >>> >> >>> >> >>> >> Also, would it be okay to not have v3 in the name, but rather just set the version to 3.0.0? >>> >> >>> >> >>> >> >>> >> Kind regards, >>> >> >>> >> Marcus >>> >> >>> >> >>> >> >>> >> From: Martijn Verburg > >>> >> Date: Thursday, 3 May 2018 at 22:13 >>> >> To: Erik Greijus > >>> >> Cc: "Alexandre (Shura) Iline" >, "adoption-discuss at openjdk.java.net " >, >, dalibor topic >, Marcus Hirt >, Patrick Reinhart > >>> >> Subject: Re: Adding Jemmy v3 to https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ >>> >> >>> >> >>> >> >>> >> Hi all, >>> >> >>> >> >>> >> >>> >> I've made a little further progress with the new Maven based Jemmy build (https://ci.adoptopenjdk.net/job/jemmy/label_exp=linux&&x64&&hg/4/ ). I have a few questions / comments. >>> >> >>> >> >>> >> >>> >> 1.) The JemmySWT-1.0.jar artifact, is that platform independent or do we need to create a JemmySWT-linux-1.0.jar, JemmySWT-mac-1.0.jar, JemmySWT-windows-1.0.jar? >>> >> >>> >> >>> >> >>> >> >>> >> 2.) I still need to figure out how to bring up the Linux UI for our build node to pass the tests, I'm skipping for now. >>> >> >>> >> >>> >> >>> >> >>> >> 3.) Releasing to Maven Central is usually two-fold: SNAPSHOTS and release versions. >>> >> >>> >> >>> >> >>> >> * In terms of SNAPSHOTS we could could likely push on every build >>> >> >>> >> * In terms of releases we can add a release task (or a release job if we Jenkins pipeline pro it) that can be manaully executed when the Jemmy team decides to cut a release >>> >> >>> >> >>> >> >>> >> My suggestion is that you: >>> >> >>> >> >>> >> >>> >> 1.) Change the version numbers to 1.0.0-SNAPSHOT >>> >> >>> >> 2.) We get a SNAPSHOT release out to Maven Central (and practice getting past the OSSRH gatekeeper) >>> >> >>> >> 3.) We perform a formal release (1.0.0) and push that to Maven Central >>> >> >>> >> 4.) The version will auto bump to 1.0.1-SNAPSHOT afterwards and can be manually changed to whatever you need >>> >> >>> >> >>> >> >>> >> I notice that `org.jemmy.v3` is your groupID, that might be OK but the OSSRH gatekeeper might expect a org.jemmy email address. I'm not 100% on this so I've cruelly dragged in Patrick Reinhart who's done Maven Central deploys for other Adopt projects in the past, sorry Patrick! >>> >> >>> >> >>> >> >>> >> Cheers, >>> >> Martijn >>> >> >>> >> >>> >> >>> >> On 13 April 2018 at 08:40, Erik Greijus > wrote: >>> >> >>> >> >>> >> >>> >> > 11 apr. 2018 kl. 18:41 skrev Martijn Verburg >: >>> >> > >>> >> > Hi all, >>> >> > >>> >> > The Jemmy build project is here: >>> >> > https://ci.adoptopenjdk.net/view/Dependencies/job/jemmy/ >>> >> > >>> >> > If managed to get a mostly successful run and have produced a jemmy.tar.gz >>> >> > file that contains the 3 jar files (jemmyCore.jar, JemmyAWTInput.jar, >>> >> > JemmyBrowser.jar). Now for some questions :-) >>> >> > >>> >> > 1.) I'm running this on Linux x86 - since we're replying on an SWT lib, do >>> >> > platform specific jemmy's need to be built? >>> >> >>> >> Yes. The JemmySWT jar should have been built as well (./SWT/JemmySWT/target/...) >>> >> >>> >> > 2.) Some of the tests naturally failed (Robot testing the UI), I'll see if >>> >> > I can get that Jenkins node to fire up an X11 so that those tests can pass. >>> >> >>> >> That would be good. >>> >> >>> >> > 3.) Can folks please grab the tar.gz from the latest artifacts link >>> >> > > >>> >> > and let me know if that's how they expect it to be named and whether the >>> >> > layout of the contents is acceptable >>> >> >>> >> I miss the JemmySWT jar file mentioned above. >>> >> >>> >> >>> >> > 4.) Versioning / naming - should I be building off a known good tag? Do we >>> >> > want the tip/commit number to be part of the artifact name? >>> >> > >>> >> > It should build on an SCM change and weekly as well >>> >> > >>> >> > >>> >> > Cheers, >>> >> > Martijn >>> >> > >>> >> > On 11 April 2018 at 09:56, Martijn Verburg > wrote: >>> >> > >>> >> >> Cool, I'll go with what I have as a working build for now and adjust to >>> >> >> use the test target when that change comes in, and then perhaps move to the >>> >> >> Maven build later. >>> >> >> >>> >> >> Cheers, >>> >> >> Martijn >>> >> >> >>> >> >> On 10 April 2018 at 21:26, Alexandre (Shura) Iline < >>> >> >> alexandre.iline at oracle.com > wrote: >>> >> >> >>> >> >>> >>> >> >>> >>> >> >>> On Apr 10, 2018, at 8:52 AM, Martijn Verburg > >>> >> >>> wrote: >>> >> >>> >>> >> >>> Hi Alexandre, >>> >> >>> >>> >> >>> I'm using JTReg from the AdoptOpenJDK Build Farm ( >>> >> >>> https://ci.adoptopenjdk.net/view/all/job/jtreg/ ) in particular >>> >> >>> the jtreg-4.2-b12.tar.gz binary. That appears to have cleared that issue >>> >> >>> up (we did have broken binaries for a bit). >>> >> >>> >>> >> >>> If I now run >>> >> >>> >>> >> >>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar bu >>> >> >>> ild-dependecies-impl >>> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >>> >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar te >>> >> >>> st-dependecies-impl >>> >> >>> >>> >> >>> Then I get a passing build! >>> >> >>> >>> >> >>> --------- >>> >> >>> >>> >> >>> Onto the next issue! If I run just: >>> >> >>> >>> >> >>> ant -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jtreg/ >>> >> >>> -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3.jar test >>> >> >>> >>> >> >>> Then I get compile errors like: >>> >> >>> >>> >> >>> compile-test: >>> >> >>> [javac] Compiling 7 source files to /Users/karianna/Documents/work >>> >> >>> space/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build/test >>> >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >>> >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:84: error: cannot find >>> >> >>> symbol >>> >> >>> [javac] prnt.lookup(new ByTextItem("Table")). >>> >> >>> wrap().mouse().click(); >>> >> >>> [javac] ^ >>> >> >>> [javac] symbol: class ByTextItem >>> >> >>> [javac] location: class ItemsTest >>> >> >>> [javac] /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/ >>> >> >>> v3/SWT/JemmySWT/test/org/jemmy/swt/ItemsTest.java:92: error: cannot find >>> >> >>> symbol >>> >> >>> [javac] prnt.lookup(new ByTextItem(tab)).wrap >>> >> >>> ().mouse().click(); >>> >> >>> [javac] ^ >>> >> >>> [javac] symbol: class ByTextItem >>> >> >>> [javac] location: class ItemsTest >>> >> >>> >>> >> >>> >>> >> >>> >>> >> >>> This, I believe, is a bug which is going to be addressed by the review in >>> >> >>> progress: http://mail.openjdk.java.net/pipermail/jemmy-dev/2 >>> >> >>> 018-April/000080.html >>> >> >>> >>> >> >>> Shura >>> >> >>> >>> >> >>> >>> >> >>> ------------ >>> >> >>> >>> >> >>> >> >>> A *README.txt* for building at the root of the project and a .*hgignore* >>> >> >>> >> >>> file would also be nice to haves. >>> >> >>> >>> >> >>> ------------ >>> >> >>> >>> >> >>> I'm now going to source a Linux 4.3 SWT lib and see if I can get Jemmy >>> >> >>> building nightly on our build farm. I'm also very interested in seeing the >>> >> >>> Maven support go in :-). >>> >> >>> >>> >> >>> Cheers, >>> >> >>> Martijn >>> >> >>> >>> >> >>> On 9 April 2018 at 18:52, Alexandre (Shura) Iline < >>> >> >>> alexandre.iline at oracle.com > wrote: >>> >> >>> >>> >> >>>> Do you happen to have full stack trace of that? >>> >> >>>> >>> >> >>>> Also, how to I get JTReg which are you using? >>> >> >>>> >>> >> >>>> The reported missing method would be a part of JTReg, clearly. >>> >> >>>> >>> >> >>>> The other thing is you should probably be ok with just running ant ?. >>> >> >>>> test. ?test? target is coming from http://hg.openjdk.java.ne >>> >> >>>> t/code-tools/jemmy/v3/file/898c9e02c8c9/make/build_template.xml. >>> >> >>>> >>> >> >>>> Shura >>> >> >>>> >>> >> >>>> >>> >> >>>> On Apr 6, 2018, at 6:47 AM, Martijn Verburg > >>> >> >>>> wrote: >>> >> >>>> >>> >> >>>> Hi Alexandre, >>> >> >>>> >>> >> >>>> I got a little further (This is using Java 1.8.0_162). Once I set my >>> >> >>>> swt.jar and jtreg.home I was able to run: >>> >> >>>> >>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >>> >> >>>> check-dependecies-impl >>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >>> >> >>>> build-dependecies-impl >>> >> >>>> ant -Dswt.jar=lib/org.eclipse.swt.cocoa.macosx.x86_64-4.3 >>> >> >>>> -Djtreg.home=/Users/karianna/Documents/workspace/AdoptOpenJD >>> >> >>> >> >>>> K_Projects/jtreg/ test-dependecies-impl >>> >> >>> >> >>>> >>> >> >>>> The first two execute OK but then the test gives me the test failure of: >>> >> >>>> >>> >> >>>> test: >>> >> >>>> [exec] Directory "/Users/karianna/Documents/wor >>> >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd" not >>> >> >>>> found: creating >>> >> >>>> [exec] Directory "/Users/karianna/Documents/wor >>> >> >>>> kspace/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_report" >>> >> >>>> not found: creating >>> >> >>>> [exec] runner starting test: org/jemmy/browser/PropPanelTest.java >>> >> >>>> [exec] runner finished test: org/jemmy/browser/PropPanelTest.java >>> >> >>>> [exec] Error. Unexpected error caught from test >>> >> >>>> org/jemmy/browser/PropPanelTest.java: java.lang.NoSuchMethodError: >>> >> >>>> com.sun.javatest.regtest.agent.JDK_Version.compareTo(Lcom/su >>> >> >>>> n/javatest/regtest/agent/JDK_Version;)I >>> >> >>>> [exec] Test results: error: 1 >>> >> >>>> [exec] Report written to /Users/karianna/Documents/work >>> >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_ >>> >> >>>> report/html/report.html >>> >> >>>> [exec] Results written to /Users/karianna/Documents/work >>> >> >>>> space/AdoptOpenJDK_Projects/v3/core/JemmyBrowser/build/test_wd >>> >> >>>> [exec] Error: Some tests failed or other problems occurred. >>> >> >>>> [exec] Result: 3 >>> >> >>>> >>> >> >>>> Any ideas? >>> >> >>>> >>> >> >>>> FYI - I'm still running this locally on my Mac OS X box until I get a >>> >> >>>> clean build so I know the minimum steps for the build farm job. Note to >>> >> >>>> self that the build box will need to provide a platform specific SWT lib >>> >> >>>> (Linux x86). >>> >> >>>> >>> >> >>>> Cheers, >>> >> >>>> Martijn >>> >> >>>> >>> >> >>>> On 28 March 2018 at 21:43, Alexandre (Shura) Iline < >>> >> >>>> alexandre.iline at oracle.com > wrote: >>> >> >>>> >>> >> >>>>> Now including aliases and more recipients.. >>> >> >>>>> >>> >> >>>>>> On Mar 28, 2018, at 1:41 PM, Alexandre (Shura) Iline < >>> >> >>>>> alexandre.iline at oracle.com > wrote: >>> >> >>>>>> >>> >> >>>>>> >>> >> >>>>>> >>> >> >>>>>>> On Mar 28, 2018, at 12:28 PM, Martijn Verburg < >>> >> >>>>> martijnverburg at gmail.com > wrote: >>> >> >>>>>>> >>> >> >>>>>>> Hi Alexandre, >>> >> >>>>>>> >>> >> >>>>>>> OK, So I naively tried to run ant in the SWT/JemmySWT folder and >>> >> >>>>> that failed with: >>> >> >>>>>>> >>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3/SWT/JemmySWT/build.xml:33: >>> >> >>>>> Please specify swt.jar >>> >> >>>>>> >>> >> >>>>>> You do need the SWT library to build SWT. >>> >> >>>>>> >>> >> >>>>>> this is what I just did: >>> >> >>>>>> >>> >> >>>>>> ~/JDK/hg/jemmy/v3/SWT/JemmySWT$ ant -Dswt.jar=/usr/lib/eclipse/plugins/org.eclipse.swt_3.8.2.jar >>> >> >>>>> jar >>> >> >>>>>> >>> >> >>>>>> >>> >> >>>>>> I clearly need to provide a README. Will do. >>> >> >>>>>> >>> >> >>>>>> Shura >>> >> >>>>>> >>> >> >>>>>>> >>> >> >>>>>>> Then I actually bothered to read the build.xml file and saw the >>> >> >>>>> build-dependecies-impl target, so I ran ant build-dependecies-impl which >>> >> >>>>> seemed to build: >>> >> >>>>>>> >>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >>> >> >>>>> /core/JemmyCore/build/JemmyCore.jar >>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >>> >> >>>>> /core/JemmyAWTInput/build/JemmyAWTInput.jar >>> >> >>>>>>> /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/v3 >>> >> >>>>> /core/JemmyBrowser/build/JemmyBrowser.jar >>> >> >>>>>>> >>> >> >>>>>>> Then I ran ant test-dependecies-impl and it wanted my jtreg.home set >>> >> >>>>>>> >>> >> >>>>>>> Before I shave more Yaks, is this the right direction to be going in? >>> >> >>>>>>> >>> >> >>>>>>> >>> >> >>>>>>> Cheers, >>> >> >>>>>>> Martijn >>> >> >>>>>>> >>> >> >>>>>>> On 28 March 2018 at 20:43, Alexandre (Shura) Iline < >>> >> >>>>> alexandre.iline at oracle.com > wrote: >>> >> >>>>>>> Martijn, >>> >> >>>>>>> >>> >> >>>>>>> Jemmy v3 consists of several project which depend on each other. >>> >> >>>>>>> >>> >> >>>>>>> If, besides hosting the source, the intension is to build it, you >>> >> >>>>> need to build projects which are in use by others who would be coming to >>> >> >>>>> AdoptOpenJDK for binaries. >>> >> >>>>>>> >>> >> >>>>>>> At this point of time, from what I know, JemmySWT is what is needed. >>> >> >>>>> Ant build scripts are constructed in a way so that by while JemmySWT is >>> >> >>>>> build, the dependences are also built, you should have no problem with that. >>> >> >>>>>>> >>> >> >>>>>>> Binaries would, then, simply include all jar files create after the >>> >> >>>>> build. The jar files will be: */*/build/*.jar >>> >> >>>>>>> >>> >> >>>>>>> Shura >>> >> >>>>>>> >>> >> >>>>>>> >>> >> >>>>>>>> On Mar 28, 2018, at 11:35 AM, Martijn Verburg < >>> >> >>>>> martijnverburg at gmail.com > wrote: >>> >> >>>>>>>> >>> >> >>>>>>>> Hi Dalibor, >>> >> >>>>>>>> >>> >> >>>>>>>> We're shifting the code tools off Cloudbees to the new >>> >> >>>>> adoptiopenjdk.net build farm. I'm more than happy to add it, a quick >>> >> >>>>> Q: >>> >> >>>>>>>> >>> >> >>>>>>>> hg clone http://hg.openjdk.java.net/code-tools/jemmy/v3/ gives me: >>> >> >>>>>>>> >>> >> >>>>>>>> drwxr-xr-x 7 karianna staff 238 28 Mar 19:30 . >>> >> >>>>>>>> drwxr-xr-x 44 karianna staff 1496 28 Mar 19:30 .. >>> >> >>>>>>>> drwxr-xr-x 13 karianna staff 442 28 Mar 19:30 .hg >>> >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 .jcheck >>> >> >>>>>>>> drwxr-xr-x 4 karianna staff 136 28 Mar 19:30 SWT >>> >> >>>>>>>> drwxr-xr-x 6 karianna staff 204 28 Mar 19:30 core >>> >> >>>>>>>> drwxr-xr-x 3 karianna staff 102 28 Mar 19:30 make >>> >> >>>>>>>> >>> >> >>>>>>>> but I can't see what the canonical entry point to build it is. >>> >> >>>>>>>> >>> >> >>>>>>>> I'll sign up to jemmy-dev and x-post there shortly. >>> >> >>>>>>>> >>> >> >>>>>>>> Cheers, >>> >> >>>>>>>> Martijn >>> >> >>>>>>>> >>> >> >>>>>>>> On 28 March 2018 at 17:02, dalibor topic > >>> >> >>>>> wrote: >>> >> >>>>>>>> Hi Martijn, >>> >> >>>>>>>> >>> >> >>>>>>>> would you be able to add the Jemmy v3 repo at >>> >> >>>>> http://hg.openjdk.java.net/code-tools/jemmy/v3/ to >>> >> >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK%20code-tools/ ? >>> >> >>>>>>>> >>> >> >>>>>>>> cheers, >>> >> >>>>>>>> dalibor topic >>> >> >>>>>>>> -- >>> >> >>>>>>>> > Dalibor Topic | Principal Product Manager >>> >> >>> >> >>>>>>>> Phone: +494089091214 <+494089091214>> | Mobile: >>> >> >>>>> +491737185961 >>> >> >>>>>>>> <+491737185961>> >>> >> >>>>>>>> >>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg >>> >> >>>>> > >>> >> >>>>>>>> >>> >> >>>>>>>> ORACLE Deutschland B.V. & Co. KG >>> >> >>>>>>>> Hauptverwaltung: Riesstr. 25, D-80992 >>> >> >>>>> > >>> >> >>>>> M?nchen >>> >> >>>>>>>> Registergericht: Amtsgericht M?nchen, HRA 95603 >>> >> >>>>>>>> >>> >> >>>>>>>> Komplement?rin: ORACLE Deutschland Verwaltung B.V. >>> >> >>>>>>>> Hertogswetering 163 /167, 3543 AS Utrecht, Niederlande >>> >> >>>>> > >>> >> >>> >> >>>>>>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 >>> >> >>>>>>>> Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher >>> >> >>>>>>>> >>> >> >>>>>>>> > Oracle is committed to >>> >> >>>>> developing >>> >> >>>>>>>> practices and products that help protect the environment >>> >> >>>>>>>> >>> >> >>>>>>> >>> >> >>>>>>> >>> >> >>>>>> >>> >> >>>>> >>> >> >>>>> >>> >> >>>> >>> >> >>>> >>> >> >>> >>> >> >>> >>> >> >> >>> >> >>> >> >>> >> >>> >> >>> > >>> > >>> >>> >> >> -- >> Cheers, Martijn (Sent from Gmail Mobile) >