RFR: Prepare jemmy for adoptopenjdk build and deploy

[Erik Greijus]

Looks good to me.

Regards
/Erik

> 17 maj 2018 kl. 22:15 skrev Patrick Reinhart <patrick at reini.net>:
> 
> Hi Shura,
> 
> 
>> Am 17.05.2018 um 04:08 schrieb Alexandre (Shura) Iline <alexandre.iline at oracle.com>:
>> 
>> 
>> 
>>> On May 10, 2018, at 9:38 AM, Patrick Reinhart <patrick at reini.net> wrote:
>>> 
>>> Hi Shura,
>>> 
>>> There is no requirement to have @author tags in the source code. I only removed the email addresss and those characters failing to pass the Javadoc generation.
>> 
>> 
>> On the @author tag, I find some of the changes inconsistent:
>> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/SWT/JemmySWT/src/org/jemmy/swt/lookup/ByItemLookup.java.sdiff.html
>> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/RoughImageComparator.java.sdiff.html
>> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev/core/JemmyAWTInput/src/org/jemmy/image/StrictImageComparator.java.sdiff.html
>> 
>> Alexandre Iline is also me: shura
> 
> Changed those accordingly…
> 
>> 
>> 
>>> For the rest of the code the main changes contain removal of Javadoc parts, that did only contained @param/@return tags with no futher content.
>>> 
>> 
>> A Javadoc cleanup, been very useful, should probably come with a separate bug, unless the changes are required for the maven work.
> 
> I know, that it would be do those in a separate bug, but exactly those changes where needed in order to meet the requirements in order to push a artifact to maven central…
> 
> The updated webrev contains the latest changes:
> 
> http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev <http://cr.openjdk.java.net/~reinhapa/reviews/jemmy/webrev>
> 
> -Patrick
> 
> 
>> 
>> Shura
>> 
>>> When I started together with Marcus, we tried to complete the incomplete @param values. If there where Jacadoc comments with partial content, I added „todo javadoc“ to those @param/@return tags that where missing or where only partiallly available. The intention was to may going over it later and fill those missing parts in. Apart from this there where no code changes done exept using some diamond operators instead of the extended generics definition. Also the main changes where done within the root pom.xml file adding the licence/scm and authors section in order to pass the maven central requirements.
>>> 
>>> Hope the answered your questions so far.
>>> 
>>> -Patrick