RFR CODETOOLS-7902413: JFileChooserOperator - Filter file list based on accessible name instead of index
Alexandre (Shura) Iline
alexandre.iline at oracle.com
Wed Mar 6 01:24:53 UTC 2019
> On Mar 5, 2019, at 5:23 PM, abdul.kolarkunnu at oracle.com wrote:
>
> Hi Shura,
>
> I intentionally removed that import as it's an unused import. I mentioned that in the end of this email.
>
>
I see. Missed that. Sorry.
Good to got then.
Shura
> If you don't like to do that along with this change, I can remove that, but it's a simple change, I thought include it in this instead of creating a new task for that.
>
> Regards,
>
> Muneer
>
>
> On 06/03/19 3:20 AM, Alexandre (Shura) Iline wrote:
>> This file should not be changed, I think:
>> http://cr.openjdk.java.net/~akolarkunnu/7902413/webrev.00/src/org/netbeans/jemmy/drivers/DefaultDriverInstaller.java.sdiff.html <http://cr.openjdk.java.net/%7Eakolarkunnu/7902413/webrev.00/src/org/netbeans/jemmy/drivers/DefaultDriverInstaller.java.sdiff.html>
>>
>> Shura
>>
>>> On Feb 28, 2019, at 9:58 PM, Muneer Kolarkunnu <abdul.kolarkunnu at oracle.com <mailto:abdul.kolarkunnu at oracle.com>> wrote:
>>>
>>> Hi All,
>>>
>>> Please review fix for the bug : https://bugs.openjdk.java.net/browse/CODETOOLS-7902413 <https://bugs.openjdk.java.net/browse/CODETOOLS-7902413>
>>>
>>> Webrev : http://cr.openjdk.java.net/~akolarkunnu/7902413/webrev.00/ <http://cr.openjdk.java.net/%7Eakolarkunnu/7902413/webrev.00/>
>>>
>>> Description: It's error prone filtering based on index, so converting it in to accessible name.
>>> Removed an unused import from DefaultDriverInstaller.java along with this fix.
>>>
>>> Regards,
>>> Muneer
>>>
>>>
>>
>
More information about the jemmy-dev
mailing list