RFR: Codetools 7902736

[Alexandre Iline]

On Wed, 11 Nov 2020 06:58:18 GMT, Abdul Kolarkunnu <akolarkunnu at openjdk.org> wrote:

>> Looks fine.
>
> Just a thought - Is it a good idea to differentiate 'null' and empty string - May be by replacing "" with "null" when selectedText is null.
> Also what about renaming 'selected' with 'selectedText' .

> On Nov 10, 2020, at 10:58 PM, Muneer Kolarkunnu <notifications at github.com> wrote:
> 
> 
> Just a thought - Is it a good idea to differentiate 'null' and empty string - May be by replacing "" with "null" when selectedText is null.
> 

I thought about it. Null selection really means nothing is selected. Empty value is saying that. “null” could be misleading because “null” could actually be a selected text.
> Also what about renaming 'selected' with 'selectedText' .
> 
> 
It’s a local var, renaming would not change any semantic or behavior or would not make code more or less easier to understood.

Shura

> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/openjdk/jemmy-v2/pull/2*issuecomment-725241331__;Iw!!GqivPVa7Brio!Ji1C1MKf4VPGDLwtUa7jf7YzOS6RmeBkdPAfxSWP2RICon79hcHht6_8o84KZWxzm7Y$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABN6PZRS36B4BVF34NWHL3LSPIYZPANCNFSM4TRJPXOQ__;!!GqivPVa7Brio!Ji1C1MKf4VPGDLwtUa7jf7YzOS6RmeBkdPAfxSWP2RICon79hcHht6_8o84KsmQwc3w$>.
>

-------------

PR: https://git.openjdk.java.net/jemmy-v2/pull/2