From shurailine at openjdk.org Wed Aug 24 20:31:58 2022 From: shurailine at openjdk.org (Alexandre Iline) Date: Wed, 24 Aug 2022 20:31:58 GMT Subject: RFR: Save and dump last mouse move. Message-ID: Save and dump last mouse move. Added Component.hasFocus() to the dump. ------------- Commit messages: - added missing files - Save and dump last mouse move. Changes: https://git.openjdk.org/jemmy-v2/pull/6/files Webrev: https://webrevs.openjdk.org/?repo=jemmy-v2&pr=6&range=00 Stats: 292 lines in 12 files changed: 272 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jemmy-v2/pull/6.diff Fetch: git fetch https://git.openjdk.org/jemmy-v2 pull/6/head:pull/6 PR: https://git.openjdk.org/jemmy-v2/pull/6 From shurailine at openjdk.org Wed Aug 24 20:31:59 2022 From: shurailine at openjdk.org (Alexandre Iline) Date: Wed, 24 Aug 2022 20:31:59 GMT Subject: RFR: Save and dump last mouse move. In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 20:25:22 GMT, Alexandre Iline wrote: > Save and dump last mouse move. > Added Component.hasFocus() to the dump. @lawrence-andrews, can you review? ------------- PR: https://git.openjdk.org/jemmy-v2/pull/6 From shurailine at openjdk.org Wed Aug 24 20:50:32 2022 From: shurailine at openjdk.org (Alexandre Iline) Date: Wed, 24 Aug 2022 20:50:32 GMT Subject: RFR: Save and dump last mouse move. [v2] In-Reply-To: References: Message-ID: > Save and dump last mouse move. > Added Component.hasFocus() to the dump. Alexandre Iline has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jemmy-v2/pull/6/files - new: https://git.openjdk.org/jemmy-v2/pull/6/files/3a886029..3a886029 Webrevs: - full: https://webrevs.openjdk.org/?repo=jemmy-v2&pr=6&range=01 - incr: https://webrevs.openjdk.org/?repo=jemmy-v2&pr=6&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jemmy-v2/pull/6.diff Fetch: git fetch https://git.openjdk.org/jemmy-v2 pull/6/head:pull/6 PR: https://git.openjdk.org/jemmy-v2/pull/6 From duke at openjdk.org Wed Aug 24 20:50:33 2022 From: duke at openjdk.org (lawrence.andrews) Date: Wed, 24 Aug 2022 20:50:33 GMT Subject: RFR: Save and dump last mouse move. [v2] In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 20:46:15 GMT, Alexandre Iline wrote: >> Save and dump last mouse move. >> Added Component.hasFocus() to the dump. > > Alexandre Iline has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. src/org/netbeans/jemmy/drivers/MouseDriver.java line 26: > 24: */ > 25: package org.netbeans.jemmy.drivers; > 26: Copy right 2016 should be modified to 2022 ------------- PR: https://git.openjdk.org/jemmy-v2/pull/6 From shurailine at openjdk.org Wed Aug 24 20:50:34 2022 From: shurailine at openjdk.org (Alexandre Iline) Date: Wed, 24 Aug 2022 20:50:34 GMT Subject: Withdrawn: Save and dump last mouse move. In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 20:25:22 GMT, Alexandre Iline wrote: > Save and dump last mouse move. > Added Component.hasFocus() to the dump. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jemmy-v2/pull/6 From duke at openjdk.org Wed Aug 24 20:55:33 2022 From: duke at openjdk.org (lawrence.andrews) Date: Wed, 24 Aug 2022 20:55:33 GMT Subject: RFR: Save and dump last mouse move. [v2] In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 20:50:32 GMT, Alexandre Iline wrote: >> Save and dump last mouse move. >> Added Component.hasFocus() to the dump. > > Alexandre Iline has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. test/org/netbeans/jemmy/util/DumpTest.java line 61: > 59: .contains("")); > 60: assertTrue(out.toString() > 61: .contains("")); Can we check whether HAS_FOCUS_DPROP is available in dump? ------------- PR: https://git.openjdk.org/jemmy-v2/pull/6 From duke at openjdk.org Wed Aug 24 22:12:35 2022 From: duke at openjdk.org (lawrence.andrews) Date: Wed, 24 Aug 2022 22:12:35 GMT Subject: RFR: Save and dump last mouse move. [v2] In-Reply-To: References: Message-ID: On Wed, 24 Aug 2022 20:50:32 GMT, Alexandre Iline wrote: >> Save and dump last mouse move. >> Added Component.hasFocus() to the dump. > > Alexandre Iline has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Looks good to me. ------------- PR: https://git.openjdk.org/jemmy-v2/pull/6