Integrated: Drop unused jtreg test headers
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Thu Apr 7 15:45:04 UTC 2022
On Thu, 7 Apr 2022 11:40:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> The `@library` tags in jtreg tests are wrong. According to the tag specification here:
>
> https://openjdk.java.net/jtreg/tag-spec.html
>
> If an absolute path is used in combination with `@library`, the path should be interpreted as either relative to the test root (e.g. test/), or relative to an external root path (specified with a property in TEST.ROOT). Since we're not using any property, it follows that the library path should be relative to `test/` - which means `/lib` is the correct choice here, not `/test/lib`.
>
> (I discovered this when using the jtreg plugin [1] to run the jextract tests - these bad `@library` tags were causing a crash in the plugin; of course the plugin should be fixed - but the tags in the tests should be fixed as well).
>
> [1] - https://github.com/openjdk/jtreg/tree/master/plugins/idea
This pull request has now been integrated.
Changeset: e184943f
Author: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.java.net/jextract/commit/e184943f15e8df68c6122b8f7e49c0a910a3b773
Stats: 227 lines in 31 files changed: 3 ins; 224 del; 0 mod
Drop unused jtreg test headers
Drop unused jtreg test headers
Reviewed-by: sundar
-------------
PR: https://git.openjdk.java.net/jextract/pull/16
More information about the jextract-dev
mailing list